[trojita] Link URL in status bar

2017-04-20 Thread Andy Bennett

Hi,

I've just upgraded Trojita from 0.5 to 0.7.

When viewing an HTML eMail it used to be the case that the URL for a link 
would appear in the status bar when the mouse hovered over that link.


This appears not to be happening anymore.

How do I switch this back on? It was essential for me to avoid clicking 
phishing links.




Regards,
@ndy

--
andy...@ashurst.eu.org
http://www.ashurst.eu.org/
0x7EBA75FF



Re: [trojita] Link URL in status bar

2017-04-20 Thread Jan Kundrát

On čtvrtek 20. dubna 2017 16:36:38 CEST, Andy Bennett wrote:
When viewing an HTML eMail it used to be the case that the URL 
for a link would appear in the status bar when the mouse hovered 
over that link.


Hi,
the status bar as a permanent widget is gone. It's been replaced by a 
tooltip which shows the link target closer to the mouser pointer. I agree 
that phishing links are an important concern; hopefully this will make them 
stand out a bit more.


Unfortunately, a correct behavior of these tooltips depend on a fix which 
went to QtWebKit that got released in 5.4. Debian Jessie is stuck with Qt 
5.3 (which is an interesting decision considering the webkit's attack 
surface...). For more details, see the bugreport [1] and the linked commit.


Cheers,
Jan

[1] https://bugs.kde.org/show_bug.cgi?id=363783

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/



Re: [trojita] Link URL in status bar

2017-04-20 Thread Jan Kundrát

On čtvrtek 20. dubna 2017 17:16:47 CEST, Jan Kundrát wrote:
Unfortunately, a correct behavior of these tooltips depend on a 
fix which went to QtWebKit that got released in 5.4. Debian 
Jessie is stuck with Qt 5.3 (which is an interesting decision 
considering the webkit's attack surface...). For more details, 
see the bugreport [1] and the linked commit.


Oops, I'm actually mistaken -- there's been no fix which went to QtWebKit 
for this. We added a local workaround which depends on a convenience QTimer 
method that got added in Qt 5.4. If you cannot upgrade your Qt for some 
reason, feel free to submit a patch which makes our code uglier with an 
explicit slot.


Cheers,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/



Re: [trojita] Link URL in status bar

2017-04-20 Thread Andy Bennett

Hi,

Unfortunately, a correct behavior of these tooltips depend on 
a fix which went to QtWebKit that got released in 5.4. Debian 
Jessie is stuck with Qt 5.3 (which is an interesting decision 
considering the webkit's attack surface...). For more details, 
see the bugreport [1] and the linked commit.


Oops, I'm actually mistaken -- there's been no fix which went 
to QtWebKit for this. We added a local workaround which depends 
on a convenience QTimer method that got added in Qt 5.4. If you 
cannot upgrade your Qt for some reason, feel free to submit a 
patch which makes our code uglier with an explicit slot.


Thanks for the replies!

It seems that jessie-backports has a QtWebKit 5.3 as well. :-(

Does it need to use a timer at all? Is it acceptable for the tooltip to 
stay there until the cursor is moved away from the link?




Regards,
@ndy

--
andy...@ashurst.eu.org
http://www.ashurst.eu.org/
0x7EBA75FF



Re: [trojita] Link URL in status bar

2017-04-20 Thread Andy Bennett

Hi,

Does it need to use a timer at all? Is it acceptable for the 
tooltip to stay there until the cursor is moved away from the 
link?


PS: the mouseover for the rest of the chrome are working fine: it's just 
the ones in the QtWebKit widget that don't appear at all.




Regards,
@ndy

--
andy...@ashurst.eu.org
http://www.ashurst.eu.org/
0x7EBA75FF



Re: [trojita] Link URL in status bar

2017-04-20 Thread Thomas Lübking

On Thu, Apr 20, 2017 at 04:58:18PM +0100, Andy Bennett wrote:
Does it need to use a timer at all? Is it acceptable for the tooltip 
to stay there until the cursor is moved away from the link?


The timer is required to delay *showing* the tooltip (so webview doesn't
immediately hide it again), so yes, it's required and core of this
workaround.
The 5.4 branching however has been in place before, I'm not sure whether
it's related to the workaround.

Cheers,
Thomas



Re: [trojita] Link URL in status bar

2017-04-20 Thread Thomas Lübking


PS: I was wrong about the 5.4 branch requirement in the last message -
it's actually because of the QTimer::singleShot to a functor which was
not available before 5.4.
So you'd just have to unwind that and remove the branch (right now,
showing a tooltip is not even attempted for you - regardless of the
webview behavior; it neither will work w/o the timer, though)

Cheers,
Thomas