Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src

[Warner Losh via svn-src-head]

> On Dec 17, 2014, at 2:16 PM, Steve Kargl  
> wrote:
> 
> 
> Ed's diff is ~1000 lines and touches several files.  Localizing
> the change to math_private.h would have been a ~20 line
> diff to a single file.

Then just back his change out, put yours in and we all win. This seems like
ample “this is better” justification to me. While there is a little more churn, 
external
trackers will apply then unapply the churn, resulting in a net win. Especially 
if you
do the blackout as one commit and the better fix as another, which means 
external
trackers can just skip the two commits of churn with little effort on their 
part.

Warner

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r276499 - head/sys/conf

[Warner Losh via svn-src-head]

This breaks building the kernel with clang 3.4.1

Warner


> On Jan 1, 2015, at 3:07 AM, Roman Divacky  wrote:
> 
> Author: rdivacky
> Date: Thu Jan  1 10:07:57 2015
> New Revision: 276499
> URL: https://svnweb.freebsd.org/changeset/base/276499
> 
> Log:
>  LLVM integrated assembler can assemble these files just fine.
> 
> Modified:
>  head/sys/conf/Makefile.amd64
>  head/sys/conf/Makefile.i386
>  head/sys/conf/Makefile.pc98
> 
> Modified: head/sys/conf/Makefile.amd64
> ==
> --- head/sys/conf/Makefile.amd64  Thu Jan  1 09:33:46 2015
> (r276498)
> +++ head/sys/conf/Makefile.amd64  Thu Jan  1 10:07:57 2015
> (r276499)
> @@ -37,11 +37,6 @@ INCLUDES+= -I$S/contrib/libfdt
> CFLAGS+=  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
> .endif
> 
> -# XXX: clang integrated-as doesn't grok .codeNN directives yet
> -ASM_CFLAGS.acpi_wakecode.S=  ${CLANG_NO_IAS}
> -ASM_CFLAGS.mpboot.S= ${CLANG_NO_IAS}
> -ASM_CFLAGS+= ${ASM_CFLAGS.${.IMPSRC:T}}
> -
> %BEFORE_DEPEND
> 
> %OBJS
> 
> Modified: head/sys/conf/Makefile.i386
> ==
> --- head/sys/conf/Makefile.i386   Thu Jan  1 09:33:46 2015
> (r276498)
> +++ head/sys/conf/Makefile.i386   Thu Jan  1 10:07:57 2015
> (r276499)
> @@ -32,11 +32,6 @@ S= ../../..
> 
> INCLUDES+= -I$S/contrib/libfdt
> 
> -# XXX: clang integrated-as doesn't grok .codeNN directives yet
> -ASM_CFLAGS.acpi_wakecode.S=  ${CLANG_NO_IAS}
> -ASM_CFLAGS.mpboot.s= ${CLANG_NO_IAS}
> -ASM_CFLAGS+= ${ASM_CFLAGS.${.IMPSRC:T}}
> -
> %BEFORE_DEPEND
> 
> %OBJS
> 
> Modified: head/sys/conf/Makefile.pc98
> ==
> --- head/sys/conf/Makefile.pc98   Thu Jan  1 09:33:46 2015
> (r276498)
> +++ head/sys/conf/Makefile.pc98   Thu Jan  1 10:07:57 2015
> (r276499)
> @@ -30,10 +30,6 @@ S= ../../..
> .endif
> .include "$S/conf/kern.pre.mk"
> 
> -# XXX: clang integrated-as doesn't grok .codeNN directives yet
> -ASM_CFLAGS.mpboot.s= ${CLANG_NO_IAS}
> -ASM_CFLAGS+= ${ASM_CFLAGS.${.IMPSRC:T}}
> -
> %BEFORE_DEPEND
> 
> %OBJS
> 

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"