Re: svn commit: r309144 - in head: lib/libipsec sys/net sys/netipsec
Fabien Thomas writes: > Author: fabient > Date: Fri Nov 25 14:44:49 2016 > New Revision: 309144 > URL: https://svnweb.freebsd.org/changeset/base/309144 > > Log: > IPsec RFC6479 support for replay window sizes up to 2^32 - 32 packets. > > Since the previous algorithm, based on bit shifting, does not scale > with large replay windows, the algorithm used here is based on > RFC 6479: IPsec Anti-Replay Algorithm without Bit Shifting. > The replay window will be fast to be updated, but will cost as many bits > in RAM as its size. > > The previous implementation did not provide a lock on the replay window, > which may lead to replay issues. This broke the build here: In file included from /usr/src/sys/netipsec/key_debug.c:54: In file included from /usr/src/sys/netipsec/ipsec.h:46: In file included from /usr/src/sys/netipsec/keydb.h:38: /usr/src/sys/sys/mutex.h:367:2: error: LOCK_DEBUG not defined, include before #error LOCK_DEBUG not defined, include before ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r309191 - head/usr.bin/dtc
Author: rakuco (ports committer)
Date: Sat Nov 26 12:36:11 2016
New Revision: 309191
URL: https://svnweb.freebsd.org/changeset/base/309191
Log:
fdt: Expect strchr() to return a const char*
In C, strchr(3) returns a char*, whereas C++ defines two overloads:
* const char *strchr(const char*, int)
* char *strchr(char*, int)
Building fdt.cc (with the WITHOUT_GPL_DTC knob set) with libc++ 3.9.0
(imported
in r309124) was failing because libc++ r260377 added the first overload to
string.h, leading to failures such as:
fdt.cc:1638:8: error: cannot initialize a variable of type 'char *' with
an
rvalue of type 'const char *'
Just define val as a const char* to fix it.
Upstreamed in https://github.com/davidchisnall/dtc/pull/14
Reviewed by: emaste
Approved by: emaste
Modified:
head/usr.bin/dtc/fdt.cc
Modified: head/usr.bin/dtc/fdt.cc
==
--- head/usr.bin/dtc/fdt.cc Sat Nov 26 10:36:48 2016(r309190)
+++ head/usr.bin/dtc/fdt.cc Sat Nov 26 12:36:11 2016(r309191)
@@ -1635,7 +1635,7 @@ device_tree::parse_dts(const string &fn,
bool device_tree::parse_define(const char *def)
{
- char *val = strchr(def, '=');
+ const char *val = strchr(def, '=');
if (!val)
{
if (strlen(def) != 0)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r309144 - in head: lib/libipsec sys/net sys/netipsec
Fabien THOMAS writes: > Hi, > > Sorry about that. Normally we build universe with it but it seems we missed > something... > I've not access to a machine to fixit before monday... Don't worry, emaste fixed it in r309174 :-) ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r309194 - head/usr.sbin/syslogd
Baptiste Daroussin writes: > Author: bapt > Date: Sat Nov 26 15:49:59 2016 > New Revision: 309194 > URL: https://svnweb.freebsd.org/changeset/base/309194 > > Log: > initialize *nextp which could be left uninitialized in case the > configuration > file cannot be open/read > > Reported by:Coverity via cem > MFC after: 2 days > CID:1365665 This is causing syslogd to crash on launch with SIGILL here (I'm on r309213). The disassembly shows it's stumbling upon an UD2 instruction here on amd64. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r226351 - in head: share/misc usr.bin/calendar/calendars
Author: rakuco (ports committer) Date: Thu Oct 13 20:36:43 2011 New Revision: 226351 URL: http://svn.freebsd.org/changeset/base/226351 Log: Add myself to committers-ports.dot and calendar.freebsd. Approved by: avilla (mentor) Modified: head/share/misc/committers-ports.dot head/usr.bin/calendar/calendars/calendar.freebsd Modified: head/share/misc/committers-ports.dot == --- head/share/misc/committers-ports.dotThu Oct 13 20:06:19 2011 (r226350) +++ head/share/misc/committers-ports.dotThu Oct 13 20:36:43 2011 (r226351) @@ -154,6 +154,7 @@ pgj [label="Gabor Pali\n...@freebsd.org\ philip [label="Philip Paeps\nphi...@freebsd.org\n2005/10/19"] pgollucci [label="Philip M. Gollucci\npgollu...@freebsd.org\n2008/07/21"] rafan [label="Rong-En Fan\nra...@freebsd.org\n2006/06/23"] +rakuco [label="Raphael Kubo da Costa\nrak...@freebsd.org\n2011/08/22"] rene [label="Rene Ladan\nr...@freebsd.org\n2010/04/11"] rnoland [label="Robert Noland\nrnol...@freebsd.org\n2008/07/21"] romain [label="Romain Tartiere\nrom...@freebsd.org\n2010/01/24"] @@ -210,6 +211,8 @@ arved -> stefan asami -> obrien +avilla -> rakuco + bapt -> eadler bapt -> jlaffaye @@ -327,6 +330,7 @@ marcus -> eik marcus -> jmallett makc -> bf +makc -> rakuco mat -> thierry Modified: head/usr.bin/calendar/calendars/calendar.freebsd == --- head/usr.bin/calendar/calendars/calendar.freebsdThu Oct 13 20:06:19 2011(r226350) +++ head/usr.bin/calendar/calendars/calendar.freebsdThu Oct 13 20:36:43 2011(r226351) @@ -22,6 +22,7 @@ 01/16 Ariff Abdullah born in Kuala Lumpur, Malaysia, 1978 01/16 Dmitry Sivachenko born in Moscow, USSR, 1978 01/16 Vanilla I. Shu born in Taipei, Taiwan, Republic of China, 1978 +01/17 Raphael Kubo da Costa born in Sao Paulo, Sao Paulo, Brazil, 1989 01/18 Dejan Lesjak born in Ljubljana, Slovenia, Yugoslavia, 1977 01/19 Marshall Kirk McKusick born in Wilmington, Delaware, United States, 1954 01/19 Ruslan Ermilov born in Simferopol, USSR, 1974 ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r269661 - head/sys/kern
Andrey V. Elsukov writes: > Author: ae > Date: Thu Aug 7 10:23:50 2014 > New Revision: 269661 > URL: http://svnweb.freebsd.org/changeset/base/269661 > > Log: > Use cpuset_setithread() to apply cpu mask to taskq threads. > > Sponsored by: Yandex LLC This broke the build here: /usr/src/sys/kern/subr_taskqueue.c:541:42: error: incompatible pointer to integer conversion passing 'cpuset_t *' (aka 'struct _cpuset *') to parameter of type 'u_char' (aka 'unsigned char') [-Werror,-Wint-conversion] error = cpuset_setithread(td->td_tid, mask); ^~~~ /usr/src/sys/sys/cpuset.h:121:42: note: passing argument to parameter 'cpu' here int cpuset_setithread(lwpid_t id, u_char cpu); ^ ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r281116 - head/usr.sbin/bluetooth/bthidd
Author: rakuco (ports committer)
Date: Sun Apr 5 18:53:48 2015
New Revision: 281116
URL: https://svnweb.freebsd.org/changeset/base/281116
Log:
bthidd: Consider usage ranges when dealing with array inputs.
So far, we were always using HID_USAGE() to determine the Usage ID of a
certain HID report input item. This does not work as intended if a field
is an array and the allowed usages are specified with a usage range, as
HID_USAGE() will return 0. We need to use the field value as an index in
the usage range list in this case instead.
This makes the volume keys in a Microsoft Bluetooth Mobile Keyboard
5000 be properly recognized. The relevant part of the HID report looks
like this:
0xA1, 0x01,// Collection (Application)
0x85, 0x07,// Report ID (7)
0x05, 0x0C,// Usage Page (Consumer)
0x19, 0x00,// Usage Minimum (Unassigned)
0x2A, 0xFF, 0x03, // Usage Maximum (0x03FF)
0x95, 0x01,// Report Count (1)
0x75, 0x10,// Report Size (16)
0x15, 0x00,// Logical Minimum (0)
0x27, 0xFF, 0x03, 0x00, 0x00, // Logical Maximum (1023)
0x81, 0x00,// Input (Data,Array,Abs,No Wrap,Linear,Preferred
// State,No Null Position)
When a key such as "volume down" is pressed, the following data is
transferred through Interrupt In:
0x07 0xEA 0x00
Differential Revision:https://reviews.freebsd.org/D2229
Reviewed by: emax
Approved by: emax
MFC after:1 week
Modified:
head/usr.sbin/bluetooth/bthidd/hid.c
Modified: head/usr.sbin/bluetooth/bthidd/hid.c
==
--- head/usr.sbin/bluetooth/bthidd/hid.cSun Apr 5 18:42:43 2015
(r281115)
+++ head/usr.sbin/bluetooth/bthidd/hid.cSun Apr 5 18:53:48 2015
(r281116)
@@ -165,9 +165,21 @@ hid_interrupt(bthid_session_p s, uint8_t
continue;
page = HID_PAGE(h.usage);
- usage = HID_USAGE(h.usage);
val = hid_get_data(data, &h);
+ /*
+* When the input field is an array and the usage is specified
+* with a range instead of an ID, we have to derive the actual
+* usage by using the item value as an index in the usage range
+* list.
+*/
+ if ((h.flags & HIO_VARIABLE)) {
+ usage = HID_USAGE(h.usage);
+ } else {
+ const uint32_t usage_offset = val - h.logical_minimum;
+ usage = HID_USAGE(h.usage_minimum + usage_offset);
+ }
+
switch (page) {
case HUP_GENERIC_DESKTOP:
switch (usage) {
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r281146 - head/usr.sbin/bluetooth/bthidd
Author: rakuco (ports committer) Date: Mon Apr 6 12:36:24 2015 New Revision: 281146 URL: https://svnweb.freebsd.org/changeset/base/281146 Log: bthidd: Remove unused macros from hid.c. ASIZE() was never used, and min() stopped being used in r207812. Differential Revision:https://reviews.freebsd.org/D2230 Reviewed by: emax Approved by: emax MFC after:1 week Modified: head/usr.sbin/bluetooth/bthidd/hid.c Modified: head/usr.sbin/bluetooth/bthidd/hid.c == --- head/usr.sbin/bluetooth/bthidd/hid.cMon Apr 6 12:22:41 2015 (r281145) +++ head/usr.sbin/bluetooth/bthidd/hid.cMon Apr 6 12:36:24 2015 (r281146) @@ -48,12 +48,6 @@ #include "bthidd.h" #include "kbd.h" -#undef min -#definemin(x, y) (((x) < (y))? (x) : (y)) - -#undef ASIZE -#defineASIZE(a)(sizeof(a)/sizeof(a[0])) - /* * Process data from control channel */ ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r289315 - in head: include lib/libc/resolv share/man/man5
Eric van Gyzen writes:
> Author: vangyzen
> Date: Wed Oct 14 14:26:44 2015
> New Revision: 289315
> URL: https://svnweb.freebsd.org/changeset/base/289315
>
> Log:
> resolver: automatically reload /etc/resolv.conf
>
> [...]
>
> Modified: head/include/resolv.h
> ==
> --- head/include/resolv.h Wed Oct 14 12:46:05 2015(r289314)
> +++ head/include/resolv.h Wed Oct 14 14:26:44 2015(r289315)
>
> [...]
>
> @@ -188,6 +189,8 @@ struct __res_state {
> } _ext;
> } _u;
> u_char *_rnd; /*%< PRIVATE: random state */
> + struct timespec conf_mtim; /*%< mod time of loaded resolv.conf */
> + time_t conf_stat; /*%< time of last stat(resolv.conf) */
> };
With this change, including the headers listed in resolver(3),
sys/types.h, netinet/in.h, arpa/nameser.h and resolv.h is not enough, as
resolv.h now depends on sys/time.h. This has broken at least one port,
net-mgmt/sx. It includes those 4 headers to find if the resolver library
is in libc. The test program fails like this:
In file included from conftest.c:31:
/usr/include/resolv.h:192:18: error: field has incomplete type 'struct timespec'
struct timespec conf_mtim; /*%< mod time of loaded resolv.conf */
^
/usr/include/resolv.h:192:9: note: forward declaration of 'struct timespec'
struct timespec conf_mtim; /*%< mod time of loaded resolv.conf */
^
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r244704 - in head: share/man/man4 sys/netgraph/bluetooth/drivers/ubt
Hans Petter Selasky writes: > On Wednesday 26 December 2012 16:10:20 Gleb Smirnoff wrote: >> Author: glebius >> Date: Wed Dec 26 15:10:20 2012 >> New Revision: 244704 >> URL: http://svnweb.freebsd.org/changeset/base/244704 >> >> Log: >> Add vendor IDs for Broadcom USB dongles (BCM20702). >> >> PR:kern/174707 >> Submitted by: rakuco >> >> Modified: >> head/share/man/man4/ng_ubt.4 >> head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c > Hi, > > I think USB_IF_CSI() was not what you meant: Ouch, you are right, sorry for the oversight! In any case, could this change be MFCed to at least 9-STABLE? ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r244714 - head/sys/netgraph/bluetooth/drivers/ubt
Author: rakuco (ports committer)
Date: Wed Dec 26 19:12:31 2012
New Revision: 244714
URL: http://svnweb.freebsd.org/changeset/base/244714
Log:
Use the correct USB interface macros instead of USB_IF_CSI.
As pointed out by hselasky@, USB_IF_CSI is the wrong macro here since we want
to declare the device's interface class, subclass and protocol, not class,
subclass and driver info.
Follow-up to r244704.
PR: kern/174707
Approved by: glebius
MFC after:1 week
Modified:
head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
Modified: head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
==
--- head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.cWed Dec 26 18:51:37
2012(r244713)
+++ head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.cWed Dec 26 19:12:31
2012(r244714)
@@ -401,7 +401,9 @@ static const STRUCT_USB_HOST_ID ubt_devs
/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
{ USB_VENDOR(USB_VENDOR_BROADCOM),
- USB_IF_CSI(UICLASS_VENDOR, 0x01, 0x01) },
+ USB_IFACE_CLASS(UICLASS_VENDOR),
+ USB_IFACE_SUBCLASS(UDSUBCLASS_RF),
+ USB_IFACE_PROTOCOL(UDPROTO_BLUETOOTH) },
};
/*
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r244715 - head/sys/netgraph/bluetooth/drivers/ubt
Author: rakuco (ports committer)
Date: Wed Dec 26 19:14:21 2012
New Revision: 244715
URL: http://svnweb.freebsd.org/changeset/base/244715
Log:
Use DEVMETHOD_END, as suggested by hselasky@.
Approved by: glebius
Modified:
head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
Modified: head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
==
--- head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.cWed Dec 26 19:12:31
2012(r244714)
+++ head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.cWed Dec 26 19:14:21
2012(r244715)
@@ -1766,7 +1766,7 @@ static device_method_tubt_methods[] =
DEVMETHOD(device_probe, ubt_probe),
DEVMETHOD(device_attach, ubt_attach),
DEVMETHOD(device_detach, ubt_detach),
- { 0, 0 }
+ DEVMETHOD_END
};
static driver_tubt_driver =
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r255128 - head/sys/netgraph/bluetooth/drivers/ubt
Eitan Adler writes: > Author: eadler > Date: Sun Sep 1 19:27:32 2013 > New Revision: 255128 > URL: http://svnweb.freebsd.org/changeset/base/255128 > > Log: > Add support for the BCM20702A0 chipset, ASUS USB-BT400. > > PR: kern/181728 > Submitted by: rakuco MFC after: 3 days as discussed with eadler. ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r253260 - head/lib/msun/src
David Chisnall writes:
> Author: theraven
> Date: Fri Jul 12 11:03:51 2013
> New Revision: 253260
> URL: http://svnweb.freebsd.org/changeset/base/253260
>
> Log:
> Fix the build with C++ where __builtin_types_compatible_p is not allowed.
>
> Modified:
> head/lib/msun/src/math.h
>
> Modified: head/lib/msun/src/math.h
> ==
> --- head/lib/msun/src/math.h Fri Jul 12 10:07:48 2013(r253259)
> +++ head/lib/msun/src/math.h Fri Jul 12 11:03:51 2013(r253260)
> @@ -81,12 +81,13 @@ extern const union __nan_un {
> #define FP_SUBNORMAL0x08
> #define FP_ZERO 0x10
>
> -#if __STDC_VERSION__ >= 201112L && defined(__clang__)
> +#if (__STDC_VERSION__ >= 201112L && defined(__clang__)) || \
> +__has_extension(c_generic_selections)
> #define __fp_type_select(x, f, d, ld) _Generic((x), \
> float: f(x),\
> double: d(x), \
> long double: ld(x))
One of the things that's making cad/brlcad fail with clang is some C
code that calls isnan() and isinf() with -std=gnu89, -Werror and
-Wc11-extensions:
/s/brlcad/src/libbn/ulp.c:170:9: error: generic selections are a C11-specific
feature [-Werror,-Wc11-extensions]
if (isnan(val) || isinf(val))
^
/usr/include/math.h:118:2: note: expanded from macro 'isnan'
__fp_type_select(x, __inline_isnanf, __inline_isnan, __inline_isnanl)
^
/usr/include/math.h:86:39: note: expanded from macro '__fp_type_select'
#define __fp_type_select(x, f, d, ld) _Generic((x), \
^
Can the check there be improved somehow to avoid this kind of error?
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r253260 - head/lib/msun/src
Raphael Kubo da Costa writes:
> David Chisnall writes:
>
>> Author: theraven
>> Date: Fri Jul 12 11:03:51 2013
>> New Revision: 253260
>> URL: http://svnweb.freebsd.org/changeset/base/253260
>>
>> Log:
>> Fix the build with C++ where __builtin_types_compatible_p is not allowed.
>>
>> Modified:
>> head/lib/msun/src/math.h
>>
>> Modified: head/lib/msun/src/math.h
>> ==
>> --- head/lib/msun/src/math.h Fri Jul 12 10:07:48 2013(r253259)
>> +++ head/lib/msun/src/math.h Fri Jul 12 11:03:51 2013(r253260)
>> @@ -81,12 +81,13 @@ extern const union __nan_un {
>> #define FP_SUBNORMAL0x08
>> #define FP_ZERO 0x10
>>
>> -#if __STDC_VERSION__ >= 201112L && defined(__clang__)
>> +#if (__STDC_VERSION__ >= 201112L && defined(__clang__)) || \
>> +__has_extension(c_generic_selections)
>> #define __fp_type_select(x, f, d, ld) _Generic((x), \
>> float: f(x),\
>> double: d(x), \
>> long double: ld(x))
>
> One of the things that's making cad/brlcad fail with clang is some C
> code that calls isnan() and isinf() with -std=gnu89, -Werror and
> -Wc11-extensions:
(To be fair, it's -pedantic that brings in -Wc11-extensions)
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r253260 - head/lib/msun/src
David Chisnall writes: > The issue is probably a clang bug. The use of _Generic() is in a > system header and so ought to be immune to warnings, but apparently > the fact that it's instantiated outside of the system header. If you > can file a clang bug > (http://llvm.org/bugs/enter_bug.cgi?product=clang) I'll take a look > (I'm at vBSDCon now, so I'll lose it otherwise). Done, at last: http://llvm.org/bugs/show_bug.cgi?id=17788 ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
