svn commit: r301867 - head/sys/security/audit
Author: rwatson Date: Mon Jun 13 09:22:20 2016 New Revision: 301867 URL: https://svnweb.freebsd.org/changeset/base/301867 Log: Implement AUE_PREAD and AUE_PWRITE BSM conversion support, eliminating console warnings when pread(2) and pwrite(2) are used with full system-call auditing enabled. We audit the same file-descriptor data for these calls as we do read(2) and write(2). Approved by: re (kib) MFC after:3 days Sponsored by: DARPA, AFRL Modified: head/sys/security/audit/audit_bsm.c Modified: head/sys/security/audit/audit_bsm.c == --- head/sys/security/audit/audit_bsm.c Mon Jun 13 09:02:08 2016 (r301866) +++ head/sys/security/audit/audit_bsm.c Mon Jun 13 09:22:20 2016 (r301867) @@ -952,6 +952,8 @@ kaudit_to_bsm(struct kaudit_record *kar, case AUE_GETDIRENTRIESATTR: case AUE_LSEEK: case AUE_POLL: + case AUE_PREAD: + case AUE_PWRITE: case AUE_READ: case AUE_READV: case AUE_WRITE: ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301869 - in head: share/misc usr.bin/calendar/calendars usr.sbin/sysrc
Author: ngie Date: Mon Jun 13 10:35:11 2016 New Revision: 301869 URL: https://svnweb.freebsd.org/changeset/base/301869 Log: Change my given name from "Garrett" to "Ngie" A legal name change from "Garrett" to "Ngie", as well as a FreeBSD account name change, is pending. Approved by: re (hrs) Modified: head/share/misc/committers-src.dot head/usr.bin/calendar/calendars/calendar.freebsd head/usr.sbin/sysrc/sysrc.8 Directory Properties: head/ (props changed) Modified: head/share/misc/committers-src.dot == --- head/share/misc/committers-src.dot Mon Jun 13 10:30:49 2016 (r301868) +++ head/share/misc/committers-src.dot Mon Jun 13 10:35:11 2016 (r301869) @@ -244,7 +244,7 @@ mp [label="Mark Peek\n...@freebsd.org\n20 mr [label="Michael Reifenberger\n...@freebsd.org\n2001/09/30"] neel [label="Neel Natu\nn...@freebsd.org\n2009/09/20"] netchild [label="Alexander Leidinger\nnetch...@freebsd.org\n2005/03/31"] -ngie [label="Garrett Cooper\nn...@freebsd.org\n2014/07/27"] +ngie [label="Ngie Cooper\nn...@freebsd.org\n2014/07/27"] nork [label="Norikatsu Shigemura\nn...@freebsd.org\n2009/06/09"] np [label="Navdeep Parhar\n...@freebsd.org\n2009/06/05"] nwhitehorn [label="Nathan Whitehorn\nnwhiteh...@freebsd.org\n2008/07/03"] Modified: head/usr.bin/calendar/calendars/calendar.freebsd == --- head/usr.bin/calendar/calendars/calendar.freebsdMon Jun 13 10:30:49 2016(r301868) +++ head/usr.bin/calendar/calendars/calendar.freebsdMon Jun 13 10:35:11 2016(r301869) @@ -36,7 +36,7 @@ 01/26 Andrew Gallatin born in Buffalo, New York, United States, 1970 01/27 Nick Sayer born in San Diego, California, United States, 1968 01/27 Jacques Anthony Vidrine born in Baton Rouge, Louisiana, United States, 1971 -01/27 Garrett Cooper born in Seattle, Washington, United States, 1984 +01/27 Ngie Cooper born in Seattle, Washington, United States, 1984 01/31 Hidetoshi Shimokawa born in Yokohama, Kanagawa, Japan, 1970 02/01 Doug Rabson born in London, England, 1966 02/01 Nicola Vitale born in Busto Arsizio, Varese, Italy, 1976 Modified: head/usr.sbin/sysrc/sysrc.8 == --- head/usr.sbin/sysrc/sysrc.8 Mon Jun 13 10:30:49 2016(r301868) +++ head/usr.sbin/sysrc/sysrc.8 Mon Jun 13 10:35:11 2016(r301869) @@ -480,6 +480,6 @@ utility first appeared in .Sh AUTHORS .An Devin Teske Aq Mt dte...@freebsd.org .Sh THANKS TO -Brandon Gooch, Garrett Cooper, Julian Elischer, Pawel Jakub Dawidek, +Brandon Gooch, Ngie Cooper, Julian Elischer, Pawel Jakub Dawidek, Cyrille Lefevre, Ross West, Stefan Esser, Marco Steinbach, Jilles Tjoelker, Allan Jude, and Lars Engels for suggestions, help, and testing. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301870 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Author: avg
Date: Mon Jun 13 10:53:34 2016
New Revision: 301870
URL: https://svnweb.freebsd.org/changeset/base/301870
Log:
zfs_vptocnp: check for an invalid znode
... which can arise after the receive or rollback
and failed zfs_rezget().
Approved by: re (kib)
MFC after:1 week
Modified:
head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
==
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c Mon Jun
13 10:35:11 2016(r301869)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c Mon Jun
13 10:53:34 2016(r301870)
@@ -7170,16 +7170,24 @@ zfs_vptocnp(struct vop_vptocnp_args *ap)
int ltype;
int error;
+ ZFS_ENTER(zfsvfs);
+ ZFS_VERIFY_ZP(zp);
+
/*
* If we are a snapshot mounted under .zfs, run the operation
* on the covered vnode.
*/
if ((error = sa_lookup(zp->z_sa_hdl,
- SA_ZPL_PARENT(zfsvfs), &parent, sizeof (parent))) != 0)
+ SA_ZPL_PARENT(zfsvfs), &parent, sizeof (parent))) != 0) {
+ ZFS_EXIT(zfsvfs);
return (error);
+ }
- if (zp->z_id != parent || zfsvfs->z_parent == zfsvfs)
+ if (zp->z_id != parent || zfsvfs->z_parent == zfsvfs) {
+ ZFS_EXIT(zfsvfs);
return (vop_stdvptocnp(ap));
+ }
+ ZFS_EXIT(zfsvfs);
covered_vp = vp->v_mount->mnt_vnodecovered;
vhold(covered_vp);
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301871 - head/usr.sbin/rpc.lockd
Author: ngie
Date: Mon Jun 13 11:19:06 2016
New Revision: 301871
URL: https://svnweb.freebsd.org/changeset/base/301871
Log:
Add missing break in lock_partialfilelock(..) with NFS_RESERR
This will help ensure that the right error is trickled up when the
function is called if the lock status is NFS_RESERR
Differential Revision: https://reviews.freebsd.org/D6622
Reviewed by: rmacklem
Approved by: re (gjb)
Tested with: fsx; svn info/svnversion (uses bdb locking); locktests from Bull
http://nfsv4.bullopensource.org/tools/tests/locktest.php
MFC after: 2 weeks
Reported by: Coverity
CID: 1008161, 1304956
Sponsored by: EMC / Isilon Storage Division
Modified:
head/usr.sbin/rpc.lockd/lockd_lock.c
Modified: head/usr.sbin/rpc.lockd/lockd_lock.c
==
--- head/usr.sbin/rpc.lockd/lockd_lock.cMon Jun 13 10:53:34 2016
(r301870)
+++ head/usr.sbin/rpc.lockd/lockd_lock.cMon Jun 13 11:19:06 2016
(r301871)
@@ -1426,6 +1426,7 @@ lock_partialfilelock(struct file_lock *f
break;
case NFS_RESERR:
retval = PFL_NFSRESERR;
+ break;
default:
debuglog("Unmatched lnlstatus %d\n");
retval = PFL_NFSDENIED_NOLOCK;
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r300943 - in head: . lib/libc++ lib/libcxxrt share/mk
On 6/12/2016 1:02 PM, Andreas Tobler wrote: > Hi Bryan, > > On 29.05.16 08:20, Bryan Drewery wrote: >> Author: bdrewery >> Date: Sun May 29 06:20:15 2016 >> New Revision: 300943 >> URL: https://svnweb.freebsd.org/changeset/base/300943 >> >> Log: >> GCC External: Revert r300886, r300904, r300917, r300918 >> >> The fix in r300873 is mostly enough. A fix for lib32 will be >> committed.separately. > > Did this commit already happen? > > I still suffer a broken buildworld on powerpc64 for 32-bit with internal > tools. > > Unknown option -std=c++11... Can you tee the entire build and send me the log please? -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
svn commit: r301872 - head/sys/arm/include
Author: ian Date: Mon Jun 13 16:48:27 2016 New Revision: 301872 URL: https://svnweb.freebsd.org/changeset/base/301872 Log: Do not define __NO_STRICT_ALIGNMENT for armv6. While the requirements are no longer natural-alignment strict, there are still some restrictions. FreeBSD network code assumes data is naturally-aligned or is running on a platform with no restrictions; pointers are not annotated to indicate the data pointed to may be packed or unaligned. The clang optimizer can sometimes combine the load or store of a pair of adjacent 32-bit values into a single doubleword load/store, and that operation requires at least 4-byte alignment. __NO_STRICT_ALIGNMENT can lead to tcp headers being only 2-byte aligned. Note that alignment faults remain disabled on armv6, this change reverts only the defining of the symbol which leads to some overly-agressive code shortcuts when building common/shared drivers and network code for arm. Approved by: re(kib) Modified: head/sys/arm/include/_types.h Modified: head/sys/arm/include/_types.h == --- head/sys/arm/include/_types.h Mon Jun 13 11:19:06 2016 (r301871) +++ head/sys/arm/include/_types.h Mon Jun 13 16:48:27 2016 (r301872) @@ -43,10 +43,6 @@ #error this file needs sys/cdefs.h as a prerequisite #endif -#if __ARM_ARCH >= 6 -#define __NO_STRICT_ALIGNMENT -#endif - /* * Basic types upon which most other types are built. */ ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301873 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Author: avg Date: Mon Jun 13 18:39:13 2016 New Revision: 301873 URL: https://svnweb.freebsd.org/changeset/base/301873 Log: l2arc: reset b_tmp_cdata to NULL in the case of unset b_daddr The change is in arc_buf_l2_cdata_free(). Without this we can trip the assertion in arc_hdr_realloc() if INVARIANTS option is enabled. Approved by: re (kib) MFC after:1 week Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c == --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c Mon Jun 13 16:48:27 2016(r301872) +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c Mon Jun 13 18:39:13 2016(r301873) @@ -2249,6 +2249,7 @@ arc_buf_l2_cdata_free(arc_buf_hdr_t *hdr ASSERT3P(hdr->b_l1hdr.b_tmp_cdata, ==, hdr->b_l1hdr.b_buf->b_data); ASSERT3U(hdr->b_l2hdr.b_compress, ==, ZIO_COMPRESS_OFF); + hdr->b_l1hdr.b_tmp_cdata = NULL; return; } ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r300943 - in head: . lib/libc++ lib/libcxxrt share/mk
On 6/12/2016 1:02 PM, Andreas Tobler wrote: > Hi Bryan, > > On 29.05.16 08:20, Bryan Drewery wrote: >> Author: bdrewery >> Date: Sun May 29 06:20:15 2016 >> New Revision: 300943 >> URL: https://svnweb.freebsd.org/changeset/base/300943 >> >> Log: >> GCC External: Revert r300886, r300904, r300917, r300918 >> >> The fix in r300873 is mostly enough. A fix for lib32 will be >> committed.separately. > > Did this commit already happen? > > I still suffer a broken buildworld on powerpc64 for 32-bit with internal > tools. > > Unknown option -std=c++11... Try with this patch please, number of -j doesn't matter. https://people.freebsd.org/~bdrewery/patches/libcompat-xgcc-c++11.diff -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
svn commit: r301874 - head/usr.sbin/extattr/tests
Author: asomers
Date: Mon Jun 13 22:00:44 2016
New Revision: 301874
URL: https://svnweb.freebsd.org/changeset/base/301874
Log:
Fix usr.sbin/extattr testcases on tmpfs
Skip the usr.sbin/extattr testscases if $TMPDIR is tmpfs, which doesn't
support extended attributes
PR: 210184
Reported by: ngie
Reviewed by: ngie
Approved by: re (glebius)
MFC after:4 weeks
Differential Revision:https://reviews.freebsd.org/D6802
Sponsored by: Spectra Logic Corp
Modified:
head/usr.sbin/extattr/tests/extattr_test.sh
Modified: head/usr.sbin/extattr/tests/extattr_test.sh
==
--- head/usr.sbin/extattr/tests/extattr_test.sh Mon Jun 13 18:39:13 2016
(r301873)
+++ head/usr.sbin/extattr/tests/extattr_test.sh Mon Jun 13 22:00:44 2016
(r301874)
@@ -30,6 +30,7 @@ bad_namespace_head() {
atf_set "descr" "Can't set attributes for nonexistent namespaces"
}
bad_namespace_body() {
+ check_fs
touch foo
atf_check -s not-exit:0 -e match:"Invalid argument" \
setextattr badnamespace myattr X foo
@@ -42,6 +43,7 @@ hex_head() {
atf_set "descr" "Set and get attribute values in hexadecimal"
}
hex_body() {
+ check_fs
touch foo
atf_check -s exit:0 -o empty setextattr user myattr XYZ foo
atf_check -s exit:0 -o inline:"58 59 5a\n" \
@@ -53,6 +55,7 @@ hex_nonascii_head() {
atf_set "descr" "Get binary attribute values in hexadecimal"
}
hex_nonascii_body() {
+ check_fs
touch foo
BINSTUFF=`echo $'\x20\x30\x40\x55\x66\x70\x81\xa2\xb3\xee\xff'`
atf_check -s exit:0 -o empty setextattr user myattr "$BINSTUFF" foo
@@ -66,6 +69,7 @@ long_name_head() {
atf_set "descr" "A maximum length attribute name"
}
long_name_body() {
+ check_fs
# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965
atf_expect_fail "BUG 208965 extattr(2) doesn't allow maxlen attr names"
@@ -84,6 +88,7 @@ loud_head() {
atf_set "descr" "Loud (non -q) output for each command"
}
loud_body() {
+ check_fs
touch foo
# setextattr(8) and friends print hard tabs. Use printf to convert
# them to spaces before checking the output.
@@ -101,6 +106,7 @@ noattrs_head() {
atf_set "descr" "A file with no extended attributes"
}
noattrs_body() {
+ check_fs
touch foo
atf_check -s exit:0 -o empty lsextattr -q user foo
}
@@ -110,6 +116,7 @@ nonexistent_file_head() {
atf_set "descr" "A file that does not exist"
}
nonexistent_file_body() {
+ check_fs
atf_check -s exit:1 -e match:"No such file or directory" \
lsextattr user foo
atf_check -s exit:1 -e match:"No such file or directory" \
@@ -125,6 +132,7 @@ null_head() {
atf_set "descr" "NUL-terminate an attribute value"
}
null_body() {
+ check_fs
touch foo
atf_check -s exit:0 -o empty setextattr -n user myattr myvalue foo
atf_check -s exit:0 -o inline:"myvalue\0\n" getextattr -q user myattr
foo
@@ -135,6 +143,7 @@ one_user_attr_head() {
atf_set "descr" "A file with one extended attribute"
}
one_user_attr_body() {
+ check_fs
touch foo
atf_check -s exit:0 -o empty setextattr user myattr myvalue foo
atf_check -s exit:0 -o inline:"myattr\n" lsextattr -q user foo
@@ -149,6 +158,7 @@ one_system_attr_head() {
atf_set "require.user" "root"
}
one_system_attr_body() {
+ check_fs
touch foo
atf_check -s exit:0 -o empty setextattr system myattr myvalue foo
atf_check -s exit:0 -o inline:"myattr\n" lsextattr -q system foo
@@ -162,6 +172,7 @@ stdin_head() {
atf_set "descr" "Set attribute value from stdin"
}
stdin_body() {
+ check_fs
dd if=/dev/random of=infile bs=1k count=8
touch foo
setextattr -i user myattr foo < infile || atf_fail "setextattr failed"
@@ -175,6 +186,7 @@ stringify_head() {
atf_set "descr" "Stringify the output of getextattr"
}
stringify_body() {
+ check_fs
touch foo
atf_check -s exit:0 -o empty setextattr user myattr "my value" foo
atf_check -s exit:0 -o inline:"\"my\\\040value\"\n" \
@@ -186,6 +198,7 @@ symlink_head() {
atf_set "descr" "A symlink to an ordinary file"
}
symlink_body() {
+ check_fs
touch foo
ln -s foo foolink
atf_check -s exit:0 -o empty setextattr user myattr myvalue foolink
@@ -199,6 +212,7 @@ symlink_nofollow_head() {
atf_set "descr" "Operating directly on a symlink"
}
symlink_nofollow_body() {
+ check_fs
touch foo
ln -s foo foolink
# Check that with -h we can operate directly on the link
@@ -221,6 +235,7 @@ system_and_user_attrs_head() {
atf_set "require.user" "root"
}
system_and_user_attrs_body() {
+ check_fs
touch f
svn commit: r301875 - head/sys/netinet6
Author: pfg
Date: Mon Jun 13 22:31:16 2016
New Revision: 301875
URL: https://svnweb.freebsd.org/changeset/base/301875
Log:
Remove the SIOCSIFALIFETIME_IN6 ioctl.
The SIOCSIFALIFETIME_IN6 provided by the kame project is unused,
it can't really be used safely and has been completely removed from
NetBSD and OpenBSD.
Obtained from:NetBSD (kern/35897)
PR: 210148 (exp-run)
Reviewed by: ae, hrs
Relnotes: yes
Approved by: re (glebius)
Differential Revision:https://reviews.freebsd.org/D5491
Modified:
head/sys/netinet6/in6.c
head/sys/netinet6/in6_var.h
Modified: head/sys/netinet6/in6.c
==
--- head/sys/netinet6/in6.c Mon Jun 13 22:00:44 2016(r301874)
+++ head/sys/netinet6/in6.c Mon Jun 13 22:31:16 2016(r301875)
@@ -360,7 +360,6 @@ in6_control(struct socket *so, u_long cm
case SIOCSPFXFLUSH_IN6:
case SIOCSRTRFLUSH_IN6:
case SIOCGIFALIFETIME_IN6:
- case SIOCSIFALIFETIME_IN6:
case SIOCGIFSTAT_IN6:
case SIOCGIFSTAT_ICMP6:
sa6 = &ifr->ifr_addr;
@@ -459,34 +458,6 @@ in6_control(struct socket *so, u_long cm
goto out;
}
break;
-
- case SIOCSIFALIFETIME_IN6:
- {
- struct in6_addrlifetime *lt;
-
- if (td != NULL) {
- error = priv_check(td, PRIV_NETINET_ALIFETIME6);
- if (error)
- goto out;
- }
- if (ia == NULL) {
- error = EADDRNOTAVAIL;
- goto out;
- }
- /* sanity for overflow - beware unsigned */
- lt = &ifr->ifr_ifru.ifru_lifetime;
- if (lt->ia6t_vltime != ND6_INFINITE_LIFETIME &&
- lt->ia6t_vltime + time_uptime < time_uptime) {
- error = EINVAL;
- goto out;
- }
- if (lt->ia6t_pltime != ND6_INFINITE_LIFETIME &&
- lt->ia6t_pltime + time_uptime < time_uptime) {
- error = EINVAL;
- goto out;
- }
- break;
- }
}
switch (cmd) {
@@ -572,21 +543,6 @@ in6_control(struct socket *so, u_long cm
}
break;
- case SIOCSIFALIFETIME_IN6:
- ia->ia6_lifetime = ifr->ifr_ifru.ifru_lifetime;
- /* for sanity */
- if (ia->ia6_lifetime.ia6t_vltime != ND6_INFINITE_LIFETIME) {
- ia->ia6_lifetime.ia6t_expire =
- time_uptime + ia->ia6_lifetime.ia6t_vltime;
- } else
- ia->ia6_lifetime.ia6t_expire = 0;
- if (ia->ia6_lifetime.ia6t_pltime != ND6_INFINITE_LIFETIME) {
- ia->ia6_lifetime.ia6t_preferred =
- time_uptime + ia->ia6_lifetime.ia6t_pltime;
- } else
- ia->ia6_lifetime.ia6t_preferred = 0;
- break;
-
case SIOCAIFADDR_IN6:
{
struct nd_prefixctl pr0;
Modified: head/sys/netinet6/in6_var.h
==
--- head/sys/netinet6/in6_var.h Mon Jun 13 22:00:44 2016(r301874)
+++ head/sys/netinet6/in6_var.h Mon Jun 13 22:31:16 2016(r301875)
@@ -453,7 +453,6 @@ struct in6_rrenumreq {
#define SIOCSRTRFLUSH_IN6 _IOWR('i', 80, struct in6_ifreq)
#define SIOCGIFALIFETIME_IN6 _IOWR('i', 81, struct in6_ifreq)
-#define SIOCSIFALIFETIME_IN6 _IOWR('i', 82, struct in6_ifreq)
#define SIOCGIFSTAT_IN6_IOWR('i', 83, struct in6_ifreq)
#define SIOCGIFSTAT_ICMP6 _IOWR('i', 84, struct in6_ifreq)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301876 - head/usr.bin/calendar/calendars
Author: mahrens Date: Mon Jun 13 23:36:15 2016 New Revision: 301876 URL: https://svnweb.freebsd.org/changeset/base/301876 Log: Add myself (mahrens) to calendar.freebsd Approved by: mckusick Approved by: re (gjb) Modified: head/usr.bin/calendar/calendars/calendar.freebsd Modified: head/usr.bin/calendar/calendars/calendar.freebsd == --- head/usr.bin/calendar/calendars/calendar.freebsdMon Jun 13 22:31:16 2016(r301875) +++ head/usr.bin/calendar/calendars/calendar.freebsdMon Jun 13 23:36:15 2016(r301876) @@ -338,6 +338,7 @@ 10/25 Eric Melville born in Los Gatos, California, United States, 1980 10/25 Julien Laffaye born in Toulouse, France, 1988 10/25 Ashish SHUKLA born in Kanpur, India, 1985 +10/26 Matthew Ahrens born in United States, 1979 10/26 Philip M. Gollucci born in Silver Spring, Maryland, United States, 1979 10/27 Takanori Watanabe born in Numazu, Shizuoka, Japan, 1972 11/05 M. Warner Losh born in Kansas City, Kansas, United States, 1966 ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r301814 - in head/sys: conf modules
On 6/10/2016 12:06 PM, Jonathan T. Looney wrote: > Author: jtl > Date: Fri Jun 10 19:06:11 2016 > New Revision: 301814 > URL: https://svnweb.freebsd.org/changeset/base/301814 > > Log: > Change the default build behavior so we don't compile extra TCP modules by > default. At least initially, the feature to support multiple TCP stacks is > aimed at supporting advanced use cases and TCP development, but it is not > necessarily aimed at a wide audience. Therefore, there is no need to build > and install the extra TCP stacks by default. Instead, the people who are > using or developing this functionality can add the extra option to build/ > install the extra TCP stacks. > > However, we do want to build the extra TCP stacks as part of test builds > (e.g. LINT or tinderbox) to ensure that developers who are testing their > changes will know that their changes do not break the additional TCP > stack modules. > > After this change, a user will need to add WITH_EXTRA_TCP_STACKS=1 to > make.conf or the kernel config in order to build the extra TCP modules. > > Differential Revision: https://reviews.freebsd.org/D6795 > Reviewed by:sjg > Approved by:re (kib) > > Modified: > head/sys/conf/kern.opts.mk > head/sys/conf/kern.post.mk > head/sys/modules/Makefile > > Modified: head/sys/conf/kern.opts.mk > == > --- head/sys/conf/kern.opts.mkFri Jun 10 18:47:11 2016 > (r301813) > +++ head/sys/conf/kern.opts.mkFri Jun 10 19:06:11 2016 > (r301814) > @@ -45,6 +45,7 @@ __DEFAULT_YES_OPTIONS = \ > > __DEFAULT_NO_OPTIONS = \ > EISA \ > +EXTRA_TCP_STACKS \ > NAND \ > OFED no description found for WITH_EXTRA_TCP_STACKS, skipping A src.conf.5 handler is needed for this. Please add a WITH_EXTRA_TCP_STACKS file into tools/build/options, svn commit, svn up, and then run from that directory: ./makeman > ../../../share/man/man5/src.conf.5 Then commit ../../../share/man/man5/src.conf.5 (That's the process at least, both commits need re@ approval) -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
Re: svn commit: r301849 - head/sys/mips/mips
On Mon, 13 Jun 2016 03:17:00 + (UTC) Adrian Chadd wrote: > Author: adrian > Date: Mon Jun 13 03:17:00 2016 > New Revision: 301849 > URL: https://svnweb.freebsd.org/changeset/base/301849 > > Log: > [mips] set hardfloat for fpu instruction generation for > gcc/binutils 5.x > This allows -HEAD to be compiled again using the gcc-5 mips port > compiler. > Reviewed by:imp > Approved by:re@ > > Modified: > head/sys/mips/mips/swtch.S > > Modified: head/sys/mips/mips/swtch.S > == > --- head/sys/mips/mips/swtch.SMon Jun 13 03:03:08 2016 > (r301848) +++ head/sys/mips/mips/swtch.S Mon Jun 13 03:17:00 > 2016 (r301849) @@ -400,6 +400,7 @@ END(cpu_switch) > * > > * > */ > +.set hardfloat > LEAF(MipsSwitchFPState) > mfc0t1, MIPS_COP_0_STATUS # Save old SR > li t0, MIPS_SR_COP_1_BIT # enable the > coprocessor Hi, https://github.com/akabaev/freebsd/commit/5735b8108c8831a5a649815318391789e977a198 is a bit more complete version that only enables hardfloat in routines that need it, not in random place of the file and for the rest of it. -- Alexander Kabaev pgpIVPympkI4f.pgp Description: Цифровая подпись OpenPGP
Re: svn commit: r301814 - in head/sys: conf modules
On 6/13/16, 8:24 PM, "Bryan Drewery" wrote: >no description found for WITH_EXTRA_TCP_STACKS, skipping >A src.conf.5 handler is needed for this. > > >Please add a WITH_EXTRA_TCP_STACKS file into tools/build/options, svn >commit, svn up, and then >run from that directory: > >./makeman > ../../../share/man/man5/src.conf.5 > >Then commit ../../../share/man/man5/src.conf.5 > >(That's the process at least, both commits need re@ approval) Thanks for the info! I'll add it to our existing "to do" item to add documentation for this feature. (In theory, that will happen in the next week or so.) Jonathan ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301877 - head/sys/compat/linuxkpi/common/src
Author: markj Date: Tue Jun 14 03:57:00 2016 New Revision: 301877 URL: https://svnweb.freebsd.org/changeset/base/301877 Log: Add a missing error check for a malloc() call in idr_get(). Submitted by: Matt Joras Approved by: re (gjb) MFC after:1 week Sponsored by: EMC / Isilon Storage Division Modified: head/sys/compat/linuxkpi/common/src/linux_idr.c Modified: head/sys/compat/linuxkpi/common/src/linux_idr.c == --- head/sys/compat/linuxkpi/common/src/linux_idr.c Mon Jun 13 23:36:15 2016(r301876) +++ head/sys/compat/linuxkpi/common/src/linux_idr.c Tue Jun 14 03:57:00 2016(r301877) @@ -292,7 +292,8 @@ idr_get(struct idr *idr) return (il); } il = malloc(sizeof(*il), M_IDR, M_ZERO | M_NOWAIT); - bitmap_fill(&il->bitmap, IDR_SIZE); + if (il != NULL) + bitmap_fill(&il->bitmap, IDR_SIZE); return (il); } ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r300770 - in head: . contrib/libc++/include contrib/libc++/include/experimental contrib/libc++/include/ext contrib/libc++/src contrib/libc++/src/include contrib/libc++/src/support lib/
On 5/27/16 9:19 AM, Dimitry Andric wrote: > This is most likely caused by the option: > > -isystem > /scratch/tmp/asomers/obj/home/asomers/freebsd/head/lib32/usr/include > > because that forces this path to become before any auto-detected system > include directory. Note that this option is not needed, since the other > option: > > --sysroot=/scratch/tmp/asomers/obj/home/asomers/freebsd/head/lib32 > > is already taking care of adding the right include directories. It even > warns about the duplicate directory: > > ignoring duplicate directory > "/scratch/tmp/asomers/obj/home/asomers/freebsd/head/lib32/usr/include" Argh, I wish GCC cross-compiler wasn't so dumb. It does require -isystem despite --sysroot. It's working currently due to a mistake of having X_COMPILER_TYPE set even for native GCC builds. This is just a reminder that GCC --sysroot is not nearly as useful and obvious as clang's. I'm unwinding some bugs from this and other related X_COMPILER changes. -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
Re: svn commit: r301849 - head/sys/mips/mips
I'll test that now. Thanks! -a On 13 June 2016 at 18:36, Alexander Kabaev wrote: > On Mon, 13 Jun 2016 03:17:00 + (UTC) > Adrian Chadd wrote: > >> Author: adrian >> Date: Mon Jun 13 03:17:00 2016 >> New Revision: 301849 >> URL: https://svnweb.freebsd.org/changeset/base/301849 >> >> Log: >> [mips] set hardfloat for fpu instruction generation for >> gcc/binutils 5.x >> This allows -HEAD to be compiled again using the gcc-5 mips port >> compiler. >> Reviewed by:imp >> Approved by:re@ >> >> Modified: >> head/sys/mips/mips/swtch.S >> >> Modified: head/sys/mips/mips/swtch.S >> == >> --- head/sys/mips/mips/swtch.SMon Jun 13 03:03:08 2016 >> (r301848) +++ head/sys/mips/mips/swtch.S Mon Jun 13 03:17:00 >> 2016 (r301849) @@ -400,6 +400,7 @@ END(cpu_switch) >> * >> >> * >> */ >> +.set hardfloat >> LEAF(MipsSwitchFPState) >> mfc0t1, MIPS_COP_0_STATUS # Save old SR >> li t0, MIPS_SR_COP_1_BIT # enable the >> coprocessor > > Hi, > > https://github.com/akabaev/freebsd/commit/5735b8108c8831a5a649815318391789e977a198 > > is a bit more complete version that only enables hardfloat in routines > that need it, not in random place of the file and for the rest of it. > > -- > Alexander Kabaev ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r301878 - head/sys/mips/mips
Author: adrian Date: Tue Jun 14 06:21:51 2016 New Revision: 301878 URL: https://svnweb.freebsd.org/changeset/base/301878 Log: [mips] Tidy up setting/clearing the hardfloat flag. Submitted by: kan Approved by: re (delphij) Modified: head/sys/mips/mips/swtch.S Modified: head/sys/mips/mips/swtch.S == --- head/sys/mips/mips/swtch.S Tue Jun 14 03:57:00 2016(r301877) +++ head/sys/mips/mips/swtch.S Tue Jun 14 06:21:51 2016(r301878) @@ -400,8 +400,9 @@ END(cpu_switch) * * */ -.set hardfloat LEAF(MipsSwitchFPState) + .set push + .set hardfloat mfc0t1, MIPS_COP_0_STATUS # Save old SR li t0, MIPS_SR_COP_1_BIT # enable the coprocessor mtc0t0, MIPS_COP_0_STATUS @@ -503,6 +504,7 @@ LEAF(MipsSwitchFPState) ITLBNOPFIX j ra nop + .set pop END(MipsSwitchFPState) /* @@ -523,6 +525,8 @@ END(MipsSwitchFPState) * */ LEAF(MipsSaveCurFPState) + .set push + .set hardfloat PTR_L a0, TD_PCB(a0) # get pointer to pcb for thread mfc0t1, MIPS_COP_0_STATUS # Disable interrupts and li t0, MIPS_SR_COP_1_BIT # enable the coprocessor @@ -581,6 +585,7 @@ LEAF(MipsSaveCurFPState) ITLBNOPFIX j ra nop + .set pop END(MipsSaveCurFPState) /* ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
