svn commit: r226961 - in head/bin: cat ln mkdir mv rm test

2011-10-31 Thread Ed Schouten 
Author: ed
Date: Mon Oct 31 08:59:17 2011
New Revision: 226961
URL: http://svn.freebsd.org/changeset/base/226961

Log:
  Put some static keywords in the source code.
  
  For these simple utilities, it doesn't harm to make all global variables
  static. In fact, this allows the compiler to perform better forms of
  optimisation and analysis.

Modified:
  head/bin/cat/cat.c
  head/bin/ln/ln.c
  head/bin/mkdir/mkdir.c
  head/bin/mv/mv.c
  head/bin/rm/rm.c
  head/bin/test/test.c

Modified: head/bin/cat/cat.c
==
--- head/bin/cat/cat.c  Mon Oct 31 08:48:27 2011(r226960)
+++ head/bin/cat/cat.c  Mon Oct 31 08:59:17 2011(r226961)
@@ -64,9 +64,9 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 
-int bflag, eflag, nflag, sflag, tflag, vflag;
-int rval;
-const char *filename;
+static int bflag, eflag, nflag, sflag, tflag, vflag;
+static int rval;
+static const char *filename;
 
 static void usage(void);
 static void scanfiles(char *argv[], int cooked);

Modified: head/bin/ln/ln.c
==
--- head/bin/ln/ln.cMon Oct 31 08:48:27 2011(r226960)
+++ head/bin/ln/ln.cMon Oct 31 08:59:17 2011(r226961)
@@ -54,16 +54,16 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 
-intfflag;  /* Unlink existing files. */
-intFflag;  /* Remove empty directories also. */
-inthflag;  /* Check new name for symlink first. */
-intiflag;  /* Interactive mode. */
-intPflag;  /* Create hard links to symlinks. */
-intsflag;  /* Symbolic, not hard, link. */
-intvflag;  /* Verbose output. */
-intwflag;  /* Warn if symlink target does not
+static int fflag;  /* Unlink existing files. */
+static int Fflag;  /* Remove empty directories also. */
+static int hflag;  /* Check new name for symlink first. */
+static int iflag;  /* Interactive mode. */
+static int Pflag;  /* Create hard links to symlinks. */
+static int sflag;  /* Symbolic, not hard, link. */
+static int vflag;  /* Verbose output. */
+static int wflag;  /* Warn if symlink target does not
 * exist, and -f is not enabled. */
-char   linkch;
+static charlinkch;
 
 intlinkit(const char *, const char *, int);
 void   usage(void);

Modified: head/bin/mkdir/mkdir.c
==
--- head/bin/mkdir/mkdir.c  Mon Oct 31 08:48:27 2011(r226960)
+++ head/bin/mkdir/mkdir.c  Mon Oct 31 08:59:17 2011(r226961)
@@ -56,7 +56,7 @@ __FBSDID("$FreeBSD$");
 static int build(char *, mode_t);
 static voidusage(void);
 
-int vflag;
+static int vflag;
 
 int
 main(int argc, char *argv[])

Modified: head/bin/mv/mv.c
==
--- head/bin/mv/mv.cMon Oct 31 08:48:27 2011(r226960)
+++ head/bin/mv/mv.cMon Oct 31 08:59:17 2011(r226961)
@@ -68,7 +68,7 @@ __FBSDID("$FreeBSD$");
 /* Exit code for a failed exec. */
 #define EXEC_FAILED 127
 
-int fflg, iflg, nflg, vflg;
+static int fflg, iflg, nflg, vflg;
 
 static int copy(const char *, const char *);
 static int do_move(const char *, const char *);

Modified: head/bin/rm/rm.c
==
--- head/bin/rm/rm.cMon Oct 31 08:48:27 2011(r226960)
+++ head/bin/rm/rm.cMon Oct 31 08:59:17 2011(r226961)
@@ -57,10 +57,10 @@ __FBSDID("$FreeBSD$");
 #include 
 #include 
 
-int dflag, eval, fflag, iflag, Pflag, vflag, Wflag, stdin_ok;
-int rflag, Iflag;
-uid_t uid;
-volatile sig_atomic_t info;
+static int dflag, eval, fflag, iflag, Pflag, vflag, Wflag, stdin_ok;
+static int rflag, Iflag;
+static uid_t uid;
+static volatile sig_atomic_t info;
 
 intcheck(char *, char *, struct stat *);
 intcheck2(char **);

Modified: head/bin/test/test.c
==
--- head/bin/test/test.cMon Oct 31 08:48:27 2011(r226960)
+++ head/bin/test/test.cMon Oct 31 08:59:17 2011(r226961)
@@ -118,7 +118,7 @@ enum token_types {
PAREN
 };
 
-struct t_op {
+static struct t_op {
const char *op_text;
short op_num, op_type;
 } const ops [] = {
@@ -165,10 +165,10 @@ struct t_op {
{0, 0,  0}
 };
 
-struct t_op const *t_wp_op;
-int nargc;
-char **t_wp;
-int parenlevel;
+static struct t_op const *t_wp_op;
+static int nargc;
+static char **t_wp;
+static int parenlevel;
 
 static int

svn commit: r226966 - head/sys/dev/md

2011-10-31 Thread Andrey V. Elsukov 
Author: ae
Date: Mon Oct 31 10:53:27 2011
New Revision: 226966
URL: http://svn.freebsd.org/changeset/base/226966

Log:
  Add information about MD_READONLY and MD_COMPRESS flags to the
  configuration dump.
  
  MFC after:1 week

Modified:
  head/sys/dev/md/md.c

Modified: head/sys/dev/md/md.c
==
--- head/sys/dev/md/md.cMon Oct 31 09:27:10 2011(r226965)
+++ head/sys/dev/md/md.cMon Oct 31 10:53:27 2011(r226966)
@@ -1370,6 +1370,11 @@ g_md_dumpconf(struct sbuf *sb, const cha
indent, (uintmax_t) mp->fwsectors);
sbuf_printf(sb, "%s%ju\n",
indent, (uintmax_t) mp->mediasize);
+   sbuf_printf(sb, "%s%s\n", 
indent,
+   (mp->flags & MD_COMPRESS) == 0 ? "off": "on");
+   sbuf_printf(sb, "%s%s\n", indent,
+   (mp->flags & MD_READONLY) == 0 ? "read-write":
+   "read-only");
sbuf_printf(sb, "%s%s\n", indent,
type);
if (mp->type == MD_VNODE && mp->vnode != NULL)
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226947 - in head/sys: dev/esp sparc64/sbus

2011-10-31 Thread Bruce Evans 

On Mon, 31 Oct 2011, Alexey Dokuchaev wrote:


On Sun, Oct 30, 2011 at 09:17:42PM +, Marius Strobl wrote:

Log:
  - Use device_t rather than the NetBSDish struct device.


Hmm, I though that style(9) advises against this practice:

   Avoid using typedefs for structure types.  Typedefs are problematic
   because they do not properly hide their underlying type; [...]

   When convention requires a typedef, make its name match the struct tag.
   Avoid typedefs ending in _t, except as specified in Standard C or by
   POSIX.

Does these rules not apply for struct device for some reason?


Yes (they don't apply here).  device_t is one of a few properly opaque
typedefs for struct pointers.  'struct device' is only (completely)
declared in kern/subr_bus.c.  Thus the implementation details of it
obviously cannot escape to drivers.  Most of the APIs in 
are supposed to be like this.  But `typedef struct kobj_class driver_t'
and `#define driver_method_t kobj_method_t' are gross exceptions.
 has to include  for dereferencing these, and
kobj.h breaks the rule by providing both typedefs for struct pointers
and complete struct declarations.

Bruce
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Peter Holm 
Author: pho
Date: Mon Oct 31 15:01:47 2011
New Revision: 226967
URL: http://svn.freebsd.org/changeset/base/226967

Log:
  The kern_renameat() looks up the fvp using the DELETE flag, which causes
  the removal of the name cache entry for fvp.
  
  Reported by:  Anton Yuzhaninov 
  In collaboration with:kib
  MFC after:1 week

Modified:
  head/sys/ufs/ufs/ufs_vnops.c

Modified: head/sys/ufs/ufs/ufs_vnops.c
==
--- head/sys/ufs/ufs/ufs_vnops.cMon Oct 31 10:53:27 2011
(r226966)
+++ head/sys/ufs/ufs/ufs_vnops.cMon Oct 31 15:01:47 2011
(r226967)
@@ -1519,6 +1519,13 @@ relock:
cache_purge(fdvp);
}
error = ufs_dirremove(fdvp, fip, fcnp->cn_flags, 0);
+   /*
+* As the relookup of the fvp is done in two steps:
+* ufs_lookup_ino() and then VFS_VGET(), another thread might do a
+* normal lookup of the from name just before the VFS_VGET() call,
+* causing the cache entry to be re-instantiated.
+*/
+   cache_purge(fvp);
 
 unlockout:
vput(fdvp);
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226928 - head/sys/vm

2011-10-31 Thread Sergey Kandaurov 
On 30 October 2011 09:06, Alan Cox  wrote:
> Author: alc
> Date: Sun Oct 30 05:06:14 2011
> New Revision: 226928
> URL: http://svn.freebsd.org/changeset/base/226928
>
> Log:
>  Eliminate vm_phys_bootstrap_alloc().  It was a failed attempt at
>  eliminating duplicated code in the various pmap implementations.
>
>  Micro-optimize vm_phys_free_pages().
>
>  Introduce vm_phys_free_contig().  It is fast routine for freeing an
>  arbitrary number of physically contiguous pages.  In particular, it
>  doesn't require the number of pages to be a power of two.
>
>  Use "u_long" instead of "unsigned long".
>
>  Bruce Evans (bde@) has convinced me that the "boundary" parameters
>  to kmem_alloc_contig(), vm_phys_alloc_contig(), and
>  vm_reserv_reclaim_contig() should be of type "vm_paddr_t" and not
>  "u_long".  Make this change.

Hello.

After updating to this revision I constantly get random mtrash_ctor()
assertions. [most often during make installkernel, otherwise idle.]

Below is one of them (previous memory consumers in panicstr differ).

Memory modified after free 0xfe0002700800(120) val=0 @ 0xfe0002700800
panic: Most recently used by proc-args

cpuid = 1
KDB: stack backtrace:
db_trace_self_wrapper() at 0x802e009a = db_trace_self_wrapper+0x2a
kdb_backtrace() at 0x80486f17 = kdb_backtrace+0x37
panic() at 0x8044f87e = panic+0x2ee
mtrash_ctor() at 0x8068c904 = mtrash_ctor+0x84
uma_zalloc_arg() at 0x8068c16c = uma_zalloc_arg+0x2dc
malloc() at 0x8043abd6 = malloc+0xc6
pargs_alloc() at 0x804425d3 = pargs_alloc+0x23
kern_execve() at 0x8041cb47 = kern_execve+0x1277
sys_execve() at 0x8041ce6d = sys_execve+0x3d
amd64_syscall() at 0x806c6319 = amd64_syscall+0x299
Xfast_syscall() at 0x806b16b7 = Xfast_syscall+0xf7
--- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x800d4cbec, rsp =
0x7fffd1a8, rbp = 0x8014124a0 ---


-- 
wbr,
pluknet
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread John Baldwin 
On Monday, October 31, 2011 11:01:47 am Peter Holm wrote:
> Author: pho
> Date: Mon Oct 31 15:01:47 2011
> New Revision: 226967
> URL: http://svn.freebsd.org/changeset/base/226967
> 
> Log:
>   The kern_renameat() looks up the fvp using the DELETE flag, which causes
>   the removal of the name cache entry for fvp.
>   
>   Reported by:Anton Yuzhaninov 
>   In collaboration with:  kib
>   MFC after:  1 week

Hmm, the log message doesn't seem to quite match the change?  Was it 
truncated?

> Modified:
>   head/sys/ufs/ufs/ufs_vnops.c
> 
> Modified: head/sys/ufs/ufs/ufs_vnops.c
> 
==
> --- head/sys/ufs/ufs/ufs_vnops.c  Mon Oct 31 10:53:27 2011
> (r226966)
> +++ head/sys/ufs/ufs/ufs_vnops.c  Mon Oct 31 15:01:47 2011
> (r226967)
> @@ -1519,6 +1519,13 @@ relock:
>   cache_purge(fdvp);
>   }
>   error = ufs_dirremove(fdvp, fip, fcnp->cn_flags, 0);
> + /*
> +  * As the relookup of the fvp is done in two steps:
> +  * ufs_lookup_ino() and then VFS_VGET(), another thread might do a
> +  * normal lookup of the from name just before the VFS_VGET() call,
> +  * causing the cache entry to be re-instantiated.
> +  */
> + cache_purge(fvp);
>  
>  unlockout:
>   vput(fdvp);
> 

-- 
John Baldwin
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226928 - head/sys/vm

2011-10-31 Thread Alan Cox 

On 10/31/2011 11:33, Sergey Kandaurov wrote:

On 30 October 2011 09:06, Alan Cox  wrote:

Author: alc
Date: Sun Oct 30 05:06:14 2011
New Revision: 226928
URL: http://svn.freebsd.org/changeset/base/226928

Log:
  Eliminate vm_phys_bootstrap_alloc().  It was a failed attempt at
  eliminating duplicated code in the various pmap implementations.

  Micro-optimize vm_phys_free_pages().

  Introduce vm_phys_free_contig().  It is fast routine for freeing an
  arbitrary number of physically contiguous pages.  In particular, it
  doesn't require the number of pages to be a power of two.

  Use "u_long" instead of "unsigned long".

  Bruce Evans (bde@) has convinced me that the "boundary" parameters
  to kmem_alloc_contig(), vm_phys_alloc_contig(), and
  vm_reserv_reclaim_contig() should be of type "vm_paddr_t" and not
  "u_long".  Make this change.

Hello.

After updating to this revision I constantly get random mtrash_ctor()
assertions. [most often during make installkernel, otherwise idle.]

Below is one of them (previous memory consumers in panicstr differ).

Memory modified after free 0xfe0002700800(120) val=0 @ 0xfe0002700800
panic: Most recently used by proc-args

cpuid = 1
KDB: stack backtrace:
db_trace_self_wrapper() at 0x802e009a = db_trace_self_wrapper+0x2a
kdb_backtrace() at 0x80486f17 = kdb_backtrace+0x37
panic() at 0x8044f87e = panic+0x2ee
mtrash_ctor() at 0x8068c904 = mtrash_ctor+0x84
uma_zalloc_arg() at 0x8068c16c = uma_zalloc_arg+0x2dc
malloc() at 0x8043abd6 = malloc+0xc6
pargs_alloc() at 0x804425d3 = pargs_alloc+0x23
kern_execve() at 0x8041cb47 = kern_execve+0x1277
sys_execve() at 0x8041ce6d = sys_execve+0x3d
amd64_syscall() at 0x806c6319 = amd64_syscall+0x299
Xfast_syscall() at 0x806b16b7 = Xfast_syscall+0xf7
--- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x800d4cbec, rsp =
0x7fffd1a8, rbp = 0x8014124a0 ---




I've not experienced anything like this, and I can't really see a direct 
connection between the above crash and the change.  So, the only thing 
that I can suggest is reverting one piece of the change at a time.  
Please try this first:


Index: vm/vm_phys.c
===
--- vm/vm_phys.c(revision 226968)
+++ vm/vm_phys.c(working copy)
@@ -758,7 +758,6 @@ vm_phys_alloc_contig(u_long npages, vm_paddr_t low
struct vnode *vp;
vm_paddr_t pa, pa_last, size;
vm_page_t deferred_vdrop_list, m, m_ret;
-   u_long npages_end;
int domain, flind, i, oind, order, pind;

 #if VM_NDOMAIN > 1
@@ -871,10 +870,13 @@ done:
deferred_vdrop_list = m;
}
}
-   /* Return excess pages to the free lists. */
-   npages_end = roundup2(npages, 1 << imin(oind, order));
-   if (npages < npages_end)
-   vm_phys_free_contig(&m_ret[npages], npages_end - npages);
+   for (; i < roundup2(npages, 1 << imin(oind, order)); i++) {
+   m = &m_ret[i];
+   KASSERT(m->order == VM_NFREEORDER,
+   ("vm_phys_alloc_contig: page %p has unexpected order 
%d",

+   m, m->order));
+   vm_phys_free_pages(m, 0);
+   }
mtx_unlock(&vm_page_queue_free_mtx);
while (deferred_vdrop_list != NULL) {
vdrop((struct vnode *)deferred_vdrop_list->pageq.tqe_prev);

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Peter Holm 
On Mon, Oct 31, 2011 at 12:41:41PM -0400, John Baldwin wrote:
> On Monday, October 31, 2011 11:01:47 am Peter Holm wrote:
> > Author: pho
> > Date: Mon Oct 31 15:01:47 2011
> > New Revision: 226967
> > URL: http://svn.freebsd.org/changeset/base/226967
> > 
> > Log:
> >   The kern_renameat() looks up the fvp using the DELETE flag, which causes
> >   the removal of the name cache entry for fvp.
> >   
> >   Reported by:  Anton Yuzhaninov 
> >   In collaboration with:kib
> >   MFC after:1 week
> 
> Hmm, the log message doesn't seem to quite match the change?  Was it 
> truncated?
> 

No, it was a misunderstanding on my part.

The log message should have read:
"Added missing cache purge of from argument."

- Peter

> > Modified:
> >   head/sys/ufs/ufs/ufs_vnops.c
> > 
> > Modified: head/sys/ufs/ufs/ufs_vnops.c
> > 
> ==
> > --- head/sys/ufs/ufs/ufs_vnops.cMon Oct 31 10:53:27 2011
> > (r226966)
> > +++ head/sys/ufs/ufs/ufs_vnops.cMon Oct 31 15:01:47 2011
> > (r226967)
> > @@ -1519,6 +1519,13 @@ relock:
> > cache_purge(fdvp);
> > }
> > error = ufs_dirremove(fdvp, fip, fcnp->cn_flags, 0);
> > +   /*
> > +* As the relookup of the fvp is done in two steps:
> > +* ufs_lookup_ino() and then VFS_VGET(), another thread might do a
> > +* normal lookup of the from name just before the VFS_VGET() call,
> > +* causing the cache entry to be re-instantiated.
> > +*/
> > +   cache_purge(fvp);
> >  
> >  unlockout:
> > vput(fdvp);
> > 
> 
> -- 
> John Baldwin
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Doug Barton 
On 10/31/2011 10:10, Peter Holm wrote:
> No, it was a misunderstanding on my part.
> 
> The log message should have read:
> "Added missing cache purge of from argument."

So perhaps a forced commit?


-- 

Nothin' ever doesn't change, but nothin' changes much.
-- OK Go

Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price.  :)  http://SupersetSolutions.com/

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226928 - head/sys/vm

2011-10-31 Thread Sergey Kandaurov 
On 31 October 2011 21:13, Alan Cox  wrote:
> On 10/31/2011 11:33, Sergey Kandaurov wrote:
>>
>> On 30 October 2011 09:06, Alan Cox  wrote:
>>>
>>> Author: alc
>>> Date: Sun Oct 30 05:06:14 2011
>>> New Revision: 226928
>>> URL: http://svn.freebsd.org/changeset/base/226928
>>>
>>> Log:
>>>  Eliminate vm_phys_bootstrap_alloc().  It was a failed attempt at
>>>  eliminating duplicated code in the various pmap implementations.
>>>
>>>  Micro-optimize vm_phys_free_pages().
>>>
>>>  Introduce vm_phys_free_contig().  It is fast routine for freeing an
>>>  arbitrary number of physically contiguous pages.  In particular, it
>>>  doesn't require the number of pages to be a power of two.
>>>
>>>  Use "u_long" instead of "unsigned long".
>>>
>>>  Bruce Evans (bde@) has convinced me that the "boundary" parameters
>>>  to kmem_alloc_contig(), vm_phys_alloc_contig(), and
>>>  vm_reserv_reclaim_contig() should be of type "vm_paddr_t" and not
>>>  "u_long".  Make this change.
>>
>> Hello.
>>
>> After updating to this revision I constantly get random mtrash_ctor()
>> assertions. [most often during make installkernel, otherwise idle.]
>>
>> Below is one of them (previous memory consumers in panicstr differ).
>>
>> Memory modified after free 0xfe0002700800(120) val=0 @
>> 0xfe0002700800
>> panic: Most recently used by proc-args
>>
>> cpuid = 1
>> KDB: stack backtrace:
>> db_trace_self_wrapper() at 0x802e009a = db_trace_self_wrapper+0x2a
>> kdb_backtrace() at 0x80486f17 = kdb_backtrace+0x37
>> panic() at 0x8044f87e = panic+0x2ee
>> mtrash_ctor() at 0x8068c904 = mtrash_ctor+0x84
>> uma_zalloc_arg() at 0x8068c16c = uma_zalloc_arg+0x2dc
>> malloc() at 0x8043abd6 = malloc+0xc6
>> pargs_alloc() at 0x804425d3 = pargs_alloc+0x23
>> kern_execve() at 0x8041cb47 = kern_execve+0x1277
>> sys_execve() at 0x8041ce6d = sys_execve+0x3d
>> amd64_syscall() at 0x806c6319 = amd64_syscall+0x299
>> Xfast_syscall() at 0x806b16b7 = Xfast_syscall+0xf7
>> --- syscall (59, FreeBSD ELF64, sys_execve), rip = 0x800d4cbec, rsp =
>> 0x7fffd1a8, rbp = 0x8014124a0 ---
>>
>>
>
> I've not experienced anything like this, and I can't really see a direct
> connection between the above crash and the change.  So, the only thing that
> I can suggest is reverting one piece of the change at a time.  Please try
> this first:
>

 I'm sorry.
It appears that was due to regression in my local changes which triggered
coinciding with this revision. I just reproduced it without your change.
Sorry for noise.

-- 
wbr,
pluknet
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r226971 - head/sys/ufs/ufs

2011-10-31 Thread Peter Holm 
Author: pho
Date: Mon Oct 31 20:24:33 2011
New Revision: 226971
URL: http://svn.freebsd.org/changeset/base/226971

Log:
  Fix the wrong commit log message for r226967: "Added missing cache purge
  of from argument" and fix the comment.

Modified:
  head/sys/ufs/ufs/ufs_vnops.c

Modified: head/sys/ufs/ufs/ufs_vnops.c
==
--- head/sys/ufs/ufs/ufs_vnops.cMon Oct 31 20:03:09 2011
(r226970)
+++ head/sys/ufs/ufs/ufs_vnops.cMon Oct 31 20:24:33 2011
(r226971)
@@ -1520,6 +1520,8 @@ relock:
}
error = ufs_dirremove(fdvp, fip, fcnp->cn_flags, 0);
/*
+* The kern_renameat() looks up the fvp using the DELETE flag, which
+* causes the removal of the name cache entry for fvp.
 * As the relookup of the fvp is done in two steps:
 * ufs_lookup_ino() and then VFS_VGET(), another thread might do a
 * normal lookup of the from name just before the VFS_VGET() call,
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226971 - head/sys/ufs/ufs

2011-10-31 Thread Doug Barton 
On 10/31/2011 13:24, Peter Holm wrote:
> Fix the wrong commit log message for r226967

Awesome, thanks!


-- 

Nothin' ever doesn't change, but nothin' changes much.
-- OK Go

Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price.  :)  http://SupersetSolutions.com/

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Peter Wemm 
On Mon, Oct 31, 2011 at 12:42 PM, Doug Barton  wrote:
> On 10/31/2011 10:10, Peter Holm wrote:
>> No, it was a misunderstanding on my part.
>>
>> The log message should have read:
>> "Added missing cache purge of from argument."
>
> So perhaps a forced commit?

No such thing anymore.



-- 
Peter Wemm - pe...@wemm.org; pe...@freebsd.org; pe...@yahoo-inc.com; KI6FJV
"All of this is for nothing if we don't go to the stars" - JMS/B5
"If Java had true garbage collection, most programs would delete
themselves upon execution." -- Robert Sewell
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Xin LI 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 10/31/11 18:06, Peter Wemm wrote:
> On Mon, Oct 31, 2011 at 12:42 PM, Doug Barton 
> wrote:
>> On 10/31/2011 10:10, Peter Holm wrote:
>>> No, it was a misunderstanding on my part.
>>> 
>>> The log message should have read: "Added missing cache purge of
>>> from argument."
>> 
>> So perhaps a forced commit?
> 
> No such thing anymore.

I think it's a little bit tricky but still possible?

(edit the file and add non-semantic change, for instance a blank line
at the end)
svn ci
(enter commit message)
^Z <-- important
(revert the files to previous state)
fg
and save.

Cheers,
- -- 
Xin LI https://www.delphij.net/
FreeBSD - The Power to Serve!   Live free or die
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAEBCAAGBQJOr0vrAAoJEATO+BI/yjfB690H/2w16ovVzxvgwyIRF3eaZ8H3
GoXsyviUTJ0bnn8pCDba+aS/L6MyxQqOqC3Brl/i6X1/K9eKMvGsfUYRk4oZFimH
g5vbsTLtvZlukRfnwyCRKSwyQk7utqtf1yx0Ae1HijVEkGKYQXDEYGdcQwZJb2aD
eC8DU0sUjE2oR3/pymvrT9SHOId/5LHZTof7f3wQHEtaXCstkbHuiqsCIhO2UgAE
Y+YwEJ1BEZmM8jbI04TQmpOjtddBIRfLIdEbl3pEoQDEhHPKBRHSFK7vTUyT9LFR
KDQWm0OFhbL3OekSDKM/clMPvhTUz0kj+2aN+VD6wkU8kaBg10+YrNIz0+B2lgs=
=DymR
-END PGP SIGNATURE-
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r226976 - head/contrib/tzdata

2011-10-31 Thread Edwin Groothuis 
Author: edwin
Date: Tue Nov  1 02:01:55 2011
New Revision: 226976
URL: http://svn.freebsd.org/changeset/base/226976

Log:
  MFV of r226974, tzdata2011n
  
  - Fiji will end DST on 22 January 2012.
  - Moldova split into two timezones has been cancelled.
  - Cuba will end DST on 13 November 2011
  
  Obtained from:ftp://ftp.iana.org/tz/releases/

Modified:
  head/contrib/tzdata/australasia
  head/contrib/tzdata/backward
  head/contrib/tzdata/europe
  head/contrib/tzdata/northamerica
  head/contrib/tzdata/zone.tab
Directory Properties:
  head/contrib/tzdata/   (props changed)

Modified: head/contrib/tzdata/australasia
==
--- head/contrib/tzdata/australasia Tue Nov  1 01:34:54 2011
(r226975)
+++ head/contrib/tzdata/australasia Tue Nov  1 02:01:55 2011
(r226976)
@@ -1,5 +1,5 @@
 # 
-# @(#)australasia  8.28
+# @(#)australasia  8.29
 # This file is in the public domain, so clarified as of
 # 2009-05-17 by Arthur David Olson.
 
@@ -308,6 +308,20 @@ Zone   Indian/Cocos6:27:40 -   LMT 1900
 # advance at 2am to 3am on October 23, 2011 and one hour back at 3am to 
 # 2am on February 26 next year.
 
+# From Ken Rylander (2011-10-24)
+# Another change to the Fiji DST end date. In the TZ database the end date for
+# Fiji DST 2012, is currently Feb 26. This has been changed to Jan 22.
+#
+# http://www.fiji.gov.fj/index.php?option=com_content&view=article&id=5017:amendments-to-daylight-savings&catid=71:press-releases&Itemid=155";>
+# 
http://www.fiji.gov.fj/index.php?option=com_content&view=article&id=5017:amendments-to-daylight-savings&catid=71:press-releases&Itemid=155
+# 
+# states:
+#
+# The end of daylight saving scheduled initially for the 26th of February 2012
+# has been brought forward to the 22nd of January 2012.
+# The commencement of daylight saving will remain unchanged and start
+# on the  23rd of October, 2011.
+
 # Rule NAMEFROMTO  TYPEIN  ON  AT  SAVELETTER/S
 Rule   Fiji19981999-   Nov Sun>=1  2:001:00S
 Rule   Fiji19992000-   Feb lastSun 3:000   -
@@ -316,7 +330,7 @@ RuleFiji2010only-   Mar lastSun 
3:000
 Rule   Fiji2010only-   Oct 24  2:001:00S
 Rule   Fiji2011only-   Mar Sun>=1  3:000   -
 Rule   Fiji2011only-   Oct 23  2:001:00S
-Rule   Fiji2012only-   Feb 26  3:000   -
+Rule   Fiji2012only-   Jan 22  3:000   -
 # Zone NAMEGMTOFF  RULES   FORMAT  [UNTIL]
 Zone   Pacific/Fiji11:53:40 -  LMT 1915 Oct 26 # Suva
12:00   FijiFJ%sT   # Fiji Time

Modified: head/contrib/tzdata/backward
==
--- head/contrib/tzdata/backwardTue Nov  1 01:34:54 2011
(r226975)
+++ head/contrib/tzdata/backwardTue Nov  1 02:01:55 2011
(r226976)
@@ -1,5 +1,5 @@
 # 
-# @(#)backward 8.10
+# @(#)backward 8.11
 # This file is in the public domain, so clarified as of
 # 2009-05-17 by Arthur David Olson.
 
@@ -67,6 +67,7 @@ Link  America/Havana  Cuba
 Link   Africa/CairoEgypt
 Link   Europe/Dublin   Eire
 Link   Europe/London   Europe/Belfast
+Link   Europe/Chisinau Europe/Tiraspol
 Link   Europe/London   GB
 Link   Europe/London   GB-Eire
 Link   Etc/GMT GMT+0

Modified: head/contrib/tzdata/europe
==
--- head/contrib/tzdata/europe  Tue Nov  1 01:34:54 2011(r226975)
+++ head/contrib/tzdata/europe  Tue Nov  1 02:01:55 2011(r226976)
@@ -1,5 +1,5 @@
 # 
-# @(#)europe   8.39
+# @(#)europe   8.40
 # This file is in the public domain, so clarified as of
 # 2009-05-17 by Arthur David Olson.
 
@@ -1678,6 +1678,18 @@ Zone Europe/Malta0:58:04 -   LMT 1893 Nov
 # a pre-1880 LMT offset of 1:58:32.
 #
 # (which agrees with the earlier entry that had been removed)
+#
+# From Alexander Krivenyshev (2011-10-26)
+# NO need to divide Moldova into two timezones at this point.
+# As of today, Transnistria (Pridnestrovie)- Tiraspol reversed its own
+# decision to abolish DST this winter. 
+# Following Moldova and neighboring Ukraine- Transnistria (Pridnestrovie)-
+# Tiraspol will go back to winter time on October 30, 2011.
+# News from Moldova (in russian):
+# http://ru.publika.md/link_317061.html";>
+# http://ru.publika.md/link_317061.html
+# 
+
 
 # Zone NAMEGMTOFF  RULES   FORMAT  [UNTIL]
 Zone   Europe/Chisinau 1:55:20 -   LMT 1880
@@ -1694,21 +1706,6 @@ Zone Europe/Chisinau 1:55:20 -   LMT 1880
 # See Romania commentary for the guessed 1997 transition to EU rules.

Re: svn commit: r226947 - in head/sys: dev/esp sparc64/sbus

2011-10-31 Thread Alexey Dokuchaev 
On Tue, Nov 01, 2011 at 12:01:16AM +1100, Bruce Evans wrote:
> On Mon, 31 Oct 2011, Alexey Dokuchaev wrote:
> >   When convention requires a typedef, make its name match the struct tag.
> >   Avoid typedefs ending in _t, except as specified in Standard C or by
> >   POSIX.
> >
> > Do these rules not apply for struct device for some reason?
> 
> Yes (they don't apply here).  device_t is one of a few properly opaque
> typedefs for struct pointers.  'struct device' is only (completely)
> declared in kern/subr_bus.c.  Thus the implementation details of it
> obviously cannot escape to drivers.  Most of the APIs in 
> are supposed to be like this.  But `typedef struct kobj_class driver_t'
> and `#define driver_method_t kobj_method_t' are gross exceptions.
>  has to include  for dereferencing these, and
> kobj.h breaks the rule by providing both typedefs for struct pointers
> and complete struct declarations.

Thanks for detailed explanation Bruce.

./danfe
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"