[sr-dev] Re: [kamailio/kamailio] core: add support for custom log function (PR #3902)
Closed #3902. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3902#event-14410454366 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: add support for custom log function (PR #3902)
OK, closing. A new PR can be created with other changes. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3902#issuecomment-2376050039 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Possibly adjusting the SDP parser to be more lenient towards scenarios where a stream is being removed/rejected and connection-information "c=" is only available per media
### Description
I encountered an issue with a specific device that is receiving a T.38 fax. The
call gets established towards the device normally with inband media, then the
device requests T.38 media and tries to remove the audio media via sending port
0 in the ReInvite SDP. Also it sends connection-information only on the media
level and there is no "c=" on the session level.
Reading through the related RFCs and the kamailio code and discussing this on
the mailing list, we came to the conclusion that kamailio is doing everything
correct as per RFC. Though we were wondering if it would be possible to adjust
the parser to be not as strict as it is right now, and allow a missing "c="
line on the media-level if the stream is removed/rejected via port 0, since i
see no sense in requiring connection information. Of course we are also in
contact with the vendor to hopefully adjust on their side.
Here are the related RFCs:
1. RFC8866 5.7
`A session description MUST contain either at least one "c=" line in each media
description or a single "c=" line at the session level. It MAY contain a single
session-level "c=" line and additional media-level "c=" line(s)
per-media-description, in which case the media-level values override the
session-level settings for the respective media.`
2. RFC3264 8.2
`Existing media streams are removed by creating a new SDP with the port number
for that stream set to zero. The stream description MAY omit all attributes
present previously, and MAY list just a single media format.`
At first i was especially confused by the RFC3264 8.2 part, since it seemed
correct what the device is sending, but if you read carefully and keep the
wording for SDP in mind only attributes ("a=") MAY be omitted. So a "c=" line
should still be in the SDP for the removed media if it's not included on the
session-level. Or do you see this differently?
### Expected behavior
Kamailio allows and parses the SDP when there is no session-wide "c=", a media
stream is being removed via port zero and there is no "c=" for this media
stream and only the remaining media streams include a "c=" line.
Actual observed behavior
Kamailio throws an error when trying to parse the SDP.
Log Messages
```
[core/parser/sdp/sdp.c:523]: parse_sdp_session(): can't find media IP in
the message
```
SIP Traffic
```
v=0
o=xmserver 1726638425 1726638427 IN IP4 169.254.1.1
s=xmserver
t=0 0
m=audio 0 RTP/AVP 8
m=image 56002 udptl t38
c=IN IP4 169.254.1.1
a=sendrecv
a=T38FaxVersion:0
a=T38MaxBitRate:14400
a=T38FaxFillBitRemoval:0
a=T38FaxTranscodingMMR:0
a=T38FaxTranscodingJBIG:0
a=T38FaxRateManagement:transferredTCF
a=T38FaxMaxBuffer:200
a=T38FaxMaxDatagram:72
a=T38FaxUdpEC:t38UDPRedundancy
```
### Possible Solutions
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.8.3 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE,
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC,
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT,
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES,
TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE
262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 12.2.0
```
* **Operating System**:
```
Debian 12
Linux hostname 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1
(2024-04-11) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3982
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
Hello, I'm already working on an SMPP module, it can already send messages in synchronous mode and supports UCS-2. I have a desire to prepare a module and PR this year. As for the implementation of proto_smpp in OpenSIPS, I have many questions about it, for example, this module does not analyze the sending result, which is very sad. I have a desire to do well - process the send result for asynchronous sending, process message delivery reports, support message concatenation and special SMS with different data_coding and protocol_id. Best regards, Vadim Saranov ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
Reopened #3766. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#event-14395127881 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
Perhaps you have used proto_smpp and have not encountered its shortcomings, but I think that its discussion is not very appropriate on this platform. I will briefly inform you that in this module there is no control over the results of sending commands neither for submit_sm, nor for enquire_link. For example, the absence of a response to enquire_link is not an error for him. It is also not possible to connect multiple SMEs with different credentials to one smpp-server. It seems that this module is in the MVP state, maybe I'm wrong. Best regards, Vadim Saranov ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
Hello Tarik, sorry I don't understand exactly what you mean. You could develop a SMPP module for Kamailio, sure. Maybe you can coordinate with Vadim, it looks that he already has a prototype or similar from previous e-mails. It will be easier for you than starting from the scratch. New modules are usually introduced with a GitHub pull-request to the repository. After a review and eventual changes, they are then introduced into the code base and will be published as part of next stable release. Cheers, Henning > -Original Message- > From: Tarik ogut via sr-dev > Sent: Mittwoch, 25. September 2024 13:45 > To: sr-dev@lists.kamailio.org > Cc: tariko...@gmail.com > Subject: [sr-dev] Re: smpp router project > > I will write smpp module for ims router project, can I get requests about it. > ___ > Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr- > dev-le...@lists.kamailio.org ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:621f3132: core: print errno on tcp bind failure
Module: kamailio
Branch: master
Commit: 621f3132708405939d3a40fb98ae57b793cd246e
URL:
https://github.com/kamailio/kamailio/commit/621f3132708405939d3a40fb98ae57b793cd246e
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-09-25T10:07:44+02:00
core: print errno on tcp bind failure
- log message with value of sr_bind_ipv6_link_local
---
Modified: src/core/tcp_main.c
---
Diff:
https://github.com/kamailio/kamailio/commit/621f3132708405939d3a40fb98ae57b793cd246e.diff
Patch:
https://github.com/kamailio/kamailio/commit/621f3132708405939d3a40fb98ae57b793cd246e.patch
---
diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index 9daaf1ce641..e65520fa7ed 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -3284,12 +3284,14 @@ int tcp_init(struct socket_info *sock_info)
}
#endif
if(bind(sock_info->socket, &addr->s, sockaddru_len(*addr)) == -1) {
- LM_ERR("bind(%x, %p, %d) on %s:%d : %s\n", sock_info->socket,
&addr->s,
- (unsigned)sockaddru_len(*addr),
sock_info->address_str.s,
- sock_info->port_no, strerror(errno));
+ LM_ERR("bind(%x, %p, %d) on [%s]:%d : (%d / %s)\n",
sock_info->socket,
+ &addr->s, (unsigned)sockaddru_len(*addr),
+ sock_info->address_str.s, sock_info->port_no,
errno,
+ strerror(errno));
if(addr->s.sa_family == AF_INET6) {
LM_ERR("might be caused by using a link local address,
is "
- "'bind_ipv6_link_local' set?\n");
+ "'bind_ipv6_link_local' set (now: %d)?\n",
+ sr_bind_ipv6_link_local);
}
goto error;
}
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:6848dd7d: Makefile.defs: version set to 6.0.0-dev3
Module: kamailio Branch: master Commit: 6848dd7d656f872013c857b6b78ebd8bae9b8604 URL: https://github.com/kamailio/kamailio/commit/6848dd7d656f872013c857b6b78ebd8bae9b8604 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-09-25T10:10:11+02:00 Makefile.defs: version set to 6.0.0-dev3 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/6848dd7d656f872013c857b6b78ebd8bae9b8604.diff Patch: https://github.com/kamailio/kamailio/commit/6848dd7d656f872013c857b6b78ebd8bae9b8604.patch --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 1f3e0e81606..c3ae2b8b857 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 6 PATCHLEVEL = 0 SUBLEVEL = 0 -EXTRAVERSION = -dev2 +EXTRAVERSION = -dev3 # memory manager switcher # 0 - f_malloc (fast malloc) ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
Hello, the SNMP module is quite old, I am not aware of any special development documentation for that module. That said, the module README is quite extensive and covers already some content in this regard. Your best bet is probably to have a look to the module README and source code. If you have questions about certain Kamailio module interface topics etc.., just ask on this list again. Cheers, Henning > -Original Message- > From: Tarik ogut via sr-dev > Sent: Mittwoch, 25. September 2024 00:12 > To: sr-dev@lists.kamailio.org > Cc: tariko...@gmail.com > Subject: [sr-dev] smpp router project > > hello i want development about smpp to sip module do you have any > documentation ? > ___ > Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr- > dev-le...@lists.kamailio.org ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
Hello, sorry, I have misread your question initially - please disregard my previous answer. Regarding the SMPP protocol, there were different attempts to develop a module, the oldest is about 20 years ago: https://kamailio.org/mailman3/hyperkitty/list/sr-us...@lists.kamailio.org/thread/NTYNP5CPFGBU6R24ZZE4RTRVNCGKVTXJ/ Have a look also at this issue: https://github.com/kamailio/kamailio/issues/2280 for a discussion of different approaches. There are other projects that have a module (called proto_smpp) for this protocol, maybe this can give you also some hints. Cheers, Henning > -Original Message- > From: Henning Westerholt > Sent: Mittwoch, 25. September 2024 10:14 > To: Kamailio (SER) - Development Mailing List > Cc: tariko...@gmail.com > Subject: RE: [sr-dev] smpp router project > > Hello, > > the SNMP module is quite old, I am not aware of any special development > documentation for that module. That said, the module README is quite > extensive and covers already some content in this regard. > > Your best bet is probably to have a look to the module README and source > code. If you have questions about certain Kamailio module interface topics > etc.., just ask on this list again. > > Cheers, > > Henning > > > -Original Message- > > From: Tarik ogut via sr-dev > > Sent: Mittwoch, 25. September 2024 00:12 > > To: sr-dev@lists.kamailio.org > > Cc: tariko...@gmail.com > > Subject: [sr-dev] smpp router project > > > > hello i want development about smpp to sip module do you have any > > documentation ? > > ___ > > Kamailio (SER) - Development Mailing List To unsubscribe send an email > > to sr- dev-le...@lists.kamailio.org ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
can i get your questions ? ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: smpp router project
I will write smpp module for ims router project, can I get requests about it. ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
