[sr-dev] [kamailio/kamailio] Advertise in listen directive doesn't let to use hostname without port (Issue #3932)

2024-07-26 Thread Evgenii Buchnev via sr-dev
Hey Team, 

Thank you for the awesome software

### Description

Neither option work:

`listen=... advertise some.custom.hostname.io`
`listen=... advertise some.custom.hostname.io:0`

to make Kamailio present only hostname(without port) in Record-Route headers, 
affects NAPTR/SRV.



### Troubleshooting


_Hostname without port - still gives port 5081 in Record-Route_

**kamailio.cfg**
...
`listen=tls:KAM_LOC_IP:5081 advertise some.custom.io name 
"provider_socket_tls"`
...


**sngrep, 200 OK for INVITE**
...
`Record-Route: `
...

**kamcmd corex.list_sockets**
...
```
{
af: IPv4
proto: tls
name: 172.17.57.164
addrlist: {
addr: 172.17.57.164
}
port: 5081
sockstr: tls:172.17.57.164:5081
mcast: no
mhomed: no
virtual: no
sockname: provider_socket_tls
advertise: tls:some.custom.io:0
}
```
...


_Hostname with port 0 - still gives port 5081 in Record-Route_

kamailio.cfg
...
`listen=tls:KAM_LOC_IP:5081 advertise some.custom.io:0 name 
"provider_socket_tls"`
...


sngrep, 200 OK for INVITE
...
`Record-Route: `
...

kamcmd corex.list_sockets
...
```
{
af: IPv4
proto: tls
name: 172.17.57.164
addrlist: {
addr: 172.17.57.164
}
port: 5081
sockstr: tls:172.17.57.164:5081
mcast: no
mhomed: no
virtual: no
sockname: provider_socket_tls
advertise: tls:some.custom.io:0
}
```
...


_Hostname with explicit different port  - gives that port  in 
Record-Route (to confirm config works)_

kamailio.cfg
...
`listen=tls:KAM_LOC_IP:5081 advertise some.custom.io: name 
"provider_socket_tls"`
...


sngrep, 200 OK for INVITE
...
`Record-Route: `
...

kamcmd corex.list_sockets
...
```
{
af: IPv4
proto: tls
name: 172.17.57.164
addrlist: {
addr: 172.17.57.164
}
port: 5081
sockstr: tls:172.17.57.164:5081
mcast: no
mhomed: no
virtual: no
sockname: provider_socket_tls
advertise: tls:some.custom.io:
}
```
...



 Reproduction

Please see Troubleshooting section

 Debugging Data

Please see Troubleshooting section

 Log Messages

N/A

 SIP Traffic

Please see Troubleshooting section

### Possible Solutions

N/A

### Additional Information


  * **Kamailio Version** - output of `kamailio -v`

```
version: kamailio 5.8.2 (x86_64/linux) dbe51d
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, 
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, 
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, 
TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 
262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: dbe51d 
compiled on 07:13:22 Jul 17 2024 with gcc 12.2.0)
```

* **Operating System**:

```
[dev]root@[voiceproxy]:~# lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:Debian GNU/Linux 12 (bookworm)
Release:12
Codename:   bookworm
[dev]root@[voiceproxy]:~# uname -a
Linux i-0875d7720d6152612 6.1.0-23-cloud-amd64 #1 SMP PREEMPT_DYNAMIC Debian 
6.1.99-1 (2024-07-15) x86_64 GNU/Linux
[dev]root@[voiceproxy]:~# cat /etc/*relea*
ID=ec2
VERSION="20240702-1796"
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/";
SUPPORT_URL="https://www.debian.org/support";
BUG_REPORT_URL="https://bugs.debian.org/";
```


* **Might be related** :
https://github.com/kamailio/kamailio/issues/1884



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3932
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Advertise in listen directive doesn't let to use hostname without port (Issue #3932)

2024-07-26 Thread Henning Westerholt via sr-dev
Closed #3932 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3932#event-13657280834
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Advertise in listen directive doesn't let to use hostname without port (Issue #3932)

2024-07-26 Thread Henning Westerholt via sr-dev
If you want to control your Record-Route, just use the function for it: 
record_route_preset(string [,string2]), see rr module README for details. 
Please adress further questions on how to use Kamailio to our users mailing 
list, as the tracker is for reporting bugs or other issues in the code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3932#issuecomment-2252130634
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Advertise in listen directive doesn't let to use hostname without port (Issue #3932)

2024-07-26 Thread Henning Westerholt via sr-dev
And to add - if there is a bug in the functionality, we can of course re-open 
the old bug as referenced above. According to the comments from Daniel there, 
advertise should work without port.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3932#issuecomment-2252138364
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Advertise in listen directive doesn't let to use hostname without port (Issue #3932)

2024-07-26 Thread Evgenii Buchnev via sr-dev
Re-opened. 
https://github.com/kamailio/kamailio/issues/3933

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3932#issuecomment-2252176460
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] Advertise in listen directive still gives port in headers even though it's not set or set to 0 (Issue #3933)

2024-07-26 Thread Evgenii Buchnev via sr-dev
Reopening. 
(https://github.com/kamailio/kamailio/issues/3932#issuecomment-2252138364)

It's bug. 

Please see highlighted on screenshot. 

![image](https://github.com/user-attachments/assets/88b9671d-d2be-4d49-8596-3e6ab3a2d294)


Hey Team, 

Thank you for the awesome software

### Description

Neither option work:

`listen=... advertise some.custom.hostname.io`
`listen=... advertise some.custom.hostname.io:0`

to make Kamailio present only hostname(without port) in Record-Route headers, 
affects NAPTR/SRV.



### Troubleshooting


_Hostname without port - still gives port 5081 in Record-Route_

**kamailio.cfg**
...
`listen=tls:KAM_LOC_IP:5081 advertise some.custom.io name 
"provider_socket_tls"`
...


**sngrep, 200 OK for INVITE**
...
`Record-Route: `
...

**kamcmd corex.list_sockets**
...
```
{
af: IPv4
proto: tls
name: 172.17.57.164
addrlist: {
addr: 172.17.57.164
}
port: 5081
sockstr: tls:172.17.57.164:5081
mcast: no
mhomed: no
virtual: no
sockname: provider_socket_tls
advertise: tls:some.custom.io:0
}
```
...


_Hostname with port 0 - still gives port 5081 in Record-Route_

kamailio.cfg
...
`listen=tls:KAM_LOC_IP:5081 advertise some.custom.io:0 name 
"provider_socket_tls"`
...


sngrep, 200 OK for INVITE
...
`Record-Route: `
...

kamcmd corex.list_sockets
...
```
{
af: IPv4
proto: tls
name: 172.17.57.164
addrlist: {
addr: 172.17.57.164
}
port: 5081
sockstr: tls:172.17.57.164:5081
mcast: no
mhomed: no
virtual: no
sockname: provider_socket_tls
advertise: tls:some.custom.io:0
}
```
...


_Hostname with explicit different port  - gives that port  in 
Record-Route (to confirm config works)_

kamailio.cfg
...
`listen=tls:KAM_LOC_IP:5081 advertise some.custom.io: name 
"provider_socket_tls"`
...


sngrep, 200 OK for INVITE
...
`Record-Route: `
...

kamcmd corex.list_sockets
...
```
{
af: IPv4
proto: tls
name: 172.17.57.164
addrlist: {
addr: 172.17.57.164
}
port: 5081
sockstr: tls:172.17.57.164:5081
mcast: no
mhomed: no
virtual: no
sockname: provider_socket_tls
advertise: tls:some.custom.io:
}
```
...



 Reproduction

Please see Troubleshooting section

 Debugging Data

Please see Troubleshooting section

 Log Messages

N/A

 SIP Traffic

Please see Troubleshooting section

### Possible Solutions

N/A

### Additional Information


  * **Kamailio Version** - output of `kamailio -v`

```
version: kamailio 5.8.2 (x86_64/linux) dbe51d
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, 
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, 
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, 
TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 
262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: dbe51d 
compiled on 07:13:22 Jul 17 2024 with gcc 12.2.0)
```

* **Operating System**:

```
[dev]root@[voiceproxy]:~# lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:Debian GNU/Linux 12 (bookworm)
Release:12
Codename:   bookworm
[dev]root@[voiceproxy]:~# uname -a
Linux i-0875d7720d6152612 6.1.0-23-cloud-amd64 #1 SMP PREEMPT_DYNAMIC Debian 
6.1.99-1 (2024-07-15) x86_64 GNU/Linux
[dev]root@[voiceproxy]:~# cat /etc/*relea*
ID=ec2
VERSION="20240702-1796"
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/";
SUPPORT_URL="https://www.debian.org/support";
BUG_REPORT_URL="https://bugs.debian.org/";
```


* **Might be related** :
https://github.com/kamailio/kamailio/issues/1884



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3933
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

2024-07-26 Thread Michael via sr-dev
Hi Daniel,

yes, topoh is active. But without topoh the problem is more or less the same. 
Exept the line "TH: dih" is missing:

```
INVITE sip:+49;npdi;rn=+49x...@bob.com;user=phone SIP/2.0
Record-Route: 

Record-Route: 
Via: SIP/2.0/UDP 
62.xxx.xxx.xxx:5070;branch=z9hG4bK7b0f.6d6fba114474d518861d077151ab15c4.0
Via: SIP/2.0/UDP 62.xxx.xxx.xxx:6038;branch=z9hG4bKv1vb4a2060dlmghpcp00.1
Max-Forwards: 62
Session-Expires: 1800;refresher=uac
Min-SE: 1800
Supported: timer,histinfo
To: 
From: "+49" 
;tag=3930969934-318037072
Call-ID: 157063545-3930969934-2127799...@dfra4-tsbc01.mydomain.com
P-Asserted-Identity: 
CSeq: 1 INVITE
Allow: 
PUBLISH,MESSAGE,UPDATE,PRACK,SUBSCRIBE,REFER,INFO,NOTIFY,REGISTER,OPTIONS,BYE,INVITE,ACK,CANCEL
Contact: 
Content-Type: application/sdp
Accept: application/sdp
P-Charging-Vector: 
icid-value=oj25k1o6ihb23s06ehc83ro5o9ce7rtd93s23slupg10;icid-generated-at=10.xxx.xxx.xxx
Content-Length: 273

v=0
o=DFRA4-TSBC01 21989954271838208 11720080987521025 IN IP4 62.xxx.xxx.xxx
s=sip call
c=IN IP4 62.xxx.xxx.xxx
t=0 0
m=audio 64822 RTP/AVP 0 8 18 101
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=sendrecv
a=ptime:20



INVITE sip:+49;npdi;rn=+49x...@bob.com;user=phone SIP/2.0
Record-Route: 
Record-Route: 
Record-Route: 

Record-Route: 
Via: SIP/2.0/UDP 
172.xxx.xxx.xxx;branch=z9hG4bK7b0f.2f311cd0af50a9dfee475476beb76ccb.0
Via: SIP/2.0/UDP 
62.xxx.xxx.xxx:5070;branch=z9hG4bK7b0f.6d6fba114474d518861d077151ab15c4.0
Via: SIP/2.0/UDP 62.xxx.xxx.xxx:6038;branch=z9hG4bKv1vb4a2060dlmghpcp00.1
Max-Forwards: 61
Session-Expires: 1800;refresher=uac
Min-SE: 1800
Supported: timer,histinfo
To: 
From: "+49" 
;tag=3930969934-318037072
Call-ID: 157063545-3930969934-2127799...@dfra4-tsbc01.mydomain.com
P-Asserted-Identity: 
CSeq: 1 INVITE
Allow: 
PUBLISH,MESSAGE,UPDATE,PRACK,SUBSCRIBE,REFER,INFO,NOTIFY,REGISTER,OPTIONS,BYE,INVITE,ACK,CANCEL
Contact: 
Content-Type: application/sdp
Accept: application/sdp
P-Charging-Vector: 
icid-value=oj25k1o6ihb23s06ehc83ro5o9ce7rtd93s23slupg10;icid-generated-at=10.xxx.xxx.xxx
Content-Length: 310
icid-value=oj25k1o6ihb23s06ehc83ro5o9ce7rtd93s23slupg10;icid-generated-at=10.xxx.xxx.xxx
Content-L
v=0
o=DFRA4-TSBC01 21989954271838208 11720080987521025 IN IP4 92.xxx.xxx.xxx
s=sip call
c=IN IP4 92.xxx.xxx.xxx
t=0 0
m=audio 26708 RTP/AVP 0 8 18 101
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:18 G729/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=sendrecv
a=rtcp:26709
a=ptime:20
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3929#issuecomment-2252228051
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

2024-07-26 Thread Daniel-Constantin Mierla via sr-dev
I just wanted to be sure that topos is not creating any issue, because `TH` 
should never leave Kamailio as a header. As it looks right now, some lenght is 
not computed right, because it adds more data than needs, which was in the 
buffer at some point in time.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3929#issuecomment-2252558202
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

2024-07-26 Thread Michael via sr-dev
In this example, the incorrect length also included part of the SDP. This 
generated an additional error message because there was a duplicate 
Content-Length header :

```
INVITE sip:+49xxx...@bob.com;transport=udp;user=phone SIP/2.0
Call-ID: 02817-md-4463d585-52e48e...@c4swlmgc2.alice.com
Contact: 
Content-Type: application/sdp
CSeq: 1133935713 INVITE
From: "0xx" 
;tag=02817-RD-4463d586-4f6eb2e21
Max-Forwards: 66
Record-Route: 
Route: 
Supported: histinfo
To: 
Via: SIP/2.0/UDP 212.xxx.xxx.xxx:5060;branch=z9hG4bK-SBUV-07e9a5a9-120bc337
P-Early-Media: supported
User-Agent: Cirpack
Allow: INVITE,ACK,UPDATE,BYE,CANCEL,OPTIONS
P-Asserted-Identity: "0xx"
P-Charging-Vector: 
icid-value="IBCF-1-172198114070166333715934";orig-ioi=3GPP-UTRAN
Content-Length: 248

v=0
o=anonymous 172198114002 172198114002 IN IP4 212.xxx.xxx.xxx
s=SIP Call
c=IN IP4 212.xxx.xxx.xxx
t=0 0
m=audio 31096 RTP/AVP 8 101
b=AS:82
a=rtpmap:8 PCMA/8000/1
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=ptime:20
a=sendrecv



INVITE sip:+49xxx...@bob.com;transport=udp;user=phone SIP/2.0
Record-Route: 
Record-Route: 
Call-ID: 02817-md-4463d585-52e48e...@c4swlmgc2.alice.com
Contact: 
Content-Type: application/sdp
CSeq: 1133935713 INVITE
From: "0x" 
;tag=02817-RD-4463d586-4f6eb2e21
Max-Forwards: 65
Record-Route: 
Supported: histinfo
To: 
Via: SIP/2.0/UDP 
172.xxx.xxx.xxx;branch=z9hG4bKfc7e.32b1e1b8641843f6f10ffaa78b49ad63.0
Via: SIP/2.0/UDP 212.xxx.xxx.xxx:5060;branch=z9hG4bK-SBUV-07e9a5a9-120bc337
User-Agent: Cirpack
Allow: INVITE,ACK,UPDATE,BYE,CANCEL,OPTIONS
P-Asserted-Identity: "0x"
P-Charging-Vector: 
icid-value="IBCF-1-172198114070166333715934";orig-ioi=3GPP-UTRAN
Content-Length: 258
icid-value="IBCF-1-172198114070166333715934";orig-ioi=3GPP-UTRAN
Content-Length: 248

v=0
o=a
v=0
o=anonymous 172198114002 172198114002 IN IP4 92.xxx.xxx.xxx
s=SIP Call
c=IN IP4 92.xxx.xxx.xxx
t=0 0
m=audio 40848 RTP/AVP 8 101
b=AS:82
a=rtpmap:8 PCMA/8000/1
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
a=sendrecv
a=rtcp
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3929#issuecomment-2252617116
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] p-charging-vector bug in siputils with force flag (Issue #3929)

2024-07-26 Thread Michael via sr-dev
Apart from the incorrect length, it seems strange to me that the PCV is being 
copied at all. If I understand the F-flag correctly, the old header should be 
deleted and a new one generated.

`Manage the P-Charging-Vector header (RFC7315). The flags can be: 'r' - remove; 
'g' - generate; 'f' - force (remove + generate).`

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3929#issuecomment-2252623251
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:660a0192: xprint: return on mod init error case

2024-07-26 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 660a019263b81d318700c205531bf4e042c912cf
URL: 
https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e042c912cf

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-07-26T19:50:40+02:00

xprint: return on mod init error case

---

Modified: src/modules/xprint/xp_lib.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e042c912cf.diff
Patch: 
https://github.com/kamailio/kamailio/commit/660a019263b81d318700c205531bf4e042c912cf.patch

---

diff --git a/src/modules/xprint/xp_lib.c b/src/modules/xprint/xp_lib.c
index b6fc5066556..fda12a82fc3 100644
--- a/src/modules/xprint/xp_lib.c
+++ b/src/modules/xprint/xp_lib.c
@@ -1899,6 +1899,7 @@ int xl_mod_init()
s = NULL;
str_ipaddr.len 
= 0;

PKG_MEM_ERROR_FMT("for str_ipaddr\n");
+   return -1;
}
} else if(strncmp(str_ipaddr.s, 
s, str_ipaddr.len)
  != 0) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:3333611a: core: cfg select - check res when getting the variable

2024-07-26 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 611a3ef9078cbcb9867db88921f0c48fce1b
URL: 
https://github.com/kamailio/kamailio/commit/611a3ef9078cbcb9867db88921f0c48fce1b

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-07-26T19:50:40+02:00

core: cfg select - check res when getting the variable

---

Modified: src/core/cfg/cfg_select.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/611a3ef9078cbcb9867db88921f0c48fce1b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/611a3ef9078cbcb9867db88921f0c48fce1b.patch

---

diff --git a/src/core/cfg/cfg_select.c b/src/core/cfg/cfg_select.c
index e6c599a204e..b4e9e6ebef7 100644
--- a/src/core/cfg/cfg_select.c
+++ b/src/core/cfg/cfg_select.c
@@ -212,7 +212,7 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg 
*msg)
group = (cfg_group_t *)s->params[1].v.p;
var = (cfg_mapping_t *)s->params[2].v.p;
 
-   if(!group || !var)
+   if(!group || !var || !res)
return -1;
 
/* use the module's handle to access the variable, so the variables

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] topos:added get_callid_mask/get_callid_unmask funtion for handeling Refer-To header (PR #3872)

2024-07-26 Thread github-actions[bot] via sr-dev
This PR is stale because it has been open 6 weeks with no activity. Remove 
stale label or comment or this will be closed in 2 weeks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3872#issuecomment-2253719457
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Contribute with AUR package

2024-07-26 Thread Nikos Toutountzoglou via sr-dev
Dear Sirs,

I have adopted an orphaned AUR package and tried to fine tune it to be used 
with Your great Kamailio open source project.
I can continue to maintain it in the AUR space. If anything needs to be 
modified in the package please let me know.

Link to the package:
https://aur.archlinux.org/packages/kamailio

or web search !aur kamailio

Regards,
Nikos___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org