[sr-dev] [kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

2024-04-26 Thread JuanPascual2 via sr-dev 

Hello
The tm.t_uac_start function generates a “tm:local-request” event.
But the tm.cancel function doesn't generete “tm:local-request” event.

Is it possible to activate a parameter in the TM or TMX module to generate the 
event?

Thanks
Juan


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3831
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] modules/statsd: ensure statsd failures do not stop execution (PR #3819)

2024-04-26 Thread Ostap via sr-dev 
@ostap0207 commented on this pull request.



>  }
 
 static int ki_statsd_decr_with_labels(sip_msg_t *msg, str *key, str *labels)
 {
-   return statsd_count(key->s, "-1", labels->s);
+   return convert_result(statsd_count(key->s, "-1", labels->s));
+}
+
+static int convert_result(bool result)
+{
+   if(result == false) {
+   return -1;
+   }
+
+   return 0;

Updated 
https://github.com/kamailio/kamailio/compare/3bbed6d62a2ef3a3fbcbf4d8ba125ab95aec28dd..ee772af9e7acbdac14247010e1e7ecf539d759ba

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3819#discussion_r1580680113
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

2024-04-26 Thread Henning Westerholt via sr-dev 
Thanks for the report, it was probably not implemented yet for CANCEL generated 
from tm over a RPC command.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3831#issuecomment-2079157964
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] free_fixup functions in cmd_export_t are not called (Issue #3814)

2024-04-26 Thread Xenofon Karamanos via sr-dev 
Indeed, when using `func1($var(x) + $var(y));` syntax the `fixup_free` is 
getting called right after the call to the actual `func1`. 

It should be called in both cases though since the `fixup` is also called for 
both, right? or is the behavior we observe now is expected? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3814#issuecomment-2079273545
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] free_fixup functions in cmd_export_t are not called (Issue #3814)

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev 
What do you mean by both cases?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3814#issuecomment-2079404313
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:8506a6fe: ims_usrloc_scscf: enclose examples in dotted lines for better visibility

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 8506a6fe781e6e0b0b1418f4087db50480db6b57
URL: 
https://github.com/kamailio/kamailio/commit/8506a6fe781e6e0b0b1418f4087db50480db6b57

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-04-26T14:35:22+02:00

ims_usrloc_scscf: enclose examples in dotted lines for better visibility

---

Modified: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/8506a6fe781e6e0b0b1418f4087db50480db6b57.diff
Patch: 
https://github.com/kamailio/kamailio/commit/8506a6fe781e6e0b0b1418f4087db50480db6b57.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:15d859e1: ims_usrloc_scscf: reformat exported structures

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 15d859e1e96552fca2708cf56047021beae29711
URL: 
https://github.com/kamailio/kamailio/commit/15d859e1e96552fca2708cf56047021beae29711

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-04-26T14:24:16+02:00

ims_usrloc_scscf: reformat exported structures

---

Modified: src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/15d859e1e96552fca2708cf56047021beae29711.diff
Patch: 
https://github.com/kamailio/kamailio/commit/15d859e1e96552fca2708cf56047021beae29711.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] free_fixup functions in cmd_export_t are not called (Issue #3814)

2024-04-26 Thread Xenofon Karamanos via sr-dev 
I meant the two cases of functions calls, one with the expressions and not! See 
updated comments above for more details

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3814#issuecomment-2079413286
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:465994de: modules: readme files regenerated - ims_usrloc_scscf ... [skip ci]

2024-04-26 Thread Kamailio Dev via sr-dev 
Module: kamailio
Branch: master
Commit: 465994de2859c7863b4cef8457be0a207f15c932
URL: 
https://github.com/kamailio/kamailio/commit/465994de2859c7863b4cef8457be0a207f15c932

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2024-04-26T15:46:09+02:00

modules: readme files regenerated - ims_usrloc_scscf ... [skip ci]

---

Modified: src/modules/ims_usrloc_scscf/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/465994de2859c7863b4cef8457be0a207f15c932.diff
Patch: 
https://github.com/kamailio/kamailio/commit/465994de2859c7863b4cef8457be0a207f15c932.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] multiple subsytems: unsigned integer conversion fixes (PR #3828)

2024-04-26 Thread Tyler Moore via sr-dev 
@devopsec pushed 1 commit.

db042404783262c79271ac6fd2e0b9f1f5010822  lib/srdb1: add uint support for 
db->pv conversions

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3828/files/f19e574beebff9b1f17f8ab63a7cf5478974eb11..db042404783262c79271ac6fd2e0b9f1f5010822
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] uac: add reload_delta parameter (PR #3829)

2024-04-26 Thread Tyler Moore via sr-dev 
@devopsec pushed 1 commit.

9650c121c66263ef51c1414acb36994c49caee9c  uac: add reload_delta parameter

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3829/files/fb61a4281c0a2a60d527f18c269c0e8eaac23476..9650c121c66263ef51c1414acb36994c49caee9c
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix uninitialized access of memory, minor refactors (PR #3787)

2024-04-26 Thread github-actions[bot] via sr-dev 
This PR is stale because it has been open 6 weeks with no activity. Remove 
stale label or comment or this will be closed in 2 weeks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3787#issuecomment-2080329029
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:efffd1db: phonenum: add national number

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: efffd1db25f2da411f53fdab4954c60c16c021ae
URL: 
https://github.com/kamailio/kamailio/commit/efffd1db25f2da411f53fdab4954c60c16c021ae

Author: Daniel Donoghue 
Committer: Daniel-Constantin Mierla 
Date: 2024-04-27T08:44:10+02:00

phonenum: add national number

- add natnum property, containing the nationally formatted number, to pv

---

Modified: src/modules/phonenum/cphonenumber.cpp
Modified: src/modules/phonenum/cphonenumber.h
Modified: src/modules/phonenum/doc/phonenum_admin.xml
Modified: src/modules/phonenum/phonenum_pv.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/efffd1db25f2da411f53fdab4954c60c16c021ae.diff
Patch: 
https://github.com/kamailio/kamailio/commit/efffd1db25f2da411f53fdab4954c60c16c021ae.patch

---

diff --git a/src/modules/phonenum/cphonenumber.cpp 
b/src/modules/phonenum/cphonenumber.cpp
index 60f5039c88f..94cc9d2cddb 100644
--- a/src/modules/phonenum/cphonenumber.cpp
+++ b/src/modules/phonenum/cphonenumber.cpp
@@ -128,9 +128,11 @@ telnum_t* telnum_parse(char* number, char* region)
return res;
}
res->valid = 1;
-   string formattedNumber;
-   _phoneUtil.Format(parsedNumber, PhoneNumberUtil::E164, 
&formattedNumber);
-   res->normalized = strdup(formattedNumber.c_str());
+   string formattedNumberE164, formattedNumberNational;
+   _phoneUtil.Format(parsedNumber, PhoneNumberUtil::E164, 
&formattedNumberE164);
+   _phoneUtil.Format(parsedNumber, PhoneNumberUtil::NATIONAL, 
&formattedNumberNational);
+   res->normalized = strdup(formattedNumberE164.c_str());
+   res->natnum = strdup(formattedNumberNational.c_str());
string descNumber = 
_phoneGeoCoder->GetDescriptionForNumber(parsedNumber, Locale("en"));
res->ndesc = strdup(descNumber.c_str());
res->ltype = 
strdup(telnum_linetype(_phoneUtil.GetNumberType(parsedNumber)));
@@ -156,6 +158,7 @@ telnum_t* telnum_new(char* number)
tn->ltype = NULL;
tn->ndesc = NULL;
tn->ccname = NULL;
+   tn->natnum = NULL;
tn->error = NULL;
return tn;
 }
@@ -183,5 +186,8 @@ void telnum_free(telnum_t* tn)
if (tn->ccname) {
free(tn->ccname);
}
+   if (tn->natnum) {
+   free(tn->natnum);
+   }
free(tn);
 }
diff --git a/src/modules/phonenum/cphonenumber.h 
b/src/modules/phonenum/cphonenumber.h
index 1a6a06df861..b9e1dc09d96 100644
--- a/src/modules/phonenum/cphonenumber.h
+++ b/src/modules/phonenum/cphonenumber.h
@@ -37,6 +37,7 @@ extern "C"
char *ltype;
char *ndesc;
char *ccname;
+   char *natnum;
char *error;
int cctel;
int valid;
diff --git a/src/modules/phonenum/doc/phonenum_admin.xml 
b/src/modules/phonenum/doc/phonenum_admin.xml
index f3a3e98ede0..740ec4780a3 100644
--- a/src/modules/phonenum/doc/phonenum_admin.xml
+++ b/src/modules/phonenum/doc/phonenum_admin.xml
@@ -205,7 +205,10 @@ if(phonenum_match_cn("1-484-555-", "US", "src")) {
valid result; 0 otherwise


-   normalized - 
normalized phone number
+   normalized - 
normalized (E164) phone number
+   
+   
+   natnum - 
nationally formatted phone number


cctel - country 
code for phone number
diff --git a/src/modules/phonenum/phonenum_pv.c 
b/src/modules/phonenum/phonenum_pv.c
index f6bcc025f66..5970c6b9845 100644
--- a/src/modules/phonenum/phonenum_pv.c
+++ b/src/modules/phonenum/phonenum_pv.c
@@ -190,6 +190,8 @@ int pv_parse_phonenum_name(pv_spec_p sp, str *in)
gpv->type = 0;
else if(strncmp(pvs.s, "ccname", 6) == 0)
gpv->type = 7;
+   else if(strncmp(pvs.s, "natnum", 6) == 0)
+   gpv->type = 8;
else
goto error;
break;
@@ -268,6 +270,10 @@ int pv_get_phonenum(struct sip_msg *msg, pv_param_t 
*param, pv_value_t *res)
if(gpv->item->r.record->ccname == NULL)
return pv_get_null(msg, param, res);
return pv_get_strzval(msg, param, res, 
gpv->item->r.record->ccname);
+   case 8: /* natnum */
+   if(gpv->item->r.record->natnum == NULL)
+   return pv_get_null(msg, param, res);
+   return pv_get_strzval(msg, param, res, 
gpv->item->r.record->natnum);
default: /* number */
if(gpv->item->r.

[sr-dev] Re: [kamailio/kamailio] phonenum: add national number (PR #3820)

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev 
Merged #3820 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3820#event-12630642727
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:f0caa96e: phonenum: clang format cpp file

2024-04-26 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: f0caa96e7622c40200d22d730ca904f27e5fe752
URL: 
https://github.com/kamailio/kamailio/commit/f0caa96e7622c40200d22d730ca904f27e5fe752

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-04-27T08:46:17+02:00

phonenum: clang format cpp file

---

Modified: src/modules/phonenum/cphonenumber.cpp

---

Diff:  
https://github.com/kamailio/kamailio/commit/f0caa96e7622c40200d22d730ca904f27e5fe752.diff
Patch: 
https://github.com/kamailio/kamailio/commit/f0caa96e7622c40200d22d730ca904f27e5fe752.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:5b0e1e6d: modules: readme files regenerated - phonenum ... [skip ci]

2024-04-26 Thread Kamailio Dev via sr-dev 
Module: kamailio
Branch: master
Commit: 5b0e1e6d23fb0bf028589ae27949f11be2b22837
URL: 
https://github.com/kamailio/kamailio/commit/5b0e1e6d23fb0bf028589ae27949f11be2b22837

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2024-04-27T08:46:10+02:00

modules: readme files regenerated - phonenum ... [skip ci]

---

Modified: src/modules/phonenum/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/5b0e1e6d23fb0bf028589ae27949f11be2b22837.diff
Patch: 
https://github.com/kamailio/kamailio/commit/5b0e1e6d23fb0bf028589ae27949f11be2b22837.patch

---

diff --git a/src/modules/phonenum/README b/src/modules/phonenum/README
index 87cb9e485f5..5d50ebf8f2e 100644
--- a/src/modules/phonenum/README
+++ b/src/modules/phonenum/README
@@ -191,7 +191,8 @@ if(phonenum_match_cn("1-484-555-", "US", "src")) {
   + number - phone number that is matched
   + valid - 1 if the matched number has a valid result; 0
 otherwise
-  + normalized - normalized phone number
+  + normalized - normalized (E164) phone number
+  + natnum - nationally formatted phone number
   + cctel - country code for phone number
   + ccname - country code name
   + ltype - local network type

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org