CVS commit: src/external/bsd/atf/lib/libatf-c
Module Name:src Committed By: fox Date: Sun Jun 7 23:09:34 UTC 2020 Modified Files: src/external/bsd/atf/lib/libatf-c: Makefile Log Message: external/bsd/atf: Suppress -Werror=stringop-truncation error This logic correctly uses strncpy(3) to fully initialize a fixed-width field, and also ensures NUL-termination on the next line as other users of the field expect. Add -Werror=stringop-truncation to prevent build failure, when run with MKSANITIZER=yes. Error was reported when build.sh was run with MKSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23 src/external/bsd/atf/lib/libatf-c/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/libexec/lfs_cleanerd
Module Name:src Committed By: fox Date: Sun Jun 7 23:15:53 UTC 2020 Modified Files: src/libexec/lfs_cleanerd: Makefile.inc Log Message: libexec/lfs_cleanerd: Suppress -Werror=stringop-truncation error This logic correctly uses strncpy(3) to fully initialize a fixed-width field, and also ensures NUL-termination on the next line as other users of the field expect. Add -Werror=stringop-truncation to prevent build failure, when run with MKSANITIZER=yes. Error was reported when build.sh was run with MKSANITIZER=yes flag. Reviewed by: kamil@, riastradh@ To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/libexec/lfs_cleanerd/Makefile.inc Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/lib/libarchive
Module Name:src Committed By: fox Date: Sun Jun 7 23:20:52 UTC 2020 Modified Files: src/tests/lib/libarchive: Makefile Log Message: tests/lib/libarchive: Suppress -Werror=stringop-truncation error This logic correctly uses strncpy(3) to fully initialize a fixed-width field, and also ensures NUL-termination on the next line as other users of the field expect. Add -Werror=stringop-truncation to prevent build failure, when run with MKSANITIZER=yes. Error was reported when build.sh was run with MKSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libarchive/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/usr.bin/ctfmerge
Module Name:src Committed By: fox Date: Sun Jun 7 23:26:54 UTC 2020 Modified Files: src/external/cddl/osnet/usr.bin/ctfmerge: Makefile Log Message: external/cddl/osnet: Suppress -Werror=stringop-truncation error This logic correctly uses strncpy(3) to fully initialize a fixed-width field, and also ensures NUL-termination on the next line as other users of the field expect. Add -Werror=stringop-truncation to prevent build failure, when run with MKSANITIZER=yes. Error was reported when build.sh was run with MKSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/external/cddl/osnet/usr.bin/ctfmerge/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/mpl/dhcp/bin/server
Module Name:src Committed By: fox Date: Sun Jun 7 23:29:16 UTC 2020 Modified Files: src/external/mpl/dhcp/bin/server: Makefile Log Message: external/mpl/dhcp: Suppress -Werror=stringop-truncation error This logic correctly uses strncpy(3) to fully initialize a fixed-width field, and also ensures NUL-termination on the next line as other users of the field expect. Add -Werror=stringop-truncation to prevent build failure, when run with MKSANITIZER=yes. Error was reported when build.sh was run with MKSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/external/mpl/dhcp/bin/server/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/libexec/httpd
Module Name:src Committed By: fox Date: Sun Jun 7 23:33:02 UTC 2020 Modified Files: src/libexec/httpd: bozohttpd.c Log Message: libexec/httpd: Fix the possible -Werror=stringop-truncation Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@, mrg@ To generate a diff of this commit: cvs rdiff -u -r1.113 -r1.114 src/libexec/httpd/bozohttpd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libpam/modules/pam_krb5
Module Name:src Committed By: fox Date: Fri Jun 12 01:20:32 UTC 2020 Modified Files: src/lib/libpam/modules/pam_krb5: pam_krb5.c Log Message: lib/libpam: Fix the possible -Werror=stringop-truncation Replace strncpy(3) with the safer strlcpy(3) and adjust the code. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@, christos@ To generate a diff of this commit: cvs rdiff -u -r1.28 -r1.29 src/lib/libpam/modules/pam_krb5/pam_krb5.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/gpl3/gcc/usr.bin/backend
Module Name:src Committed By: fox Date: Fri Jun 12 14:37:51 UTC 2020 Modified Files: src/external/gpl3/gcc/usr.bin/backend: Makefile Log Message: external/gpl3/gcc: Suppress -Werror=maybe-uninitialized Seems like false positive since the ASM_GENERATE_INTERNAL_LABEL macro stores the value into prev_label, so it is alright for prev_label to be uninitialized. Error was reported when build.sh was run with MKSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.57 -r1.58 src/external/gpl3/gcc/usr.bin/backend/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/bin/csh
Module Name:src Committed By: fox Date: Wed Feb 5 20:06:17 UTC 2020 Modified Files: src/bin/csh: sem.c Log Message: bin/csh: Fix the -Wclobber warning. Mark the variable as volatile as it can be clobbered when a vfork occurs. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/bin/csh/sem.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/games/battlestar
Module Name:src Committed By: fox Date: Wed Feb 5 20:11:54 UTC 2020 Modified Files: src/games/battlestar: parse.c Log Message: games/battlestar: Fix the -Werror=restrict warning. Replace strcpy(1) with the safer snprintf(3) which guarantees NULL termination of strings. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/games/battlestar/parse.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/games/battlestar
Module Name:src Committed By: fox Date: Thu Feb 6 22:09:43 UTC 2020 Modified Files: src/games/battlestar: parse.c Log Message: games/battlestar: Replace snprintf(3) with strlcpy(3) for better performance. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/games/battlestar/parse.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/bin/sh
Module Name:src Committed By: fox Date: Fri Feb 7 01:25:08 UTC 2020 Modified Files: src/bin/sh: main.c Log Message: bin/sh: Fixes -Werror=shadow causing build breaks. Conflicting variable name, sigset_t sigs has been renamed to sigset_t mask Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.84 -r1.85 src/bin/sh/main.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/altq/altqstat
Module Name:src Committed By: fox Date: Fri Feb 7 20:13:26 UTC 2020 Modified Files: src/usr.sbin/altq/altqstat: quip_client.c Log Message: usr.sbin/altq: Fix -Wstringop-truncation warning. Looks like the original intention was to truncate the string at len. Replace strncpy(3) with strlcpy(3). Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/usr.sbin/altq/altqstat/quip_client.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/config
Module Name:src Committed By: fox Date: Fri Feb 7 20:17:48 UTC 2020 Modified Files: src/usr.bin/config: Makefile Log Message: usr.bin/config: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION to scan.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. gcc version 8.3.0 Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.11 -r1.12 src/usr.bin/config/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/games/hack
Module Name:src Committed By: fox Date: Fri Feb 7 20:34:18 UTC 2020 Modified Files: src/games/hack: hack.end.c Log Message: games/hack: Fix -Wstringop-truncation warning. Replace strncpy(3) with strlcpy(3). Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/games/hack/hack.end.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/altq/altqstat
Module Name:src Committed By: fox Date: Fri Feb 7 21:53:20 UTC 2020 Modified Files: src/usr.sbin/altq/altqstat: quip_client.c Log Message: usr.sbin/altq: Revert the strlcpy(3) change since this changes expected behavior from strncpy(3). Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/usr.sbin/altq/altqstat/quip_client.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/games/hack
Module Name:src Committed By: fox Date: Fri Feb 7 22:04:02 UTC 2020 Modified Files: src/games/hack: hack.end.c Log Message: games/hack: Revert the strlcpy(1) change since this changes expected behavior from strncpy(3). Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/games/hack/hack.end.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/games/hack
Module Name:src Committed By: fox Date: Sat Feb 8 00:59:55 UTC 2020 Modified Files: src/games/hack: Makefile Log Message: games/hack: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION to hack.end.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47 src/games/hack/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/altq/altqstat
Module Name:src Committed By: fox Date: Sat Feb 8 01:01:31 UTC 2020 Modified Files: src/usr.sbin/altq/altqstat: Makefile Log Message: usr.sbin/altq: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION to quip_client.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/usr.sbin/altq/altqstat/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/dhcpcd/dist/src
Module Name:src Committed By: fox Date: Sat Feb 8 12:17:16 UTC 2020 Modified Files: src/external/bsd/dhcpcd/dist/src: dhcp.c Log Message: external/bsd/dhcpcd: Fix a -Wconversion warning. Type cast uint16_t to size_t to prevent implicit type conversion. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. gcc version 8.3.0 Reviewed by: roy@, kamil@ To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/external/bsd/dhcpcd/dist/src/dhcp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/talk
Module Name:src Committed By: fox Date: Sat Feb 8 12:53:29 UTC 2020 Modified Files: src/usr.bin/talk: Makefile Log Message: usr.bin/talk: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION to get_names.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/usr.bin/talk/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/fstyp
Module Name:src Committed By: fox Date: Sat Feb 8 12:56:56 UTC 2020 Modified Files: src/usr.sbin/fstyp: exfat.c Log Message: usr.sbin/fstyp: Fix -Werror=conversion error. Type cast the size_t to uint32_t to prevent implicit type conversion errors. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/fstyp/exfat.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/ntp/bin/ntpd
Module Name:src Committed By: fox Date: Sat Feb 8 13:20:10 UTC 2020 Modified Files: src/external/bsd/ntp/bin/ntpd: Makefile Log Message: external/bsd/ntp: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION to refclock_jjy.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/external/bsd/ntp/bin/ntpd/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/tftp
Module Name:src Committed By: fox Date: Sat Feb 8 13:33:56 UTC 2020 Modified Files: src/usr.bin/tftp: Makefile Log Message: user.bin/tftp: Suppress -Werror=format-overflow error. Add -Wno-error=format-overflow tftp.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/usr.bin/tftp/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/ipf/bin/ipmon
Module Name:src Committed By: fox Date: Sun Feb 9 07:47:50 UTC 2020 Modified Files: src/external/bsd/ipf/bin/ipmon: Makefile Log Message: external/bsd/ipf: Suppress -Werror=format-overflow= error. Add -Wno-error=format-overflow in ipmon.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/external/bsd/ipf/bin/ipmon/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/ipf/bin/ipsend
Module Name:src Committed By: fox Date: Sun Feb 9 07:51:20 UTC 2020 Modified Files: src/external/bsd/ipf/bin/ipsend: Makefile Log Message: external/bsd/ipf: Suppress -Werror=maybe-uninitialized error. Add -Wno-error=maybe-uninitialized in ipsopt.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/external/bsd/ipf/bin/ipsend/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/usr.bin/ctfconvert
Module Name:src Committed By: fox Date: Sun Feb 9 07:55:13 UTC 2020 Modified Files: src/external/cddl/osnet/usr.bin/ctfconvert: Makefile Log Message: external/cddl/osnet: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION dwarf.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/external/cddl/osnet/usr.bin/ctfconvert/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/mpl/dhcp/bin/server
Module Name:src Committed By: fox Date: Sun Feb 9 07:59:44 UTC 2020 Modified Files: src/external/mpl/dhcp/bin/server: Makefile Log Message: external/mpl/dhcp: Suppress -Werror=format-overflow error. Add -Wno-error=format-overflow mdb6.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/external/mpl/dhcp/bin/server/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/gpl3/gcc/usr.bin
Module Name:src Committed By: fox Date: Sun Feb 9 08:04:40 UTC 2020 Modified Files: src/external/gpl3/gcc/usr.bin/cc1: Makefile src/external/gpl3/gcc/usr.bin/cc1obj: Makefile Log Message: external/gpl3/gcc: Suppress -Werror=format-overflow error. Add -Wno-error=format-overflow for c-cppbuiltin.c and c-typeck.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/external/gpl3/gcc/usr.bin/cc1/Makefile cvs rdiff -u -r1.12 -r1.13 src/external/gpl3/gcc/usr.bin/cc1obj/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/xlint
Module Name:src Committed By: fox Date: Sun Feb 9 08:10:26 UTC 2020 Modified Files: src/usr.bin/xlint/xlint: xlint.c Log Message: usr.bin/xlint: Fix -Werror=format-overflow= error. Replace sprintf(3) with snprintf(3). Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.47 -r1.48 src/usr.bin/xlint/xlint/xlint.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/srtconfig
Module Name:src Committed By: fox Date: Sun Feb 9 15:10:31 UTC 2020 Modified Files: src/usr.sbin/srtconfig: Makefile Log Message: usr.sbin/srtconfig: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION to srtconfig.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/srtconfig/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/timed/timed
Module Name:src Committed By: fox Date: Sun Feb 9 15:13:28 UTC 2020 Modified Files: src/usr.sbin/timed/timed: Makefile Log Message: usr.sbin/timed: Suppress -Werror=stringop-truncation error. Add GCC_NO_STRINGOP_TRUNCATION master.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/usr.sbin/timed/timed/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/ypserv/makedbm
Module Name:src Committed By: fox Date: Sun Feb 9 15:52:48 UTC 2020 Modified Files: src/usr.sbin/ypserv/makedbm: Makefile Log Message: usr.sbin/ypserv: Suppress -Werror=format-truncation= error. Add GCC_NO_FORMAT_TRUNCATION makedbm.c to prevent build failure. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/usr.sbin/ypserv/makedbm/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/ipf/bin
Module Name:src Committed By: fox Date: Wed Feb 12 00:30:48 UTC 2020 Modified Files: src/external/bsd/ipf/bin/ipmon: Makefile src/external/bsd/ipf/bin/ipsend: Makefile Log Message: external/bsd/ipf: Fix build failure under LLVM. -Wno-error= flag now only applies to gcc 8 and not to LLVM based builds. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/external/bsd/ipf/bin/ipmon/Makefile cvs rdiff -u -r1.4 -r1.5 src/external/bsd/ipf/bin/ipsend/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/gpl3/gcc/usr.bin
Module Name:src Committed By: fox Date: Wed Feb 12 00:36:38 UTC 2020 Modified Files: src/external/gpl3/gcc/usr.bin/cc1: Makefile src/external/gpl3/gcc/usr.bin/cc1obj: Makefile Log Message: external/gpl3/gcc: Fix build failure under LLVM. -Wno-error= flag now only applies to gcc 8 and not to LLVM based builds. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/external/gpl3/gcc/usr.bin/cc1/Makefile cvs rdiff -u -r1.13 -r1.14 src/external/gpl3/gcc/usr.bin/cc1obj/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/mpl/dhcp/bin/server
Module Name:src Committed By: fox Date: Wed Feb 12 00:41:50 UTC 2020 Modified Files: src/external/mpl/dhcp/bin/server: Makefile Log Message: external/mpl/dhcp: Fix build failure under LLVM. -Wno-error= flag now only applies to gcc 8 and not to LLVM based builds. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/external/mpl/dhcp/bin/server/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/common/lib/libc/stdlib
Module Name:src
Committed By: fox
Date: Sat Feb 22 14:47:29 UTC 2020
Modified Files:
src/common/lib/libc/stdlib: random.c
Log Message:
common/lib/libc/stdlib: Fix possible signed integer overflow.
common/lib/libc/stdlib/random.c:482:6 can result in signed integer overflow.
This bug was reported by UBSan runs.
The change has been tested using the following program to generate random
numbers
in both the old and the new library and can be used to verify the correctness
of the
library after the change.
#include
#include
#define COUNT 1000 * 1000
int
main(void)
{
int i;
FILE *fp = fopen("numbers.txt", "w");
srandom(0xdeadbeef);
for(i = 0; i < COUNT; i++) {
fprintf(fp, "%ld\n", random());
}
fclose(fp);
return 0;
}
Reviewed by: riastradh@ , kamil@
To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/common/lib/libc/stdlib/random.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs
Module Name:src Committed By: fox Date: Mon Mar 9 15:37:46 UTC 2020 Modified Files: src/external/cddl/osnet/dist/uts/common/fs/zfs: dmu_tx.c spa.c Log Message: external/cddl/osnet: Fix possible signed integer overflow Detected by UBSan and fixed upstream Cherry-pick: >From 05852b3467b44cdf88541ec67624cd1f5f2ded1d Mon Sep 17 00:00:00 2001 From: luozhengzheng Date: Fri, 14 Oct 2016 05:25:05 +0800 Subject: [PATCH] Fix coverity defects: CID 147571, 147574 CID 147571: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) CID 147574: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) Reviewed-by: Brian Behlendorf Signed-off-by: luozhengzheng Closes #5268 Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 \ src/external/cddl/osnet/dist/uts/common/fs/zfs/dmu_tx.c cvs rdiff -u -r1.10 -r1.11 \ src/external/cddl/osnet/dist/uts/common/fs/zfs/spa.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs
Module Name:src Committed By: fox Date: Mon Mar 9 15:40:50 UTC 2020 Modified Files: src/external/cddl/osnet/dist/uts/common/fs/zfs: metaslab.c Log Message: external/cddl/osnet: Fix possible null pointer access. Detected by UBSan and fixed upstream, pick only the fix from the commit. Cherry-pick: >From 928e8ad47d3478a3d5d01f0dd6ae74a9371af65e Mon Sep 17 00:00:00 2001 From: Serapheim Dimitropoulos Date: Wed, 20 Feb 2019 09:59:57 -0800 Subject: [PATCH] Introduce auxiliary metaslab histograms Reviewed by: Paul Dagnelie Reviewed-by: Brian Behlendorf Reviewed by: Matt Ahrens Signed-off-by: Serapheim Dimitropoulos Closes #8358 Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.1.1.3 -r1.2 \ src/external/cddl/osnet/dist/uts/common/fs/zfs/metaslab.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/lib/libdtrace
Module Name:src Committed By: fox Date: Tue Mar 17 00:50:12 UTC 2020 Modified Files: src/external/cddl/osnet/lib/libdtrace: Makefile Log Message: external/cddl/osnet: Supress -Werror=maybe-uninitialized error in libdtrace. It looks like this is a false positive, since the section of code triggering the error external/cddl/osnet/dist/lib/libdtrace/common/dt_proc.c:400:42: is only accessed after "err" is initialized. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/external/cddl/osnet/lib/libdtrace/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs
Module Name:src Committed By: fox Date: Tue Mar 17 00:54:03 UTC 2020 Modified Files: src/external/cddl/osnet/dist/uts/common/fs/zfs: zfs_acl.c Log Message: external/cddl/osnet: Fix -Werror=maybe-uninitialized error in zfs_acl.c. Detected by build.sh with MKLIBCSANITIZER=yes and fixed upstream, pick only the fix from the commit. Upstream commits https://github.com/zfsonfreebsd/ZoF/commit/100a91aa3e9773f2a2a373c5cb066b52c780716c https://github.com/openzfs/zfs/commit/100a91aa3e9773f2a2a373c5cb066b52c780716c Cherry-pick: >From 100a91aa3e9773f2a2a373c5cb066b52c780716c Mon Sep 17 00:00:00 2001 From: Chunwei Chen Date: Fri, 17 Jun 2016 17:36:01 -0700 Subject: [PATCH] Fix NFS credential Signed-off-by: Chunwei Chen Signed-off-by: Brian Behlendorf Closes #4772 Closes #4758 Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 \ src/external/cddl/osnet/dist/uts/common/fs/zfs/zfs_acl.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/iscsi/dist/src/lib
Module Name:src Committed By: fox Date: Tue Mar 17 00:57:55 UTC 2020 Modified Files: src/external/bsd/iscsi/dist/src/lib: initiator.c Log Message: external/bsd/iscsi: Fix -Werror=maybe-uninitialized error in initiator.c. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Submitted by: mlelstv@ Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/external/bsd/iscsi/dist/src/lib/initiator.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/lib/libdtrace
Module Name:src Committed By: fox Date: Tue Mar 17 01:36:29 UTC 2020 Modified Files: src/external/cddl/osnet/lib/libdtrace: Makefile Log Message: external/cddl/osnet: Do not suppress the warning output for libdtrace. Changed -Wno-maybe-uninitialized to -Wno-error=maybe-uninitialized to allow warnings to be printed out during build. Suggested by: christos@ To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/external/cddl/osnet/lib/libdtrace/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libusbhid
Module Name:src Committed By: fox Date: Sat Apr 4 21:21:35 UTC 2020 Modified Files: src/lib/libusbhid: data.c Log Message: lib/libusbhid: Fix possible left shift changes signedness bit. This bug was reported by UBSan runs. lib/libusbhid/data.c:58:25 lib/libusbhid/data.c:91:7 lib/libusbhid/data.c:92:7 Can result in left shift changes signedness bit as a side effect positive number can go negative, cast it to unsigned for the operation and silence the issue. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/lib/libusbhid/data.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libusbhid
Module Name:src Committed By: fox Date: Sat Apr 4 21:23:04 UTC 2020 Modified Files: src/lib/libusbhid: usage.c Log Message: lib/libusbhid: Fix possible left shift changes signedness bit. This bug was reported by UBSan runs. lib/libusbhid/usage.c:247:27 lib/libusbhid/usage.c:244:28 lib/libusbhid/usage.c:235:13 Can result in left shift changes signedness bit as a side effect positive number can go negative, cast it to unsigned for the operation and silence the issue. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/lib/libusbhid/usage.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libusbhid
Module Name:src Committed By: fox Date: Sat Apr 4 21:26:17 UTC 2020 Modified Files: src/lib/libusbhid: parse.c Log Message: lib/libusbhid: Fix possible left shift changes signedness bit. This bug was reported by UBSan runs. lib/libusbhid/parse.c:246:20 Can result in left shift changes signedness bit as a side effect positive number can go negative, cast it to unsigned for the operation and silence the issue. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/lib/libusbhid/parse.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/dhcpcd/sbin/dhcpcd
Module Name:src Committed By: fox Date: Sat May 2 19:35:03 UTC 2020 Modified Files: src/external/bsd/dhcpcd/sbin/dhcpcd: Makefile Log Message: external/bsd/dhcpcd: Suppress -Werror=sign-conversion error. Add -Wno-error=sign-conversion to prevent build failure, when run with MKLIBCSANITIZER=yes. Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag. Reviewed by: kamil@ To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/external/bsd/dhcpcd/sbin/dhcpcd/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: fox Date: Thu Dec 13 16:20:20 UTC 2018 Modified Files: src/sys/dev/usb: usbdevs Log Message: Add Logitech Gamepad F310 and Logitech Dual Action Gamepad To generate a diff of this commit: cvs rdiff -u -r1.762 -r1.763 src/sys/dev/usb/usbdevs Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: fox Date: Thu Dec 13 16:23:34 UTC 2018 Modified Files: src/sys/dev/usb: usbdevs.h usbdevs_data.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.755 -r1.756 src/sys/dev/usb/usbdevs.h \ src/sys/dev/usb/usbdevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/sys/uvm
Module Name:src Committed By: fox Date: Tue Dec 18 07:11:35 UTC 2018 Modified Files: src/tests/sys/uvm: t_uvm_physseg.c Log Message: Fixed the build failures caused by incompatible type comparisons. Reviewed by To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/sys/uvm/t_uvm_physseg.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/sys/uvm
Module Name:src Committed By: fox Date: Wed Jan 16 13:21:02 UTC 2019 Modified Files: src/tests/sys/uvm: t_uvm_physseg.c Log Message: Fixed the build failures caused by incompatible type comparisons when VM_PHYSSEG is > 1. Reviewed by To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/tests/sys/uvm/t_uvm_physseg.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/sys/uvm
Module Name:src Committed By: fox Date: Wed Jan 16 13:35:51 UTC 2019 Modified Files: src/tests/sys/uvm: t_uvm_physseg.c Log Message: Fixed issues with uvm_physseg_plug test case. There is a condition check which failed for VM_PHYSSEG_MAX == 2 (not for 1 or 3 and above), in case of 2, pgs == slab + npages1 + npages3, so we need to change ">" check to ">=" check. Reviewed by To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/tests/sys/uvm/t_uvm_physseg.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/sys/uvm
Module Name:src Committed By: fox Date: Wed Jan 16 13:45:29 UTC 2019 Modified Files: src/tests/sys/uvm: t_uvm_physseg.c Log Message: Fixed issues with uvm_physseg_atboot_free_leak test case. "\n" in ATF discriptions make it behave in weird ways, like saying "this test is bogus.", fixed the issue by removing the "\n". Reviewed by To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/tests/sys/uvm/t_uvm_physseg.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/sys/uvm
Module Name:src Committed By: fox Date: Wed Jan 16 13:54:17 UTC 2019 Modified Files: src/tests/sys/uvm: t_uvm_physseg.c Log Message: Fixed issues with uvm_page_physunload_delete_end test case. 1. "avail_start" and "start" were different, resulting in unreachable code in uvm_page_physunload(), where the condition check "avail_start" < "end" fails. The test has been fixed by setting "avail_start" and "start" to the same value. 2. If "start" is the address with end address being "start + 2", we can unplug twice, the first paddr_t would be "start" and the second one would be "start + 1". Modified the ATF_CHECK_EQ() to reflect these changes. Reviewed by To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/tests/sys/uvm/t_uvm_physseg.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
