CVS commit: src/tests/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 09:14:47 UTC 2021 Modified Files: src/tests/usr.bin/xlint/lint1: msg_115.c msg_115.exp Log Message: tests/lint: demonstrate wrong error message for initialization Seen in usr.bin/make/var.c:4022 in C99 mode, where a ModChain variable is initialized and two of the members are const-qualified. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/tests/usr.bin/xlint/lint1/msg_115.c cvs rdiff -u -r1.3 -r1.4 src/tests/usr.bin/xlint/lint1/msg_115.exp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Sat Jul 31 09:30:17 UTC 2021 Modified Files: src/usr.bin/make: Makefile make.h suff.c var.c src/usr.bin/make/filemon: filemon_ktrace.c Log Message: make: fix lint warnings The string functions from str.h are declared as 'static __unused' when compiled with GCC, but lint explicitly undefines __GCC__ during preprocessing. Therefore, make those functions inline, to prevent warnings that they are unused. The macro UNCONST is used in a few places, and (again) since lint undefines __GCC__, that macro expanded to a simple type cast, which lint warned about. To prevent this warning, implement UNCONST as a function that works everywhere and hides the type cast. In filemon_open, the code for closing F->in was obviously unreachable. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.115 -r1.116 src/usr.bin/make/Makefile cvs rdiff -u -r1.263 -r1.264 src/usr.bin/make/make.h cvs rdiff -u -r1.350 -r1.351 src/usr.bin/make/suff.c cvs rdiff -u -r1.944 -r1.945 src/usr.bin/make/var.c cvs rdiff -u -r1.14 -r1.15 src/usr.bin/make/filemon/filemon_ktrace.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/ic
Module Name:src Committed By: tnn Date: Sat Jul 31 10:04:13 UTC 2021 Modified Files: src/sys/dev/ic: com.c Log Message: only read cpr register if we're going to use the value To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365 src/sys/dev/ic/com.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/sparc/sparc
Module Name:src Committed By: andvar Date: Sat Jul 31 10:07:23 UTC 2021 Modified Files: src/sys/arch/sparc/sparc: autoconf.c Log Message: fix typos in comments To generate a diff of this commit: cvs rdiff -u -r1.266 -r1.267 src/sys/arch/sparc/sparc/autoconf.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 10:09:03 UTC 2021 Modified Files: src/tests/usr.bin/xlint/lint1: msg_115.c msg_115.exp Log Message: tests/lint: demonstrate more wrong warnings for const struct members The code 't_const = false' occurs 4 times in the lint code, each corresponding to one of the wrong warnings in the test. This bug has been existing at least since 2001. Back then, the lint output was: 2001.12.24.20.52.09 | (23): lint error: popctrl() 1 | (15): syntax error [249] | (19): warning: left operand of 'FARG' must be modifiable lvalue [115] | (21): syntax error [249] | (23): warning: function initialize_const_struct_member falls off bottom without returning value [217] | exit status 1 from 2002.12.06.03.27.39 | (23): lint error: func.c, 168: popctrl() | (15): warning: left operand of '=' must be modifiable lvalue [115] | (19): warning: left operand of 'FARG' must be modifiable lvalue [115] | (21): syntax error [249] | (23): warning: function initialize_const_struct_member falls off bottom without returning value [217] | exit status 1 until 2003.10.27.00.12.44 To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/tests/usr.bin/xlint/lint1/msg_115.c cvs rdiff -u -r1.4 -r1.5 src/tests/usr.bin/xlint/lint1/msg_115.exp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet6
Module Name:src Committed By: andvar Date: Sat Jul 31 10:12:04 UTC 2021 Modified Files: src/sys/netinet6: in6.h Log Message: fix typos in comments To generate a diff of this commit: cvs rdiff -u -r1.100 -r1.101 src/sys/netinet6/in6.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 11:03:04 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: decl.c externs1.h func.c init.c lint1.h tree.c Log Message: lint: merge duplicate code for generating unqualified type This is a preparation for fixing the wrong warnings in msg_115.c. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.210 -r1.211 src/usr.bin/xlint/lint1/decl.c cvs rdiff -u -r1.121 -r1.122 src/usr.bin/xlint/lint1/externs1.h cvs rdiff -u -r1.115 -r1.116 src/usr.bin/xlint/lint1/func.c cvs rdiff -u -r1.203 -r1.204 src/usr.bin/xlint/lint1/init.c cvs rdiff -u -r1.118 -r1.119 src/usr.bin/xlint/lint1/lint1.h cvs rdiff -u -r1.319 -r1.320 src/usr.bin/xlint/lint1/tree.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/sunxi
Module Name:src Committed By: tnn Date: Sat Jul 31 11:34:40 UTC 2021 Modified Files: src/sys/arch/arm/sunxi: sunxi_platform.c Log Message: sunxi_platform: declare UART FIFO sizes for SoCs we support To generate a diff of this commit: cvs rdiff -u -r1.44 -r1.45 src/sys/arch/arm/sunxi/sunxi_platform.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 11:37:54 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: tree.c Log Message: lint: in has_constant_member, don't reuse variables No functional change. To generate a diff of this commit: cvs rdiff -u -r1.320 -r1.321 src/usr.bin/xlint/lint1/tree.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 13:47:19 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: lex.c Log Message: lint: reduce indentation in 'search' No functional change. To generate a diff of this commit: cvs rdiff -u -r1.56 -r1.57 src/usr.bin/xlint/lint1/lex.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: andvar Date: Sat Jul 31 14:36:33 UTC 2021 Modified Files: src/common/lib/libc/hash/sha3: sha3.c src/sys/arch/arm/ixp12x0: ixp12x0_clk.c src/sys/arch/dreamcast/dev: pvr.c src/sys/dev/ic: mb86950.c mb86960.c mb86960var.h src/sys/dev/usb: umcs.h Log Message: fix more typos in style found one in file - check/fix them all. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/common/lib/libc/hash/sha3/sha3.c cvs rdiff -u -r1.18 -r1.19 src/sys/arch/arm/ixp12x0/ixp12x0_clk.c cvs rdiff -u -r1.37 -r1.38 src/sys/arch/dreamcast/dev/pvr.c cvs rdiff -u -r1.34 -r1.35 src/sys/dev/ic/mb86950.c cvs rdiff -u -r1.95 -r1.96 src/sys/dev/ic/mb86960.c cvs rdiff -u -r1.40 -r1.41 src/sys/dev/ic/mb86960var.h cvs rdiff -u -r1.2 -r1.3 src/sys/dev/usb/umcs.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/etc/rc.d
Module Name:src Committed By: mlelstv Date: Sat Jul 31 14:47:04 UTC 2021 Modified Files: src/etc/rc.d: devpubd Log Message: Run devpubd before volume managers and pseudo disks. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/etc/rc.d/devpubd Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/alpha/alpha
Module Name:src Committed By: thorpej Date: Sat Jul 31 14:51:25 UTC 2021 Modified Files: src/sys/arch/alpha/alpha: pmap.c Log Message: Fix a silly mistake (missing return) in the DEBUG case of the kernel pmap case of pmap_extract(). To generate a diff of this commit: cvs rdiff -u -r1.299 -r1.300 src/sys/arch/alpha/alpha/pmap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/libexec/lfs_cleanerd
Module Name:src Committed By: andvar Date: Sat Jul 31 15:02:54 UTC 2021 Modified Files: src/libexec/lfs_cleanerd: lfs_cleanerd.8 Log Message: s/threshhold/threshold To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/libexec/lfs_cleanerd/lfs_cleanerd.8 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/sparc/sparc
Module Name:src Committed By: andvar Date: Sat Jul 31 16:54:37 UTC 2021 Modified Files: src/sys/arch/sparc/sparc: autoconf.c Log Message: s/propective/prospective To generate a diff of this commit: cvs rdiff -u -r1.267 -r1.268 src/sys/arch/sparc/sparc/autoconf.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 17:09:21 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: Makefile cgram.y decl.c externs1.h Log Message: lint: add debugging output for the grammar tokens No functional change outside debug mode. To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81 src/usr.bin/xlint/lint1/Makefile cvs rdiff -u -r1.351 -r1.352 src/usr.bin/xlint/lint1/cgram.y cvs rdiff -u -r1.211 -r1.212 src/usr.bin/xlint/lint1/decl.c cvs rdiff -u -r1.122 -r1.123 src/usr.bin/xlint/lint1/externs1.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 18:16:42 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: Makefile externs1.h init.c tree.c Added Files: src/usr.bin/xlint/lint1: debug.c Log Message: lint: extract debug logging to separate file Lint currently has several different kinds of debug log: * The -DDEBUG log is controlled at compile time. * The -d command line options enables some other debug logging. * The -DYYDEBUG log for parsing is controlled at compile time. * The -y command line option only has an effect in -DYYDEBUG mode. Extracting the logging into a separate file is a first step towards unifying these logs and making the code for debug logging stand out less than the current #ifdef DEBUG. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.81 -r1.82 src/usr.bin/xlint/lint1/Makefile cvs rdiff -u -r0 -r1.1 src/usr.bin/xlint/lint1/debug.c cvs rdiff -u -r1.123 -r1.124 src/usr.bin/xlint/lint1/externs1.h cvs rdiff -u -r1.204 -r1.205 src/usr.bin/xlint/lint1/init.c cvs rdiff -u -r1.321 -r1.322 src/usr.bin/xlint/lint1/tree.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src
Committed By: rillig
Date: Sat Jul 31 19:07:52 UTC 2021
Modified Files:
src/usr.bin/xlint/lint1: decl.c err.c externs1.h func.c init.c lex.c
main1.c
Log Message:
lint: clean up debug logging
The calls to debug_step, unlike printf, don't need a trailing newline.
Remove the debug_step0 macro and its relatives since lint already uses
enough other features from C99 that it essentially requires this
standard, which supports varargs macro arguments. Among these features
are __func__ and printf("%zu").
In non-debug mode, do not evaluate the arguments of debug_step.
Evaluating the arguments had caused an internal error when running the
test op_shl_lp64. This is indeed a bug since initdecl should have
initialized the type table for __uint128_t. This had been forgotten
when support for __uint128_t was added in decl.c 1.69 from 2018-09-07.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.212 -r1.213 src/usr.bin/xlint/lint1/decl.c
cvs rdiff -u -r1.131 -r1.132 src/usr.bin/xlint/lint1/err.c
cvs rdiff -u -r1.124 -r1.125 src/usr.bin/xlint/lint1/externs1.h
cvs rdiff -u -r1.116 -r1.117 src/usr.bin/xlint/lint1/func.c
cvs rdiff -u -r1.205 -r1.206 src/usr.bin/xlint/lint1/init.c
cvs rdiff -u -r1.57 -r1.58 src/usr.bin/xlint/lint1/lex.c
cvs rdiff -u -r1.49 -r1.50 src/usr.bin/xlint/lint1/main1.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 19:12:35 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: externs1.h Log Message: lint: do not evaluate arguments of debug_step To analyze the unexpected test failure of op_shl_lp64, I had reverted debug_step to evaluate its arguments. I then accidentally committed that without running the tests again. Anyway, the previous commit can now be used as a demonstration that initdecl is indeed missing the initialization for __uint128_t, which leads to the internal error in op_shl_lp64. To generate a diff of this commit: cvs rdiff -u -r1.125 -r1.126 src/usr.bin/xlint/lint1/externs1.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sat Jul 31 19:20:59 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: decl.c Log Message: lint: initialize shared types in the same order as in tspec_t This makes it easier to see whether there are any types missing, such as __uint128_t. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.213 -r1.214 src/usr.bin/xlint/lint1/decl.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: rillig Date: Sat Jul 31 19:52:44 UTC 2021 Modified Files: src/tests/usr.bin/xlint/lint1: op_shl_lp64.c op_shl_lp64.exp src/usr.bin/xlint/lint1: decl.c emit1.c lint1.h src/usr.bin/xlint/lint2: read.c Log Message: lint: improve support for __int128_t and __uint128_t For the .ln files, I chose the letter 'J' to represent the 128-bit integer types since it is close to 'I' for int. The naming of 'L' for 'long' is obvious, but 'Q' for 64-bit integers is a quad-16-bit word, which is an unusual measurement unit nowadays. One benefit of choosing 'J' is that the next letter, 'K' can then be used for 256-bit integer types. Support for 128-bit integer types is still very basic. Plus, it is only supported on LP64 platforms, which means that lint cannot be cross-compiled to check for an LP64 platform while running on an ILP32 platform. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/tests/usr.bin/xlint/lint1/op_shl_lp64.c \ src/tests/usr.bin/xlint/lint1/op_shl_lp64.exp cvs rdiff -u -r1.214 -r1.215 src/usr.bin/xlint/lint1/decl.c cvs rdiff -u -r1.46 -r1.47 src/usr.bin/xlint/lint1/emit1.c cvs rdiff -u -r1.119 -r1.120 src/usr.bin/xlint/lint1/lint1.h cvs rdiff -u -r1.45 -r1.46 src/usr.bin/xlint/lint2/read.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: andvar Date: Sat Jul 31 20:29:37 UTC 2021 Modified Files: src/sys/arch/hp300/dev: rd.c src/sys/arch/m68k/fpsp: round.sa src/sys/arch/mips/sibyte/include: sb1250_mac.h src/sys/dev/gpib: rd.c src/sys/dev/ic: cs89x0.c siisatareg.h src/sys/dev/usb: umcs.h src/sys/netinet: tcp_congctl.c tcp_input.c tcp_subr.c tcp_var.h src/sys/ufs/lfs: lfs_vfsops.c Log Message: s/threshhold/threshold To generate a diff of this commit: cvs rdiff -u -r1.109 -r1.110 src/sys/arch/hp300/dev/rd.c cvs rdiff -u -r1.3 -r1.4 src/sys/arch/m68k/fpsp/round.sa cvs rdiff -u -r1.7 -r1.8 src/sys/arch/mips/sibyte/include/sb1250_mac.h cvs rdiff -u -r1.43 -r1.44 src/sys/dev/gpib/rd.c cvs rdiff -u -r1.50 -r1.51 src/sys/dev/ic/cs89x0.c cvs rdiff -u -r1.11 -r1.12 src/sys/dev/ic/siisatareg.h cvs rdiff -u -r1.3 -r1.4 src/sys/dev/usb/umcs.h cvs rdiff -u -r1.27 -r1.28 src/sys/netinet/tcp_congctl.c cvs rdiff -u -r1.428 -r1.429 src/sys/netinet/tcp_input.c cvs rdiff -u -r1.288 -r1.289 src/sys/netinet/tcp_subr.c cvs rdiff -u -r1.195 -r1.196 src/sys/netinet/tcp_var.h cvs rdiff -u -r1.380 -r1.381 src/sys/ufs/lfs/lfs_vfsops.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: andvar Date: Sat Jul 31 20:51:32 UTC 2021 Modified Files: src/lib/libc/sys: _lwp_create.2 src/lib/libedit: tty.h src/sys/arch/atari/pci: pci_vga.c src/sys/arch/hpcmips/include: sysconf.h src/sys/dev/hpc: hpcfbio.h src/sys/dev/isa: tcic2_isa.c Log Message: s/dependend/dependent/ To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/lib/libc/sys/_lwp_create.2 cvs rdiff -u -r1.23 -r1.24 src/lib/libedit/tty.h cvs rdiff -u -r1.17 -r1.18 src/sys/arch/atari/pci/pci_vga.c cvs rdiff -u -r1.17 -r1.18 src/sys/arch/hpcmips/include/sysconf.h cvs rdiff -u -r1.2 -r1.3 src/sys/dev/hpc/hpcfbio.h cvs rdiff -u -r1.28 -r1.29 src/sys/dev/isa/tcic2_isa.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: rillig Date: Sat Jul 31 20:55:46 UTC 2021 Modified Files: src/distrib/sets/lists/tests: mi src/usr.bin/make/unit-tests: Makefile varmod-order-numeric.exp varmod-order-numeric.mk varmod-order.exp varmod-order.mk Added Files: src/usr.bin/make/unit-tests: varmod-order-string.exp varmod-order-string.mk Log Message: tests/make: split tests for the variable modifier ':O' The tests for parse errors are now in varmod-order, which lets the other tests focus on the desired behavior of the modifiers. To generate a diff of this commit: cvs rdiff -u -r1.1097 -r1.1098 src/distrib/sets/lists/tests/mi cvs rdiff -u -r1.281 -r1.282 src/usr.bin/make/unit-tests/Makefile cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit-tests/varmod-order-numeric.exp \ src/usr.bin/make/unit-tests/varmod-order-numeric.mk \ src/usr.bin/make/unit-tests/varmod-order.exp cvs rdiff -u -r0 -r1.1 src/usr.bin/make/unit-tests/varmod-order-string.exp \ src/usr.bin/make/unit-tests/varmod-order-string.mk cvs rdiff -u -r1.5 -r1.6 src/usr.bin/make/unit-tests/varmod-order.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sun Aug 1 06:40:37 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: cgram.y decl.c func.c lex.c main1.c Log Message: lint: add debug logging for symbol table, clean up debug logging When I tried to fix msg_115, I quickly ran into a segmentation fault, probably related to the symbol table. To better understand this part, log insertions and deletions. The other debug log messages do not need to mention the current file position anymore, this is what lex_next_line takes care of since scan.l 1.113 from 2021-01-05. To generate a diff of this commit: cvs rdiff -u -r1.352 -r1.353 src/usr.bin/xlint/lint1/cgram.y cvs rdiff -u -r1.215 -r1.216 src/usr.bin/xlint/lint1/decl.c cvs rdiff -u -r1.117 -r1.118 src/usr.bin/xlint/lint1/func.c cvs rdiff -u -r1.58 -r1.59 src/usr.bin/xlint/lint1/lex.c cvs rdiff -u -r1.50 -r1.51 src/usr.bin/xlint/lint1/main1.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Sun Aug 1 06:58:58 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: lex.c Log Message: lint: extract duplicate code for modifying the symbol table No functional change. To generate a diff of this commit: cvs rdiff -u -r1.59 -r1.60 src/usr.bin/xlint/lint1/lex.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
