CVS commit: src/sys/sys
Module Name:src Committed By: kre Date: Mon Feb 15 09:29:57 UTC 2021 Modified Files: src/sys/sys: mbuf.h Log Message: Don't compare int against size_t .. since mbuf lengths should never be negative, cast it from int to size_t (rather than the other way around). Hopefully fix build. To generate a diff of this commit: cvs rdiff -u -r1.229 -r1.230 src/sys/sys/mbuf.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet6
Module Name:src Committed By: martin Date: Mon Feb 15 10:13:45 UTC 2021 Modified Files: src/sys/netinet6: icmp6.c Log Message: Fix the build. Maybe there should be a ICMP6_HDR_ALIGNMENT, but for now there is only IP6_HDR_ALIGNMENT. To generate a diff of this commit: cvs rdiff -u -r1.248 -r1.249 src/sys/netinet6/icmp6.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: jmcneill Date: Mon Feb 15 13:03:52 UTC 2021 Modified Files: src/sys/arch/arm/pic: pic.c Log Message: pic: reduce the number of daif accesses in pic_do_pending_ints The caller has already provided daif state. No need to keep updating daif via pic_set_priority if it's already in the state we need (interrupts disabled). To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63 src/sys/arch/arm/pic/pic.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: isaki Date: Mon Feb 15 13:39:18 UTC 2021 Modified Files: src/sys/dev/usb: uaudio.c Log Message: Fix my copy-and-paste bug in rev1.160. This fixes recording sample dropout. To generate a diff of this commit: cvs rdiff -u -r1.168 -r1.169 src/sys/dev/usb/uaudio.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libc/locale
Module Name:src Committed By: christos Date: Mon Feb 15 14:35:04 UTC 2021 Modified Files: src/lib/libc/locale: Makefile.inc Added Files: src/lib/libc/locale: duplocale.3 freelocale.3 newlocale.3 Log Message: Add missing man pages (from FreeBSD) To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65 src/lib/libc/locale/Makefile.inc cvs rdiff -u -r0 -r1.1 src/lib/libc/locale/duplocale.3 \ src/lib/libc/locale/freelocale.3 src/lib/libc/locale/newlocale.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/comp
Module Name:src Committed By: christos Date: Mon Feb 15 14:38:06 UTC 2021 Modified Files: src/distrib/sets/lists/comp: mi Log Message: new locale pages, sort To generate a diff of this commit: cvs rdiff -u -r1.2373 -r1.2374 src/distrib/sets/lists/comp/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: jmcneill Date: Mon Feb 15 15:07:48 UTC 2021 Modified Files: src/sys/arch/arm/pic: pic_splfuncs.c Log Message: splx: only dispatch softints if interrupts are enabled To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sys/arch/arm/pic/pic_splfuncs.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libc/locale
Module Name:src Committed By: christos Date: Mon Feb 15 15:36:53 UTC 2021 Modified Files: src/lib/libc/locale: duplocale.3 freelocale.3 newlocale.3 Log Message: Remove FreeBSD portions that are not relevant to our implementation (pointed out by joerg@) To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/lib/libc/locale/duplocale.3 \ src/lib/libc/locale/freelocale.3 src/lib/libc/locale/newlocale.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libc/locale
Module Name:src Committed By: wiz Date: Mon Feb 15 15:38:43 UTC 2021 Modified Files: src/lib/libc/locale: duplocale.3 freelocale.3 newlocale.3 Log Message: Remove reference to multibyte(3) and trailing commas. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/lib/libc/locale/duplocale.3 \ src/lib/libc/locale/freelocale.3 src/lib/libc/locale/newlocale.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: jmcneill Date: Mon Feb 15 15:42:58 UTC 2021 Modified Files: src/sys/arch/arm/pic: pic_splfuncs.c Log Message: splx: only dispatch hard interrupts if interrupts are enabled To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/arch/arm/pic/pic_splfuncs.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/sys
Module Name:src Committed By: christos Date: Mon Feb 15 15:53:49 UTC 2021 Modified Files: src/sys/sys: param.h Log Message: Fix reversed test (thanks mlelstv) To generate a diff of this commit: cvs rdiff -u -r1.685 -r1.686 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/lib/libcurses/director
Module Name:src Committed By: joerg Date: Mon Feb 15 15:55:51 UTC 2021 Modified Files: src/tests/lib/libcurses/director: testlang_parse.y Log Message: Simplify to avoid copy based on the size of the source. To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/tests/lib/libcurses/director/testlang_parse.y Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: jmcneill Date: Mon Feb 15 16:04:01 UTC 2021 Modified Files: src/sys/arch/arm/pic: pic_splfuncs.c Log Message: splx: restore priority even if interrupts are disabled To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/sys/arch/arm/pic/pic_splfuncs.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: jmcneill Date: Mon Feb 15 16:32:07 UTC 2021 Modified Files: src/sys/arch/arm/pic: pic.c pic_splfuncs.c picvar.h Log Message: splx: use pic_set_priority_psw in interrupts disabled case to skip a few more daif accesses. To generate a diff of this commit: cvs rdiff -u -r1.63 -r1.64 src/sys/arch/arm/pic/pic.c cvs rdiff -u -r1.11 -r1.12 src/sys/arch/arm/pic/pic_splfuncs.c cvs rdiff -u -r1.26 -r1.27 src/sys/arch/arm/pic/picvar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src
Committed By: rillig
Date: Mon Feb 15 17:44:09 UTC 2021
Modified Files:
src/usr.bin/make: var.c
Log Message:
make: split parameters for evaluating variable expressions
The details of how variable expressions are evaluated is controlled by
several parameters: startc and endc differ for $(VAR) and ${VAR}, the
value of the expression can be interpreted as a single big word, and
when joining several words (such as with ':M' or ':S'), there may be a
custom word separator (defined with ':ts*').
The scope of half of these parameters is the whole variable expression,
the other half of the parameters are reset after each chain of indirect
modifiers. To make this distinction obvious in the code, extract Expr
from ApplyModifiersState. Previously, these details were hidden in how
parameters are passed and restored among ApplyModifiersIndirect and
ApplyModifiers.
The changes in the individual ApplyModifier functions are numerous but
straight-forward. They mostly replace 'st' with 'expr'.
The changes in ApplyModifiers and ApplyModifiersIndirect are more
subtle. The value of the expression is no longer passed around but is
stored in a fixed location, in Expr, which makes it easier to reason
about memory management.
The code in ApplyModifiers after 'cleanup' looks quite different but
preserves the existing behavior. Expr_SetValueRefer is nothing else
than the combination of FStr_Done followed by FStr_InitRefer. Storing
exprStatus back at the end was responsible for passing the definedness
of the expression after applying the indirect modifiers back to the
outer ApplyModifiersState. The same effect is now achieved by having
Expr.status with a wider scope.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.822 -r1.823 src/usr.bin/make/var.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/sys/arch/aarch64/aarch64
Module Name:src Committed By: jmcneill Date: Mon Feb 15 17:46:36 UTC 2021 Modified Files: src/sys/arch/aarch64/aarch64: trap.c Log Message: interrupt: enable interrupts before running soft intr handlers. To avoid stack usage going out of control, only do this at ci_intr_depth==0. To generate a diff of this commit: cvs rdiff -u -r1.41 -r1.42 src/sys/arch/aarch64/aarch64/trap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Mon Feb 15 17:59:09 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: update comments for Expr, amending the previous commit To generate a diff of this commit: cvs rdiff -u -r1.823 -r1.824 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Mon Feb 15 18:21:14 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: rename ExprStatus to ExprDefined The type describes the definedness of an expression, not a general status, therefore the new name is more precise. The constants are renamed as well since their prefix 'VES' does not match the type name anymore, it was correct 3 days ago when the type was still named VarExprStatus. The name VES_NONE was misleading since 'none' does not describe its actual effect. That name came from the time when the status was a bit set, and 'none' simply meant 'none of the bits are set'. The names used in debug logging will be renamed in a follow-up commit, to demonstrate that the changes in this commit indeed have no functional change, especially not the change from '!=' to '==' in line 4304. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.824 -r1.825 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Mon Feb 15 18:23:32 UTC 2021 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: directive-export-impl.exp directive-unexport-env.exp var-op-append.exp vardebug.exp varmod-defined.exp varmod-indirect.exp varmod-match-escape.exp varname-empty.exp varname.exp Log Message: make: rename ExprDefined constants for debug logging To generate a diff of this commit: cvs rdiff -u -r1.825 -r1.826 src/usr.bin/make/var.c cvs rdiff -u -r1.2 -r1.3 \ src/usr.bin/make/unit-tests/directive-export-impl.exp cvs rdiff -u -r1.4 -r1.5 \ src/usr.bin/make/unit-tests/directive-unexport-env.exp \ src/usr.bin/make/unit-tests/var-op-append.exp cvs rdiff -u -r1.15 -r1.16 src/usr.bin/make/unit-tests/vardebug.exp cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit-tests/varmod-defined.exp cvs rdiff -u -r1.10 -r1.11 src/usr.bin/make/unit-tests/varmod-indirect.exp cvs rdiff -u -r1.6 -r1.7 src/usr.bin/make/unit-tests/varmod-match-escape.exp cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/unit-tests/varname-empty.exp cvs rdiff -u -r1.11 -r1.12 src/usr.bin/make/unit-tests/varname.exp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/sys
Module Name:src Committed By: christos Date: Mon Feb 15 18:33:29 UTC 2021 Modified Files: src/sys/sys: param.h Log Message: Fix pointer aligned macro to match the original (thanks @mlelstv) To generate a diff of this commit: cvs rdiff -u -r1.686 -r1.687 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet
Module Name:src Committed By: christos Date: Mon Feb 15 19:19:30 UTC 2021 Modified Files: src/sys/netinet: if_arp.c Log Message: put back alignment (reported by martin@) To generate a diff of this commit: cvs rdiff -u -r1.302 -r1.303 src/sys/netinet/if_arp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/sys
Module Name:src Committed By: christos Date: Mon Feb 15 19:46:53 UTC 2021 Modified Files: src/sys/sys: param.h Log Message: the fourth time is the charm To generate a diff of this commit: cvs rdiff -u -r1.687 -r1.688 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet
Module Name:src Committed By: christos Date: Mon Feb 15 19:49:17 UTC 2021 Modified Files: src/sys/netinet: if_arp.c Log Message: Undo previous; POINTER_ALIGNED_P was broken. To generate a diff of this commit: cvs rdiff -u -r1.303 -r1.304 src/sys/netinet/if_arp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/evbmips/mipssim
Module Name:src Committed By: reinoud Date: Mon Feb 15 22:39:46 UTC 2021 Modified Files: src/sys/arch/evbmips/mipssim: autoconf.h machdep.c mainbus.c mipssim_bus_io.c mipssim_intr.c mipssimreg.h mipssimvar.h Added Files: src/sys/arch/evbmips/mipssim: mipssim_dma.c virtio_mainbus.c Log Message: Add VirtIO devices to the MIPSSIM target for use in Qemu. Its supported by a local patch starting at Qemu-5.1.0nb12 To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/arch/evbmips/mipssim/autoconf.h \ src/sys/arch/evbmips/mipssim/machdep.c \ src/sys/arch/evbmips/mipssim/mainbus.c \ src/sys/arch/evbmips/mipssim/mipssim_bus_io.c \ src/sys/arch/evbmips/mipssim/mipssim_intr.c \ src/sys/arch/evbmips/mipssim/mipssimreg.h \ src/sys/arch/evbmips/mipssim/mipssimvar.h cvs rdiff -u -r0 -r1.1 src/sys/arch/evbmips/mipssim/mipssim_dma.c \ src/sys/arch/evbmips/mipssim/virtio_mainbus.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets
Module Name:src Committed By: rillig Date: Mon Feb 15 23:00:03 UTC 2021 Modified Files: src/distrib/sets: fmt-list Log Message: distrib/sets/list-fmt: sort commented entries like regular entries Seen in lists/modules/ad.aarch64, among others. These lines are not intended as comments but as regular entries that just happen to be commented out. This is the same as how pkglint treats commented variable assignments, which take part in aligning blocks of variable assignments even though they are syntactically comments. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/distrib/sets/fmt-list Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/raidframe
Module Name:src Committed By: oster Date: Mon Feb 15 23:27:03 UTC 2021 Modified Files: src/sys/dev/raidframe: rf_reconstruct.c Log Message: Fix a long long-standing off-by-one error in computing lastPSID. SUsPerPU is only really supported for a value of 1, and since the first PSID is 0, the last will be numStripe-1. Also update the setting of pending_writes to reflect the change to lastPSID. Needs pullups to -8 and -9. To generate a diff of this commit: cvs rdiff -u -r1.124 -r1.125 src/sys/dev/raidframe/rf_reconstruct.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets
Module Name:src Committed By: rillig Date: Mon Feb 15 23:46:46 UTC 2021 Modified Files: src/distrib/sets: fmt-list Log Message: distrib/sets/fmt-list: document how to sort by directory first In lists/base/mi, the directory ./libdata/firmware contains several subdirectories for which the entries do not look aligned right now, even after normalizing the alignment. This is because the indentation for a directory is not determined globally for all directory entries from the complete file, but instead for each group of items, after sorting, that have the same directory. This results in several entries having only a single item per group, such as ./libdata/firmware/nouveau, and this single item is obviously consistently indented since all of its 1 lines are already indented to the same depth. One possible solution for this is to sort the entries in another order, keeping all entries from a directory together. This allows to quickly see all entries from a certain directory, but on the other hand, when adding a new directory plus some entries, the directory has to be listed far away from its entries. (This would be done automatically by fmt-list though, which weakens this argument a bit.) Another possible solution for this is to first determine the indentation for all entries from each directory, no matter how far these entries are apart, and then indent these entries to the common indentation. This may or may not help since there will still be single entries between groups of differently indented entries. Writing down the intuitive rules for how to align the entries properly is a nontrivial task. See pkglint/varalignblock, which is around 650 lines of code, plus around 4000 lines of test code. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/fmt-list Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/mips/include
Module Name:src Committed By: simonb Date: Tue Feb 16 05:11:27 UTC 2021 Modified Files: src/sys/arch/mips/include: intr.h Log Message: Add no-profiled attribute for splhigh_noprof() and splx_noprof(). To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/sys/arch/mips/include/intr.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet
Module Name:src Committed By: martin Date: Tue Feb 16 05:44:14 UTC 2021 Modified Files: src/sys/netinet: if_arp.c Log Message: Undo previous backout: alignment is needed here. The reason for the previous backout was a misunderstanding (POINTER_ALIGNED_P was broken, but the assertion fired even after it got fixed). To generate a diff of this commit: cvs rdiff -u -r1.304 -r1.305 src/sys/netinet/if_arp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/mips
Module Name:src Committed By: simonb Date: Tue Feb 16 06:06:58 UTC 2021 Modified Files: src/sys/arch/mips/include: asm.h profile.h src/sys/arch/mips/mips: mipsX_subr.S mips_fixup.c Log Message: Working kernel profiling for n32/n64: - Different MCOUNT and _KERN_MCOUNT macros for n32/n64. - Don't profile mipsXX_lwp_trampoline(). - Allow a few new instructions in the stub fixups. To generate a diff of this commit: cvs rdiff -u -r1.63 -r1.64 src/sys/arch/mips/include/asm.h cvs rdiff -u -r1.22 -r1.23 src/sys/arch/mips/include/profile.h cvs rdiff -u -r1.112 -r1.113 src/sys/arch/mips/mips/mipsX_subr.S cvs rdiff -u -r1.20 -r1.21 src/sys/arch/mips/mips/mips_fixup.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: skrll Date: Tue Feb 16 07:27:12 UTC 2021 Modified Files: src/sys/arch/arm/pic: picvar.h Log Message: Provide a pic_set_priority_psw in the case that __HAVE_PIC_SET_PRIORITY is not defined. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/sys/arch/arm/pic/picvar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
