CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Wed Feb 3 08:00:36 UTC 2021 Modified Files: src/usr.bin/make: dir.c job.c main.c meta.c nonints.h parse.c suff.c targ.c util.c var.c Log Message: make: use shortcut functions Global_SetExpand and Global_AppendExpand There are many places where global variables are set or appended to. To reduce clutter and code size, encode the VAR_GLOBAL in the function name. The word Expand in the function names says that the variable name is expanded. In most of the cases, this is not necessary, but there are no corresponding functions Global_Set or Global_Append yet. Encoding the information whether the name is expanded or not in the function name will make inconsistencies obvious in future manual code reviews. Letting the compiler check this by using different types for unexpanded and expanded variable names is probably not worth the effort. There are still a few bugs to be fixed, such as in SetVar, which expands the variable name twice in a row. To generate a diff of this commit: cvs rdiff -u -r1.265 -r1.266 src/usr.bin/make/dir.c cvs rdiff -u -r1.412 -r1.413 src/usr.bin/make/job.c cvs rdiff -u -r1.526 -r1.527 src/usr.bin/make/main.c cvs rdiff -u -r1.170 -r1.171 src/usr.bin/make/meta.c cvs rdiff -u -r1.190 -r1.191 src/usr.bin/make/nonints.h cvs rdiff -u -r1.538 -r1.539 src/usr.bin/make/parse.c cvs rdiff -u -r1.341 -r1.342 src/usr.bin/make/suff.c cvs rdiff -u -r1.161 -r1.162 src/usr.bin/make/targ.c cvs rdiff -u -r1.75 -r1.76 src/usr.bin/make/util.c cvs rdiff -u -r1.790 -r1.791 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Wed Feb 3 08:08:18 UTC 2021 Modified Files: src/usr.bin/make: job.c main.c meta.c nonints.h parse.c suff.c var.c Log Message: make: replace Global_SetExpand with Global_Set for constant names To generate a diff of this commit: cvs rdiff -u -r1.413 -r1.414 src/usr.bin/make/job.c cvs rdiff -u -r1.527 -r1.528 src/usr.bin/make/main.c cvs rdiff -u -r1.171 -r1.172 src/usr.bin/make/meta.c cvs rdiff -u -r1.191 -r1.192 src/usr.bin/make/nonints.h cvs rdiff -u -r1.539 -r1.540 src/usr.bin/make/parse.c cvs rdiff -u -r1.342 -r1.343 src/usr.bin/make/suff.c cvs rdiff -u -r1.791 -r1.792 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make/unit-tests
Module Name:src Committed By: rillig Date: Wed Feb 3 08:34:15 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: Makefile varname-empty.exp varname-empty.mk Log Message: make: in the test varname-empty, keep more debug output Filtering out the interesting lines based on the very specific pattern "Var_Set" was surprising. To generate a diff of this commit: cvs rdiff -u -r1.266 -r1.267 src/usr.bin/make/unit-tests/Makefile cvs rdiff -u -r1.5 -r1.6 src/usr.bin/make/unit-tests/varname-empty.exp cvs rdiff -u -r1.7 -r1.8 src/usr.bin/make/unit-tests/varname-empty.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Wed Feb 3 08:40:47 UTC 2021 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: var-op-append.exp var-op-append.mk varname-empty.exp Log Message: make: fix double expansion when appending to a new variable To generate a diff of this commit: cvs rdiff -u -r1.792 -r1.793 src/usr.bin/make/var.c cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit-tests/var-op-append.exp cvs rdiff -u -r1.7 -r1.8 src/usr.bin/make/unit-tests/var-op-append.mk cvs rdiff -u -r1.6 -r1.7 src/usr.bin/make/unit-tests/varname-empty.exp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/net
Module Name:src Committed By: roy Date: Wed Feb 3 10:31:10 UTC 2021 Modified Files: src/sys/net: if_arp.h Log Message: Whitespace To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/net/if_arp.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/powerpc/include
Module Name:src Committed By: rin Date: Wed Feb 3 10:37:05 UTC 2021 Modified Files: src/sys/arch/powerpc/include: cpu.h Log Message: Pull out constant definitions inside struct declaration. Enable CTASSERT(9) for CPUSAVE_SIZE. To generate a diff of this commit: cvs rdiff -u -r1.115 -r1.116 src/sys/arch/powerpc/include/cpu.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet
Module Name:src Committed By: roy Date: Wed Feb 3 11:52:23 UTC 2021 Modified Files: src/sys/netinet: tcp_debug.h Log Message: tcp_debug: restore __packed To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/sys/netinet/tcp_debug.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: roy Date: Wed Feb 3 11:53:43 UTC 2021 Modified Files: src/sys/net: if_arp.h if_ether.h if_gre.h src/sys/netinet: if_ether.h igmp.h in.h ip.h ip6.h ip_icmp.h ip_mroute.h ip_var.h tcp.h tcp_var.h udp.h udp_var.h Log Message: Sprinkle CTASSERT to enforce on-wire layout without __packed To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36 src/sys/net/if_arp.h cvs rdiff -u -r1.82 -r1.83 src/sys/net/if_ether.h cvs rdiff -u -r1.45 -r1.46 src/sys/net/if_gre.h cvs rdiff -u -r1.35 -r1.36 src/sys/netinet/if_ether.h src/sys/netinet/tcp.h cvs rdiff -u -r1.13 -r1.14 src/sys/netinet/igmp.h cvs rdiff -u -r1.112 -r1.113 src/sys/netinet/in.h cvs rdiff -u -r1.36 -r1.37 src/sys/netinet/ip.h cvs rdiff -u -r1.27 -r1.28 src/sys/netinet/ip6.h cvs rdiff -u -r1.41 -r1.42 src/sys/netinet/ip_icmp.h cvs rdiff -u -r1.33 -r1.34 src/sys/netinet/ip_mroute.h cvs rdiff -u -r1.131 -r1.132 src/sys/netinet/ip_var.h cvs rdiff -u -r1.193 -r1.194 src/sys/netinet/tcp_var.h cvs rdiff -u -r1.17 -r1.18 src/sys/netinet/udp.h cvs rdiff -u -r1.47 -r1.48 src/sys/netinet/udp_var.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/net
Module Name:src Committed By: roy Date: Wed Feb 3 12:11:34 UTC 2021 Modified Files: src/sys/net: if_llc.h Log Message: if_llc.h: Replace __packed with CTASSERT To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/sys/net/if_llc.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Wed Feb 3 13:44:39 UTC 2021 Modified Files: src/usr.bin/make: nonints.h parse.c var.c Log Message: make: split Var_Append into Var_Append and Var_AppendExpand The plain Var_Append now does not expand the variable name anymore. It is used in situations where the variable name is known to not contain a dollar sign. This is a preparation for adding Global_Append, corresponding to Global_AppendExpand. To generate a diff of this commit: cvs rdiff -u -r1.192 -r1.193 src/usr.bin/make/nonints.h cvs rdiff -u -r1.540 -r1.541 src/usr.bin/make/parse.c cvs rdiff -u -r1.793 -r1.794 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Wed Feb 3 13:53:12 UTC 2021 Modified Files: src/usr.bin/make: dir.c job.c main.c meta.c nonints.h parse.c targ.c var.c Log Message: make: replace Global_AppendExpand with Global_Append All callers with a variable name that is guaranteed to not contain a dollar sign have been converted to call Global_Append instead of the previous Global_AppendExpand. After that, Global_AppendExpand was unused, therefore it was effectively just renamed. To generate a diff of this commit: cvs rdiff -u -r1.266 -r1.267 src/usr.bin/make/dir.c cvs rdiff -u -r1.414 -r1.415 src/usr.bin/make/job.c cvs rdiff -u -r1.528 -r1.529 src/usr.bin/make/main.c cvs rdiff -u -r1.172 -r1.173 src/usr.bin/make/meta.c cvs rdiff -u -r1.193 -r1.194 src/usr.bin/make/nonints.h cvs rdiff -u -r1.541 -r1.542 src/usr.bin/make/parse.c cvs rdiff -u -r1.162 -r1.163 src/usr.bin/make/targ.c cvs rdiff -u -r1.794 -r1.795 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/iomd
Module Name:src Committed By: isaki Date: Wed Feb 3 14:22:21 UTC 2021 Modified Files: src/sys/arch/arm/iomd: vidcaudio.c Log Message: Remove a comment no longer correct. Because halt_output is no longer called from an interrupt context, but that does not mean it's better to put this back to halt_output. To generate a diff of this commit: cvs rdiff -u -r1.60 -r1.61 src/sys/arch/arm/iomd/vidcaudio.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Wed Feb 3 14:33:09 UTC 2021 Modified Files: src/usr.bin/make: nonints.h parse.c var.c Log Message: make: split Var_Exists into plain Var_Exists and Var_ExistsExpand Most previous calls to Var_Exists use constant variable names. Only the two calls in parse.c need to expand the variable name. It may be a good idea to expand the variable name once in VarAssign_Eval instead of repeating the expansion in each of its special cases. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.194 -r1.195 src/usr.bin/make/nonints.h cvs rdiff -u -r1.542 -r1.543 src/usr.bin/make/parse.c cvs rdiff -u -r1.795 -r1.796 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src
Committed By: isaki
Date: Wed Feb 3 14:44:32 UTC 2021
Modified Files:
src/sys/dev/pci: cs4280.c cs4281.c cs428x.h
Log Message:
Remove code no longer used.
The code that used sc->{halt_input,halt_output} function pointer
was removed in 2004. (see cs428x.c rev 1.7)
To generate a diff of this commit:
cvs rdiff -u -r1.72 -r1.73 src/sys/dev/pci/cs4280.c
cvs rdiff -u -r1.56 -r1.57 src/sys/dev/pci/cs4281.c
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/pci/cs428x.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src
Committed By: rillig
Date: Wed Feb 3 15:08:17 UTC 2021
Modified Files:
src/usr.bin/make: meta.c nonints.h var.c
Log Message:
make: rename Var_Delete to Var_DeleteExpand, Var_DeleteVar to Var_Delete
The function names now follow the naming scheme from the other functions
that handle variables.
There are several calls that remain syntactically unchanged but that
omit the call to strchr('$') now. Since all these calls use constant
variable names, there is no functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.173 -r1.174 src/usr.bin/make/meta.c
cvs rdiff -u -r1.195 -r1.196 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.796 -r1.797 src/usr.bin/make/var.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/sys/arch/hppa/gsc
Module Name:src Committed By: isaki Date: Wed Feb 3 15:13:49 UTC 2021 Modified Files: src/sys/arch/hppa/gsc: harmony.c Log Message: Fix locking against myself. trigger_output will be called with sc_intr_lock held. >From source code review, not tested. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/arch/hppa/gsc/harmony.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/gpl2/send-pr/dist/send-pr
Module Name:src Committed By: ryoon Date: Wed Feb 3 15:42:53 UTC 2021 Modified Files: src/external/gpl2/send-pr/dist/send-pr: send-pr-el.in Log Message: Do not use old-style backquotes and other old-style expressions. Fix PR misc/55918. Tested with pkgsrc/editors/emacs26 and emacs27. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/external/gpl2/send-pr/dist/send-pr/send-pr-el.in Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet
Module Name:src Committed By: roy Date: Wed Feb 3 17:10:13 UTC 2021 Modified Files: src/sys/netinet: if_ether.h Log Message: Guard CTASSERT To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/netinet/if_ether.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: roy Date: Wed Feb 3 18:13:14 UTC 2021 Modified Files: src/sys/net: if_arp.h if_ether.h if_gre.h if_llc.h src/sys/netinet: igmp.h in.h ip.h ip6.h ip_carp.h ip_icmp.h ip_mroute.h ip_var.h tcp.h tcp_debug.h udp.h Log Message: CTASSERT -> __CTASSERT to unbreak userland build. While here move __packed in tcp_debug.h back to where it was and note removal warrants more investigation. To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/net/if_arp.h cvs rdiff -u -r1.83 -r1.84 src/sys/net/if_ether.h cvs rdiff -u -r1.46 -r1.47 src/sys/net/if_gre.h cvs rdiff -u -r1.22 -r1.23 src/sys/net/if_llc.h cvs rdiff -u -r1.14 -r1.15 src/sys/netinet/igmp.h cvs rdiff -u -r1.113 -r1.114 src/sys/netinet/in.h cvs rdiff -u -r1.37 -r1.38 src/sys/netinet/ip.h cvs rdiff -u -r1.28 -r1.29 src/sys/netinet/ip6.h cvs rdiff -u -r1.13 -r1.14 src/sys/netinet/ip_carp.h cvs rdiff -u -r1.42 -r1.43 src/sys/netinet/ip_icmp.h cvs rdiff -u -r1.34 -r1.35 src/sys/netinet/ip_mroute.h cvs rdiff -u -r1.132 -r1.133 src/sys/netinet/ip_var.h cvs rdiff -u -r1.36 -r1.37 src/sys/netinet/tcp.h cvs rdiff -u -r1.20 -r1.21 src/sys/netinet/tcp_debug.h cvs rdiff -u -r1.18 -r1.19 src/sys/netinet/udp.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: reinoud Date: Wed Feb 3 20:28:00 UTC 2021 Modified Files: src/sys/dev/pci: if_vioif.c Log Message: Allocate enough space for the bus_dmamap_t arrays for rxq_hdr_dmamaps[] and txq_hdr_maps[] To generate a diff of this commit: cvs rdiff -u -r1.67 -r1.68 src/sys/dev/pci/if_vioif.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: reinoud Date: Wed Feb 3 21:04:41 UTC 2021 Modified Files: src/sys/dev/pci: if_vioif.c Log Message: Oops, made a mistake in my last commit To generate a diff of this commit: cvs rdiff -u -r1.68 -r1.69 src/sys/dev/pci/if_vioif.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: thorpej Date: Wed Feb 3 23:23:42 UTC 2021 Modified Files: src/sys/dev/usb: usbdevs Log Message: Add a CHICONY optical mouse product ID. To generate a diff of this commit: cvs rdiff -u -r1.789 -r1.790 src/sys/dev/usb/usbdevs Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: thorpej Date: Wed Feb 3 23:24:08 UTC 2021 Modified Files: src/sys/dev/usb: usbdevs.h usbdevs_data.h Log Message: Regen for addition of CHICONY optical mouse. To generate a diff of this commit: cvs rdiff -u -r1.779 -r1.780 src/sys/dev/usb/usbdevs.h \ src/sys/dev/usb/usbdevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: thorpej Date: Wed Feb 3 23:26:08 UTC 2021 Modified Files: src/sys/dev/usb: ums.c Log Message: I have a cheap USB optical mouse (CHICONY product 0x0939, also known as "PixArt USB Optical Mouse") that likes to disconnect after 60 seconds and then reattach 2 seconds later (ad nauseum) unless it's kept open, so use the "always open" quirk on that device as well. To generate a diff of this commit: cvs rdiff -u -r1.99 -r1.100 src/sys/dev/usb/ums.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make/unit-tests
Module Name:src Committed By: rillig Date: Thu Feb 4 00:16:03 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: Makefile varname-empty.exp Log Message: make: remove .PARSEDIR from test output of varname-empty The .PARSEDIR has nothing to do with .CURDIR. This wrong assumption made the NetBSD test suite fail since the actual .PARSEDIR was not replaced with "". To generate a diff of this commit: cvs rdiff -u -r1.267 -r1.268 src/usr.bin/make/unit-tests/Makefile cvs rdiff -u -r1.7 -r1.8 src/usr.bin/make/unit-tests/varname-empty.exp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: rillig Date: Thu Feb 4 06:55:00 UTC 2021 Modified Files: src/tests/usr.bin/xlint/lint1: d_constant_conv2.exp d_gcc_extension.exp d_type_conv1.exp d_type_conv2.exp d_type_conv3.exp msg_259.c msg_259.exp src/usr.bin/xlint/lint1: err.c tree.c Log Message: lint: add back "due to prototype" to message 259 That message is only supposed to warn about compatibility to traditional C, in case the function should ever be compiled without its prototype being in effect. All other type checks are supposed to be in another function, as documented, but that type check misses to report a few error-prone type combinations (long to char, long to int). 30 years after the introduction of prototypes with C90, almost all existing code uses prototypes. The warning has thus lost most of its usefulness and can rather be confusing since a conversion from 'char' to 'long' is not problematic with prototypes in action, and the probability of the code being backported to a pre-C90 compiler is diminishingly small. The words "due to prototype" now serve as a hint again. The proper fix could be to suppress this warning in C99 mode since that's far enough from traditional C. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/tests/usr.bin/xlint/lint1/d_constant_conv2.exp \ src/tests/usr.bin/xlint/lint1/d_type_conv1.exp \ src/tests/usr.bin/xlint/lint1/d_type_conv2.exp \ src/tests/usr.bin/xlint/lint1/d_type_conv3.exp \ src/tests/usr.bin/xlint/lint1/msg_259.c \ src/tests/usr.bin/xlint/lint1/msg_259.exp cvs rdiff -u -r1.5 -r1.6 src/tests/usr.bin/xlint/lint1/d_gcc_extension.exp cvs rdiff -u -r1.77 -r1.78 src/usr.bin/xlint/lint1/err.c cvs rdiff -u -r1.204 -r1.205 src/usr.bin/xlint/lint1/tree.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/usr.bin/xlint/lint1
Module Name:src Committed By: rillig Date: Thu Feb 4 07:39:39 UTC 2021 Modified Files: src/tests/usr.bin/xlint/lint1: msg_259.c Log Message: lint: update message text for 259 in test That's the one place that is not checked for matching the actual message by my usual pre-commit checks. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/tests/usr.bin/xlint/lint1/msg_259.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
