CVS commit: src/sys/arch/aarch64/aarch64

[Nick Hudson]

Module Name:src
Committed By:   skrll
Date:   Sun Dec 20 08:26:33 UTC 2020

Modified Files:
src/sys/arch/aarch64/aarch64: pmap.c

Log Message:
Improve the English in the previous comment fix.


To generate a diff of this commit:
cvs rdiff -u -r1.98 -r1.99 src/sys/arch/aarch64/aarch64/pmap.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/arch/sparc64/dev

[Julian Coleman]

Module Name:src
Committed By:   jdc
Date:   Sun Dec 20 09:08:15 UTC 2020

Modified Files:
src/sys/arch/sparc64/dev: pcf8591_envctrl.c

Log Message:
For the E250:
  set fans to medium speed when attaching and full speed when detaching.
  remove unused PS fan definition.
In general:
  return early from attach if the device isn't present.
  handle errors from sysmon during attach so that detach doesn't crash.
  try to handle errors when acquiring the iic bus during detach.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/arch/sparc64/dev/pcf8591_envctrl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sbin/atactl

[Jared D. McNeill]

Module Name:src
Committed By:   jmcneill
Date:   Sun Dec 20 10:19:30 UTC 2020

Modified Files:
src/sbin/atactl: atactl.c

Log Message:
Managment -> Management


To generate a diff of this commit:
cvs rdiff -u -r1.84 -r1.85 src/sbin/atactl/atactl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/arch/arm/arm32

[Jared D. McNeill]

Module Name:src
Committed By:   jmcneill
Date:   Sun Dec 20 10:34:33 UTC 2020

Modified Files:
src/sys/arch/arm/arm32: bus_dma.c

Log Message:
style fix


To generate a diff of this commit:
cvs rdiff -u -r1.127 -r1.128 src/sys/arch/arm/arm32/bus_dma.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 10:59:22 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): replace freeIt with FStr in EvalUndefined

Previously, the parameter out_freeIt was not guaranteed to be
initialized in every case, at least when looking only at EvalUndefined.
This contradicted the variable name.

Replace the two parameters with a single FStr to ensure that these
variables are always initialized together.


To generate a diff of this commit:
cvs rdiff -u -r1.739 -r1.740 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/uvm

[Nick Hudson]

Module Name:src
Committed By:   skrll
Date:   Sun Dec 20 11:11:34 UTC 2020

Modified Files:
src/sys/uvm: uvm_page.c

Log Message:
Some KNF.  NFC.


To generate a diff of this commit:
cvs rdiff -u -r1.249 -r1.250 src/sys/uvm/uvm_page.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 11:38:51 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): document memory handling in ApplyModifiers


To generate a diff of this commit:
cvs rdiff -u -r1.740 -r1.741 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/arch/sparc64/sparc64

[Palle Lyckegaard]

Module Name:src
Committed By:   palle
Date:   Sun Dec 20 11:58:58 UTC 2020

Modified Files:
src/sys/arch/sparc64/sparc64: locore.s

Log Message:
sun4v: add comment in sun4v_tl1_ptbl_miss code path - no functional change


To generate a diff of this commit:
cvs rdiff -u -r1.423 -r1.424 src/sys/arch/sparc64/sparc64/locore.s

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/arch/mips/mips

[Nick Hudson]

Module Name:src
Committed By:   skrll
Date:   Sun Dec 20 12:27:20 UTC 2020

Modified Files:
src/sys/arch/mips/mips: pmap_machdep.c

Log Message:
Remove old part of comment


To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/sys/arch/mips/mips/pmap_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 12:46:49 UTC 2020

Modified Files:
src/usr.bin/make: cond.c

Log Message:
make(1): clean up memory handling in CondParser_String


To generate a diff of this commit:
cvs rdiff -u -r1.226 -r1.227 src/usr.bin/make/cond.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 12:53:35 UTC 2020

Modified Files:
src/usr.bin/make: nonints.h var.c

Log Message:
make(1): export FStr and MFStr

These types are a replacement for the pattern "var + var_freeIt" that
enforces these two variables to be updated together.


To generate a diff of this commit:
cvs rdiff -u -r1.175 -r1.176 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.741 -r1.742 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 13:03:48 UTC 2020

Modified Files:
src/usr.bin/make: cond.c

Log Message:
make(1): clean up memory handling in CondParser_String


To generate a diff of this commit:
cvs rdiff -u -r1.227 -r1.228 src/usr.bin/make/cond.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 13:38:43 UTC 2020

Modified Files:
src/usr.bin/make: arch.c cond.c nonints.h parse.c suff.c var.c

Log Message:
make(1): return FStr from Var_Parse

This reduces the number of variable declarations at the call sites.


To generate a diff of this commit:
cvs rdiff -u -r1.189 -r1.190 src/usr.bin/make/arch.c
cvs rdiff -u -r1.228 -r1.229 src/usr.bin/make/cond.c
cvs rdiff -u -r1.176 -r1.177 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.503 -r1.504 src/usr.bin/make/parse.c
cvs rdiff -u -r1.331 -r1.332 src/usr.bin/make/suff.c
cvs rdiff -u -r1.742 -r1.743 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 13:46:27 UTC 2020

Modified Files:
src/usr.bin/make: arch.c

Log Message:
make(1): eliminate libName_freeIt from Arch_ParseArchive


To generate a diff of this commit:
cvs rdiff -u -r1.190 -r1.191 src/usr.bin/make/arch.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 13:50:10 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): use FStr in VarNew


To generate a diff of this commit:
cvs rdiff -u -r1.743 -r1.744 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 14:32:14 UTC 2020

Modified Files:
src/usr.bin/make: cond.c main.c meta.c nonints.h parse.c trace.c var.c

Log Message:
make(1): change return type of Var_Value to FStr


To generate a diff of this commit:
cvs rdiff -u -r1.229 -r1.230 src/usr.bin/make/cond.c
cvs rdiff -u -r1.498 -r1.499 src/usr.bin/make/main.c
cvs rdiff -u -r1.160 -r1.161 src/usr.bin/make/meta.c
cvs rdiff -u -r1.177 -r1.178 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.504 -r1.505 src/usr.bin/make/parse.c
cvs rdiff -u -r1.24 -r1.25 src/usr.bin/make/trace.c
cvs rdiff -u -r1.744 -r1.745 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 14:39:46 UTC 2020

Modified Files:
src/usr.bin/make: main.c nonints.h

Log Message:
make(1): remove constant parameter from MakeMode


To generate a diff of this commit:
cvs rdiff -u -r1.499 -r1.500 src/usr.bin/make/main.c
cvs rdiff -u -r1.178 -r1.179 src/usr.bin/make/nonints.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 14:48:35 UTC 2020

Modified Files:
src/usr.bin/make: parse.c

Log Message:
make(1): clean up memory handling in Parse_DoVar


To generate a diff of this commit:
cvs rdiff -u -r1.505 -r1.506 src/usr.bin/make/parse.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 14:52:16 UTC 2020

Modified Files:
src/usr.bin/make: parse.c

Log Message:
make(1): clean up memory handling in VarAssign_EvalShell


To generate a diff of this commit:
cvs rdiff -u -r1.506 -r1.507 src/usr.bin/make/parse.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 15:04:29 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): fix memory leak in Var_Delete (since yesterday)

The memory leak had been introduced in var.c 1.736 from 2020-12-19
20:47:24.


To generate a diff of this commit:
cvs rdiff -u -r1.745 -r1.746 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 15:26:40 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): extract SetVar from Var_SetWithFlags

SetVar contains the part that is not concerned about memory management
and expansion of the variable name.


To generate a diff of this commit:
cvs rdiff -u -r1.746 -r1.747 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 15:31:29 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): use FStr for memory management in Var_SetWithFlags


To generate a diff of this commit:
cvs rdiff -u -r1.747 -r1.748 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/uvm

[Nick Hudson]

Module Name:src
Committed By:   skrll
Date:   Sun Dec 20 15:50:44 UTC 2020

Modified Files:
src/sys/uvm: uvm_page.h

Log Message:
Remove VM_MD_TO_PAGE that was accidentally committed in 1.106.  It's going
to be readded with the code that uses it


To generate a diff of this commit:
cvs rdiff -u -r1.107 -r1.108 src/sys/uvm/uvm_page.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/arch/mips/mips

[Nick Hudson]

Module Name:src
Committed By:   skrll
Date:   Sun Dec 20 15:59:28 UTC 2020

Modified Files:
src/sys/arch/mips/mips: pmap_machdep.c

Log Message:
Remove bogus KASSERT - can't assert a spin mutex is !mutex_owned.


To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/sys/arch/mips/mips/pmap_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys

[Nick Hudson]

Module Name:src
Committed By:   skrll
Date:   Sun Dec 20 16:38:26 UTC 2020

Modified Files:
src/sys/arch/m68k/include: pmap_coldfire.h
src/sys/arch/mips/include: pmap.h
src/sys/arch/mips/mips: pmap_machdep.c
src/sys/arch/powerpc/booke: booke_pmap.c
src/sys/arch/powerpc/include/booke: pmap.h
src/sys/arch/riscv/include: pmap.h
src/sys/arch/riscv/riscv: trap.c
src/sys/uvm: uvm_page.h
src/sys/uvm/pmap: pmap.c pmap.h vmpagemd.h

Log Message:
Support __HAVE_PMAP_PV_TRACK in sys/uvm/pmap based pmaps (aka common pmap)


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/arch/m68k/include/pmap_coldfire.h
cvs rdiff -u -r1.74 -r1.75 src/sys/arch/mips/include/pmap.h
cvs rdiff -u -r1.32 -r1.33 src/sys/arch/mips/mips/pmap_machdep.c
cvs rdiff -u -r1.29 -r1.30 src/sys/arch/powerpc/booke/booke_pmap.c
cvs rdiff -u -r1.23 -r1.24 src/sys/arch/powerpc/include/booke/pmap.h
cvs rdiff -u -r1.7 -r1.8 src/sys/arch/riscv/include/pmap.h
cvs rdiff -u -r1.14 -r1.15 src/sys/arch/riscv/riscv/trap.c
cvs rdiff -u -r1.108 -r1.109 src/sys/uvm/uvm_page.h
cvs rdiff -u -r1.57 -r1.58 src/sys/uvm/pmap/pmap.c
cvs rdiff -u -r1.17 -r1.18 src/sys/uvm/pmap/pmap.h
cvs rdiff -u -r1.16 -r1.17 src/sys/uvm/pmap/vmpagemd.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 17:22:11 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): turn ApplyModifiersState.val into a local variable

This reduces the scope and makes it more obvious at which places this
variable can be changed and how the memory management is done.


To generate a diff of this commit:
cvs rdiff -u -r1.748 -r1.749 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 18:13:50 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): extract ApplySingleModifier from ApplyModifiers


To generate a diff of this commit:
cvs rdiff -u -r1.749 -r1.750 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 18:23:24 UTC 2020

Modified Files:
src/usr.bin/make: parse.c var.c

Log Message:
make(1): remove redundant const declarations for parameters


To generate a diff of this commit:
cvs rdiff -u -r1.507 -r1.508 src/usr.bin/make/parse.c
cvs rdiff -u -r1.750 -r1.751 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 19:02:28 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): document that indirect modifiers fall back to SysV modifiers


To generate a diff of this commit:
cvs rdiff -u -r1.751 -r1.752 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 19:10:54 UTC 2020

Modified Files:
src/usr.bin/make: var.c
src/usr.bin/make/unit-tests: opt-debug-lint.exp opt-debug-lint.mk

Log Message:
make(1): remove wrong error message for indirect modifier in lint mode


To generate a diff of this commit:
cvs rdiff -u -r1.752 -r1.753 src/usr.bin/make/var.c
cvs rdiff -u -r1.11 -r1.12 src/usr.bin/make/unit-tests/opt-debug-lint.exp \
src/usr.bin/make/unit-tests/opt-debug-lint.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make/unit-tests

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 19:29:06 UTC 2020

Modified Files:
src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk varmod-indirect.exp
varmod-indirect.mk

Log Message:
make(1): move tests for indirect modifiers around

The next commit will error out on unknown modifiers and influence the
exit status.  The test modmisc.mk contains both parse time tests and run
time tests.  To prevent the latter from being run, the parse error is
moved to varmod-indirect.mk, which only contains parse time tests.


To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47 src/usr.bin/make/unit-tests/modmisc.exp
cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/unit-tests/modmisc.mk
cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/varmod-indirect.exp \
src/usr.bin/make/unit-tests/varmod-indirect.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/dev/pci

[Jaromir Dolecek]

Module Name:src
Committed By:   jdolecek
Date:   Sun Dec 20 19:30:04 UTC 2020

Modified Files:
src/sys/dev/pci: aceride.c

Log Message:
disable (U)DMA for ATAPI on aceride(4), the chip doesn't support it
PR port-sparc64/55540


To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/dev/pci/aceride.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make/unit-tests

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 19:37:23 UTC 2020

Modified Files:
src/usr.bin/make/unit-tests: Makefile varmod-edge.exp

Log Message:
make(1): include line numbers in output of test varmod-edge.mk

Suppressing the line numbers does not provide much benefit, given that
the test file doesn't change often.


To generate a diff of this commit:
cvs rdiff -u -r1.252 -r1.253 src/usr.bin/make/unit-tests/Makefile
cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/unit-tests/varmod-edge.exp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 19:47:34 UTC 2020

Modified Files:
src/usr.bin/make: var.c
src/usr.bin/make/unit-tests: cond-token-string.exp opt-debug-lint.exp
vardebug.exp varmod-edge.exp varmod-indirect.exp varmod-range.exp
varparse-errors.exp varparse-errors.mk

Log Message:
make(1): error out on unknown variable modifiers at parse time

Before, make printed an "error message" that did not include the word
error and thus was not easily identified as such.  This "error message"
also did not influence the exit status in the default mode but only in
-dL mode.  The error message also didn't include any line number
information and was thus rude.


To generate a diff of this commit:
cvs rdiff -u -r1.753 -r1.754 src/usr.bin/make/var.c
cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit-tests/cond-token-string.exp
cvs rdiff -u -r1.12 -r1.13 src/usr.bin/make/unit-tests/opt-debug-lint.exp
cvs rdiff -u -r1.13 -r1.14 src/usr.bin/make/unit-tests/vardebug.exp
cvs rdiff -u -r1.9 -r1.10 src/usr.bin/make/unit-tests/varmod-edge.exp
cvs rdiff -u -r1.2 -r1.3 src/usr.bin/make/unit-tests/varmod-indirect.exp \
src/usr.bin/make/unit-tests/varparse-errors.exp \
src/usr.bin/make/unit-tests/varparse-errors.mk
cvs rdiff -u -r1.5 -r1.6 src/usr.bin/make/unit-tests/varmod-range.exp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 19:51:38 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): remove redundant assignment in ApplyModifier_SysV


To generate a diff of this commit:
cvs rdiff -u -r1.754 -r1.755 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 21:07:32 UTC 2020

Modified Files:
src/usr.bin/make: compat.c job.c nonints.h

Log Message:
make(1): omit linear search for command in Compat_RunCommand


To generate a diff of this commit:
cvs rdiff -u -r1.215 -r1.216 src/usr.bin/make/compat.c
cvs rdiff -u -r1.388 -r1.389 src/usr.bin/make/job.c
cvs rdiff -u -r1.179 -r1.180 src/usr.bin/make/nonints.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/etc

[Valeriy E. Ushakov]

Module Name:src
Committed By:   uwe
Date:   Sun Dec 20 21:30:28 UTC 2020

Modified Files:
src/etc: rc.subr

Log Message:
run_rc_command - don't prefix the rcvar variable name with the dollar sign.

The output without the dollar sign is less confusing as it's actual
valid shell syntax:

  $ /etc/rc.d/foo rcvar
  # food
  food=YES

Brought up on tech-userlevel@ by Rocky Hotas with some LGTMs from
other people and no objections.

We still refer to '$food' in warnings/errors though.


To generate a diff of this commit:
cvs rdiff -u -r1.105 -r1.106 src/etc/rc.subr

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 22:02:54 UTC 2020

Modified Files:
src/usr.bin/make: meta.c

Log Message:
make(1): fix declared variable type in printCMDs

No functional changes since StringListNode and GNodeListNode are both
typedefs of a simple generic ListNode.


To generate a diff of this commit:
cvs rdiff -u -r1.161 -r1.162 src/usr.bin/make/meta.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 22:12:36 UTC 2020

Modified Files:
src/usr.bin/make: meta.c

Log Message:
make(1): reduce scope of cp in meta_oodate

That function is way too long (550 lines) and has too creative variable
names such as fname, fname1, fname2, fname3.


To generate a diff of this commit:
cvs rdiff -u -r1.162 -r1.163 src/usr.bin/make/meta.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 22:36:40 UTC 2020

Modified Files:
src/usr.bin/make: meta.c

Log Message:
make(1): fix undefined behavior in meta_oodate

Do not increment a null pointer.

Do not assign to a variable twice in the same statement.  To be fair,
this may be safe because of the sequence point when the function is
called, but anyway, it looks too close to undefined behavior.


To generate a diff of this commit:
cvs rdiff -u -r1.163 -r1.164 src/usr.bin/make/meta.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make/unit-tests

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 22:57:40 UTC 2020

Modified Files:
src/usr.bin/make/unit-tests: varmod-extension.exp varmod-extension.mk
varmod-head.exp varmod-head.mk varmod-root.exp varmod-root.mk
varmod-tail.exp varmod-tail.mk

Log Message:
make(1): add tests for variable modifiers on trailing slashes


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/usr.bin/make/unit-tests/varmod-extension.exp \
src/usr.bin/make/unit-tests/varmod-head.exp \
src/usr.bin/make/unit-tests/varmod-root.exp \
src/usr.bin/make/unit-tests/varmod-tail.exp
cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit-tests/varmod-extension.mk \
src/usr.bin/make/unit-tests/varmod-head.mk \
src/usr.bin/make/unit-tests/varmod-root.mk \
src/usr.bin/make/unit-tests/varmod-tail.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 23:27:37 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): use FStr for ApplyModifiersState.newVal

Memory management is still complicated in this area.  To clean this up,
the previous value of the expression needs to be converted to an MFStr
first, and later to an FStr.


To generate a diff of this commit:
cvs rdiff -u -r1.755 -r1.756 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make/unit-tests

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Sun Dec 20 23:29:50 UTC 2020

Modified Files:
src/usr.bin/make/unit-tests: varmod-to-many-words.mk
varmod-to-one-word.mk

Log Message:
make(1): add tests for :tW and :tw modifiers


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/usr.bin/make/unit-tests/varmod-to-many-words.mk \
src/usr.bin/make/unit-tests/varmod-to-one-word.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Mon Dec 21 00:11:29 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): clean up memory management for expanding variable expressions

Previously, memory management had been split among several variables.
The general idea was very simple though.  The current value of the
expression needs to be kept in memory, and each modifier either keeps
that value or replaces it with its own newly allocated result, or
var_Error or varUndefined.

Using MFStr, it does not matter anymore that var_Error and varUndefined
are statically allocated since these are assigned using MFStr_InitRefer.

The complexity of the implementation is now closer to the actual
complexity.  Most probably the code can be simplified even more.


To generate a diff of this commit:
cvs rdiff -u -r1.756 -r1.757 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Mon Dec 21 00:20:58 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): switch memory handling from MFStr to FStr

This makes all intermediate strings constant.  For this simple
search-and-replace refactoring, all intermediate locations where the
"current value of the expression" was stored had to be of the type
MFStr.

Using FStr instead of MFStr allows to save a few memory allocations,
which will be done in the follow-up commits.


To generate a diff of this commit:
cvs rdiff -u -r1.757 -r1.758 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Mon Dec 21 00:30:13 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): save a few memory allocations in variable expressions


To generate a diff of this commit:
cvs rdiff -u -r1.758 -r1.759 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Mon Dec 21 02:09:34 UTC 2020

Modified Files:
src/usr.bin/make: parse.c

Log Message:
make(1): fix garbled output for failed shell command (since 2020-12-20)

Passing a struct as printf argument for the %s conversion doesn't work.
On NetBSD-8.0-x86_64, the output looks normal, but on SunOS-5.9, the
output is garbled, containing bytes 0xFF and 0xFE.

This bug had been introduced in parse.c 1.507 from 2020-12-20 14:52:16.

Thanks to sjg for finding this bug so quickly.


To generate a diff of this commit:
cvs rdiff -u -r1.508 -r1.509 src/usr.bin/make/parse.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/usr.bin/make

[Roland Illig]

Module Name:src
Committed By:   rillig
Date:   Mon Dec 21 02:38:57 UTC 2020

Modified Files:
src/usr.bin/make: var.c

Log Message:
make(1): remove redundant parameters from ParseModifierPart


To generate a diff of this commit:
cvs rdiff -u -r1.759 -r1.760 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.