Re: [sage-devel] Proposal: Policy for standard packages from binary wheels
On Sat, Aug 03, 2024 at 11:15:13PM -0700, Matthias Koeppe wrote: > Currently all "standard" packages of the Sage distribution, by policy > (https://doc.sagemath.org/html/en/developer/packaging.html; recommended > reading), > - either can be installed from source ("normal" packages); > - or they are Python packages that can be installed from > platform-independent wheels. > > (We added the second option in order to treat Javascript assets as prebuilt > data, thus avoiding the complexity of Javascript build infrastructure in > the Sage distribution.) > > In https://github.com/sagemath/sage/pull/38219 (needs review), I propose > the following mild policy change: > - as a third option, a "standard" package is allowed to be a Python package > that can be installed from platform-dependent (binary) wheels. In this > case, a "configure" option must be provided that disables the package. pip packages? Confused... -- An old man doll... just what I always wanted! - Clara -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ZrAcNRhsMZ8aBXSN%40archie.me.
Re: [sage-devel] Proposal: Policy for standard packages from binary wheels
On Mon, Aug 05, 2024 at 08:28:12PM +0300, Georgi Guninski wrote: > On Sun, Aug 4, 2024 at 9:03 PM Matthias Koeppe > wrote: > > > > > In https://github.com/sagemath/sage/pull/38219 (needs review), I propose > > the following mild policy change: > > - as a third option, a "standard" package is allowed to be a Python package > > that can be installed from platform-dependent (binary) wheels. In this > > case, a "configure" option must be provided that disables the package. > > > > (Again this new option is motivated by avoiding the complexity of new build > > infrastructure related to another language; in this case, Rust. See the PR > > for two example Rust-based example packages; previous discussion: > > https://groups.google.com/g/sage-devel/c/JiSryImYGe0/m/4B8z6F4AEwAJ) > > > > I would recommend running antivirus just before `make install` and > commercial supply chain backdoor scanner. Especially if there is no > way to verify the integrity. In Windows, that's quite common for people to have antivirus installed. But for people on Linux, they usually don't install one. -- An old man doll... just what I always wanted! - Clara -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ZrK0q7peEW26uIGx%40archie.me.
Re: [sage-devel] Re: Synchronization of GitHub state and priority labels continues on Tuesday July 11th
On 8/6/24 20:42, Kwankyu Lee wrote: On Tuesday, August 6, 2024 at 3:30:29 PM UTC+9 seb@gmail.com wrote: This would replace something annoying for senior developers by something annoying for new contributors. I'm not sure if this is a good idea. Naturally, the volume of annoyance is much larger for senior developers. Did you have to manually resolve merge conflicts in your example? If not, just don't push it back to the repository in such a situation in the future. If so, I agree with Tobias that *needs review* is a correct status. Not for my example, but I observed in others that trivial merge conflicts resolution put the PR back to "needs review" status. Force-pushing will too. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/2f0646a3-e057-4bd5-b5cc-de39b1f7612a%40gmail.com.
[sage-devel] Need assistance on PR #38434 (finding suitesparse)
Hi Matthias, I opened PR #38434 around two weeks ago (https://github.com/sagemath/sage/pull/38434) where I fix contourpy and cvxopt build failures. For the latter, I approached the problem by using `pkg-config` to find suitesparse headers (required by cvxopt's umfpack extension). The PR got no further replies after I force-pushed. So I had to run actions workflow manually and indeed, I can still reproduce the build problem on ubuntu jammy (https://github.com/bagasme/sage/actions/runs/10224751766/job/28292898635): ``` #31 898.6 [cvxopt-1.3.2] [spkg-install] running build_ext #31 898.6 [cvxopt-1.3.2] [spkg-install] INFO: Disabling color, you really want to install colorlog. #31 898.6 [cvxopt-1.3.2] [spkg-install] Disabling color, you really want to install colorlog. #31 898.6 [cvxopt-1.3.2] [spkg-install] building 'umfpack' extension #31 898.6 [cvxopt-1.3.2] [spkg-install] gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -O2 -fPIC -I -I/sage/local/var/lib/sage/venv-python3.10/include -I/usr/include/python3.10 -c src/C/umfpack.c -o build/temp.linux-x86_64-cpython-310/src/C/umfpack.o #31 898.6 [cvxopt-1.3.2] [spkg-install] src/C/umfpack.c:23:10: fatal error: umfpack.h: No such file or directory #31 898.6 [cvxopt-1.3.2] [spkg-install]23 | #include "umfpack.h" #31 898.6 [cvxopt-1.3.2] [spkg-install] | ^~~ #31 898.6 [cvxopt-1.3.2] [spkg-install] compilation terminated. #31 898.6 [cvxopt-1.3.2] [spkg-install] error: command '/usr/bin/gcc' failed with exit code 1 ... ``` Am I missing something? And should I submit new PR instead of force-pushing in this case? Thanks. -- An old man doll... just what I always wanted! - Clara -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ZrRxQOFcQX84MZQG%40archie.me.
Re: [sage-devel] Mail etiquette: please don't quote all of the email you reply to unless needed
On 9/4/24 17:46, Georgi Guninski wrote: I observe that a lot of users quote **everything** when replying. In plaintext the email looks like: TOP POST X_1 wrote X_2 wrote X_3 wrote X_n wrote This wastes space and I believe is considered bad email etiquette. In some desktop GUI mail user agents or web Gmail, an easy way to delete all of the quoted text is . Better yet: interleaved reply trimming unneeded context like: > X_1 wrote >> some required context > Lorem ipsum dolor sit amet, consectetur adipiscing elit. >> some other required context Thanks. -- An old man doll... just what I always wanted! - Clara -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/948ecb8f-fdbc-4e45-a99b-cb62446f5b4f%40gmail.com.