[sage-devel] Re: Enabling Merge Requests from GitLab
Simon, a very quick correspondence between trac and github/lab terms is as follows: trac ticket, no git branch - issue trac ticket, with a git branch - pull (merge, on gitlab) request github has a command line tool, called hub, allowing one to e.g. create pull requests and issues, without using a browser. https://hub.github.com/hub-pull-request.1.html https://hub.github.com/hub-issue.1.html I don't know whether gitlab has something akin to hub. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
Re: [sage-devel] Re: Enabling Merge Requests from GitLab
On 08/23/2018 11:15 AM, Dima Pasechnik wrote: > github has a command line tool, called hub, allowing one to e.g. create pull > requests and issues, without using a browser. > https://hub.github.com/hub-pull-request.1.html > https://hub.github.com/hub-issue.1.html > > I don't know whether gitlab has something akin to hub. FWIW Gitlab has an API which allows doing stuff via e.g. a Python library; this is quite convenient for doing batch-jobs etc. [1] https://docs.gitlab.com/ee/api/ [2] https://github.com/python-gitlab/python-gitlab -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
Re: [sage-devel] Workflows on GitLab
On Thu, Aug 23, 2018 at 6:13 AM Julian Rüth wrote: > > Hello Jeroen, > > I agree that fragmentation can be a problem. Then again, I think that > sometimes splitting discussion on the issue and the discussion on an actual > attempt to solve that issue can be useful; at least it doesn't feel unnatural > to me. Also being able to create a new merge request can be nice if you > actually want to start from scratch. But sure, what you described is much > more common: I would add that in practice I've rarely found this to be too much of a problem. For most issues you will have at most one pull request; maybe two. And discussions on pull requests tend to remain focused on the substance of the code changes, than the substance of the issue itself (except in the case where an issue is raised *and* a fix is proposed simultaneously in a pull request--this can happen frequently which is why I don't like the forced "issue" vs "pull request" distinction). In this case the solution is usually to just open another pull request, if you have an alternative proposal. I think it rarely leads to an overly difficult to follow discussion. Not saying it doesn't happen though. > On Wednesday, August 22, 2018 at 9:24:36 PM UTC+2, Jeroen Demeyer wrote: >> >> [...] Something that regularly happens on the Sage Trac: >> >> 1. Somebody creates an issue >> 2. Somebody (the same or other person) adds a branch >> 3. Somebody else forks that branch and adds a reviewer patch >> >> In the GitHub model, you now have 1 issue and 2 pull requests for >> exactly the same issue. Even if cross-links are added, you still end up >> with spaghetti discussions. > > > In most projects, the reviewers are the people who actually have the power to > merge and so GitHub/GitLab want you to check "allow edit from maintainers" > when creating a Pull/Merge Request to allow reviewer patches. But that won't > work for Sage's development model. One way around this would be to encourage > creation of Merge Requests from a shared namespace such as > https://gitlab.com/sagemath/dev/sage where everybody developing Sage would > have push access. This would be somewhat similar to the current public > namespace in the git repository that is connected to trac. That's a good point, and a use case for that I hadn't considered. Anyone on the sage-devel team can be given write access to sagemath/dev/sage and can create branches there to make merge requests from, rather than from a private fork. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
Re: [sage-devel] Workflows on GitLab
On Thu, Aug 23, 2018 at 8:51 AM Dima Pasechnik wrote: > > > > On Thursday, August 23, 2018 at 7:13:32 AM UTC+3, Julian Rüth wrote: >> >> Hello Jeroen, >> >> I agree that fragmentation can be a problem. Then again, I think that >> sometimes splitting discussion on the issue and the discussion on an actual >> attempt to solve that issue can be useful; at least it doesn't feel >> unnatural to me. Also being able to create a new merge request can be nice >> if you actually want to start from scratch. But sure, what you described is >> much more common: >> >> On Wednesday, August 22, 2018 at 9:24:36 PM UTC+2, Jeroen Demeyer wrote: >>> >>> [...] Something that regularly happens on the Sage Trac: >>> >>> 1. Somebody creates an issue >>> 2. Somebody (the same or other person) adds a branch >>> 3. Somebody else forks that branch and adds a reviewer patch >>> >>> In the GitHub model, you now have 1 issue and 2 pull requests for >>> exactly the same issue. Even if cross-links are added, you still end up >>> with spaghetti discussions. >> >> >> In most projects, the reviewers are the people who actually have the power >> to merge and so GitHub/GitLab want you to check "allow edit from >> maintainers" when creating a Pull/Merge Request to allow reviewer patches. >> But that won't work for Sage's development model. One way around this would >> be to encourage creation of Merge Requests from a shared namespace such as >> https://gitlab.com/sagemath/dev/sage where everybody developing Sage would >> have push access. This would be somewhat similar to the current public >> namespace in the git repository that is connected to trac. > > > it would suffice to allow the reviewer to push into the ticket's author fork, > no need for a global shared git namespace/repo (the latter is causing bad > performance, as it grows fast and people tend not to clean after themselves). > Perhaps it's even easier to set up correct access to forks using "teams". I think GitLab will make it a little bit easier for people to clean up after themselves. Like on GitHub, when a merge request is merged there is a big button to delete the source branch. We should encourage people to push it unless they have some pressing reason not to. I usually push it instinctively. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
Re: [sage-devel] Re: Enabling Merge Requests from GitLab
On Wed, Aug 22, 2018 at 10:25 PM Simon King wrote: > > Hi Erik, > > On 2018-08-22, Erik Bray wrote: > > Really the workflow is meant to be you create an issue first, and then > > you create one or more pull requests to resolve that issue. I am also > > a fan of being able to "elevate" an issue to a pull request. This is > > possible to do on GitHub through the web API and I have a script I use > > for it, but they're trying to discourage that, and I think even > > deprecate the ability to do so. I'm mystified as to why. > > I'd need A LOT more explanations. > > What is an "issue"? > What is a "pull request"? > > What exactly is the expected workflow on gitlab? Right now there isn't one. That's mostly outside the scope of this discussion because right now we are not enabling issue creation on GitLab. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
[sage-devel] update installation guide - macOS user required
Dear all, At [#25595] we did update the outdated information of our installation guide. Though neither me nor the reviewer has access to a macOS and we would be happy to hear comment about whether the macOS app script has been broken (I did modify the Makefile to generate the app), what are the various ways to install stuff on mac, etc... [#25595] https://trac.sagemath.org/ticket/25995 Best Vincent -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
[sage-devel] recommendation: delete local/share/mathjax/mathjax, run make doc-clean, then make
I found that my Sage documentation directory was taking up 15GB of hard drive space, because of a bug (which I think has been fixed, but I don't remember where). The bug was caused by a recursive symlink local/share/mathjax/mathjax -> local/share/mathjax When the contents of local/share/mathjax were copied to various _static directories in the html documentation, rather than just reproducing the symlink, it created many layers of subdirectories; for example, ca/intro/_static/mathjax/mathjax/mathjax/... Basically mathjax all the way down. I don't know if this happened all at once, or once each time I built the documentation. To see if you have this problem, see if you have the symlink. You might also find out how much disk space local/share/doc/sage takes up (for example, "du -s -h /path/to/SAGE_ROOT/local/share/doc/sage"). On my computer, it is 1.9GB. If you are using up a lot more space than that, you might have hit this bug. To fix: remove the symlink SAGE_ROOT/local/share/mathjax/mathjax. Then run "make doc-clean" to remove the old documentation, and then run "make" to rebuild the documentation. Question: - has the bug been fixed, or is that symlink still being created? -- John -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
[sage-devel] Re: recommendation: delete local/share/mathjax/mathjax, run make doc-clean, then make
Running the du command (which took quite a bit of time to run), mine was 21GB. That might have been why the docbuild for me was hanging after it had finished tutorial... Trying now. Best, Travis On Friday, August 24, 2018 at 6:13:11 AM UTC+10, John H Palmieri wrote: > > I found that my Sage documentation directory was taking up 15GB of hard > drive space, because of a bug (which I think has been fixed, but I don't > remember where). The bug was caused by a recursive symlink > > local/share/mathjax/mathjax -> local/share/mathjax > > When the contents of local/share/mathjax were copied to various _static > directories in the html documentation, rather than just reproducing the > symlink, it created many layers of subdirectories; for example, > ca/intro/_static/mathjax/mathjax/mathjax/... Basically mathjax all the way > down. I don't know if this happened all at once, or once each time I built > the documentation. > > To see if you have this problem, see if you have the symlink. You might > also find out how much disk space local/share/doc/sage takes up (for > example, "du -s -h /path/to/SAGE_ROOT/local/share/doc/sage"). On my > computer, it is 1.9GB. If you are using up a lot more space than that, you > might have hit this bug. > > To fix: remove the symlink SAGE_ROOT/local/share/mathjax/mathjax. Then run > "make doc-clean" to remove the old documentation, and then run "make" to > rebuild the documentation. > > Question: > > - has the bug been fixed, or is that symlink still being created? > > -- > John > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
[sage-devel] Re: recommendation: delete local/share/mathjax/mathjax, run make doc-clean, then make
> Running the du command (which took quite a bit of time to run), mine was > 21GB. That might have been why the docbuild for me was hanging after it had > finished tutorial... Trying now. > Yep, that seems to have done the trick. Best, Travis -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
[sage-devel] Re: recommendation: delete local/share/mathjax/mathjax, run make doc-clean, then make
Yeah, I also got hit by this, gigabytes of extra stuff :-( The symlink comes from sagenb/spkg-install, see https://trac.sagemath.org/ticket/18011 Some symlinking is still happening on 8.4.beta1, see $ git show 32f5bbeac80 commit 32f5bbeac804b37776007407eb00b8acd39559e7 Author: Erik M. Bray Date: Wed May 16 09:52:27 2018 + try installing the symlink anyways and don't poke around SAGE_LOCAL On Thursday, August 23, 2018 at 11:13:11 PM UTC+3, John H Palmieri wrote: > > I found that my Sage documentation directory was taking up 15GB of hard > drive space, because of a bug (which I think has been fixed, but I don't > remember where). The bug was caused by a recursive symlink > > local/share/mathjax/mathjax -> local/share/mathjax > > When the contents of local/share/mathjax were copied to various _static > directories in the html documentation, rather than just reproducing the > symlink, it created many layers of subdirectories; for example, > ca/intro/_static/mathjax/mathjax/mathjax/... Basically mathjax all the way > down. I don't know if this happened all at once, or once each time I built > the documentation. > > To see if you have this problem, see if you have the symlink. You might > also find out how much disk space local/share/doc/sage takes up (for > example, "du -s -h /path/to/SAGE_ROOT/local/share/doc/sage"). On my > computer, it is 1.9GB. If you are using up a lot more space than that, you > might have hit this bug. > > To fix: remove the symlink SAGE_ROOT/local/share/mathjax/mathjax. Then run > "make doc-clean" to remove the old documentation, and then run "make" to > rebuild the documentation. > > Question: > > - has the bug been fixed, or is that symlink still being created? > > -- > John > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
