Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> +packages can be queried or installed from the internet. Package files for
+install, upgrade, and query operations may be specified as an *ftp* or *http*
+style URL:
+
+_http://HOST[:PORT]/path/to/package.rpm_
+
+_ftp://[USER:PASSWORD]@HOST[:PORT]/path/to/package.rpm_
+
+If both the user and password are omitted, anonymous *ftp* is used.
+
+*rpm* allows the following options to be used with ftp URLs:
+
+*rpm* allows the following options to be used with *http* and *ftp* URLs:
+
+*--httpproxy* _HOST_
+   The host _HOST_ will be used as a proxy server for all *http* and

Indeed, and this is another thing to note in the Typographic conventions in the 
template, e.g.
```
- Use imperative style when describing functionality (if possible)
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005869991
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -72,15 +79,15 @@ See *rpm.common*(8) for the options common to all *rpm* 
> executables.
 *--do-this*
Do Y instead of default action.
 
-*-o* _ARG_,
-*--output*=_ARG_
+*-o* _FILE_,
+*--output*=_FILE_
Use file _ARG_ for output.

(One of those cases where just pushing a fixup! is easier than comment & 
explain, but meh) :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005431772
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
pmatilai left a comment (rpm-software-management/rpm#3659)

Converting to a draft until I double-check against the actually accepted 
version of template, but otherwise feel free to review already.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#issuecomment-2740196984
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> + proxy http server instead of the default port. This option may also
+   be specified by configuring the macro *%\_httpport*.
+
+# ENVIRONMENT
+*RPM_CONFIGDIR*
+   Used to override the default *rpm* configuration home,
+   typically _/usr/lib/rpm_.
+
+# EXIT STATUS
+On success, 0 is returned, a non-zero failure code otherwise.
+
+# FILES
+
+## rpmrc Configuration
+
+Each file in the colon separated rpmrc path is read sequentially by

Ack, works for me :+1: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005886791
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] check-rpaths-worker should handle ELF files that have both RPATH and RUNPATH (Issue #3667)

2025-03-20 Thread Thomas Fitzsimmons
fitzsim left a comment (rpm-software-management/rpm#3667)

> > I did create a minimal standlone library that replicates the issue using 
> > GCC, binutils, and the Common Lisp elf system, which I can provide steps 
> > for if necessary.
> 
> Please do. Without a reproducer it's hard for us to do much about it.

To replicate the issue:

```shell
wget 
https://github.com/fitzsim/add-runpath-to-rpath-elf/raw/refs/heads/main/libboth-rpath-and-runpath.so
/usr/lib/rpm/check-rpaths-worker libboth-rpath-and-runpath.so 
```

See the [reproducer 
repository](https://github.com/fitzsim/add-runpath-to-rpath-elf) for more 
detail.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3667#issuecomment-2740837068
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> -
-*-v*, *--verbose*
-   Print verbose information - normally routine progress messages will
-   be displayed.
-
-*-vv*
-   Print lots of ugly debugging information.
-
-*--rcfile* _FILELIST_
-   Replace the default list of configuration files to be read with
-   _FILELIST_.  See *rpmrc Configuration* for details.
-
-*--load* _FILE_
-   Load an individual macro file.
+# OPERATIONS
+*-e*,

At the risk of sounding nitpicky, how about listing these operations in the 
order that they're listed in SYNOPSIS? E.g. erasing surely isn't the most 
interesting operation :laughing:

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#pullrequestreview-2703183720
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> +RPM-COMMON(8)
+
+# NAME
+rpm-common - operations and options common to the main *rpm*(8) executables
+
+# SYNOPSIS
+_RPMCMD_ [options] {*-?*|*--help*}
+
+_RPMCMD_ [options] *--showrc*
+
+_RPMCMD_ [options] *--version*
+
+# DESCRIPTION
+The following *rpm* executables share common configuration and the
+options and operations documented in this manual:
+- *rpm*(8)

Oh, yup. Either way works for me :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005874868
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -24,9 +24,13 @@ Typographic conventions:
 - Use hard wrapping at 80 columns for all text
 - Use bold for literal values such as command name and options:
 *cmd* does X, with option *--do-this* does Y instead
-- Use bold when referring to section names
+- Use bold *UPPERCASE* for first level sections, and *Mixed case*

Yep that got a bit mixed up while editing: hopefully clarified now:

- Use UPPERCASE for first level sections, and Mixed case for second level 
sections (if present)
- Use matching case and bold when referring to section names

So the first bullet is for sections in general, the second is for references to 
them.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005453974
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
Merged #3639 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#event-16907482603
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -12,6 +12,6 @@ There are two separate sets of documents here:
 * [RPM's Reference Manual](manual/index.md)
 
 The API documention is also build here. But if you see this it is probably not 
built yet. 
-If it is built (in-tree) it can be found [here](librpm/html/index.html).
+If it is built (in-tree) it can be found [here](html/index.html).

> Nah, the api docs aren't rendered to the same style at all so I think it 
> doesn't matter.

Indeed, that's kinda what I was thinking, too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005251645
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
dmnks left a comment (rpm-software-management/rpm#3639)

/me scrolls up

OK, I think we're good now :tada: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#issuecomment-2740185569
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai pushed 1 commit.

521d1c974fdd1ea212b1930f84c8d1dd336d9589  fixup! Add a template man page with 
style guidance

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639/files/7ee787c87d55e553ed182a88abb77b6524aae47c..521d1c974fdd1ea212b1930f84c8d1dd336d9589
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -72,15 +79,15 @@ See *rpm.common*(8) for the options common to all *rpm* 
> executables.
 *--do-this*
Do Y instead of default action.
 
-*-o* _ARG_,
-*--output*=_ARG_
+*-o* _FILE_,
+*--output*=_FILE_
Use file _ARG_ for output.

ARGh :facepalm: Yep, fixed :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005450999
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -124,10 +131,18 @@ On success, 0 is returned, a non-zero failure code 
> otherwise.
 
 # EXAMPLES
 Add at least one example for each major functionality of the command.
-
-```
-rpmcmd --do-this package-1.0-1.noarch.rpm
-```
+Command first in bold, then description, similar to option descriptions.
+If command output is included in the description, use indented literal block.

Oh, right, those. Well, lets worry about it when we cross that bridge, it's a 
minor detail in the end.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005449900
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai pushed 1 commit.

8a9eb30bb15a08154c51c6cd0f58113a3c2f7a63  Add a template man page with style 
guidance

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639/files/521d1c974fdd1ea212b1930f84c8d1dd336d9589..8a9eb30bb15a08154c51c6cd0f58113a3c2f7a63
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
dmnks left a comment (rpm-software-management/rpm#3639)

Lol, okay then, will let you do that :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#issuecomment-2740188452
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
pmatilai left a comment (rpm-software-management/rpm#3639)

Okay, I'll smash the fixups together and do one more push :+1: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#issuecomment-2740187709
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> +```
+
+# CONFIGURATION
+List main configurables affecting this program here, but don't describe.
+See *rpm.config*(5) for details:
+- *%\_bar_mode*
+- *%\_foo_mode*
+
+# ENVIRONMENT
+Describe environment variables affecting program execution.
+
+# EXIT STATUS
+On success, 0 is returned, a non-zero failure code otherwise.
+
+# EXAMPLES
+Add at least one example for each major functionality of the command.

Is it, though? There's only the example now, no description. Or do you mean the 
introductory sentence?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005045917
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> +Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+*-d*
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_
+   Use file _ARG_ for output.
+
+*--format*=<*aa*|*bb*>
+   Use format *aa* or *bb* for output.
+
+*--compress*=<_method_>

Oh, in that case, I'd vote for `<*foo*|*bar*|*meh*>`, too. Once we're using the 
`<>` style, might as well indeed enumerate the options if they're just a 
couple. It also saves us one line from the description since you don't have to 
mention the possible values explicitly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005041474
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> +Use {} for the operation switches:
+
+*rpmcmd* {*-b*|*--bardize*} [options] [bardize-options] [_ARGUMENT_] ...
+
+*rpmcmd* {*-f*|*--frobnize*} [options] [_ARGUMENT_] ...
+
+# DESCRIPTION
+Describe what *rpmcmd* command does in plain, understandable
+English. Command-line switches belong to *OPTIONS* and *OPERATIONS*
+as appropriate.
+
+Typographic conventions:
+- Use hard wrapping at 80 columns for all text
+- Use bold for literal values such as command name and options:
+*cmd* does X, with option *--do-this* does Y instead
+- Use bold when referring to section names

Oh, indeed, good point. Yep, using matching case is nice.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005047068
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Yup. So to confirm, keeping this stuff inside a container unconditionally is a 
good thing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005210097
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Ack. I'm thinking if we should just drop the bundler option altogether? It's 
not a lot of extra code but still.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005227237
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Nah, maybe not. It's literally 4 or so cmake commands, and can be useful.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005233293
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Oh I managed to gloss over that somehow, looking for something else I guess.
I would really contain this to containers only. It's not a lot of code but the 
less options there are the less options there are to maintain and worry about, 
and downloading and installing stuff from the net from our makefiles is not 
something I'm terribly comfortable with. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005242117
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -12,6 +12,6 @@ There are two separate sets of documents here:
 * [RPM's Reference Manual](manual/index.md)
 
 The API documention is also build here. But if you see this it is probably not 
built yet. 
-If it is built (in-tree) it can be found [here](librpm/html/index.html).
+If it is built (in-tree) it can be found [here](html/index.html).

But your point stands - the link is just wrong because we don't have a 
"process" for publishing the API docs right now, hmm...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005251098
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Indeed :laughing: There's a lot going on, including C++ compilation, when 
installing the required gems. Somewhat I feel more comfortable to just do it a 
container, hence the `JEKYLL_BIN` option that defaults to `podman`.

Of course, people who develop with Ruby likely have this stuff already 
installed locally or system-wide and thus don't need (or want, really) to 
duplicate all that data once again in a container, so there's the `bundler` 
option too. This is also useful for when you already build RPM inside an 
interactive container (like Toolbox) and want to run "make site" from it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005186982
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Yep, a container FTW for sure. There were some pretty hair-raising messages 
scrolling by in the process of buildign this stuff, such as
> Don't run Bundler as root. Installing your bundle as root will break this
application for all non-root users on this machine.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005191992
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Oh yup, noticed those too :sweat_smile: That should be fine in the container 
environment of course but is surely hair-raising :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005195771
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -12,6 +12,6 @@ There are two separate sets of documents here:
 * [RPM's Reference Manual](manual/index.md)
 
 The API documention is also build here. But if you see this it is probably not 
built yet. 
-If it is built (in-tree) it can be found [here](librpm/html/index.html).
+If it is built (in-tree) it can be found [here](html/index.html).

This thing ends up on https://rpm-software-management.github.io/rpm/ and is 
currently wrong either way. I wonder if we should just drop it until we 
actually render the API docs to a place where we can link them :thinking: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#pullrequestreview-2701771698
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Uh, so let me get this straight: rendering our site requires C and C++ 
compilers? :flushed: :laughing: 
I can see it all breaks if you just remove them, I guess it builds some Ruby 
extensions from source, but seems pretty wacko on the outset. :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#pullrequestreview-2701870840
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +```
+
+# CONFIGURATION
+List main configurables affecting this program here, but don't describe.
+See *rpm.config*(5) for details:
+- *%\_bar_mode*
+- *%\_foo_mode*
+
+# ENVIRONMENT
+Describe environment variables affecting program execution.
+
+# EXIT STATUS
+On success, 0 is returned, a non-zero failure code otherwise.
+
+# EXAMPLES
+Add at least one example for each major functionality of the command.

Heh, actually the provided example was in wrong style. Oh well :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005052423
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+# OPTIONS
+Describe common options and in this section.
+
+Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+See *rpm.common*(8) for the options common to all *rpm* executables.
+
+*-d*,
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_

Clarified this in both the typographic conventions + arguments sections.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005062124
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+*-d*
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_
+   Use file _ARG_ for output.
+
+*--format*=<*aa*|*bb*>
+   Use format *aa* or *bb* for output.
+
+*--compress*=<_method_>

Except that if there's a short and a long option for it, then you'd need to 
duplicate the list of values. So I'd say lets just go with `<_FOO_>` everywhere 
for these multi-value things - its just less format details to remember and get 
wrong when writing manuals.

Actually, it's somewhat similar to using {} for single-line blocks in C: it 
seems fine when you only have that single line, but once you need to add more, 
you annoyingly need to touch the surrounding code too :sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005066532
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] check-rpaths-worker should handle ELF files that have both RPATH and RUNPATH (Issue #3667)

2025-03-20 Thread Panu Matilainen
pmatilai left a comment (rpm-software-management/rpm#3667)

> I did create a minimal standlone library that replicates the issue using GCC, 
> binutils, and the Common Lisp elf system, which I can provide steps for if 
> necessary.

Please do. Without a reproducer it's hard for us to do much about it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3667#issuecomment-2739603356
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> +Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+*-d*
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_
+   Use file _ARG_ for output.
+
+*--format*=<*aa*|*bb*>
+   Use format *aa* or *bb* for output.
+
+*--compress*=<_method_>

> Except that if there's a short and a long option for it, then you'd need to 
> duplicate the list of values. So I'd say lets just go with `<_FOO_>` 
> everywhere for these multi-value things - its just less format details to 
> remember and get wrong when writing manuals.

Good point, and ack.

> Actually, it's somewhat similar to using {} for single-line blocks in C: it 
> seems fine when you only have that single line, but once you need to add 
> more, you annoyingly need to touch the surrounding code too 😅

Right :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005092893
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+# OPTIONS
+Describe common options and in this section.
+
+Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+See *rpm.common*(8) for the options common to all *rpm* executables.
+
+*-d*,
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_

But `# ARGUMENTS` is for positional arguments, not option arguments 
:sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005006728
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+*-d*
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_
+   Use file _ARG_ for output.
+
+*--format*=<*aa*|*bb*>
+   Use format *aa* or *bb* for output.
+
+*--compress*=<_method_>

I agree typing the `<*foo*|*bar*|*meh*>` list is a bit of a handful. So I guess 
we might as well just use placeholders. I'd still like to differentiate this 
from the free-form placeholders somehow. Surrounding the placeholder with `<>` 
would be one possible notation:
```
*--compress*=<_METHOD_>
*--output*=_FILE_
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005010909
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+# OPTIONS
+Describe common options and in this section.
+
+Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+See *rpm.common*(8) for the options common to all *rpm* executables.
+
+*-d*,
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_

Otherwise agreed - the placeholder should be named in a way that makes it 
obvious - such as `_FILE_` if its indeed a file. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005012284
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +```
+
+# CONFIGURATION
+List main configurables affecting this program here, but don't describe.
+See *rpm.config*(5) for details:
+- *%\_bar_mode*
+- *%\_foo_mode*
+
+# ENVIRONMENT
+Describe environment variables affecting program execution.
+
+# EXIT STATUS
+On success, 0 is returned, a non-zero failure code otherwise.
+
+# EXAMPLES
+Add at least one example for each major functionality of the command.

Yup. It's kinda covered by the actual example, but stating it explicitly 
doesn't hurt.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005014965
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +
+# OPTIONS
+Describe common options and in this section.
+
+Typographic conventions:
+- Put option aliases on separate lines
+- Put option arguments with pre-determined values into <> (see below)
+
+See *rpm.common*(8) for the options common to all *rpm* executables.
+
+*-d*,
+*--do-this*
+   Do Y instead of default action.
+
+*-o* _ARG_,
+*--output*=_ARG_

Oh and okay, *that* goes for both kinds of arguments so it deserves an explicit 
mention.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#discussion_r2005013945
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -12,6 +12,6 @@ There are two separate sets of documents here:
 * [RPM's Reference Manual](manual/index.md)
 
 The API documention is also build here. But if you see this it is probably not 
built yet. 
-If it is built (in-tree) it can be found [here](librpm/html/index.html).
+If it is built (in-tree) it can be found [here](html/index.html).

But okay, it's not linked from rpm.org so this is fine - at least its now 
correct for local rendering, which makes it only half as broken as it was 
before :smile: The online link(s) get fixed in 
https://github.com/rpm-software-management/rpm/issues/2216 then.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005263600
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -0,0 +1,17 @@
+FROM registry.fedoraproject.org/fedora:41
+
+RUN dnf install -y \
+gcc \
+gcc-c++ \

Fair point. The bundler option isn't downloading anything, though, it's just 
checking for the gems locally (like we do with any other build deps in cmake). 
It assumes you have the deps preinstalled, or install them yourself.

That said, indeed, the extra option (+ maintenance) isn't worth the added 
benefit (of using the native gems if you have them). So I'll drop that. It'll 
make the whole thing simpler, too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005255824
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add an easy autosigning setup script (PR #3665)

2025-03-20 Thread Panu Matilainen
@pmatilai pushed 1 commit.

a5b63e37d8b668320854900e665c413caa6c780c  fixup! Add support for setting up 
auto-signing with gpg, tests and a man page

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3665/files/68dddb7355de7809291fd5f1a7b07f79765eb697..a5b63e37d8b668320854900e665c413caa6c780c
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add an easy autosigning setup script (PR #3665)

2025-03-20 Thread Panu Matilainen
pmatilai left a comment (rpm-software-management/rpm#3665)

Oops, the $email quote remark fixed now too, and spotted + fixed a couple of 
other missing quotes as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3665#issuecomment-2739879913
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -24,9 +24,13 @@ Typographic conventions:
 - Use hard wrapping at 80 columns for all text
 - Use bold for literal values such as command name and options:
 *cmd* does X, with option *--do-this* does Y instead
-- Use bold when referring to section names
+- Use bold *UPPERCASE* for first level sections, and *Mixed case*

I'd add "when referring to sections", otherwise it sounds like you should use 
bold for the sections themselves :sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#pullrequestreview-2702324831
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a template man page with style guidance (PR #3639)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -72,15 +79,15 @@ See *rpm.common*(8) for the options common to all *rpm* 
> executables.
 *--do-this*
Do Y instead of default action.
 
-*-o* _ARG_,
-*--output*=_ARG_
+*-o* _FILE_,
+*--output*=_FILE_
Use file _ARG_ for output.

Seems like this was forgotten to be updated.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3639#pullrequestreview-2702329437
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -12,6 +12,6 @@ There are two separate sets of documents here:
 * [RPM's Reference Manual](manual/index.md)
 
 The API documention is also build here. But if you see this it is probably not 
built yet. 
-If it is built (in-tree) it can be found [here](librpm/html/index.html).
+If it is built (in-tree) it can be found [here](html/index.html).

Ack,the commit message should probably state this more explicitly, i.e. that 
this is just for *local* rendering. I'll fix that too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005394777
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: create standard (and a template) for rpm man pages (Issue #3654)

2025-03-20 Thread Panu Matilainen
pmatilai left a comment (rpm-software-management/rpm#3654)

Done in #3639 but forgot to add fixes: there.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3654#issuecomment-2740273423
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: create standard (and a template) for rpm man pages (Issue #3654)

2025-03-20 Thread Panu Matilainen
Closed #3654 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3654#event-16908215243
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -0,0 +1,229 @@
+RPM-COMMON(8)
+
+# NAME
+rpm-common - operations and options common to the main *rpm*(8) executables

s/operations/Operations/

> @@ -0,0 +1,229 @@
+RPM-COMMON(8)
+
+# NAME
+rpm-common - operations and options common to the main *rpm*(8) executables
+
+# SYNOPSIS
+_RPMCMD_ [options] {*-?*|*--help*}

We have **rpmcmd** in the template. Technically, this is a user-supplied 
argument (argument 0) so perhaps it's correct but not sure...

> +RPM-COMMON(8)
+
+# NAME
+rpm-common - operations and options common to the main *rpm*(8) executables
+
+# SYNOPSIS
+_RPMCMD_ [options] {*-?*|*--help*}
+
+_RPMCMD_ [options] *--showrc*
+
+_RPMCMD_ [options] *--version*
+
+# DESCRIPTION
+The following *rpm* executables share common configuration and the
+options and operations documented in this manual:
+- *rpm*(8)

I'm thinking if it makes sense to list these. It's easy to get out of sync, and 
we already link from the relevant commands to this man page.

> +*-?*,
+*--help*
+   Print a longer usage message than normal.
+
+*--version*
+   Print a single line containing the version number of *rpm* being
+   used.
+
+*--showrc*
+   Dump information about *rpm* configuration to standard output.
+
+# ARGUMENTS
+The common operations take no arguments.
+
+# OPTIONS
+*--color* <*never*|*auto*|*always*>

You'll notice this one so just making a bookmark here :smile: 

> + for the common macro definition needs.
+
+*--quiet*
+   Print as little as possible - normally only error messages will be
+   displayed.
+
+*--rcfile* _FILELIST_
+   Replace the default list of configuration files to be read with
+   _FILELIST_.  See *rpmrc Configuration* for details.
+
+*--root* _DIRECTORY_
+   Use the file system tree rooted at _DIRECTORY_ for all operations.
+   Note that this means the database within _DIRECTORY_ will be used
+   for dependency checks and any scriptlet(s) (e.g. *%post* if
+   installing, or *%prep* if building, a package) will be run after a
+   chroot(2) to _DIRECTORY_.

Missing bold

> + be displayed. Supply more than once to increase verbosity, eg. *-vv*.
+
+# DEBUG OPTIONS
+*--debug*
+   Print lots of debug information.
+
+*--fsmdebug*
+   Print debuging information of payload handling code.
+
+*--rpmiodebug*
+   Print debug information about file IO.
+
+*--stats*
+   Print runtime statistics of often used functions.
+
+# DEBUG OPTIONS

Duplicate section (except `--deploops`)

> + root directory.
+
+*--undefine*='_MACRO_'
+   Undefines _MACRO_.
+
+*-v*,
+*--verbose*
+   Print verbose information - normally routine progress messages will
+   be displayed. Supply more than once to increase verbosity, eg. *-vv*.
+
+# DEBUG OPTIONS
+*--debug*
+   Print lots of debug information.
+
+*--fsmdebug*
+   Print debuging information of payload handling code.

debugging

> +*curl*(1) or *wget*(1) for fetching data from the internet.
+
+For some operations, *rpm* can act as an FTP and/or HTTP client so that
+packages can be queried or installed from the internet. Package files for
+install, upgrade, and query operations may be specified as an *ftp* or *http*
+style URL:
+
+_http://HOST[:PORT]/path/to/package.rpm_
+
+_ftp://[USER:PASSWORD]@HOST[:PORT]/path/to/package.rpm_
+
+If both the user and password are omitted, anonymous *ftp* is used.
+
+*rpm* allows the following options to be used with ftp URLs:
+
+*rpm* allows the following options to be used with *http* and *ftp* URLs:

Duplicate line

> +packages can be queried or installed from the internet. Package files for
+install, upgrade, and query operations may be specified as an *ftp* or *http*
+style URL:
+
+_http://HOST[:PORT]/path/to/package.rpm_
+
+_ftp://[USER:PASSWORD]@HOST[:PORT]/path/to/package.rpm_
+
+If both the user and password are omitted, anonymous *ftp* is used.
+
+*rpm* allows the following options to be used with ftp URLs:
+
+*rpm* allows the following options to be used with *http* and *ftp* URLs:
+
+*--httpproxy* _HOST_
+   The host _HOST_ will be used as a proxy server for all *http* and

Maybe just `The _HOST_ will be used` ?

> + proxy http server instead of the default port. This option may also
+   be specified by configuring the macro *%\_httpport*.
+
+# ENVIRONMENT
+*RPM_CONFIGDIR*
+   Used to override the default *rpm* configuration home,
+   typically _/usr/lib/rpm_.
+
+# EXIT STATUS
+On success, 0 is returned, a non-zero failure code otherwise.
+
+# FILES
+
+## rpmrc Configuration
+
+Each file in the colon separated rpmrc path is read sequentially by

"rpmrc" is not obivous in this context. Is that the `--rcfile` option?

> + installing, or *%prep* if building, a package) will be run after a
+   chroot(2) to _DIRECTORY_.
+
+   Note that rpm assumes the environment inside the root is set up by
+   the caller, such as any mounts needed for the operation inside t

Re: [Rpm-maint] [rpm-software-management/rpm] Add a cmake target for hands-free docs server (PR #3666)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -12,6 +12,6 @@ There are two separate sets of documents here:
 * [RPM's Reference Manual](manual/index.md)
 
 The API documention is also build here. But if you see this it is probably not 
built yet. 
-If it is built (in-tree) it can be found [here](librpm/html/index.html).
+If it is built (in-tree) it can be found [here](html/index.html).

> On a similar note, the man page link is broken for me in the "make site" 
> version. It's not touched here and is right in the actual 
> https://rpm-software-management.github.io/rpm/ site (but then the pages 
> aren't getting properly rendered atm so...)

You need to build the API docs with `make apidoc` first. I guess this should be 
a dependency of `make site` perhaps?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3666#discussion_r2005241609
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> + installing, or *%prep* if building, a package) will be run after a
+   chroot(2) to _DIRECTORY_.
+
+   Note that rpm assumes the environment inside the root is set up by
+   the caller, such as any mounts needed for the operation inside the
+   root directory.
+
+*--undefine*='_MACRO_'
+   Undefines _MACRO_.
+
+*-v*,
+*--verbose*
+   Print verbose information - normally routine progress messages will
+   be displayed. Supply more than once to increase verbosity, eg. *-vv*.
+
+# DEBUG OPTIONS

Oh but we have various other similar options that are not specific to an 
opereration, such as "SELECT OPTIONS" and "TRANSACTION OPTIONS" and so - this 
is just an attempt to bring a little bit of order into the chaos.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005824217
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> + installing, or *%prep* if building, a package) will be run after a
+   chroot(2) to _DIRECTORY_.
+
+   Note that rpm assumes the environment inside the root is set up by
+   the caller, such as any mounts needed for the operation inside the
+   root directory.
+
+*--undefine*='_MACRO_'
+   Undefines _MACRO_.
+
+*-v*,
+*--verbose*
+   Print verbose information - normally routine progress messages will
+   be displayed. Supply more than once to increase verbosity, eg. *-vv*.
+
+# DEBUG OPTIONS

Hmm, there seem to be duplicate debug options now, oops :sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005826273
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -202,11 +148,6 @@ The following options may also be used:
but *%builddir*/*%buildsubdir* points back to the current working
directory. *%prep* is skipped entirely.
 
-*--target* _PLATFORM_

This seems to have been dropped completely (not added elsewhere), is that 
intentional?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#pullrequestreview-2703253942
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
pmatilai left a comment (rpm-software-management/rpm#3659)

I'll try to get this updated tomorrow.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#issuecomment-2740780373
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> + installing, or *%prep* if building, a package) will be run after a
+   chroot(2) to _DIRECTORY_.
+
+   Note that rpm assumes the environment inside the root is set up by
+   the caller, such as any mounts needed for the operation inside the
+   root directory.
+
+*--undefine*='_MACRO_'
+   Undefines _MACRO_.
+
+*-v*,
+*--verbose*
+   Print verbose information - normally routine progress messages will
+   be displayed. Supply more than once to increase verbosity, eg. *-vv*.
+
+# DEBUG OPTIONS

Understood, I haven't yet gone through the whole PR and indeed, that's what the 
updated rpm.8 page has. And I agree of course, there doesn't have to a be 
strict rule for "only separate by operation" as it can grow very long, the 
option list, otherwise.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005831787
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -0,0 +1,229 @@
+RPM-COMMON(8)
+
+# NAME
+rpm-common - operations and options common to the main *rpm*(8) executables
+
+# SYNOPSIS
+_RPMCMD_ [options] {*-?*|*--help*}

Yup, I'm not sure either. `*rpmcmd* seems wrong because that's supposed to be a 
literal thing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005846838
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add an easy autosigning setup script (PR #3665)

2025-03-20 Thread Panu Matilainen
@pmatilai pushed 1 commit.

68dddb7355de7809291fd5f1a7b07f79765eb697  fixup! Add support for setting up 
auto-signing with gpg, tests and a man page

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3665/files/77f2a7ed207393c11d8f5947b5e64a93023d33fa..68dddb7355de7809291fd5f1a7b07f79765eb697
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> + proxy http server instead of the default port. This option may also
+   be specified by configuring the macro *%\_httpport*.
+
+# ENVIRONMENT
+*RPM_CONFIGDIR*
+   Used to override the default *rpm* configuration home,
+   typically _/usr/lib/rpm_.
+
+# EXIT STATUS
+On success, 0 is returned, a non-zero failure code otherwise.
+
+# FILES
+
+## rpmrc Configuration
+
+Each file in the colon separated rpmrc path is read sequentially by

Yup, I basically just lifted the existing text to a different place without 
even trying to improve it. 
rpmrc does of course relate to `--rcfile` too, but more importantly the default 
rpmrc's and the path they're looked through forms the other base pillar of rpm 
configuration in addition to macros.

I'd leave better explaining the system to #3614, this is more about 
reorganizing to match the new style rather than fixing the contents too, 
although some content-fixing is necessary as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005837184
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Panu Matilainen
@pmatilai commented on this pull request.



> +packages can be queried or installed from the internet. Package files for
+install, upgrade, and query operations may be specified as an *ftp* or *http*
+style URL:
+
+_http://HOST[:PORT]/path/to/package.rpm_
+
+_ftp://[USER:PASSWORD]@HOST[:PORT]/path/to/package.rpm_
+
+If both the user and password are omitted, anonymous *ftp* is used.
+
+*rpm* allows the following options to be used with ftp URLs:
+
+*rpm* allows the following options to be used with *http* and *ftp* URLs:
+
+*--httpproxy* _HOST_
+   The host _HOST_ will be used as a proxy server for all *http* and

Yeah that's kinda the thing with these obvious placeholders, they easily make 
explaining it silly :sweat_smile: 
Maybe that should really be "Use _HOST_ as the proxy server for all...", the 
imperative style is pretty handy for man pages too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005843442
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> + installing, or *%prep* if building, a package) will be run after a
+   chroot(2) to _DIRECTORY_.
+
+   Note that rpm assumes the environment inside the root is set up by
+   the caller, such as any mounts needed for the operation inside the
+   root directory.
+
+*--undefine*='_MACRO_'
+   Undefines _MACRO_.
+
+*-v*,
+*--verbose*
+   Print verbose information - normally routine progress messages will
+   be displayed. Supply more than once to increase verbosity, eg. *-vv*.
+
+# DEBUG OPTIONS

OTOH, it's not explicitly discouraged in the template either, it's just not 
mentioned... so meh, don't bother :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#discussion_r2005855726
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm(8) rework towards the new unified style (PR #3659)

2025-03-20 Thread Michal Domonkos
@dmnks commented on this pull request.



> -*--version*
-   Print a single line containing the version number of *rpm* being
-   used.
-
-*--quiet*
-   Print as little as possible - normally only error messages will be
-   displayed.
-
-*-v*
-   Print verbose information - normally routine progress messages will
-   be displayed.
-
-*-vv*
-   Print lots of ugly debugging information.
-
-*--rpmfcdebug*

This one also has been removed completely, probably unintentional

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3659#pullrequestreview-2703274436
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint