Re: [Rpm-maint] [rpm-software-management/rpm] unable to import GPG keys if bit 7 "critical" of the subpacket type is set (Issue #2323)

2022-12-14 Thread Michael Schroeder
15.5? That's not released yet, right? I don't know if it contains any 
maintenance updates.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2323#issuecomment-1350769608
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] unable to import GPG keys if bit 7 "critical" of the subpacket type is set (Issue #2323)

2022-12-14 Thread Michael Schroeder
It should be available in 15.3 and 15.4.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2323#issuecomment-1350770444
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Examine Compressed Headers (Issue #2220)

2022-12-14 Thread Michael Schroeder
Just a data point: when I created ndb I played with putting lzo compressed 
headers in the database. I thought that decompression would be faster than IO, 
so the net result would be faster database access. But it turned out that 
things got slower with compression, so I removed the feature again. (This was 
quite some time ago, so take this with a grain of salt.)

Compressing the main headers in the package format sounds more promising.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2220#issuecomment-1350836235
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] transfiletriggerpostun doesn't work when rpms are removed. (Issue #2324)

2022-12-14 Thread xiacunshun
I found this problem when I uninstall rpms.
https://github.com/systemd/systemd/issues/25682

A similar issue:
https://github.com/rpm-software-management/rpm/commit/f6521c50f6836374a0f7995f8f393aaf36e178ea


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2324
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RPM shows the same Package in two versions / can only be uninstalled once (Issue #2320)

2022-12-14 Thread Panu Matilainen
Closed #2320 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2320#event-8037518590
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RPM shows the same Package in two versions / can only be uninstalled once (Issue #2320)

2022-12-14 Thread Panu Matilainen
So actually the db_recovery docs already separate BDB from the other cases, 
with instructions on how to tell which one is being used. 

Support for BDB databases has been removed entirely in more recent rpm versions 
so there's nothing we can do about this now. And note that the "locks grouped 
by..." output comes from BDB utilities, not rpm.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2320#issuecomment-1351403309
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks when running rpmbuild (PR #2293)

2022-12-14 Thread Panu Matilainen
Merged #2293 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2293#event-8037585033
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks when running rpmbuild (PR #2293)

2022-12-14 Thread Panu Matilainen
The rest seems straightforward enough. Thanks for the patches!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2293#issuecomment-1351415981
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Examine Compressed Headers (Issue #2220)

2022-12-14 Thread Daniel Alley
LZO doesn't have particularly fast decompression as far as I'm aware.  zstd is 
2-3x faster and lz4 is 5x faster according to these numbers 
https://github.com/facebook/zstd

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2220#issuecomment-1351552602
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm install failed:error: unpacking of archive failed on file /usr/sbin/aaa;636c6826: cpio: open failed - No such file or directory (Issue #2273)

2022-12-14 Thread xujing
When I tried to fix it with the following patch, the `openat(dirfd, dest, 
O_WRONLY|O_CREAT, 0200)` still failed with a message "No such file or 
directory". In this case, the open does not seem to cover this scenario.
```
diff --git a/lib/fsm.c b/lib/fsm.c
index c9ab3e1..4ceca3d 100644
--- a/lib/fsm.c
+++ b/lib/fsm.c
@@ -282,6 +282,12 @@ static int fsmOpen(int *wfdp, int dirfd, const char *dest)
 /* Create the file with 0200 permissions (write by owner). */
 int fd = openat(dirfd, dest, O_WRONLY|O_EXCL|O_CREAT, 0200);
 
+if (fd < 0 && errno == EEXIST) {
+   rpmlog(RPMLOG_WARNING, "xujing: %8s (%s [%d]) %s\n", __func__,
+  dest, fd, (rc < 0 ? strerror(errno) : ""));
+   fd = openat(dirfd, dest, O_WRONLY|O_CREAT, 0200);
+}
+
 if (fd < 0)
rc = RPMERR_OPEN_FAILED;
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2273#issuecomment-1352469285
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpm install failed:error: unpacking of archive failed on file /usr/sbin/aaa;636c6826: cpio: open failed - No such file or directory (Issue #2273)

2022-12-14 Thread xujing
I tried to modify the %install and the installation still failed, but it was 
due to symlink failure.
```
%install
mkdir %{buildroot}/sbin/
touch %{buildroot}/sbin/aaa

%if %{with sbinsymlinks}
mkdir -p %{buildroot}/usr/sbin/
cd %{buildroot}/usr/sbin/
ln -sv ../../sbin/aaa .
%endif
```
```
[root@localhost SPECS]# rpm -ivh 
/root/rpmbuild/RPMS/noarch/test-1.0-1.noarch.rpm --force
Verifying...  # [100%]
Preparing...  # [100%]
Updating / installing...
   1:test-1.0-1   # [100%]
error: unpacking of archive failed on file /usr/sbin/aaa;639a7f70: cpio: 
**symlink failed - No such file or directory**
error: test-1.0-1.noarch: install failed
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2273#issuecomment-1352470844
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] transfiletriggerpostun doesn't work when rpms are removed. (Issue #2324)

2022-12-14 Thread xiacunshun
I got some clues as following:
in lib/rpmtriggers.c:109
`strcmp(prefix, rpmdsN(ds)) == 0`

The  rpmdsN(ds) cannot get the right prefix matching the one we need ( 
/usr/lib/systemd/system/ ) due to the wrong value ds->N[ds->I] returns. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2324#issuecomment-1352484963
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] transfiletriggerpostun doesn't work when rpms are removed. (Issue #2324)

2022-12-14 Thread xiacunshun
https://user-images.githubusercontent.com/7437321/207760024-9ed2b111-7df0-4389-98f9-91167ad79e65.png";>


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2324#issuecomment-1352485469
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Use the real user/group name in BUILDROOT if we set %attr(-, -, -) explicitly (Issue #1933)

2022-12-14 Thread xujing
I reconfirmed the rpmrebuild code. The spec file automatically generated by 
rpmrebuild does not configure defattr. It seems that this scenario does not 
exist unless manually configured.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1933#issuecomment-1352503592
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint