[openstreetmap/openstreetmap-website] Update to iD v2.30.4 (PR #5250)
updates the editor layer index again, this time addressing https://github.com/openstreetmap/iD/issues/10486 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5250 -- Commit Summary -- * Update to iD v2.30.4 -- File Changes -- M vendor/assets/iD/iD.js (2) M vendor/assets/iD/iD/data/imagery.min.json (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5250.patch https://github.com/openstreetmap/openstreetmap-website/pull/5250.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5250 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update to iD v2.30.3 (PR #5248)
updates the editor layer index, adressing https://github.com/openstreetmap/iD/issues/10483 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5248 -- Commit Summary -- * Update to iD v2.30.3 -- File Changes -- M vendor/assets/iD/iD.js (2) M vendor/assets/iD/iD/data/imagery.min.json (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5248.patch https://github.com/openstreetmap/openstreetmap-website/pull/5248.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5248 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update to iD v2.31.1 (PR #5623)
Small bugfix release, fixing flickering when switching background layers or zooming (https://github.com/openstreetmap/iD/issues/10738). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5623 -- Commit Summary -- * Update to iD v2.31.1 -- File Changes -- M vendor/assets/iD/iD.css.erb (3) M vendor/assets/iD/iD.js (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5623.patch https://github.com/openstreetmap/openstreetmap-website/pull/5623.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5623 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Automatic deselecting "Map Notes" when changing to/from Edit Mode is annoying (#1212)
> after clicking "edit", iD editor opens without notes visible FYI: With v2.31 (#5610), iD will load the notes layer if it was previously enabled on the osm.org map (also when no individual note is selected). Disabling the notes layer in the editor will however not disable it for the osm map. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1212#issuecomment-2636871410 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update to iD v2.31.0 (PR #5610)
## changes to the osm-website code: This version of iD introduces a new hash parameter to enable to _notes_ layer on startup. For a seamless integration into the website, I have added a check if the notes layer is currently active, and pass it forward to the iD iframe. The implementation is currently referring to the `_osm_location` cookie for this. Let me know if this should be done in a different way instead.
## Upstream Changelog :sparkles: Usability & Accessibility * Fix flickering when switching between background imagery layers, make switching backgrounds snappier * Prevent password managers from autofilling tag fields ([#10508]) * Make parking space thinner in partial fill rendering ([#10442]) * Include route number in label of named route relations ([#10478]) * Make oneway arrows more visible on dark colored lines ([#9143]) * Add hash parameter to enable notes layer by default ([#8042]) :scissors: Operations * When extracting a node from a way (shortcut: E), the relations are now preserved by default. Extracting a node without its relations is still possible using ⇧ Shift E ([#9816]) * Remove rarely-used keyboard shortcut L to prevent accidental activation of the geolocate tool ([#]) :white_check_mark: Validation * Include wikidata errors from osmose QA service ([#9998]) :bug: Bugfixes * Fix unsolvable validator error triggered by regional presets ([#10459]) * Render highway direction cones only on matching parent ways ([#9013]) * Prevent edit menu from being covered up by street level imagery or other map overlay panels ([#10495]) * Fix grid lines from showing up on background map tiles in certain situations (semi-transparent tiles or fractional browser zoom level) ([#10594]) * Prevent search results from sometimes getting stuck in the highlighted state when mouse-hovering the list of search results while typing ([#10661]) * Allow tiles in minimap to be slightly underzoomed, preventing them from blacking out on low map zoom levels ([#10653]) * Fix confusing behaviour after logging out in the standalone build of iD ([#10683]) * Fix editor being stuck in a disabled state when login popup window is closed prematurely ([#10651]) * Preserve `opening_hours` when matching a NSI preset ([#10564]) * Fix bug causing invisible features when `layer` tag is a decimal number ([#9933]) :earth_asia: Localization * Update Sinitic languages in the Multilingual Names field ([#10488]) * Update the list of languages in the Wikipedia field ([#10489]) * Add Ladin (language code `lld`) as an available option for multilingual names * Add 30 indigenous languages as dropdown options for multilingual names ([#10684]) * Add `lang`uage attributes to input fields for multilingual names, as well as wikidata and wikipedia fields ([#10716]) :mortar_board: Walkthrough / Help * Fix walkthrough from showing tooltips on wrong location under certain circumstances ([#10650], [#10624], [#10634]) :rocket: Presets * Updated the [`cycleway`](https://osm.wiki/Key:cycleway) & [`sidewalk`](https://osm.wiki/Key:sidewalk) fields to recognise the `:both` suffix, for example [`cycleway:both`](https://osm.wiki/Key:cycleway:both) ([#9587]) :hammer: Development * Migrate unit tests from karma to vitest ([#10452]) [#8042]: https://github.com/openstreetmap/iD/pull/8042 [#9013]: https://github.com/openstreetmap/iD/issues/9013 [#9143]: https://github.com/openstreetmap/iD/pull/9143 [#9587]: https://github.com/openstreetmap/iD/issues/9587 [#9816]: https://github.com/openstreetmap/iD/issues/9816 [#9933]: https://github.com/openstreetmap/iD/pull/9933 [#9998]: https://github.com/openstreetmap/iD/pull/9998 [#]: https://github.com/openstreetmap/iD/issues/ [#10442]: https://github.com/openstreetmap/iD/pull/10442 [#10452]: https://github.com/openstreetmap/iD/pull/10452 [#10459]: https://github.com/openstreetmap/iD/pull/10459 [#10478]: https://github.com/openstreetmap/iD/pull/10478 [#10488]: https://github.com/openstreetmap/iD/pull/10488 [#10489]: https://github.com/openstreetmap/iD/pull/10489 [#10495]: https://github.com/openstreetmap/iD/issues/10495 [#10508]: https://github.com/openstreetmap/iD/pull/10508 [#10564]: https://github.com/openstreetmap/iD/pull/10564 [#10594]: https://github.com/openstreetmap/iD/pull/10594 [#10624]: https://github.com/openstreetmap/iD/issues/10624 [#10634]: https://github.com/openstreetmap/iD/issues/10634 [#10650]: https://github.com/openstreetmap/iD/issues/10650 [#10651]: https://github.com/openstreetmap/iD/issues/10651 [#10653]: https://github.com/openstreetmap/iD/issues/10653 [#10683]: https://github.com/openstreetmap/iD/issues/10683 [#10684]: https://github.com/openstreetmap/iD/pull/10684 [#10716]: https://github.com/openstreetmap/iD/pull/10716 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5610 -- Commit Summary -- * Upda
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@tyrasd pushed 1 commit. 0b5fa06a39e1cd793e2c77116201c521aa02ec38 lint -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/051ae5953f18e2bcc4a4612e9851c95c0f86842e..0b5fa06a39e1cd793e2c77116201c521aa02ec38 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
The current version of iD (v2.31, before the fix for https://github.com/openstreetmap/iD/issue/10761 : https://github.com/openstreetmap/iD/pull/10766), does not fully support `x-www-form-urlencoded` "query-style" strings in the hash: Specifically, spaces encoded as `+` will not be decoded back to ` `. This workaround essentially temporarily reverts the behaviour of the website to the state before #5592, and can be dropped again with the next minor version upgrade of iD (`v2.32`). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5661 -- Commit Summary -- * workaround for iD bug #10761 -- File Changes -- M app/assets/javascripts/edit/id.js.erb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5661.patch https://github.com/openstreetmap/openstreetmap-website/pull/5661.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@tyrasd pushed 1 commit. c025613ff6038439d3b5591aebee915f75999575 replace all occurrences of `+` -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/0b5fa06a39e1cd793e2c77116201c521aa02ec38..c025613ff6038439d3b5591aebee915f75999575 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
> Also, wouldn't it be better to create an iD 2.31.2 patch for this It would be possible to create a patch release for this but I would prefer to only include this change in the next minor release version, as strictly speaking this does change the [API](https://github.com/openstreetmap/iD/blob/develop/API.md) slightly. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661#issuecomment-2654067208 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@tyrasd commented on this pull request.
> @@ -33,5 +33,5 @@ $(document).ready(function () {
if (id.data("gpx")) params.set("gpx", id.data("gpx"));
- id.attr("src", id.data("url") + "#" + params);
+ id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20"));
I've fixed the `replace` regex to do this for all `+` characters. Thanks for
spotting this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5661#discussion_r1952877147
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] iD: listen to URL hash changes (PR #5394)
When the `map` hash parameter is changed (and was not not triggered by map interaction from inside iD itself): pan to the new location. This mirrors the behaviour when manually editing the `map` hash parameter on osm.org outside of iD. This also fixes https://github.com/openstreetmap/iD/issues/10592 (error in js console when iD is opened outside of an iframe by directly navigating to osm.org/id). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5394 -- Commit Summary -- * iD: listen to manual hashchanges from iframe parent -- File Changes -- M app/assets/javascripts/id.js (28) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5394.patch https://github.com/openstreetmap/openstreetmap-website/pull/5394.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5394 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] iD: listen to URL hash changes (PR #5394)
> using openstreetmap.org/id directly is not really supported :+1: agree -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5394#issuecomment-2539710967 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] fix map panning to objects when url hash is not empty but has no map location (PR #5679)
Fix for #865. Unfortunately, the code is slightly different between OSM objects
(nodes/ways/relations), notes and changesets. I tried to make it somewhat more
coherent by always using the `map.addObject({}, callback)` approach to zoom to
the location if the `hash` parameters had no location information.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5679
-- Commit Summary --
* fix map panning to objects when url hash is not empty but has no map
location, fixes #865
-- File Changes --
M app/assets/javascripts/index.js (3)
M app/assets/javascripts/index/changeset.js (3)
M app/assets/javascripts/index/note.js (28)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5679.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5679.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5679
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] don't re-pan the map when selecting another note that is already on screen (PR #5686)
Fixes #5683 (a regression in #5679): the problem was that when clicking on a new note on the map, the URL hash with the `map` parameter is cleared somewhere before `pushstate` gets called, resulting in the map to be panned in `map.addObject` during the `initialize` step. It's now solved by passing an additional parameter to `initialize` and only do the map centering there. This also allowed to fix #648 via 3a016a5f1. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5686 -- Commit Summary -- * don't re-pan the map when selecting another note that is already on the screen * don't pan map wen closing/reopening/commenting a note, fixes #648 -- File Changes -- M app/assets/javascripts/index/note.js (15) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5686.patch https://github.com/openstreetmap/openstreetmap-website/pull/5686.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5686 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't re-pan the map when selecting another note that is already on screen (PR #5686)
@tyrasd pushed 1 commit. 793757a6ff4a6ca3cb7ad5454fec1c51fe63804f don't pan map wen closing/reopening/commenting a note, fixes #648 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5686/files/3a016a5f164ea40ebdc29cc6d3fdf799700172c2..793757a6ff4a6ca3cb7ad5454fec1c51fe63804f You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Selecting a note centres the map on it and zooms (Issue #5683)
tyrasd left a comment (openstreetmap/openstreetmap-website#5683) sorry, this was an unintended side effect of #5679. working on a fix now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5683#issuecomment-2661343897 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add reload on iframe redirect (PR #5823)
@tyrasd commented on this pull request.
> @@ -36,4 +36,10 @@ $(function () {
if (idData.gpx) params.set("gpx", idData.gpx);
id.attr("src", idData.url + "#" + params);
+
+ id.ready(function () {
+if (!this.contentWindow.location.href.startsWith(idData.url)) {
I get a `Uncaught TypeError: this.contentWindow is undefined` error every time
I regularly start an iD editing session. Is that expected? Would it not be
better to skip the check if everything is loaded correctly, maybe like this:
```js
if (this.contentWindow &&
!this.contentWindow.location.href.startsWith(idData.url)) {
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5823#pullrequestreview-2753636419
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update to iD v2.33.0 (PR #5912)
release notes are available at https://github.com/openstreetmap/iD/releases/tag/v2.33.0 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5912 -- Commit Summary -- * Update to iD v2.33.0 -- File Changes -- A .Vendorfile.swp (0) A package-lock.json (2716) M package.json (3) M vendor/assets/iD/iD.css.erb (85) M vendor/assets/iD/iD.js (138748) M vendor/assets/iD/iD/data/imagery.min.json (2) M vendor/assets/iD/iD/data/languages.min.json (2) M vendor/assets/iD/iD/data/phone_formats.min.json (2) M vendor/assets/iD/iD/data/shortcuts.min.json (2) M vendor/assets/iD/iD/data/territory_languages.min.json (2) M vendor/assets/iD/iD/img/fa-sprite.svg (2) M vendor/assets/iD/iD/locales/bg.min.json (2) M vendor/assets/iD/iD/locales/br.min.json (2) M vendor/assets/iD/iD/locales/cy.min.json (2) M vendor/assets/iD/iD/locales/da.min.json (2) M vendor/assets/iD/iD/locales/de-AT.min.json (2) M vendor/assets/iD/iD/locales/de-CH.min.json (2) M vendor/assets/iD/iD/locales/de.min.json (2) M vendor/assets/iD/iD/locales/en-AU.min.json (2) M vendor/assets/iD/iD/locales/en-CA.min.json (2) M vendor/assets/iD/iD/locales/en-GB.min.json (2) M vendor/assets/iD/iD/locales/en-IE.min.json (2) M vendor/assets/iD/iD/locales/en-IN.min.json (2) M vendor/assets/iD/iD/locales/en-NZ.min.json (2) M vendor/assets/iD/iD/locales/en-PH.min.json (2) M vendor/assets/iD/iD/locales/en-US.min.json (2) M vendor/assets/iD/iD/locales/en.min.json (2) M vendor/assets/iD/iD/locales/es.min.json (2) M vendor/assets/iD/iD/locales/et.min.json (2) M vendor/assets/iD/iD/locales/eu.min.json (2) M vendor/assets/iD/iD/locales/fi.min.json (2) M vendor/assets/iD/iD/locales/fr-FR.min.json (2) M vendor/assets/iD/iD/locales/fr.min.json (2) M vendor/assets/iD/iD/locales/gan.min.json (2) M vendor/assets/iD/iD/locales/he-IL.min.json (2) M vendor/assets/iD/iD/locales/he.min.json (2) M vendor/assets/iD/iD/locales/hu.min.json (2) M vendor/assets/iD/iD/locales/id.min.json (2) M vendor/assets/iD/iD/locales/index.min.json (2) M vendor/assets/iD/iD/locales/it.min.json (2) M vendor/assets/iD/iD/locales/lv.min.json (2) M vendor/assets/iD/iD/locales/pl.min.json (2) M vendor/assets/iD/iD/locales/pt-BR.min.json (2) M vendor/assets/iD/iD/locales/pt.min.json (2) M vendor/assets/iD/iD/locales/ro.min.json (2) M vendor/assets/iD/iD/locales/ru.min.json (2) M vendor/assets/iD/iD/locales/sk.min.json (2) M vendor/assets/iD/iD/locales/sr.min.json (2) M vendor/assets/iD/iD/locales/sv.min.json (2) M vendor/assets/iD/iD/locales/th.min.json (2) M vendor/assets/iD/iD/locales/uk.min.json (2) M vendor/assets/iD/iD/locales/yue.min.json (2) M vendor/assets/iD/iD/locales/zh-CN.min.json (2) M vendor/assets/iD/iD/locales/zh-HK.min.json (2) M vendor/assets/iD/iD/locales/zh-TW.min.json (2) M vendor/assets/iD/iD/locales/zh.min.json (2) A vendor/assets/iD/iD/mapillary-js/cover-logo.svg (16) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5912.patch https://github.com/openstreetmap/openstreetmap-website/pull/5912.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5912 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Update to iD v2.33.0 (PR #5912)
@tyrasd pushed 1 commit. c48123ba70167817fd755622fd996ae7843ce5f5 Update to iD v2.33.0 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/7a9d2af0e09ea4eb2ac9a26b72ba7c6557b3a657..c48123ba70167817fd755622fd996ae7843ce5f5 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Update to iD v2.33.0 (PR #5912)
@tyrasd pushed 1 commit. d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1 Update to iD v2.33.0 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/c48123ba70167817fd755622fd996ae7843ce5f5..d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add reload on iframe redirect (adb034d)
I get a `Uncaught TypeError: this.contentWindow is undefined` error every time
I regularly start an iD editing session. Is that expected? Would it not be
better to skip the check if everything is loaded correctly, maybe like this:
```js
if (this.contentWindow &&
!this.contentWindow.location.href.startsWith(idData.url)) {
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/adb034d26e6f465d07c75a2fcfd3477c38539c4f#r155069344
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)
tyrasd left a comment (openstreetmap/openstreetmap-website#5700) Yeah, this seems good to me. Thanks @hlfan -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5700#issuecomment-2665645883 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
tyrasd left a comment (openstreetmap/openstreetmap-website#5698) closing in favour of #5700 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2665640851 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
Closed #5698. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#event-16347893361 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)
tyrasd left a comment (openstreetmap/openstreetmap-website#5632) > fix to uninitialized variables yeah, but the previous version of the code used the _uninitialized_ state explicitly to encode the case for when the `#map` parameter should explicitly be absent in the url of the iD iframe. :wink: -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5632#issuecomment-2663935924 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
@tyrasd pushed 1 commit. e56340b3ea6024738d03af3c1647019584a09bc3 drop superfluous semicolon -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698/files/1599c360b0517ac0f6d15d514e0afc7509983c66..e56340b3ea6024738d03af3c1647019584a09bc3 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
ehrm…
Given that:
* `mapParams.center/.zoom` get the location via different means (either via the
URL's hash, `mlat/mlon` query parameters or the previously last visited
location that's stored in a cookie)
* iD will not auto-center to a the supplied osm features if a `#map=…`
parameter is present
The expected behavior is that:
* if iD is loaded via a link that only has a map object (e.g.
`osm.org/edit?node=1`, or `osm.org/edit?note=1234`), the editor should
auto-center to the respective object during startup
* if iD is loaded via a link that has both a map object and a map hash (e.g.
`osm.org/edit?node=1#map=0/0/0`), it should set the map to the given
lat/lon/zoom values
* if iD is loaded via a bare link (`osm.org/edit`), it should use the map view
that is stored in the cookie
So… since `mapParams` should already have the information from the `hashArgs`,
I guess it should be able to reduce the inner `if` to something like the
following, is that what you mean by _Removing the `else`_??
```js
if (!hashArgs.center) {
setMapView = false;
};
```
I just tried to keep the fix here to the bare minimum and didn't want to touch
the rest of the logic…
PS: if I see this correctly, `idData.lat/.lon` are only set when the editor is
loaded using a `…?note=xxx` link, see 6494747882358cc1506ae442c89eed3db1de94a4.
This is AFAICT not necessary anymore because notes are by now also using the
`mapParams.object` path. But let's handle that in another PR, shall we?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663920675
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
tyrasd left a comment (openstreetmap/openstreetmap-website#5698) > idData already has the coordinates This one is also a bit confusing. Normally, `idData.lat/.lon` are not present. If I see this correctly, `idData.lat/.lon` are only set when the editor is loaded using a `…?note=xxx` link, see 6494747882358cc1506ae442c89eed3db1de94a4. This is AFAICT not necessary anymore because notes are by now also using the `mapParams.object` path. But let's handle that in another PR, shall we? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663929836 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
tyrasd left a comment (openstreetmap/openstreetmap-website#5698) > The map parameter would always be set. not in the iframe's `src` parameter before 5310c5b :shrug:  > Why would you not want to use the coordinates for nodes, ways and notes if > these are already loaded in the > [site_controller](https://github.com/openstreetmap/openstreetmap-website/blob/483f4c1341ee2b0eb438dc7704e4ba272d1e74fe/app/controllers/site_controller.rb#L86)? Ok, wait. Of course it would be good to load the editor right away at the correct coordinates. For nodes and notes this is trivial (we can use the `lat`/`lon` directly), not sure how doable it would be in the ruby code for ways and relations, as there would be some zoom-level calculation to do (which depends on the size of the feature as well as the size of the browser window and the applied browser-zoom %). What I was trying to do here is to merely fix the regression from #5632 by restoring the previous behavior, and nothing more. If you can come up with a better fix, please go ahead, I'm happy to close this one in favor of a better solution. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663993901 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update to iD v2.32.0 (PR #5750)
Release notes: https://github.com/openstreetmap/iD/releases/tag/v2.32.0 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5750 -- Commit Summary -- * Update to iD v2.32.0 -- File Changes -- M vendor/assets/iD/iD.css.erb (139) M vendor/assets/iD/iD.js (3061) M vendor/assets/iD/iD/data/address_formats.min.json (2) M vendor/assets/iD/iD/data/imagery.min.json (2) M vendor/assets/iD/iD/img/community-sprite.svg (2) M vendor/assets/iD/iD/img/fa-sprite.svg (2) M vendor/assets/iD/iD/img/maki-sprite.svg (2) M vendor/assets/iD/iD/locales/ar-AA.min.json (2) M vendor/assets/iD/iD/locales/ar.min.json (2) M vendor/assets/iD/iD/locales/bg.min.json (2) M vendor/assets/iD/iD/locales/br.min.json (2) M vendor/assets/iD/iD/locales/ca.min.json (2) M vendor/assets/iD/iD/locales/cs.min.json (2) M vendor/assets/iD/iD/locales/cy.min.json (2) M vendor/assets/iD/iD/locales/da.min.json (2) M vendor/assets/iD/iD/locales/de-AT.min.json (2) M vendor/assets/iD/iD/locales/de-CH.min.json (2) M vendor/assets/iD/iD/locales/de.min.json (2) M vendor/assets/iD/iD/locales/el.min.json (2) M vendor/assets/iD/iD/locales/en-AU.min.json (2) M vendor/assets/iD/iD/locales/en-CA.min.json (2) M vendor/assets/iD/iD/locales/en-GB.min.json (2) M vendor/assets/iD/iD/locales/en-IE.min.json (2) M vendor/assets/iD/iD/locales/en-IN.min.json (2) M vendor/assets/iD/iD/locales/en-NZ.min.json (2) M vendor/assets/iD/iD/locales/en-PH.min.json (2) M vendor/assets/iD/iD/locales/en-US.min.json (2) M vendor/assets/iD/iD/locales/en.min.json (2) M vendor/assets/iD/iD/locales/eo.min.json (2) M vendor/assets/iD/iD/locales/es.min.json (2) M vendor/assets/iD/iD/locales/et.min.json (2) M vendor/assets/iD/iD/locales/eu.min.json (2) M vendor/assets/iD/iD/locales/fa-IR.min.json (2) M vendor/assets/iD/iD/locales/fa.min.json (2) M vendor/assets/iD/iD/locales/fi.min.json (2) M vendor/assets/iD/iD/locales/fr-FR.min.json (2) M vendor/assets/iD/iD/locales/fr.min.json (2) M vendor/assets/iD/iD/locales/ga.min.json (2) M vendor/assets/iD/iD/locales/gan.min.json (2) M vendor/assets/iD/iD/locales/gl.min.json (2) M vendor/assets/iD/iD/locales/he-IL.min.json (2) M vendor/assets/iD/iD/locales/he.min.json (2) M vendor/assets/iD/iD/locales/hr.min.json (2) M vendor/assets/iD/iD/locales/hu.min.json (2) M vendor/assets/iD/iD/locales/id.min.json (2) M vendor/assets/iD/iD/locales/index.min.json (2) M vendor/assets/iD/iD/locales/it.min.json (2) M vendor/assets/iD/iD/locales/ja.min.json (2) M vendor/assets/iD/iD/locales/ko.min.json (2) M vendor/assets/iD/iD/locales/lv.min.json (2) M vendor/assets/iD/iD/locales/mk.min.json (2) M vendor/assets/iD/iD/locales/nl-BE.min.json (2) M vendor/assets/iD/iD/locales/nl-NL.min.json (2) M vendor/assets/iD/iD/locales/nl.min.json (2) M vendor/assets/iD/iD/locales/no.min.json (2) M vendor/assets/iD/iD/locales/pa-PK.min.json (2) M vendor/assets/iD/iD/locales/pa.min.json (2) M vendor/assets/iD/iD/locales/pl.min.json (2) M vendor/assets/iD/iD/locales/pt-BR.min.json (2) M vendor/assets/iD/iD/locales/pt.min.json (2) M vendor/assets/iD/iD/locales/ru.min.json (2) M vendor/assets/iD/iD/locales/sk.min.json (2) M vendor/assets/iD/iD/locales/sr.min.json (2) M vendor/assets/iD/iD/locales/sv.min.json (2) M vendor/assets/iD/iD/locales/th.min.json (2) M vendor/assets/iD/iD/locales/tr.min.json (2) M vendor/assets/iD/iD/locales/uk.min.json (2) M vendor/assets/iD/iD/locales/ur.min.json (2) M vendor/assets/iD/iD/locales/vi.min.json (2) M vendor/assets/iD/iD/locales/yue.min.json (2) M vendor/assets/iD/iD/locales/zh-CN.min.json (2) M vendor/assets/iD/iD/locales/zh-HK.min.json (2) M vendor/assets/iD/iD/locales/zh-TW.min.json (2) M vendor/assets/iD/iD/locales/zh.min.json (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5750.patch https://github.com/openstreetmap/openstreetmap-website/pull/5750.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5750 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)
fixes https://github.com/openstreetmap/iD/issues/10779 (a regression introduced in #5632) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5698 -- Commit Summary -- * don't set map coords if mapParams contains object, but no "map" in hash -- File Changes -- M app/assets/javascripts/edit/id.js.erb (12) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5698.patch https://github.com/openstreetmap/openstreetmap-website/pull/5698.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)
tyrasd left a comment (openstreetmap/openstreetmap-website#5632) FYI, this added a small bug, see https://github.com/openstreetmap/iD/issues/10779 / #5698 I really appreciate the cleanup efforts of the iD integration code. :+1: Nevertheless, it would have been nice to tag me in this (and the other couple of related PRs). That way, I could have given look as well. :blush: -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5632#issuecomment-2662561272 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Update to iD v2.34.0 (PR #6008)
@tyrasd pushed 1 commit. 82c33d461469fd1fe129edba135414b9e11edffc Update to iD v2.34.0 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6008/files/5e3d6ef224c76e17b736555903ec23c906da6c24..82c33d461469fd1fe129edba135414b9e11edffc You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Update to iD v2.34.0 (PR #6008)
Upstream changelog: https://github.com/openstreetmap/iD/releases/tag/v2.34.0 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6008 -- Commit Summary -- * Update to iD v2.34.0 -- File Changes -- A package-lock.json (2716) M vendor/assets/iD/iD.js (962) M vendor/assets/iD/iD/data/address_formats.min.json (2) M vendor/assets/iD/iD/data/imagery.min.json (2) M vendor/assets/iD/iD/img/community-sprite.svg (2) M vendor/assets/iD/iD/img/fa-sprite.svg (2) M vendor/assets/iD/iD/locales/ar-AA.min.json (2) M vendor/assets/iD/iD/locales/ar.min.json (2) M vendor/assets/iD/iD/locales/ast.min.json (2) M vendor/assets/iD/iD/locales/be.min.json (2) M vendor/assets/iD/iD/locales/bg.min.json (2) M vendor/assets/iD/iD/locales/br.min.json (2) M vendor/assets/iD/iD/locales/ca.min.json (2) M vendor/assets/iD/iD/locales/ckb.min.json (2) M vendor/assets/iD/iD/locales/cs.min.json (2) M vendor/assets/iD/iD/locales/cy.min.json (2) M vendor/assets/iD/iD/locales/da.min.json (2) M vendor/assets/iD/iD/locales/de-AT.min.json (2) M vendor/assets/iD/iD/locales/de-CH.min.json (2) M vendor/assets/iD/iD/locales/de.min.json (2) M vendor/assets/iD/iD/locales/el.min.json (2) M vendor/assets/iD/iD/locales/en-AU.min.json (2) M vendor/assets/iD/iD/locales/en-CA.min.json (2) M vendor/assets/iD/iD/locales/en-GB.min.json (2) M vendor/assets/iD/iD/locales/en-IE.min.json (2) M vendor/assets/iD/iD/locales/en-IN.min.json (2) M vendor/assets/iD/iD/locales/en-NZ.min.json (2) M vendor/assets/iD/iD/locales/en-PH.min.json (2) M vendor/assets/iD/iD/locales/en-US.min.json (2) M vendor/assets/iD/iD/locales/en.min.json (2) M vendor/assets/iD/iD/locales/eo.min.json (2) M vendor/assets/iD/iD/locales/es.min.json (2) M vendor/assets/iD/iD/locales/et.min.json (2) M vendor/assets/iD/iD/locales/fa-IR.min.json (2) M vendor/assets/iD/iD/locales/fa.min.json (2) M vendor/assets/iD/iD/locales/fi.min.json (2) M vendor/assets/iD/iD/locales/fil.min.json (2) M vendor/assets/iD/iD/locales/fr-FR.min.json (2) M vendor/assets/iD/iD/locales/fr.min.json (2) M vendor/assets/iD/iD/locales/ga.min.json (2) M vendor/assets/iD/iD/locales/gan.min.json (2) M vendor/assets/iD/iD/locales/gl.min.json (2) M vendor/assets/iD/iD/locales/he-IL.min.json (2) M vendor/assets/iD/iD/locales/he.min.json (2) M vendor/assets/iD/iD/locales/hi.min.json (2) M vendor/assets/iD/iD/locales/hu.min.json (2) M vendor/assets/iD/iD/locales/id.min.json (2) M vendor/assets/iD/iD/locales/index.min.json (2) M vendor/assets/iD/iD/locales/it.min.json (2) M vendor/assets/iD/iD/locales/ja.min.json (2) M vendor/assets/iD/iD/locales/ko.min.json (2) M vendor/assets/iD/iD/locales/lb.min.json (2) M vendor/assets/iD/iD/locales/lv.min.json (2) M vendor/assets/iD/iD/locales/mk.min.json (2) M vendor/assets/iD/iD/locales/ms.min.json (2) M vendor/assets/iD/iD/locales/nl-BE.min.json (2) M vendor/assets/iD/iD/locales/nl-NL.min.json (2) M vendor/assets/iD/iD/locales/nl.min.json (2) M vendor/assets/iD/iD/locales/no.min.json (2) M vendor/assets/iD/iD/locales/pa-PK.min.json (2) M vendor/assets/iD/iD/locales/pa.min.json (2) M vendor/assets/iD/iD/locales/pl.min.json (2) M vendor/assets/iD/iD/locales/pt-BR.min.json (2) M vendor/assets/iD/iD/locales/pt.min.json (2) M vendor/assets/iD/iD/locales/ru.min.json (2) M vendor/assets/iD/iD/locales/sk.min.json (2) M vendor/assets/iD/iD/locales/sr.min.json (2) M vendor/assets/iD/iD/locales/sv.min.json (2) M vendor/assets/iD/iD/locales/th.min.json (2) M vendor/assets/iD/iD/locales/tr.min.json (2) M vendor/assets/iD/iD/locales/uk.min.json (2) M vendor/assets/iD/iD/locales/ur.min.json (2) M vendor/assets/iD/iD/locales/vi.min.json (2) M vendor/assets/iD/iD/locales/yue.min.json (2) M vendor/assets/iD/iD/locales/zh-CN.min.json (2) M vendor/assets/iD/iD/locales/zh-HK.min.json (2) M vendor/assets/iD/iD/locales/zh-TW.min.json (2) M vendor/assets/iD/iD/locales/zh.min.json (2) D vendor/assets/iD/iD/mapillary-js/cover-logo.svg (16) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6008.patch https://github.com/openstreetmap/openstreetmap-website/pull/6008.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6008 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)
Focus iD's iframe element to allow iD to receive keyboard shortcuts directly after loading. This is useful when people want to start adding new elements right away using the shortcuts (`1`, `2`, `3`), to pan/zoom the map using the arrow keys, to open the help dialog `?`, to directly perform operations on a pre-selected map feature, or to use standard browser keyboard navigation (e.g. `tab`) in the editor. This fixes https://github.com/openstreetmap/iD/issues/9828 This PR also contains a fix the annoying false-positive exception on iD's startup, see https://github.com/openstreetmap/openstreetmap-website/pull/5823#discussion_r2035464188 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6083 -- Commit Summary -- * make sure iD's iframe is focused on startup -- File Changes -- M app/assets/javascripts/edit/id.js.erb (3) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6083.patch https://github.com/openstreetmap/openstreetmap-website/pull/6083.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
