Re: [openstreetmap/openstreetmap-website] Login page does not check if a user is logged in (Issue #5441)
> We can add a message to the login page that you're already logged in. And if > there's a referrer, we can add a link to that page. That is a good solution, given the fact the current behavior is useful to some people. > Quite this is behaving as intended but the user has changed context behind > the site's back - the page was rendered in one context with a set of cookies > that indicated the user is logged in and the user then switched to a > different context with different cookies which is not really a supported > thing to do. Just for the record, the change is not "behind the site's back". When switching containers, a new tab is opened and the page is loaded again. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5441#issuecomment-2563582731 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Accessibility issue: links "click here" (Issue #5431)
I have generated a PR to fix this issue. Please review and provide your valuable feedback -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5431#issuecomment-2564004320 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
[openstreetmap/openstreetmap-website] Accessibility issue fixed #5431 (PR #5445)
I have tried to fix the accessibility issue. Instead of click here, resend the confirmation email message has been used You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5445 -- Commit Summary -- * Accessibility issue fixed -- File Changes -- M app/views/confirmations/confirm.html.erb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5445.patch https://github.com/openstreetmap/openstreetmap-website/pull/5445.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5445 You are receiving this because you are subscribed to this thread. Message ID:___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
+:twitter_x => %r{(?:twitter|x)\.com/([a-zA-Z0-9_]+)},
+:vimeo => %r{vimeo.com/([a-zA-Z0-9_]+)},
+:whatsapp => %r{wa\.me/(\d+)},
+:youtube => %r{youtube\.com/@([a-zA-Z0-9_-]+)}
+ }.freeze
+
+ NO_USERNAME_PLATFORMS = %w[discord line skype slack].freeze
+
+ def parsed
+URL_PATTERNS.each do |platform, pattern|
+ username = url.match(pattern)
It's a user's name shown in the URL of some websites' profile page (for
example, in the `https://github.com/nertc` `nertc` is a `username`)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1898344770
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
+<%= t ".social_links.legend" %>
+
+ <%= f.fields_for :social_links do |social_link_form| %>
+
+ <%= social_link_form.text_field :url, :hide_label => true,
:wrapper_class => "col-sm-8" %>
+ <%= social_link_form.check_box :_destroy, :wrapper_class => "d-none
social_link_destroy" %>
+ <%= social_link_form.label :_destroy, t(".social_links.remove"),
:class => "btn btn-outline-primary col-sm-1 align-self-start" %>
+
+ <% end %>
+
+
+<%= link_to "+", "#", :id => "add-social-link", :class => "btn
btn-outline-primary" %>
I had a different logic that needed a link, as I changed logic, I agree with
you, I'll change it to button.
My idea was that `+` sign doesn't require any additional icons and is
intuitive, while `Remove` needs `trash icon` to be intuitive (`-` sign doesn't
always mean removal and sometimes it may be ambiguous). But I agree with you,
maybe it's better to be consistent in this too. Which one do you think is
better, to change `+` sign to `Add` (which will be much easier and less-code
solution) or to change `Remove` to `trash icon` (which may be nicer in terms of
UI, but will require trash icon and, therefore, more code)?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1898348555
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
