[R-pkg-devel] New Package olr 4 NOTES

2019-12-04 Thread Mat Fok via R-package-devel
Hi All,
This is the first time I am trying to upload a package. It is fun learning this 
stuff.
Thank you all for kindly looking at the NOTES.
This is the log I recevied from CRAN volunteers: 
https://win-builder.r-project.org/incoming_pretest/olr_1.0.0.2000_20191129_024844/Windows/00check.log
(I was wondering how to reproduce that log. I have run other things like 
devtools::check())

The package is here: https://github.com/MatHatter/olr_r/tree/master/Rstuff

I will address every problem below:
1. OK. Not misspelled:
Possibly mis-spelled words in DESCRIPTION:
  olr (8:18, 9:20)
2. FIXED thisThe Description field should not start with the package name,
  'This package' or similar.
3. FIXED thisThe Description field contains
  https://pypi.org/project/olr/.
Please enclose URLs in angle brackets (<...>).
4. Don't know how to fix this, unless it is not anything.
The build time stamp is missing.
5. First I took these files out of the folder completely, but then I thought 
that it might be needed for something and .Rhistory probably will be there no 
matter what so I used the function
> usethis::use_build_ignore(c(".Rproj.user", ".gitignore", ".Rhistory"))✔ 
> Setting active project to 'C:/Rstuff/olr'✔ Adding '^\\.gitignore$', 
> '^\\.Rhistory$' to '.Rbuildignore'
but as you see .Rproj.user was already in my .Rbuildignore so I don't know if 
this is going to work.* checking for hidden files and directories ... NOTE
Found the following hidden files and directories:
  .Rhistory
  .gitignore
  .Rproj.user
These were most likely included in error. See section 'Package
structure' in the 'Writing R Extensions' manual.

6. Lastly, I do not know how to fix this. I used the use_gpl3_license() I 
believe.
* checking top-level files ... NOTE
Non-standard files/directories found at top level:
  'LICENSE.md' 'olr.Rproj'
FYI,This is what my .Rbuildignore file looks 
like^olr\.Rproj$^\.Rproj\.user$^LICENSE\.md$^\.gitignore$^\.Rhistory$
Thank you all so much.
From,
Mathew Fok





[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] New Package olr 4 NOTES

2019-12-04 Thread Mat Fok via R-package-devel
Hi,
Thank you. I am wondering why the log would output .Rproj.user when it was 
already in the .Rignorefile. Hope the .Rignore file is correct anyways as I 
have mentioned below.
Thanks,
Mathew


Sent from Yahoo Mail for iPhone


On Wednesday, December 4, 2019, 2:11 PM, Duncan Murdoch 
 wrote:

On 04/12/2019 1:02 p.m., Mat Fok via R-package-devel wrote:
> Hi All,
> This is the first time I am trying to upload a package. It is fun learning 
> this stuff.
> Thank you all for kindly looking at the NOTES.
> This is the log I recevied from CRAN volunteers: 
> https://win-builder.r-project.org/incoming_pretest/olr_1.0.0.2000_20191129_024844/Windows/00check.log
> (I was wondering how to reproduce that log. I have run other things like 
> devtools::check())
> 
> The package is here: https://github.com/MatHatter/olr_r/tree/master/Rstuff
> 
> I will address every problem below:
> 1. OK. Not misspelled:
> Possibly mis-spelled words in DESCRIPTION:
>    olr (8:18, 9:20)
> 2. FIXED thisThe Description field should not start with the package name,
>    'This package' or similar.
> 3. FIXED thisThe Description field contains
>    https://pypi.org/project/olr/.
> Please enclose URLs in angle brackets (<...>).
> 4. Don't know how to fix this, unless it is not anything.
> The build time stamp is missing.

That's a sign that you didn't build the package using "R CMD build" at 
the command line (or one of the R functions that calls it).  Don't use 
tar directly to create it, let R do it (because adding a timestamp is 
not the only thing it does).

If you used a devtools function to build the tarball, then you probably 
did something wrong, but it's hard to say what without seeing the 
command you used.  Or maybe devtools has a bug, but it's pretty widely 
used, so I doubt that.

> 5. First I took these files out of the folder completely, but then I thought 
> that it might be needed for something and .Rhistory probably will be there no 
> matter what so I used the function
>> usethis::use_build_ignore(c(".Rproj.user", ".gitignore", ".Rhistory"))✔ 
>> Setting active project to 'C:/Rstuff/olr'✔ Adding '^\\.gitignore$', 
>> '^\\.Rhistory$' to '.Rbuildignore'
> but as you see .Rproj.user was already in my .Rbuildignore so I don't know if 
> this is going to work.* checking for hidden files and directories ... NOTE
> Found the following hidden files and directories:
>    .Rhistory
>    .gitignore
>    .Rproj.user
> These were most likely included in error. See section 'Package
> structure' in the 'Writing R Extensions' manual.

If you had .Rbuildignore set to ignore them, then R would not put them 
in the tarball.

Duncan Murdoch

> 
> 6. Lastly, I do not know how to fix this. I used the use_gpl3_license() I 
> believe.
> * checking top-level files ... NOTE
> Non-standard files/directories found at top level:
>    'LICENSE.md' 'olr.Rproj'
> FYI,This is what my .Rbuildignore file looks 
> like^olr\.Rproj$^\.Rproj\.user$^LICENSE\.md$^\.gitignore$^\.Rhistory$
> Thank you all so much.
> From,
> Mathew Fok




[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] New Package olr 4 NOTES

2019-12-05 Thread Mat Fok via R-package-devel
I meant .Rbuildignore.


Sent from Yahoo Mail for iPhone


On Thursday, December 5, 2019, 3:19 AM, Martin Maechler 
 wrote:

>>>>> Mat Fok via R-package-devel 
>>>>>    on Wed, 4 Dec 2019 22:25:47 + writes:

    > Hi,
    > Thank you. I am wondering why the log would output .Rproj.user when it 
was already in the .Rignorefile. Hope the .Rignore file is correct anyways as I 
have mentioned below.

If you really use .Rignore then no wonder you have problems.
The correct file name is  .Rbuildignore

Martin

    > Thanks,
    > Mathew




[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] New Package olr 4 NOTES

2019-12-05 Thread Mat Fok via R-package-devel
Hi Max,
Following your comment about, ".Rbuildignore is used by R CMD build to exclude 
some files from the bundled package. If you created the tar.gz file manually, 
then .Rbuildignore was, well, ignored. And .Rproj.user would then have been 
included in the tarball."
I assume that if I create the tar.gz file "automatically" through R and not 
7zip, then the .Rbuildignore is not ignored and I won't have the problem of 
.Rproj.user being included in the tarball:

devtools::build(pkg = "C:/Rstuff/olr", path = NULL, binary = FALSE, vignettes = 
TRUE, manual = FALSE, args = NULL, quiet = FALSE)

√  checking for file 'C:\Rstuff\olr/DESCRIPTION' ...-  preparing 'olr':√  
checking DESCRIPTION meta-information ...-  checking for LF line-endings in 
source and make files and shell scripts-  checking for empty or unneeded 
directories-  building 'olr_1.0.0.2000.tar.gz'   [1] 
"C:/Rstuff/olr_1.0.0.2000.tar.gz"
Thank you very much!





On Thursday, December 5, 2019, 9:25 AM, Max Turgeon  
wrote:

#yiv7416260906 -- P {margin-top:0;margin-bottom:0;}#yiv7416260906 
.Rbuildignore is used by R CMD build to exclude some files from the bundled 
package. If you created the tar.gz file manually, then .Rbuildignore was, well, 
ignored. And .Rproj.user would then have been included in the tarball.





Max Turgeon
Assistant ProfessorDepartment of Statistics
Department of Computer Science
University of Manitobamaxturgeon.ca





From: R-package-devel  on behalf of Mat 
Fok via R-package-devel 
Sent: December 5, 2019 8:17 AM
To: Martin Maechler
Cc: R-package-devel
Subject: Re: [R-pkg-devel] New Package olr 4 NOTES I meant .Rbuildignore.


Sent from Yahoo Mail for iPhone


On Thursday, December 5, 2019, 3:19 AM, Martin Maechler 
 wrote:

>>>>> Mat Fok via R-package-devel 
>>>>>    on Wed, 4 Dec 2019 22:25:47 + writes:

    > Hi,
    > Thank you. I am wondering why the log would output .Rproj.user when it 
was already in the .Rignorefile. Hope the .Rignore file is correct anyways as I 
have mentioned below.

If you really use .Rignore then no wonder you have problems.
The correct file name is  .Rbuildignore

Martin

    > Thanks,
    > Mathew




    [[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel




[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


[R-pkg-devel] Update on olr package

2019-12-08 Thread Mat Fok via R-package-devel
Hi,
MatHatter/olr_r
Thank you all for helping! It has lead me in the right direction. I have 
resolved a lot of the previous .Rbuildignore problems, because I have been 
using R CMD to build the tarball or in other words, I have been using the batch 
files to run the build and checks.
R CMD -as--cran
These are the two problems I am seeing now:
The Description field contains  https://pypi.org/project/olr/.Please enclose 
URLs in angle brackets (<...>).
However, I have already put the brackets there.
Second issue:
* checking PDF version of manual ... WARNINGLaTeX errors when creating PDF 
version.This typically indicates Rd problems.* checking PDF version of manual 
without hyperrefs or index ... ERRORRe-running with no redirection of 
stdout/stderr.* DONEStatus: 1 ERROR, 1 WARNING, 1 NOTE
HOWEVER, when I do R CMD -no--manual I don't have any issues.
Can I make an override to CRAN or how do I address these issues?
Thank you!
[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel