Re: avr5 not found in qemu-avr 9.1.1 on macOS

2024-11-18 Thread Iris Artin
> FYI this works:
> 
> $ qemu-system-avr -M 2009 -cpu avr5-avr-cpu
> -> OK

Aha! Thank you!





Re: avr5 not found in qemu-avr 9.1.1 on macOS

2024-11-18 Thread Philippe Mathieu-Daudé

Hi Iris,

Thanks for this bug report.

On 17/11/24 02:51, Iris Artin wrote:

$ brew install qemu
Warning: qemu 9.1.1 is already installed and up-to-date.
$ qemu-system-avr -version
QEMU emulator version 9.1.1
Copyright (c) 2003-2024 Fabrice Bellard and the QEMU Project developers
$ qemu-system-avr -machine 2009 -cpu help
Available CPUs:
   avr5
   avr51
   avr6
$ qemu-system-avr -machine 2009 -cpu avr5
qemu-system-avr: unable to find CPU model 'avr5'

What am I missing? Thanks!


Gavin, this seems related to your commit:

commit 7db8f7e895bff8b2eac08dfbc977d22a5a9fff36
Author: Gavin Shan 
Date:   Wed Nov 15 09:56:06 2023 +1000

target/avr: Use generic cpu_list()

Before it's applied:

[gshan@gshan q]$ ./build/qemu-system-avr -cpu ?
avr5-avr-cpu
avr51-avr-cpu
avr6-avr-cpu

After it's applied:

[gshan@gshan q]$ ./build/qemu-system-avr -cpu ?
Available CPUs:
  avr5
  avr51
  avr6

FYI this works:

$ qemu-system-avr -M 2009 -cpu avr5-avr-cpu
-> OK

Could you have a look?

Thanks,

Phil.



Re: avr5 not found in qemu-avr 9.1.1 on macOS

2024-11-18 Thread Peter Maydell
On Mon, 18 Nov 2024 at 10:54, Philippe Mathieu-Daudé  wrote:
>
> Hi Iris,
>
> Thanks for this bug report.
>
> On 17/11/24 02:51, Iris Artin wrote:
> > $ brew install qemu
> > Warning: qemu 9.1.1 is already installed and up-to-date.
> > $ qemu-system-avr -version
> > QEMU emulator version 9.1.1
> > Copyright (c) 2003-2024 Fabrice Bellard and the QEMU Project developers
> > $ qemu-system-avr -machine 2009 -cpu help
> > Available CPUs:
> >avr5
> >avr51
> >avr6
> > $ qemu-system-avr -machine 2009 -cpu avr5
> > qemu-system-avr: unable to find CPU model 'avr5'
> >
> > What am I missing? Thanks!
>
> Gavin, this seems related to your commit:
>
> commit 7db8f7e895bff8b2eac08dfbc977d22a5a9fff36
> Author: Gavin Shan 
> Date:   Wed Nov 15 09:56:06 2023 +1000
>
>  target/avr: Use generic cpu_list()
>
>  Before it's applied:
>
>  [gshan@gshan q]$ ./build/qemu-system-avr -cpu ?
>  avr5-avr-cpu
>  avr51-avr-cpu
>  avr6-avr-cpu
>
>  After it's applied:
>
>  [gshan@gshan q]$ ./build/qemu-system-avr -cpu ?
>  Available CPUs:
>avr5
>avr51
>avr6
>
> FYI this works:
>
> $ qemu-system-avr -M 2009 -cpu avr5-avr-cpu
> -> OK

I think the new help output is correct (in the sense that it's
what we intend it to say), and the place we want to get to here
is that -cpu accepts the correct "avr5" name. (We should probably for
back-compat have it also accept the long-form names I guess.)

We don't require "-cpu cortex-a15-arm-cpu" for arm targets,
for instance.

thanks
-- PMM