[PATCH] ui: Optimization dirty rect empty check logic

[lijiejun]

Reduce unnecessary code execution in function qemu_spice_create_update,
such as "int blocks = DIV_ROUND_UP(surface_width(ssd->ds), blksize);"
and "int bpp = surface_bytes_per_pixel(ssd->ds);".

Signed-off-by: lijiejun 
---
 ui/spice-display.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ui/spice-display.c b/ui/spice-display.c
index 6eb98a5a5c..508e35ed0f 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -194,10 +194,6 @@ static void qemu_spice_create_update(SimpleSpiceDisplay 
*ssd)
 int bpp = surface_bytes_per_pixel(ssd->ds);
 uint8_t *guest, *mirror;
 
-if (qemu_spice_rect_is_empty(&ssd->dirty)) {
-return;
-};
-
 dirty_top = g_new(int, blocks);
 for (blk = 0; blk < blocks; blk++) {
 dirty_top[blk] = -1;
@@ -488,7 +484,9 @@ void qemu_spice_display_refresh(SimpleSpiceDisplay *ssd)
 
 WITH_QEMU_LOCK_GUARD(&ssd->lock) {
 if (QTAILQ_EMPTY(&ssd->updates) && ssd->ds) {
-qemu_spice_create_update(ssd);
+if (!qemu_spice_rect_is_empty(&ssd->dirty)) {
+qemu_spice_create_update(ssd);
+}
 ssd->notify++;
 }
 }
-- 
2.25.1

[PATCH] migration: using qapi_free_SocketAddress instead of g_free

[lijiejun]

use unified function qapi_free_SocketAddress to free SocketAddress
object.

Signed-off-by: lijiejun 
---
 migration/migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/migration.c b/migration/migration.c
index 3ce04b2aaf..e78d31bbbf 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -493,7 +493,7 @@ bool migrate_uri_parse(const char *uri, MigrationChannel 
**channel,
 addr->u.socket.type = saddr->type;
 addr->u.socket.u = saddr->u;
 /* Don't free the objects inside; their ownership moved to "addr" */
-g_free(saddr);
+qapi_free_SocketAddress(saddr);
 } else if (strstart(uri, "file:", NULL)) {
 addr->transport = MIGRATION_ADDRESS_TYPE_FILE;
 addr->u.file.filename = g_strdup(uri + strlen("file:"));
-- 
2.25.1

[PATCH] virtio-gpu: Add spaces around operator

[lijiejun]

Fix code style. Operator needs spaces forend sides, and delete line space.

Signed-off-by: lijiejun 
---
 hw/display/virtio-gpu-3d.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 9eb4890..d989648 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
 break;
 case VIRTIO_GPU_CMD_RESOURCE_FLUSH:
 virgl_cmd_resource_flush(g, cmd);
-   break;
+break;
 case VIRTIO_GPU_CMD_RESOURCE_UNREF:
 virgl_cmd_resource_unref(g, cmd);
 break;
@@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
 case VIRTIO_GPU_CMD_GET_CAPSET:
 virgl_cmd_get_capset(g, cmd);
 break;
-
 case VIRTIO_GPU_CMD_GET_DISPLAY_INFO:
 virtio_gpu_get_display_info(g, cmd);
 break;
-- 
1.8.3.1

[PATCH] virtio-gpu: Adjust code space style

[lijiejun]

Fix code style. Operator needs align with eight spaces, and delete line space.

Signed-off-by: lijiejun 
---
 hw/display/virtio-gpu-3d.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 9eb4890..d989648 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
 break;
 case VIRTIO_GPU_CMD_RESOURCE_FLUSH:
 virgl_cmd_resource_flush(g, cmd);
-   break;
+break;
 case VIRTIO_GPU_CMD_RESOURCE_UNREF:
 virgl_cmd_resource_unref(g, cmd);
 break;
@@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
 case VIRTIO_GPU_CMD_GET_CAPSET:
 virgl_cmd_get_capset(g, cmd);
 break;
-
 case VIRTIO_GPU_CMD_GET_DISPLAY_INFO:
 virtio_gpu_get_display_info(g, cmd);
 break;
-- 
1.8.3.1