header not included but used in vl.c

[Toe Dev]

Hello,
 does it have a reason why the file vl.c lacks reference
 #include "qemu/module.h" ?
 but still uses the defines include their(for example the enum value:
MODULE_INIT_OPTS)?
I'm using eclipse so I was notified by the IDE immediately.

Thanks for yours help :)

header not included but used in vl.c

[Toe Dev]

Hello,
 does it have a reason why the file vl.c lacks reference
 #include "qemu/module.h" ?
 but still uses the defines include their(for example the enum value:
MODULE_INIT_OPTS)?
I'm using eclipse so I was notified by the IDE immediately.

Thanks for yours help :)

[Qemu-devel] Greetings qemu folks

[Toe Dev]

I am new in QEMU developing and I have general questions about QEMU source
code as I could not find any guidelines about it.

1) I have no success running qemu in nographic mode.
   The internet says using chardev driver to redirect kernel output to host
OS...
   what is the right way to do that?

2) My main target is to output a lot of this to console cause I new to qemu
and I want fastfeedback on stuff like this. I try start
qemu with -D option but the log files never have been  written
by qemu, but either no success.

3) What is the right way to do logging in qemu for development purposes?

Best Regards,

Yali.

[Qemu-devel] Subject: Re: [PATCH] hw/block/nvme

[Toe Dev]

Hey,
While reviewing I noticed maybe we need to update the spec revision.
In: nvme_class_init(...)

current code  pc->revision=2
change to: pc->revision=3
However not really important I think.. Just for consistency.
When I done reviewing, should it be patched too, How?

cscope redundant chars

[Toe Dev]

add cscope phony(ctags have one) and remove redundancy

diff --git a/Makefile b/Makefile
index 84ef881600..9cf62532f9 100644
--- a/Makefile
+++ b/Makefile
@@ -1005,16 +1005,18 @@ ctags:
rm -f tags
find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +

+.PHONY: cscope
+
+cscope:
+   rm -f cscope.*
+   find $(SRC_PATH) -name "*.[chsS]" -print | sed 's,^\./,,' >
"$(SRC_PATH)/cscope.files"
+   cscope -b -q -k cscope.files
+
 .PHONY: TAGS
 TAGS:
rm -f TAGS
find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +

-cscope:
-   rm -f "$(SRC_PATH)"/cscope.*
-   find "$(SRC_PATH)/" -name "*.[chsS]" -print | sed 's,^\./,,' >
"$(SRC_PATH)/cscope.files"
-   cscope -b -i"$(SRC_PATH)/cscope.files"
-