[PATCH] qemu-options.hx: Update for reboot-timeout parameter
Since ee5d0f89d, -1 is not valid for the value of reboot-timeout. Update
that in qemu-options doc.
Signed-off-by: Han Han
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 793d70ff..6b92a916 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -327,8 +327,8 @@ format(true color). The resolution should be supported by
the SVGA mode, so
the recommended is 320x240, 640x480, 800x640.
A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
-when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
-reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
+when boot failed, then reboot. If @option{reboot-timeout} is not set,
+guest will not reboot by default. Currently Seabios for X86
system support it.
Do strict boot via @option{strict=on} as far as firmware/BIOS
--
2.23.0
[PATCH] qemu-img.texi: Describe data_file and data_file_raw
https://bugzilla.redhat.com/show_bug.cgi?id=1763105
Signed-off-by: Han Han
---
qemu-img.texi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index b5156d6316..44596c2d93 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't
be changed to NOCOW
by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
+@item data_file
+File name of data file that is stored in the image and used as a default for
+opening the image. If the option is used, qcow2 file only stores the metadata
+of the image.
+
+@item data_file_raw
+This option requires @option{data_file}. If this option is set to @code{on},
+qemu will always keep the external data file consistent as a standalone
+read-only raw image. Default value is @code{off}.
+
@end table
@item Other
--
2.20.1
Re: [PATCH] qemu-img.texi: Describe data_file and data_file_raw
On Sat, Oct 19, 2019 at 4:58 AM John Snow wrote:
> CC qemu-block
>
> On 10/18/19 5:59 AM, Han Han wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1763105
> >
> > Signed-off-by: Han Han
> > ---
> > qemu-img.texi | 10 ++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/qemu-img.texi b/qemu-img.texi
> > index b5156d6316..44596c2d93 100644
> > --- a/qemu-img.texi
> > +++ b/qemu-img.texi
> > @@ -763,6 +763,16 @@ file which is COW and has data blocks already, it
> couldn't be changed to NOCOW
> > by setting @code{nocow=on}. One can issue @code{lsattr filename} to
> check if
> > the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
> >
> > +@item data_file
> > +File name of data file that is stored in the image and used as a
> default for
> > +opening the image. If the option is used, qcow2 file only stores the
> metadata
> > +of the image.
> > +
>
> This is a little unclear, and seems to imply the data file is stored
> *IN* the image.
>
> "Optional filename to be used as a data store for this qcow2 file. If
> this option is used, the qcow2 file only stores metadata for this image."
>
Thanks for your advice. I will update it in v2.
>
> > +@item data_file_raw
> > +This option requires @option{data_file}. If this option is set to
> @code{on},
> > +qemu will always keep the external data file consistent as a standalone
> > +read-only raw image. Default value is @code{off}.
> > +
> > @end table
> >
> > @item Other
> >
>
>
--
Best regards,
---
Han Han
Quality Engineer
Redhat.
Email: h...@redhat.com
Phone: +861065339333
[PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
https://bugzilla.redhat.com/show_bug.cgi?id=1763105
Signed-off-by: Han Han
---
qemu-img.texi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index b5156d6316..983c6122f8 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't
be changed to NOCOW
by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
+@item data_file
+File name of data file that is stored in the image and used as a default for
+opening the image. If the option is used, qcow2 file only stores the metadata
+for the image.
+
+@item data_file_raw
+This option requires @option{data_file}. If this option is set to @code{on},
+qemu will always keep the external data file consistent as a standalone
+read-only raw image. Default value is @code{off}.
+
@end table
@item Other
--
2.20.1
[PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
https://bugzilla.redhat.com/show_bug.cgi?id=1763105
Signed-off-by: Han Han
---
qemu-img.texi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index b5156d6316..983c6122f8 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't
be changed to NOCOW
by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
+@item data_file
+File name of data file that is stored in the image and used as a default for
+opening the image. If the option is used, qcow2 file only stores the metadata
+for the image.
+
+@item data_file_raw
+This option requires @option{data_file}. If this option is set to @code{on},
+qemu will always keep the external data file consistent as a standalone
+read-only raw image. Default value is @code{off}.
+
@end table
@item Other
--
2.20.1
Re: [PATCH] scripts: Fix undefinited name 'file' error for python3
Anyone help to review it?
On Tue, Nov 26, 2019 at 1:54 PM Han Han wrote:
> ping
>
> On Wed, Nov 13, 2019 at 9:17 PM Han Han wrote:
>
>> In python3, 'file' is no longer a keyword for file type object. So it
>> will can error when run the scripts by python3:
>>
>> $ python3 ./scripts/vmstate-static-checker.py -s 4.0.json -d 4.1.json
>> Traceback (most recent call last):
>> File "./scripts/vmstate-static-checker.py", line 431, in
>> sys.exit(main())
>> File "./scripts/vmstate-static-checker.py", line 378, in main
>> parser.add_argument('-s', '--src', type=file, required=True,
>> NameError: name 'file' is not defined
>>
>> Replace file type to argparse.FileType('r').
>>
>> Signed-off-by: Han Han
>> ---
>> scripts/vmstate-static-checker.py | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/vmstate-static-checker.py
>> b/scripts/vmstate-static-checker.py
>> index d3467288..14f199a0 100755
>> --- a/scripts/vmstate-static-checker.py
>> +++ b/scripts/vmstate-static-checker.py
>> @@ -375,9 +375,9 @@ def main():
>> help_text = "Parse JSON-formatted vmstate dumps from QEMU in files
>> SRC and DEST. Checks whether migration from SRC to DEST QEMU versions
>> would break based on the VMSTATE information contained within the JSON
>> outputs. The JSON output is created from a QEMU invocation with the
>> -dump-vmstate parameter and a filename argument to it. Other parameters to
>> QEMU do not matter, except the -M (machine type) parameter."
>>
>> parser = argparse.ArgumentParser(description=help_text)
>> -parser.add_argument('-s', '--src', type=file, required=True,
>> +parser.add_argument('-s', '--src', type=argparse.FileType('r'),
>> required=True,
>> help='json dump from src qemu')
>> -parser.add_argument('-d', '--dest', type=file, required=True,
>> +parser.add_argument('-d', '--dest', type=argparse.FileType('r'),
>> required=True,
>> help='json dump from dest qemu')
>> parser.add_argument('--reverse', required=False, default=False,
>> action='store_true',
>> --
>> 2.23.0
>>
>>
>
> --
> Best regards,
> ---
> Han Han
> Quality Engineer
> Redhat.
>
> Email: h...@redhat.com
> Phone: +861065339333
>
--
Best regards,
---
Han Han
Quality Engineer
Redhat.
Email: h...@redhat.com
Phone: +861065339333
Re: [PATCH] scripts: Fix undefinited name 'file' error for python3
On Wed, Dec 4, 2019 at 4:23 PM Thomas Huth wrote:
> On 04/12/2019 07.48, Han Han wrote:
> > Anyone help to review it?
>
> Hi!
>
> When sending patches to the qemu-devel mailing list, please always make
> sure to put the corresponding maintainers on CC:, otherwise your mails
> might get lost in the high traffic of the mailing list. For this case,
> it would have been good to CC: the "Migration" and "Python script"
> maintainers, see the corresponding sections of the MAINTAINERS file in
> the top most directory of the QEMU sources.
>
OK. Thanks for your advice
>
> Anyway, it seems someone else ran into the same issue already, too, and
> it got already fixed here:
>
> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e8d0ac5801edda91412e5
>
> Thomas
>
>
> > On Tue, Nov 26, 2019 at 1:54 PM Han Han > <mailto:h...@redhat.com>> wrote:
> >
> > ping
> >
> > On Wed, Nov 13, 2019 at 9:17 PM Han Han > <mailto:h...@redhat.com>> wrote:
> >
> > In python3, 'file' is no longer a keyword for file type object.
> > So it
> > will can error when run the scripts by python3:
> >
> > $ python3 ./scripts/vmstate-static-checker.py -s 4.0.json -d
> > 4.1.json
> > Traceback (most recent call last):
> > File "./scripts/vmstate-static-checker.py", line 431, in
>
> > sys.exit(main())
> > File "./scripts/vmstate-static-checker.py", line 378, in main
> > parser.add_argument('-s', '--src', type=file, required=True,
> > NameError: name 'file' is not defined
> >
> > Replace file type to argparse.FileType('r').
> >
> > Signed-off-by: Han Han mailto:h...@redhat.com
> >>
> > ---
> > scripts/vmstate-static-checker.py | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/vmstate-static-checker.py
> > b/scripts/vmstate-static-checker.py
> > index d3467288..14f199a0 100755
> > --- a/scripts/vmstate-static-checker.py
> > +++ b/scripts/vmstate-static-checker.py
> > @@ -375,9 +375,9 @@ def main():
> > help_text = "Parse JSON-formatted vmstate dumps from QEMU
> > in files SRC and DEST. Checks whether migration from SRC to
> > DEST QEMU versions would break based on the VMSTATE information
> > contained within the JSON outputs. The JSON output is created
> > from a QEMU invocation with the -dump-vmstate parameter and a
> > filename argument to it. Other parameters to QEMU do not
> > matter, except the -M (machine type) parameter."
> >
> > parser = argparse.ArgumentParser(description=help_text)
> > -parser.add_argument('-s', '--src', type=file, required=True,
> > +parser.add_argument('-s', '--src',
> > type=argparse.FileType('r'), required=True,
> > help='json dump from src qemu')
> > -parser.add_argument('-d', '--dest', type=file,
> required=True,
> > +parser.add_argument('-d', '--dest',
> > type=argparse.FileType('r'), required=True,
> > help='json dump from dest qemu')
> > parser.add_argument('--reverse', required=False,
> default=False,
> > action='store_true',
> > --
> > 2.23.0
> >
> >
> >
> > --
> > Best regards,
> > ---
> > Han Han
> > Quality Engineer
> > Redhat.
> >
> > Email: h...@redhat.com <mailto:h...@redhat.com>
> > Phone: +861065339333
>
>
--
Best regards,
---
Han Han
Quality Engineer
Redhat.
Email: h...@redhat.com
Phone: +861065339333
[PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
accordingly.
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 65c9473b73..e14d88e9b2 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -327,8 +327,8 @@ format(true color). The resolution should be supported by
the SVGA mode, so
the recommended is 320x240, 640x480, 800x640.
A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
-when boot failed, then reboot. If @option{reboot-timeout} is not set,
-guest will not reboot by default. Currently Seabios for X86
+when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
+reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
system support it.
Do strict boot via @option{strict=on} as far as firmware/BIOS
--
2.24.0.rc1
[PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter"
This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
accordingly.
Signed-off-by: Han Han
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 65c9473b..e14d88e9 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -327,8 +327,8 @@ format(true color). The resolution should be supported by
the SVGA mode, so
the recommended is 320x240, 640x480, 800x640.
A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
-when boot failed, then reboot. If @option{reboot-timeout} is not set,
-guest will not reboot by default. Currently Seabios for X86
+when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
+reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
system support it.
Do strict boot via @option{strict=on} as far as firmware/BIOS
--
2.23.0
Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
OK. Updated in version 2.
On Wed, Dec 4, 2019 at 8:21 PM Dr. David Alan Gilbert
wrote:
> * Han Han (h...@redhat.com) wrote:
> > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> Patchew spotted you're missing the signed-off-by; please send one.
>
> Dave
>
> > In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> > accordingly.
> > ---
> > qemu-options.hx | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 65c9473b73..e14d88e9b2 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -327,8 +327,8 @@ format(true color). The resolution should be
> supported by the SVGA mode, so
> > the recommended is 320x240, 640x480, 800x640.
> >
> > A timeout could be passed to bios, guest will pause for
> @var{rb_timeout} ms
> > -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> > -guest will not reboot by default. Currently Seabios for X86
> > +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will
> not
> > +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> > system support it.
> >
> > Do strict boot via @option{strict=on} as far as firmware/BIOS
> > --
> > 2.24.0.rc1
> >
> --
> Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
>
>
--
Best regards,
---
Han Han
Quality Engineer
Redhat.
Email: h...@redhat.com
Phone: +861065339333
[PATCH] qapi: virtio: Fix the introduced version
The items of qapi/virtio.json are introduced at a5ebce38576. They will be
in the version 7.2 not 7.1.
Signed-off-by: Han Han
---
qapi/virtio.json | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/qapi/virtio.json b/qapi/virtio.json
index e47a8fb2e0..872c7e3623 100644
--- a/qapi/virtio.json
+++ b/qapi/virtio.json
@@ -15,7 +15,7 @@
#
# @name: Name of the VirtIODevice
#
-# Since: 7.1
+# Since: 7.2
#
##
{ 'struct': 'VirtioInfo',
@@ -32,7 +32,7 @@
#
# Returns: List of gathered VirtIODevices
#
-# Since: 7.1
+# Since: 7.2
#
# Example:
#
@@ -97,7 +97,7 @@
#
# @log-size: vhost_dev log_size
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -167,7 +167,7 @@
# Present if the given VirtIODevice has an active vhost
# device.
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -206,7 +206,7 @@
#
# Returns: VirtioStatus of the virtio device
#
-# Since: 7.1
+# Since: 7.2
#
# Examples:
#
@@ -452,7 +452,7 @@
#
# @unknown-statuses: Virtio device statuses bitmap that have not been decoded
#
-# Since: 7.1
+# Since: 7.2
##
{ 'struct': 'VirtioDeviceStatus',
@@ -471,7 +471,7 @@
# @unknown-protocols: Vhost user device protocol features bitmap that
# have not been decoded
#
-# Since: 7.1
+# Since: 7.2
##
{ 'struct': 'VhostDeviceProtocols',
@@ -492,7 +492,7 @@
# @unknown-dev-features: Virtio device features bitmap that have not
#been decoded
#
-# Since: 7.1
+# Since: 7.2
##
{ 'struct': 'VirtioDeviceFeatures',
@@ -535,7 +535,7 @@
#
# @signalled-used-valid: VirtQueue signalled_used_valid flag
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -576,7 +576,7 @@
#shadow_avail_idx will not be displayed in the case where
#the selected VirtIODevice has a running vhost device.
#
-# Since: 7.1
+# Since: 7.2
#
# Examples:
#
@@ -666,7 +666,7 @@
#
# @used-size: vhost_virtqueue used_size
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -699,7 +699,7 @@
#
# Returns: VirtVhostQueueStatus of the vhost_virtqueue
#
-# Since: 7.1
+# Since: 7.2
#
# Examples:
#
@@ -767,7 +767,7 @@
#
# @flags: List of descriptor flags
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -787,7 +787,7 @@
#
# @ring: VRingAvail ring[] entry at provided index
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -805,7 +805,7 @@
#
# @idx: VRingUsed index
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -829,7 +829,7 @@
#
# @used: VRingUsed info
#
-# Since: 7.1
+# Since: 7.2
#
##
@@ -857,7 +857,7 @@
#
# Returns: VirtioQueueElement information
#
-# Since: 7.1
+# Since: 7.2
#
# Examples:
#
--
2.38.1
[PATCH] docs: Fix broken links
Signed-off-by: Han Han --- docs/amd-memory-encryption.txt | 4 ++-- docs/pvrdma.txt| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt index 43bf3ee6a5..80b8eb00e9 100644 --- a/docs/amd-memory-encryption.txt +++ b/docs/amd-memory-encryption.txt @@ -95,10 +95,10 @@ References - AMD Memory Encryption whitepaper: -http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf +https://developer.amd.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf Secure Encrypted Virtualization Key Management: -[1] http://support.amd.com/TechDocs/55766_SEV-KM API_Specification.pdf +[1] http://developer.amd.com/wordpress/media/2017/11/55766_SEV-KM-API_Specification.pdf KVM Forum slides: http://www.linux-kvm.org/images/7/74/02x08A-Thomas_Lendacky-AMDs_Virtualizatoin_Memory_Encryption_Technology.pdf diff --git a/docs/pvrdma.txt b/docs/pvrdma.txt index 0f0dd8a7e5..5c122fe818 100644 --- a/docs/pvrdma.txt +++ b/docs/pvrdma.txt @@ -18,7 +18,7 @@ over-commit and, even if not implemented yet, migration support will be possible with some HW assistance. A project presentation accompany this document: -- http://events.linuxfoundation.org/sites/events/files/slides/lpc-2017-pvrdma-marcel-apfelbaum-yuval-shaia.pdf +- https://blog.linuxplumbersconf.org/2017/ocw/system/presentations/4730/original/lpc-2017-pvrdma-marcel-apfelbaum-yuval-shaia.pdf -- 2.27.0
Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again
However, another important question is: how can we avoid such undocumented
incompatibility appears again?
I can show another case caused by such incompatibile change:
https://bugzilla.redhat.com/show_bug.cgi?id=1745868#c0
For the qemu devices, attributes, values, qmp cmds, qmp cmds arguments used
by libvirt, could we get a way to inform libvirt
that an incompatibile qemu change is coming, please update libvirt code
ASAP to adjust to that change?
Or another way that is more gently: popping up the warning of depreciation
instead of dropping it, and then drop it in the version
after next version.
On Tue, Oct 29, 2019 at 1:59 PM Dr. David Alan Gilbert
wrote:
> * Markus Armbruster (arm...@redhat.com) wrote:
> > "Dr. David Alan Gilbert" writes:
> >
> > > * Markus Armbruster (arm...@redhat.com) wrote:
> > >> "Dr. David Alan Gilbert (git)" writes:
> > >>
> > >> > From: "Dr. David Alan Gilbert"
> > >> >
> > >> > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout
> > >> > to only allow the range 0..65535; however both qemu and libvirt
> document
> > >> > the special value -1 to mean don't reboot.
> > >> > Allow it again.
> > >> >
> > >> > Fixes: ee5d0f89de3e53cdb0dc ("fw_cfg: Fix -boot reboot-timeout
> error checking")
> > >> > RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=1765443
> > >> > Signed-off-by: Dr. David Alan Gilbert
> > >> > ---
> > >> > hw/nvram/fw_cfg.c | 5 +++--
> > >> > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >> >
> > >> > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> > >> > index 7dc3ac378e..1a9ec44232 100644
> > >> > --- a/hw/nvram/fw_cfg.c
> > >> > +++ b/hw/nvram/fw_cfg.c
> > >> > @@ -247,10 +247,11 @@ static void fw_cfg_reboot(FWCfgState *s)
> > >> >
> > >> > if (reboot_timeout) {
> > >> > rt_val = qemu_opt_get_number(opts, "reboot-timeout", -1);
> > >> > +
> > >> > /* validate the input */
> > >> > -if (rt_val < 0 || rt_val > 0x) {
> > >> > +if (rt_val < -1 || rt_val > 0x) {
> > >> > error_report("reboot timeout is invalid,"
> > >> > - "it should be a value between 0 and
> 65535");
> > >> > + "it should be a value between -1 and
> 65535");
> > >> > exit(1);
> > >> > }
> > >> > }
> > >>
> > >> Semantic conflict with "PATCH] qemu-options.hx: Update for
> > >> reboot-timeout parameter", Message-Id:
> > >> <20191015151451.727323-1-h...@redhat.com>.
> > >
> > > Thanks for spotting that.
> > > I think Han and also submitted patches to review it from libvirt
> > > and it wasn't obvious what to do. (Cc'd Han in).
> > >
> > >> I'm too tired right now to risk an opinion on which one we want.
> > >
> > > As is everyone else ! The problem here is that its documented
> > > as a valid thing to do, and libvirt does it, and you might have
> > > a current XML file that did it. Now I think you could change libvirt
> > > to omit the reboot-timeout parameter if it was called with -1.
> > >
> > > So given its a documented thing in both qemu and libvirt xml
> > > if we want to remove it then it sohuld be deprecated properly - but
> it's
> > > already broken.
> >
> > Since commit ee5d0f89d, v4.0.0.
> >
> > If that commit had not made it into a release, we'd certainly treat the
> > loss of "-1 means don't reboot" as regression.
> >
> > But it has. We can treat it as a regression anyway. We can also
> > declare "ship has sailed".
> >
> > I'm leaning towads the former.
> >
> > If we restore "-1 means don't reboot", then I don't see a need to
> > deprecate it. Just keep it.
> >
> > What do you think?
>
> That's also my view; especially since the problem seems to be an easy
> fix.
>
> Dave
>
> --
> Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
>
--
Best regards,
---
Han Han
Quality Engineer
Redhat.
Email: h...@redhat.com
Phone: +861065339333
[PATCH] dev-uas: Fix a error of variable sized type not at end
Fix the following error when compiling:
FAILED: libcommon.fa.p/hw_usb_dev-uas.c.o
clang -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader
-I/usr/include/libusb-1.0 -I/usr/include/spice-1 -I/usr/include/spice-server
-I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/libmount
-I/usr/include/blkid -I/usr/include/pixman-1 -I/usr/include/vte-2.91
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/libxml2
-I/usr/include/cairo -I/usr/include/gtk-3.0 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0
-I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0
-I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/SDL2
-I/usr/include/slirp -I/usr/include/virgl -I/usr/include/capstone -Xclang
-fcolor-diagnostics -pipe -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g
-fsanitize=undefined -fsanitize=address -m64 -mcx16 -D_GNU_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
-Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes
-fno-strict-aliasing -fno-common -fwrapv -Wold-style-definition -Wtype-limits
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body
-Wnested-externs -Wendif-labels -Wexpansion-to-defined
-Wno-initializer-overrides -Wno-missing-include-dirs -Wno-shift-negative-value
-Wno-string-plus-int -Wno-typedef-redefinition
-Wno-tautological-type-limit-compare -Wno-psabi -fstack-protector-strong
-fsanitize=fuzzer-no-link -isystem /home/hhan/Software/qemu/linux-headers
-isystem linux-headers -iquote /home/hhan/Software/qemu/tcg/i386 -iquote .
-iquote /home/hhan/Software/qemu -iquote /home/hhan/Software/qemu/accel/tcg
-iquote /home/hhan/Software/qemu/include -iquote
/home/hhan/Software/qemu/disas/libvixl -pthread -fPIC -DSTRUCT_IOVEC_DEFINED
-D_REENTRANT -Wno-undef -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600
-DNCURSES_WIDECHAR -MD -MQ libcommon.fa.p/hw_usb_dev-uas.c.o -MF
libcommon.fa.p/hw_usb_dev-uas.c.o.d -o libcommon.fa.p/hw_usb_dev-uas.c.o -c
../hw/usb/dev-uas.c
../hw/usb/dev-uas.c:158:31: error: field 'status' with variable sized type
'uas_iu' not at the end of a struct or class is a GNU extension
[-Werror,-Wgnu-variable-sized-type-not-at-end]
Signed-off-by: Han Han
---
hw/usb/dev-uas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index cec071d96c..5ef3f4fec9 100644
--- a/hw/usb/dev-uas.c
+++ b/hw/usb/dev-uas.c
@@ -154,9 +154,9 @@ struct UASRequest {
struct UASStatus {
uint32_t stream;
-uas_iustatus;
uint32_t length;
QTAILQ_ENTRY(UASStatus) next;
+uas_iustatus;
};
/* - */
--
2.28.0
Re: [PATCH] target/i386/cpu: Fix notes for CPU models
On Sun, Dec 22, 2024 at 4:59 PM Michael Tokarev wrote: > 19.12.2024 11:51, Han Han wrote: > ... > > Applied to the trivial-patches tree, thank you! > > Please do Cc: qemu-devel@ the next time. > > OK. Thanks for your advice > /mjt > >
