date:20250307

[PATCH v5 00/29] Support AST2700 A1

2025-03-07 Thread Jamin Lin via

v1:
1. Refactor INTC model to support both INTC0 and INTC1.
2. Support AST2700 A1.
3. Create ast2700a0-evb machine.

v2:
To streamline the review process, split the following patch series into
three parts.

https://patchwork.kernel.org/project/qemu-devel/cover/20250121070424.2465942-1-jamin_...@aspeedtech.com/
This patch series focuses on cleaning up the INTC model to
facilitate future support for the INTC_IO model.

v3:
1. Update and add functional test for AST2700
2. Add AST2700 INTC design guidance and its block diagram.
3. Retaining the INTC naming and introducing a new INTCIO model to support the
AST2700 A1.
4. Create ast2700a1-evb machine and rename ast2700a0-evb machine
5. Fix silicon revision issue and support AST2700 A1.

v4:
1. rework functional test for AST2700
2. the initial machine "ast2700-evb" is aliased to "ast2700a0-evb.
3. intc: Reduce regs array size by adding a register sub-region
4. intc: split patch for Support setting different register sizes
5. update ast2700a1-evb machine parent to TYPE_ASPEED_MACHINE

v5:
1. Rename status_addr and addr to status_reg and reg for clarity
2. Introduce dynamic allocation for regs array
3. Sort the memmap table by mapping address
4. ast27x0.c split patch for Support two levels of INTC controllers for
AST2700 A1
5. tests/functional/aspped split patch for Introduce start_ast2700_test API
6. keep variable naming for reviewer suggestion.
7. Add reviewer suggestion and split patch to make more readable.

With the patch applied, QEMU now supports two machines for running AST2700 SoCs:
ast2700a0-evb: Designed for AST2700 A0
ast2700a1-evb: Designed for AST2700 A1

Test information
1. QEMU version:
https://github.com/qemu/qemu/commit/50d38b8921837827ea397d4b20c8bc5efe186e53
2. ASPEED SDK v09.05 pre-built image
https://github.com/AspeedTech-BMC/openbmc/releases/tag/v09.05
ast2700-default-obmc.tar.gz (AST2700 A1)

https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast2700-default-obmc.tar.gz
ast2700-a0-default-obmc.tar.gz (AST2700 A0)

https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast2700-a0-default-obmc.tar.gz

This patch series depends on the following patch series:
https://patchwork.kernel.org/project/qemu-devel/cover/20250303073547.1145080-1-jamin_...@aspeedtech.com/
https://patchwork.kernel.org/project/qemu-devel/cover/20250225075622.305515-1-jamin_...@aspeedtech.com/

Jamin Lin (29):
hw/intc/aspeed: Support setting different memory size
hw/intc/aspeed: Rename status_addr and addr to status_reg and reg for
clarity
hw/intc/aspeed: Introduce dynamic allocation for regs array
hw/intc/aspeed: Support setting different register size
hw/intc/aspeed: Reduce regs array size by adding a register sub-region
hw/intc/aspeed: Introduce helper functions for enable and status
registers
hw/intc/aspeed: Add object type name to trace events for better
debugging
hw/arm/aspeed: Rename IRQ table and machine name for AST2700 A0
hw/arm/aspeed_ast27x0: Sort the IRQ table by IRQ number
hw/intc/aspeed: Support different memory region ops
hw/intc/aspeed: Rename num_ints to num_inpins for clarity
hw/intc/aspeed: Add support for multiple output pins in INTC
hw/intc/aspeed: Refactor INTC to support separate input and output pin
indices
hw/intc/aspeed: Introduce AspeedINTCIRQ structure to save the irq
index and register address
hw/intc/aspeed: Introduce IRQ handler function to reduce code
duplication
hw/intc/aspeed: Add Support for Multi-Output IRQ Handling
hw/intc/aspeed: Add Support for AST2700 INTCIO Controller
hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon
Revisions
hw/arm/aspeed_ast27x0.c Support AST2700 A1 GIC Interrupt Mapping
hw/arm/aspeed_ast27x0: Define an Array of AspeedINTCState with Two
Instances
hw/arm/aspeed_ast27x0: Support two levels of INTC controllers for
AST2700 A1
hw/arm/aspeed_ast27x0: Add SoC Support for AST2700 A1
hw/arm/aspeed: Add Machine Support for AST2700 A1
hw/arm/aspeed_ast27x0: Sort the memmap table by mapping address
tests/functional/aspeed: Introduce start_ast2700_test API
tests/functional/aspeed: Update temperature hwmon path
tests/functional/aspeed: Update test ASPEED SDK v09.05
tests/functional/aspeed: Add test case for AST2700 A1
docs/specs: Add aspeed-intc

Re: [PATCH v5 26/29] tests/functional/aspeed: Update temperature hwmon path

2025-03-07 Thread Cédric Le Goater


On 3/6/25 11:38, Jamin Lin wrote:

Modified the temperature hwmon path to use a wildcard to handle different SDK
versions: "cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input".

Signed-off-by: Jamin Lin 



Reviewed-by: Cédric Le Goater 

Thanks,

C.



---
  tests/functional/test_aarch64_aspeed.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/functional/test_aarch64_aspeed.py 
b/tests/functional/test_aarch64_aspeed.py
index e1ad7fd470..07b0c7c1fd 100755
--- a/tests/functional/test_aarch64_aspeed.py
+++ b/tests/functional/test_aarch64_aspeed.py
@@ -83,11 +83,11 @@ def start_ast2700_test(self, name):
  'echo lm75 0x4d > /sys/class/i2c-dev/i2c-1/device/new_device ',
  'i2c i2c-1: new_device: Instantiated device lm75 at 0x4d');
  exec_command_and_wait_for_pattern(self,
-'cat /sys/class/hwmon/hwmon20/temp1_input', '0')
+'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '0')
  self.vm.cmd('qom-set', path='/machine/peripheral/tmp-test',
  property='temperature', value=18000)
  exec_command_and_wait_for_pattern(self,
-'cat /sys/class/hwmon/hwmon20/temp1_input', '18000')
+'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', 
'18000')
  
  def test_aarch64_ast2700_evb_sdk_v09_03(self):

  self.set_machine('ast2700-evb')

Re: [PATCH 56/57] docs/qapidoc: add intermediate output debugger

2025-03-07 Thread Markus Armbruster

John Snow  writes:

> Add debugging output for the qapidoc transmogrifier - setting DEBUG=1
> will produce .ir files (one for each qapidoc directive) that write the
> generated rst file to disk to allow for easy debugging and verification
> of the generated document.
>
> Signed-off-by: John Snow 

I understand we generally need to examine these .ir files only when
things go wrong, or maybe to help understanding the transmogrifier.  I
guess few people will care, and only rarely.  But when we care, we
likely care a *lot*.  Sure we want to dig the information on how to get
.ir files out of a commit message then?

Re: [PATCH] doc: add missing 'Asset' type in function test doc

2025-03-07 Thread Thomas Huth


On 06/03/2025 07.44, Philippe Mathieu-Daudé wrote:

On 6/3/25 07:07, Aditya Gupta wrote:

Seems 'Asset' got missed in the documentation by mistake.

Also fix the one spellcheck issue pointed by spellcheck

Signed-off-by: Aditya Gupta 
---
  docs/devel/testing/functional.rst | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/ 
functional.rst

index ecc738922b7c..50fca2a0291e 100644
--- a/docs/devel/testing/functional.rst
+++ b/docs/devel/testing/functional.rst
@@ -251,7 +251,7 @@ Many functional tests download assets (e.g. Linux 
kernels, initrds,

  firmware images, etc.) from the internet to be able to run tests with
  them. This imposes additional challenges to the test framework.
-First there is the the problem that some people might not have an
+First there is the problem that some people might not have an
  unconstrained internet connection, so such tests should not be run by
  default when running ``make check``. To accomplish this situation,
  the tests that download files should only be added to the "thorough"
@@ -274,7 +274,9 @@ the tests are run. This pre-caching is done with the 
qemu_test.Asset

  class. To use it in your test, declare an asset in your test class with
  its URL and SHA256 checksum like this::
-    ASSET_somename = (
+    from qemu_test import Asset
+
+    ASSET_somename = Asset(
  ('https://www.qemu.org/assets/images/qemu_head_200.png'),
  '34b74cad46ea28a2966c1d04e102510daf1fd73e6582b6b74523940d5da029dd')


Reviewed-by: Philippe Mathieu-Daudé 


Thanks, queued!

 Thomas

Re: New git repository for Go bindings

2025-03-07 Thread Daniel P . Berrangé

On Fri, Mar 07, 2025 at 01:30:38PM +0100, Victor Toso wrote:
> Hi,
> 
> I've been working on and off in having Go bindings for QEMU's
> QAPI specification. The last version [0] seems to be accepted so
> far but we would like not to have that in qemu.git.
> 
> In the past [1], Daniel suggested creating a repo per each
> generated schema: go-qemu.git, go-qga.git, go-qsd.git
>
> While that works well from the point of view of Go applications
> and is neat organized too, afaict they are all bounded to QEMU's
> release schedule so it might be enough to create a single repo
> such as:
> 
> qapi-generators.git
> └── golang
> ├── module.py # The go generator
> ├── qemu  # For qapi/qapi-schema.json
> │   ├── doc.go
> │   ├── gen_iface_command.go
> │   ├── gen_iface_event.go
> │   ├── gen_type_alternate.go
> │   ├── gen_type_command.go
> │   ├── gen_type_enum.go
> │   ├── gen_type_event.go
> │   ├── gen_type_struct.go
> │   ├── gen_type_union.go
> │   ├── go.mod
> │   ├── protocol.go
> │   └── utils.go
> ├── qga # qga/qapi-schema.json
> └── qsd # storage-daemon/qapi/qapi-schema.json
> 
> Or perhaps a per language repo?

I'd suggest we keep the repo dedicated just for 'go' language, as mixed
language repos are more trouble than they are worth when it comes to
dealing with language specific build tools.


With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 0/5] ppc/amigaone patches

2025-03-07 Thread BALATON Zoltan


On Thu, 27 Feb 2025, BALATON Zoltan wrote:

Hello,

v2:
- change unused read function to g_assert_not_reached()
- new patch to add defines to constants
- added R-b tags


Ping? Will there be a pull request for soft freeze with this series 
included or do I need to do anything with this?


Regards,
BALATON Zoltan


This series adds NVRAM and support for -kernel, -initrd and -append
options to the amigaone machine. This makes it easier to boot AmigaOS
and avoids a crash in the guest when it tries to access NVRAM.

While the -kernel option emulates what U-Boot passes to the kernel,
old Linux kernels for amigaone may not work with it because of two
reasons: these come in legacy U-Boot Multi-File image format that QEMU
cannot read and even after unpacking that and creating a kernel uimage
it won't find PCI devices because it does not initialise them
correctly. This works when booted from U-Boot because U-Boot inits PCI
devices. So does my BBoot loader which can be used to load AmigaOS so
I don't intend to emulate that part of U-Boot.

I'd like this to be merged for the next release please. When merging
please update https://wiki.qemu.org/ChangeLog/10.0 with the following:

amigaone

Added support for NVRAM and -kernel, -initrd, -append command line
options. By default the NVRAM contents are not preserved between
sessions. To make it persistent create a backing file with 'qemu-image
create -f raw nvram.bin 4k' and add -drive
if=mtd,format=raw,file=nvram.bin to keep NVRAM contents in the backing
file so settings stored in it will be preserved between sessions.

To run AmigaOS with BBoot using the -kernel option at least BBoot
version 0.8 is needed. Older BBoot versions only work with -device
loader and cannot be used with -kernel on amigaone.

Regards,

BALATON Zoltan (5):
 ppc/amigaone: Simplify replacement dummy_fw
 ppc/amigaone: Implement NVRAM emulation
 ppc/amigaone: Add default environment
 ppc/amigaone: Add kernel and initrd support
 ppc/amigaone: Add #defines for memory map constants

hw/ppc/amigaone.c | 284 +++---
1 file changed, 271 insertions(+), 13 deletions(-)

[PATCH v3 2/3] bsd-user: Propagate alignment argument to mmap_find_vma()

2025-03-07 Thread Philippe Mathieu-Daudé

Propagate the alignment to mmap_find_vma(), effectively
embedding mmap_find_vma_aligned() within mmap_find_vma().

Since we ignore the alignment in do_bsd_shmat(), leave a
FIXME comment.

Signed-off-by: Philippe Mathieu-Daudé 
---
 bsd-user/bsd-mem.h |  2 +-
 bsd-user/qemu.h|  2 +-
 bsd-user/mmap.c| 10 ++
 3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h
index f5ec0de24ca..87219da2919 100644
--- a/bsd-user/bsd-mem.h
+++ b/bsd-user/bsd-mem.h
@@ -372,7 +372,7 @@ static inline abi_long do_bsd_shmat(int shmid, abi_ulong 
shmaddr, int shmflg)
 } else {
 abi_ulong mmap_start;
 
-mmap_start = mmap_find_vma(0, shm_info.shm_segsz);
+mmap_start = mmap_find_vma(0, shm_info.shm_segsz, 0 /* FIXME??? 
*/);
 
 if (mmap_start == -1) {
 return -TARGET_ENOMEM;
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 4e97c796318..0b3bd65b180 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -242,7 +242,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong 
old_size,
abi_ulong new_addr);
 int target_msync(abi_ulong start, abi_ulong len, int flags);
 extern abi_ulong mmap_next_start;
-abi_ulong mmap_find_vma(abi_ulong start, abi_ulong size);
+abi_ulong mmap_find_vma(abi_ulong start, abi_ulong size, abi_ulong alignment);
 void mmap_reserve(abi_ulong start, abi_ulong size);
 void TSA_NO_TSA mmap_fork_start(void);
 void TSA_NO_TSA mmap_fork_end(int child);
diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
index 28d7e387a20..da22fcc7c41 100644
--- a/bsd-user/mmap.c
+++ b/bsd-user/mmap.c
@@ -275,8 +275,7 @@ static abi_ulong mmap_find_vma_reserved(abi_ulong start, 
abi_ulong size,
  * It must be called with mmap_lock() held.
  * Return -1 if error.
  */
-static abi_ulong mmap_find_vma_aligned(abi_ulong start, abi_ulong size,
-   abi_ulong alignment)
+abi_ulong mmap_find_vma(abi_ulong start, abi_ulong size, abi_ulong alignment)
 {
 void *ptr, *prev;
 abi_ulong addr;
@@ -395,11 +394,6 @@ static abi_ulong mmap_find_vma_aligned(abi_ulong start, 
abi_ulong size,
 }
 }
 
-abi_ulong mmap_find_vma(abi_ulong start, abi_ulong size)
-{
-return mmap_find_vma_aligned(start, size, 0);
-}
-
 /* NOTE: all the constants are the HOST ones */
 abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
  int flags, int fd, off_t offset)
@@ -496,7 +490,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int 
prot,
 if ((flags & MAP_ALIGNMENT_MASK) != 0) {
 alignment = (flags & MAP_ALIGNMENT_MASK) >> MAP_ALIGNMENT_SHIFT;
 }
-start = mmap_find_vma_aligned(real_start, host_len, alignment);
+start = mmap_find_vma(real_start, host_len, alignment);
 if (start == (abi_ulong)-1) {
 errno = ENOMEM;
 goto fail;
-- 
2.47.1

1 2 3 4 5 >

1 - 100 of 441 matches

Mail list logo