Re: [PATCH 0/4] python: update linting for new mypy/pylint releases

[John Snow]

On Wed, Nov 6, 2024 at 4:57 AM Kevin Wolf  wrote:

> Am 01.11.2024 um 18:36 hat John Snow geschrieben:
> > Various python tests in the "check-python-tox" test case on GitLab have
> > begun failing due to newer package versions. This patch set corrects
> > those issues and also improves the reliability of local developer tests
> > which may be using these tooling versions outside of GitLab pinned
> > version tests.
> >
> > There are remaining issues with the "check-dev" test I have yet to
> > rectify, but appear unrelated to linter versions specifically and will
> > be handled separately.
> >
> > As a result of this patch, the optionally-run and may-fail
> > "check-python-tox" test case on GitLab will become green again, and
> > local invocations of "make check-tox" in the python subdirectory will
> > also pass again. "check-python-minreqs" on GitLab and "make
> > check-minreqs" in the local developer environment were/are
> > unaffected. local iotest invocations for test case #297 ought to now
> > begin passing on developer workstations with bleeding-edge python
> > packages.
> >
> > John Snow (4):
> >   iotests: reflow ReproducibleTestRunner arguments
> >   iotests: correct resultclass type in ReproducibleTestRunner
> >   python: disable too-many-positional-arguments warning
> >   python: silence pylint raising-non-exception error
>
> Thanks, applied to the block branch.
>

Thank you!


>
> (Yes, of course I had to wait until I ran into the problem patch 2 fixes
> myself, and after figuring out the fix from the incomprehensible error
> message, I found that this series already contains it.)
>

Sorry O:-)

The only issue remaining I'm aware of (besides the broader problem of
iotests not using pinned versions yet) is that "make check-dev" is failing
due to (maybe?) some changes in bleeding edge setuptools (?) that impact
how editable packages are installed. That test is only ever manually run
and developer-local though, so I think it shouldn't get in anyone's way but
mine.

If there's something else you're noticing, I'm unaware of it atm and you
should definitely let me know about it.


>
> Kevin
>
>

[RFC PATCH 1/5] hw/nvme/ctrl: specify the 'valid' field in MemoryRegionOps

[Tomoyuki HIROSE]

'valid' field in MemoryRegionOps struct indicates how the MemoryRegion
can be accessed by the guest. In the previous code, the 'valid' field
was not specified explicitly. As a result, the CMB area could only be
accessed in units of 4 bytes.

This commit specifies the 'valid' field in MemoryRegionOps of CMB and
the CMB area can be accessed in units of 8 bytes.

Signed-off-by: Tomoyuki HIROSE 
---
 hw/nvme/ctrl.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 8e4612e035..acbd10628f 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -8166,6 +8166,11 @@ static const MemoryRegionOps nvme_cmb_ops = {
 .min_access_size = 1,
 .max_access_size = 8,
 },
+.valid = {
+.unaligned = true,
+.min_access_size = 1,
+.max_access_size = 8,
+},
 };
 
 static bool nvme_check_params(NvmeCtrl *n, Error **errp)
-- 
2.43.0

Re: [PATCH v7 0/3] vhost-user-blk: live resize additional APIs

[Vladimir Sementsov-Ogievskiy]

On 06.11.24 21:17, Michael S. Tsirkin wrote:

On Wed, Nov 06, 2024 at 02:18:34PM +0300, Vladimir Sementsov-Ogievskiy wrote:

v7: update QAPI version 9.1 -> 9.2




Not like this. ypur patches are merged, pls post a fix patch on top.
Thanks!


Ah, missed this. Ok.




Vladimir Sementsov-Ogievskiy (3):
   qdev-monitor: add option to report GenericError from find_device_state
   vhost-user-blk: split vhost_user_blk_sync_config()
   qapi: introduce device-sync-config

  hw/block/vhost-user-blk.c | 27 ++--
  hw/virtio/virtio-pci.c|  9 +++
  include/hw/qdev-core.h|  6 +
  qapi/qdev.json| 24 ++
  system/qdev-monitor.c | 53 ---
  5 files changed, 108 insertions(+), 11 deletions(-)

--
2.34.1




--
Best regards,
Vladimir

[PATCH] qapi: fix device-sync-config since-version

[Vladimir Sementsov-Ogievskiy]

Actually it comes in 9.2, not 9.1.

Fixes: 3f98408e2e ("qapi: introduce device-sync-config")
Signed-off-by: Vladimir Sementsov-Ogievskiy 
---
 qapi/qdev.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/qdev.json b/qapi/qdev.json
index 2a581129c9..25cbcf977b 100644
--- a/qapi/qdev.json
+++ b/qapi/qdev.json
@@ -182,7 +182,7 @@
 #
 # @unstable: The command is experimental.
 #
-# Since: 9.1
+# Since: 9.2
 ##
 { 'command': 'device-sync-config',
   'features': [ 'unstable' ],
-- 
2.34.1