Re: [Python-Dev] Update on labels to be used on GitHub

2017-02-14 Thread Brett Cannon 
On Mon, 13 Feb 2017 at 14:43 Victor Stinner 
wrote:

> 2017-02-13 21:08 GMT+01:00 Brett Cannon :
> > We now have two sets of labels for representing cherry-picking statuses:
> > "backport to N.M" and "cherry-pick for N.M". The former are to help keep
> > track of what branches a PR should be cherry-picked to and can be removed
> > once the PR for a cherry-pick has been created (you can add a comment
> like
> > "cherry-picked from GH-NN" to make the link between the PRs).
>
> The first time I looked at the "backport to 3.6" flag, I understood
> that the change was written on the 3.6 branch and asked to rebase the
> change on 3.6. If I was confused, I'm sure that someone else will be
> confused as well :-)
>
> What do you think of renaming the label to "need 3.6 backport" (or
> "need backport to 3.6")?
>

That's fine by me. Anyone else have an opinion?
___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Update on labels to be used on GitHub

2017-02-14 Thread Zachary Ware 
On Tue, Feb 14, 2017 at 11:32 AM, Brett Cannon  wrote:
> On Mon, 13 Feb 2017 at 14:43 Victor Stinner 
> wrote:
>>
>> 2017-02-13 21:08 GMT+01:00 Brett Cannon :
>> > We now have two sets of labels for representing cherry-picking statuses:
>> > "backport to N.M" and "cherry-pick for N.M". The former are to help keep
>> > track of what branches a PR should be cherry-picked to and can be
>> > removed
>> > once the PR for a cherry-pick has been created (you can add a comment
>> > like
>> > "cherry-picked from GH-NN" to make the link between the PRs).
>>
>> The first time I looked at the "backport to 3.6" flag, I understood
>> that the change was written on the 3.6 branch and asked to rebase the
>> change on 3.6. If I was confused, I'm sure that someone else will be
>> confused as well :-)
>>
>> What do you think of renaming the label to "need 3.6 backport" (or
>> "need backport to 3.6")?
>
>
> That's fine by me. Anyone else have an opinion?

To propose another color for the bikeshed, what about having labels
for each branch along with "needs backport" and "cherry-pick" labels?
PRs that should be backported get "needs backport" and each branch
that should get the patch, and cherry-pick PRs get exactly one branch
label and the "cherry-pick" label.  I think this would make it easier
to see which branch a particular PR is against from the PR list.

-- 
Zach
___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Update on labels to be used on GitHub

2017-02-14 Thread Victor Stinner 
2017-02-14 18:43 GMT+01:00 Zachary Ware :
> To propose another color for the bikeshed, what about having labels
> for each branch along with "needs backport" and "cherry-pick" labels?

Oh right, labels have colors. I propose pink for "needs backport" and
yellow for "cherry-pick"!

Just kidding, sorry ;-)

Victor
___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Update on labels to be used on GitHub

2017-02-14 Thread MRAB 

On 2017-02-14 17:58, Victor Stinner wrote:

2017-02-14 18:43 GMT+01:00 Zachary Ware :

To propose another color for the bikeshed, what about having labels
for each branch along with "needs backport" and "cherry-pick" labels?


Oh right, labels have colors. I propose pink for "needs backport" and
yellow for "cherry-pick"!

Just kidding, sorry ;-)


Surely the colour for "cherry-pick" should be the colour of cherries! :-)

___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Update on labels to be used on GitHub

2017-02-14 Thread Brett Cannon 
On Tue, 14 Feb 2017 at 10:13 MRAB  wrote:

> On 2017-02-14 17:58, Victor Stinner wrote:
> > 2017-02-14 18:43 GMT+01:00 Zachary Ware :
> >> To propose another color for the bikeshed, what about having labels
> >> for each branch along with "needs backport" and "cherry-pick" labels?
> >
> > Oh right, labels have colors. I propose pink for "needs backport" and
> > yellow for "cherry-pick"!
> >
> > Just kidding, sorry ;-)
> >
> Surely the colour for "cherry-pick" should be the colour of cherries! :-)
>

Since the wording keeps throwing people I have renamed "backport to N.M" to
"needs backport to N.M". I left the "cherry-pick for N.M" labels but made
them a shade of pink (I associate cherry red with "bug" too much to switch
over to red entirely :) .
___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Python-Dev Digest

2017-02-14 Thread 陈 氏 
help


From: Python-Dev  on 
behalf of [email protected] 
Sent: Wednesday, February 15, 2017 1:00:05 AM
To: [email protected]
Subject: Python-Dev Digest, Vol 163, Issue 20

Send Python-Dev mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
https://mail.python.org/mailman/listinfo/python-dev
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Python-Dev digest..."


Today's Topics:

   1. Re: [Python-checkins] [python/cpython] 4538dd: Fix bpo-29528
  Use a secure variable to stop spam (... (Brett Cannon)
   2. Re: [Python-checkins] [python/cpython] 4538dd: Fix bpo-29528
  Use a secure variable to stop spam (... (Berker Peksa?)
   3. Heads-up, I've rejoined (Eric S. Raymond)
   4. Update on labels to be used on GitHub (Brett Cannon)
   5. Re: Update on labels to be used on GitHub (Victor Stinner)


--

Message: 1
Date: Mon, 13 Feb 2017 17:54:51 +
From: Brett Cannon 
To: [email protected], [email protected]
Cc: [email protected]
Subject: Re: [Python-Dev] [Python-checkins] [python/cpython] 4538dd:
Fix bpo-29528 Use a secure variable to stop spam (...
Message-ID:

Content-Type: text/plain; charset="utf-8"

On Mon, 13 Feb 2017 at 07:10 Barry Warsaw  wrote:

> On Feb 11, 2017, at 08:11 PM, Andrew M. Kuchling wrote:
>
> >Are we planning to include the diffs in python-checkins e-mail, or are
> >they gone for good?
> >
> >(While they made the list's messages and digests larger, I liked
> >having the diffs because you could page through them to see what
> >changes were made without having to go through to another site.)
>
> Yep, this was recently discussed and I think the plan is to bring them back
> for python-checkins, but that it's not possible to enable them on PRs due
> to
> GH limitations.
>

Serhiy asked about it and I said that the email integration we are using
from GitHub doesn't allow for customizing the email it sends out beyond how
is listed in the From line. If people find a different integration that
they want to use for sending email then that can be set up.
-- next part --
An HTML attachment was scrubbed...
URL: 


--

Message: 2
Date: Mon, 13 Feb 2017 21:25:34 +0300
From: Berker Peksa? 
To: Python Dev , [email protected]
Subject: Re: [Python-Dev] [Python-checkins] [python/cpython] 4538dd:
Fix bpo-29528 Use a secure variable to stop spam (...
Message-ID:

Content-Type: text/plain; charset=UTF-8

--Berker


On Mon, Feb 13, 2017 at 8:54 PM, Brett Cannon  wrote:
>
>
> On Mon, 13 Feb 2017 at 07:10 Barry Warsaw  wrote:
>>
>> On Feb 11, 2017, at 08:11 PM, Andrew M. Kuchling wrote:
>>
>> >Are we planning to include the diffs in python-checkins e-mail, or are
>> >they gone for good?
>> >
>> >(While they made the list's messages and digests larger, I liked
>> >having the diffs because you could page through them to see what
>> >changes were made without having to go through to another site.)
>>
>> Yep, this was recently discussed and I think the plan is to bring them
>> back
>> for python-checkins, but that it's not possible to enable them on PRs due
>> to
>> GH limitations.
>
>
> Serhiy asked about it and I said that the email integration we are using
> from GitHub doesn't allow for customizing the email it sends out beyond how
> is listed in the From line. If people find a different integration that they
> want to use for sending email then that can be set up.

I wrote a webhook that includes diffs: An example output can be seen
at https://github.com/python/core-workflow/issues/24#issuecomment-279162079
Since it listens all 'push' events, it's possible to catch all commits
and send them to python-checkins.

--Berker


--

Message: 3
Date: Mon, 13 Feb 2017 14:05:55 -0500 (EST)
From: [email protected] (Eric S. Raymond)
To: [email protected]
Subject: [Python-Dev] Heads-up, I've rejoined
Message-ID: <[email protected]>

Some of the older Pythonistas will remember my previous time on this
list, and possibly that I faded away quietly under time pressure from
other projects and the whole being-famous nonsense.

I'm back, for now primarily to listen. I have some questions about the
future direction of Python which I'll bring up when I have time for
the vigorous discussion that will certainly ensue.
--
>>esr>>


--

Message: 4
Date: Mon, 13 Feb 2017 20:08:55 +
From: Brett Cannon 
To: pyth