Re: [Python-Dev] Generate all Argument Clinic code into separate files

2015-02-22 Thread Serhiy Storchaka 

On 22.02.15 05:03, Nick Coghlan wrote:

On 22 February 2015 at 06:58, Brett Cannon  wrote:

+1 to moving to a separate file for all .c files. Might be painful now but
the long-terms benefits are worth it.


Yeah, agreed. Originally I was a fan of having everything inline so I
could see them while I was working on the code, but I eventually
changed my mind to favour making it a clearer build step with a
separate generated file. I suspect it was a matter of starting to
trust AC to do the right thing, so having it implicitly asking me to
check its work all the time ultimately become annoying rather than
reassuring :)


OK. Opened an issue: https://bugs.python.org/issue23501


___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] cpython: Issue #23152: Renames attribute_data_to_stat to _Py_attribute_data_to_stat

2015-02-22 Thread Steve Dower 
Why does it do that?

Top-posted from my Windows Phone

From: Serhiy Storchaka
Sent: ‎2/‎21/‎2015 22:57
To: [email protected]
Subject: Re: [Python-Dev] cpython: Issue #23152: Renames attribute_data_to_stat 
to _Py_attribute_data_to_stat

On 22.02.15 01:26, Steve Dower wrote:
> Thanks! Fixed now.

Clinic removes the declaration of _Py_time_t_to_FILE_TIME.


___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/steve.dower%40microsoft.com
___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] cpython: Issue #23152: Renames attribute_data_to_stat to _Py_attribute_data_to_stat

2015-02-22 Thread Serhiy Storchaka 

On 22.02.15 16:12, Steve Dower wrote:

Why does it do that?


Because it is in the section of generated code.


___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] cpython: Issue #23152: Renames attribute_data_to_stat to _Py_attribute_data_to_stat

2015-02-22 Thread Steve Dower 
Ah, that makes sense. Feel free to move it up a few lines (or into a header if 
that's preferred) if it's bothering you. Otherwise I can do it in about 6-8 
hours.

Cheers,
Steve

Top-posted from my Windows Phone

From: Serhiy Storchaka
Sent: ‎2/‎22/‎2015 7:29
To: [email protected]
Subject: Re: [Python-Dev] cpython: Issue #23152: Renames attribute_data_to_stat 
to _Py_attribute_data_to_stat

On 22.02.15 16:12, Steve Dower wrote:
> Why does it do that?

Because it is in the section of generated code.


___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/steve.dower%40microsoft.com
___
Python-Dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com