Re: [Python-Dev] [Python-checkins] cpython: Issue #11651: Move options for running tests into a Python script.
Thanks for catching that. Fixed in 0b52b6f1bfab. Nadeem ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-checkins] cpython (3.2): Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug.
R. David Murray wrote: > On Tue, 02 Aug 2011 01:22:03 +0200, stefan.krah > wrote: > > Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug. > > See: https://bugzilla.redhat.com/show_bug.cgi?id=726536 > > [email protected](linux_distribution()[0] == 'Fedora', "Fedora > > setlocale() " > > + "bug: > > https://bugzilla.redhat.com/show_bug.cgi?id=726536";) > > Why 'Fedora'? This bug affects more than just Fedora: as I reported on > the issue, I'm seeing it on Gentoo as well. (Also, including the issue > number in the commit message is helpful). > > Note that since the bug report says that "Gentoo has been including this > fix for two years", the fact that it is failing on my Gentoo system > would seem to indicate that something about the fix is not right. > > So, I'm not sure this skip is even valid. I'm not sure we've finished > diagnosing the bug. Fedora's glibc has an additional issue with the Turkish 'I' that can be reproduced by the simple C program in: https://bugzilla.redhat.com/show_bug.cgi?id=726536 I disabled the test specifically on Fedora because it a) seems to be the only Linux buildbot where this test fails and b) this does not seem like a Python issue to me. Since you say that the fix for issue #1813 might not be right, do you think that the fix should work around this glibc issue? > If there are any helpful tests I can run on Gentoo, please let me know. Yes, you could run the small test program. If you get the same results as on Fedora, then I wonder why the Gentoo buildbots are green. Do they have tr_TR and tr_TR.iso88599 installed? Stefan Krah ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-checkins] cpython (3.2): Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug.
On 2 Aug, 2011, at 4:22, R. David Murray wrote: > On Tue, 02 Aug 2011 01:22:03 +0200, stefan.krah > wrote: >> http://hg.python.org/cpython/rev/68b5f87566fb >> changeset: 71683:68b5f87566fb >> branch: 3.2 >> parent: 71679:1f9ca1819d7c >> user:Stefan Krah >> date:Tue Aug 02 01:06:16 2011 +0200 >> summary: >> Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug. >> See: https://bugzilla.redhat.com/show_bug.cgi?id=726536 >> >> files: >> Lib/test/test_locale.py | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> >> diff --git a/Lib/test/test_locale.py b/Lib/test/test_locale.py >> --- a/Lib/test/test_locale.py >> +++ b/Lib/test/test_locale.py >> @@ -1,4 +1,5 @@ >> from test.support import run_unittest, verbose >> +from platform import linux_distribution >> import unittest >> import locale >> import sys >> @@ -391,6 +392,8 @@ >> # crasher from bug #7419 >> self.assertRaises(locale.Error, locale.setlocale, 12345) >> >> [email protected](linux_distribution()[0] == 'Fedora', "Fedora >> setlocale() " >> + "bug: >> https://bugzilla.redhat.com/show_bug.cgi?id=726536";) >> def test_getsetlocale_issue1813(self): >> # Issue #1813: setting and getting the locale under a Turkish locale >> oldlocale = locale.setlocale(locale.LC_CTYPE) > > Why 'Fedora'? This bug affects more than just Fedora: as I reported on > the issue, I'm seeing it on Gentoo as well. (Also, including the issue > number in the commit message is helpful). > > Note that since the bug report says that "Gentoo has been including this > fix for two years", the fact that it is failing on my Gentoo system > would seem to indicate that something about the fix is not right. > > So, I'm not sure this skip is even valid. I'm not sure we've finished > diagnosing the bug. > > If there are any helpful tests I can run on Gentoo, please let me know. Wouldn't it be better to mark this as an expected failure on the affected platforms? Skipping the test unconditionally will skip the test even when Fedora gets around to fixing this issue. Ronald > > -- > R. David Murray http://www.bitdance.com > ___ > Python-Dev mailing list > [email protected] > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/ronaldoussoren%40mac.com smime.p7s Description: S/MIME cryptographic signature ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-checkins] cpython (3.2): Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug.
Stefan Krah wrote:
> Fedora's glibc has an additional issue with the Turkish 'I' that can
> be reproduced by the simple C program in:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=726536
OK, this runs successfully on Ubuntu Lucid and FreeBSD (if you change
the first tr_TR to tr_TR.UTF-8).
But it fails on Debian lenny, as does test_getsetlocale_issue1813().
I suspect many buildbots are green because they don't have tr_TR and
tr_TR.iso8859-9 installed.
Synopsis for the people who don't want to wade through the bug reports:
If this is a valid C program ...
#include
#include
int
main(void)
{
char *s;
printf("%s\n", setlocale(LC_CTYPE, "tr_TR"));
printf("%s\n", setlocale(LC_CTYPE, NULL));
s = setlocale(LC_CTYPE, "tr_TR.ISO8859-9");
printf("%s\n", s ? s : "null");
return 0;
}
..., several systems (Fedora 14, Debian lenny) have a glibc bug that
is exposed by test_getsetlocale_issue1813(). People usually don't
see this because tr_TR and tr_TR.iso8859-9 aren't installed.
Stefan Krah
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-checkins] cpython (3.2): Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug.
On 8/2/2011 4:48 AM, Stefan Krah wrote: > R. David Murray wrote: >> If there are any helpful tests I can run on Gentoo, please let me know. > > Yes, you could run the small test program. If you get the same results > as on Fedora, then I wonder why the Gentoo buildbots are green. > > Do they have tr_TR and tr_TR.iso88599 installed? Highly doubtful. It is a normal part of the Gentoo install process to select the locales that you want for the system. Even the example list of locales doesn't include any Turkish locales, so one would've had to gone to specific effort to add that one. -- Scott Dial [email protected] ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-checkins] cpython (3.2): Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug.
On Tue, 02 Aug 2011 12:12:37 +0200, Stefan Krah wrote:
> Stefan Krah wrote:
> > Fedora's glibc has an additional issue with the Turkish 'I' that can
> > be reproduced by the simple C program in:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=726536
>
> OK, this runs successfully on Ubuntu Lucid and FreeBSD (if you change
> the first tr_TR to tr_TR.UTF-8).
>
> But it fails on Debian lenny, as does test_getsetlocale_issue1813().
>
> I suspect many buildbots are green because they don't have tr_TR and
> tr_TR.iso8859-9 installed.
This is true for my Gentoo buildbots. Once we've figured out the
best way to handle this, I'll fix that (install the other locales) for
my two.
> Synopsis for the people who don't want to wade through the bug reports:
>
> If this is a valid C program ...
>
> #include
> #include
> int
> main(void)
> {
> char *s;
> printf("%s\n", setlocale(LC_CTYPE, "tr_TR"));
> printf("%s\n", setlocale(LC_CTYPE, NULL));
> s = setlocale(LC_CTYPE, "tr_TR.ISO8859-9");
> printf("%s\n", s ? s : "null");
> return 0;
> }
>
> ..., several systems (Fedora 14, Debian lenny) have a glibc bug that
> is exposed by test_getsetlocale_issue1813(). People usually don't
> see this because tr_TR and tr_TR.iso8859-9 aren't installed.
I get null as the final output of that regardless of whether I use
'tr_TR' or 'tr_TR.utf8'.
This is with glibc-2.13-r2 (the r2 is Gentoo's mod number).
I'll attach this to the bug report, too, perhaps the discussion should
move there.
--
R. David Murray http://www.bitdance.com
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] cpython (3.2): Fix closes Issue12676 - Invalid identifier used in TypeError message in
On Tue, 02 Aug 2011 12:33:55 +0200
senthil.kumaran wrote:
> raise TypeError("data should be a bytes-like object\
> -or an iterable, got %r " % type(it))
> +or an iterable, got %r " % type(data))
There are still a lot of spaces in your message. You should use string
literal concatenation instead:
raise TypeError(
"data should be a bytes-like object "
"or an iterable, got %r"
% type(data))
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] email-6.0.0.a1
On 19/07/2011 22:21, R. David Murray wrote: The basic additional API is that a 'source' attribute contains the text the generator read from the input source, and a 'value' attribute that contains the value with all the Content-Transfer-Encoding stuff undone so that you have a real unicode string. By changing a policy setting, you can have that value as the string value of the header. You can also assign a string with non-ASCII characters to a header, and the right thing will happen. (Well, eventually it will happen...right now it only works correctly for unstructured headers). Further, Date headers have a datetime attribute (and accept being set to a datetime), and address headers have attributes for accessing the individual addresses in the header. Other structured headers will eventually grow additional attributes as well. This all sounds pretty awesome, congrats :-) Has the header wrapping bug that was all part of the big headers mess been resolved now? cheers, Chris -- Simplistix - Content Management, Batch Processing & Python Consulting - http://www.simplistix.co.uk ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] email-6.0.0.a1
On Tue, 02 Aug 2011 18:48:11 +0100, Chris Withers wrote: > On 19/07/2011 22:21, R. David Murray wrote: > > The basic additional API is that a 'source' attribute contains the > > text the generator read from the input source, and a 'value' attribute > > that contains the value with all the Content-Transfer-Encoding stuff > > undone so that you have a real unicode string. By changing a policy > > setting, you can have that value as the string value of the header. > > You can also assign a string with non-ASCII characters to a header, and > > the right thing will happen. (Well, eventually it will happen...right > > now it only works correctly for unstructured headers). Further, Date > > headers have a datetime attribute (and accept being set to a datetime), > > and address headers have attributes for accessing the individual addresses > > in the header. Other structured headers will eventually grow additional > > attributes as well. > > This all sounds pretty awesome, congrats :-) > > Has the header wrapping bug that was all part of the big headers mess > been resolved now? If it is the bug I think you are talking about, it was resolved in 3.2.1. If there's still an open header wrapping bug (other than the one about smime and spaces after the ':') please let me know the issue number, as I don't see any in my list. There may still be an issue with whitespace padding in the encoded word context; I haven't tested issue 1467619 since I made my other changes. If it is not fixed in 3.2.1 already, it will be fixed in email6 by the time I finish the new wrapping code for that. --David ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] cpython: NEWS note for bbeda42ea6a8
On Wed, 03 Aug 2011 00:30:41 +0200 benjamin.peterson wrote: > > diff --git a/Misc/NEWS b/Misc/NEWS > --- a/Misc/NEWS > +++ b/Misc/NEWS > @@ -10,6 +10,8 @@ > Core and Builtins > - > > +- Add ThreadError to threading.__all__. > + This should surely be in the library section. Regards Antoine. ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Fwd: [Python-checkins] devguide: Add Sandro to the list of core developers
Speaking of developers.rst, could whoever added Jason Coombs also update developers.rst? I've added Jason to the committers mailing list. Thanks. Eric. Original Message Subject: [Python-checkins] devguide: Add Sandro to the list of core developers Date: Tue, 02 Aug 2011 14:58:38 +0200 From: antoine.pitrou Reply-To: [email protected] To: [email protected] http://hg.python.org/devguide/rev/2783106b0ccc changeset: 438:2783106b0ccc user:Antoine Pitrou date:Tue Aug 02 14:56:56 2011 +0200 summary: Add Sandro to the list of core developers files: developers.rst | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/developers.rst b/developers.rst --- a/developers.rst +++ b/developers.rst @@ -24,6 +24,10 @@ Permissions History --- +- Sandro Tosi was given push privileges on Aug 1 2011 by Antoine Pitrou, + for documentation and other contributions, on recommendation by Ezio + Melotti, R. David Murray and others. + - Charles-François Natali was given push privileges on May 19 2011 by Antoine Pitrou, for general contributions, on recommandation by Victor Stinner, Brian Curtin and others. -- Repository URL: http://hg.python.org/devguide ___ Python-Dev mailing list [email protected] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] cpython: expose sched.h functions (closes #12655)
Am 03.08.2011 00:30, schrieb benjamin.peterson:
> http://hg.python.org/cpython/rev/89e92e684b37
> changeset: 71704:89e92e684b37
> user:Benjamin Peterson
> date:Tue Aug 02 17:30:04 2011 -0500
> summary:
> expose sched.h functions (closes #12655)
> +static PyObject *
> +posix_sched_setaffinity(PyObject *self, PyObject *args)
> +{
> +pid_t pid;
> +Py_cpu_set *cpu_set;
> +
> +if (!PyArg_ParseTuple(args, _Py_PARSE_PID "O!|sched_setaffinity",
[...]
> +static PyObject *
> +posix_sched_getaffinity(PyObject *self, PyObject *args)
> +{
> +pid_t pid;
> +int ncpus;
> +Py_cpu_set *res;
> +
> +if (!PyArg_ParseTuple(args, _Py_PARSE_PID "i|sched_getaffinity",
These should be separated by ":", not "|", if I'm not mistaken?
Georg
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
