[Python-Dev] Patch reviews

2007-06-06 Thread BJörn Lindqvist
Here is a review of some patches:

* [ 1673759 ] '%G' string formatting doesn't catch same errors as '%g'

This patch is done, has been reviewed and works as advertised. Just
needs someone to commit it I think.

* [ 1100942 ] datetime.strptime constructor added

Doesn't apply cleanly, emits compiler warnings, but works as
expected. Lacks tests.

* [  968063 ] Add fileinput.islastline()

Good and useful patch (see the pup.py program) but lacks unit tests
and documentation.

* [ 1501979 ] syntax errors on continuation lines

Doesn't apply cleanly, but that is easy to fix. Needs someone to fix a
few minor flaws in it, but the patch works really well.

* [ 1375011 ] Improper handling of duplicate cookies

Fixes a fairly exotic bug in which Pythons cookie handling deviates in
an obscure way from Netscapes cookie specification. See the bug about
it at 1372650. As far as I can understand, the patch fixes the problem.

If someone still does the 5 for 1 deal, my patch is [ 1676135 ].

-- 
mvh Björn
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] Timeout in urllib2.urlopen

2007-06-06 Thread Facundo Batista

[EMAIL PROTECTED]:~/devel/reps/python/trunk$ ./python 
Python 2.6a0 (trunk, Jun  6 2007, 12:32:23) 
[GCC 4.1.2 (Ubuntu 4.1.2-0ubuntu4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import urllib2
>>> u = urllib2.urlopen("http://www.taniquetil.com.ar/plog";)
>>> u.headers.items()
[..., ('content-type', 'text/html;charset=iso-8859-1'), ...]
>>> 
>>> u = urllib2.urlopen("http://www.taniquetil.com.ar/plog";, timeout=3)
Traceback (most recent call last):
  ...
urllib2.URLError: 
>>> 

Ok, my blog is a bit slow, but the timeout is working ok, :D

Regards,

-- 
.   Facundo
.
Blog: http://www.taniquetil.com.ar/plog/
PyAr: http://www.python.org/ar/


___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Windows buildbot (Was: buildbot failure in x86 W2k trunk)

2007-06-06 Thread Thomas Heller
Thomas Heller schrieb:
> Thomas Heller schrieb:
 Are there others that can provide a Windows buildbot? It would probably
 be good to have two -- and a WinXP one would be good.
>>> 
>>> It certainly would be good. Unfortunately, Windows users are not that
>>> much engaged in the open source culture, so few of them volunteer
>>> (plus it's more painful, with Windows not being a true multi-user
>>> system).
>> 
>> I'll try to setup a buildbot under WinXP.
> 
> The buildbot is now working.

Should I try to setup another buildbot client for win32/AMD64?

Thomas

___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Windows buildbot (Was: buildbot failure in x86 W2k trunk)

2007-06-06 Thread Martin v. Löwis
> Should I try to setup another buildbot client for win32/AMD64?

We don't have a Win64 buildbot yet. Depending on whether you plan
to use PCbuild or PCbuild8, this might be a challenge to get working
(I think it's a challenge either way, but different).
If it could actually work, it might be useful.

Regards,
Martin
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com