Re: [Python-Dev] slight inconsistency in svn checkin email subject lines

2006-01-02 Thread Martin v. Löwis 
Trent Mick wrote:
> Is this intentional? If not, could someone point me to where the svn
> trigger scripts are maintained so I could poke around for a fix? (Or
> just fix it themselves. :)

It was not my intention. They are in
dinsdale.python.org:/data/repos/projects

Regards,
Martin
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Barry Warsaw 
I think we have a fundamental problem with Python-ast.c and
Python-ast.h.  These files should not be both auto-generated and checked
into Subversion.  The problem is that if you do a "make distclean",
these files will get removed and "svn stat" will give you a ! flag.  Of
course, you can "svn up" to get them back, but that just masks the
problem.  

Worse, if you distclean, then configure, then make, it is possible these
files will change.  Say you're working on a patch that touches a lot of
files and you do an "svn commit".  It's certainly possible that you'll
accidentally commit new versions of the Python-ast.* files, possibly
even broken ones.

The general rule should be that no file that is ever generated can be
checked into Subversion.  Probably the right approach is to check in a
template file that will not get removed by a distclean, and modify the
build process to generate Python-ast.* from those template files.

-Barry



signature.asc
Description: This is a digitally signed message part
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Neal Norwitz 
On 1/2/06, Barry Warsaw <[EMAIL PROTECTED]> wrote:
> I think we have a fundamental problem with Python-ast.c and
> Python-ast.h.  These files should not be both auto-generated and checked
> into Subversion.

I agree with the problem statement.

> The general rule should be that no file that is ever generated can be
> checked into Subversion.  Probably the right approach is to check in a
> template file that will not get removed by a distclean, and modify the
> build process to generate Python-ast.* from those template files.

I'm not sure about your proposed solution, though.

There's a bootstrapping issue.  Python-ast.[ch] are generated by a
python 2.2+ script.  /f created a bug report if only 2.1 is available.

The Python-ast.[ch] should probably not be removed by distclean.  This
is similar to configure.  Would that make you happy?  What else would
improve the current situation?

If you go the template route, you would just copy the files. That
doesn't seem to gain anything.

n
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Barry Warsaw 
On Mon, 2006-01-02 at 15:16 -0800, Neal Norwitz wrote:

> The Python-ast.[ch] should probably not be removed by distclean.  This
> is similar to configure.  Would that make you happy?  What else would
> improve the current situation?

I think it would, without causing bootstrapping issues.

-Barry



signature.asc
Description: This is a digitally signed message part
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] buildbot

2006-01-02 Thread Neal Norwitz 
Here's some info on setting up buildbot
.  These instructions should be
cleaned up and put in the developers faq.  Right now, the only person
that can generate/assign buildbot names/passwords is Martin AFAIK.

We currently have 4 slaves setup:
  Linux: x86 and amd64 (gentoo 2.6, glibc 2.3)
  Solaris10 sparc
  OS X: G5 (not yet working, need to setup path to svn)

It would be nice to get HP-UX, AIX, and Windows in various flavors. 
Ideally, any common platform we support should be added.  This
includes O/S, version, H/W, and various configurations.  Not sure we
care about much more Linux variants.  Note the x86 is the same one I
use for generating doc and more detailed build results.  I'll put that
info into a separate mail.

We also are only running the slaves on the trunk.

Thanks to Martin for setting this up.

n
--

Instructions:

Request a buildbot name and password from [EMAIL PROTECTED]
  Please state the machine type, operating system, compiler, and branch.
  For example, "amd64 gentoo gcc trunk" or "powerpc64 aix43 xlC 2.4".

Download buildbot  (we currently use 0.7.1)
Install buildbot (and dependencies like Twisted-1.3 if necesary)
Create buildslave account [optional]

If adding a slave for the trunk:

   # example directory, choose whatever you like
   DIR=`pwd`/buildslave/python-trunk
   mkdir -p $DIR
   cd $DIR
   buildbot slave `pwd` www.python.org:9020 "assigned-name" "assigned-password"

If adding a slave for the 2.4 branch:

   # example directory, choose whatever you like
   DIR=buildslave/python-2.4
   mkdir -p $DIR
   cd $DIR
   buildbot slave `pwd` www.python.org:9024 "assigned-name" "assigned-password"

Edit info/admin and info/host appropriately.  You can use this command
for info/host if you'd like:

   uname -a > info/host

To start the buildbot:

   buildbot start `pwd`

To ensure buildbot is started on reboot:

   (crontab -l | egrep -v '^#' ; echo "@reboot /usr/bin/buildbot start
$DIR") | crontab -

Make sure the buildslave account is able run cron jobs.
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] current test problems

2006-01-02 Thread Neal Norwitz 
test_bsddb3 fails for me with BSD DB 4.1 and 4.2 on gentoo Linux.  I
think it has for a long time.  Is anyone else seeing these failures? 
You must use -u bsddb when running regrtest.

4.2 has 2 failures:

  test02_associateAfterDB
(bsddb.test.test_associate.ShelveAssociateRecnoTestCase)
  test02_associateAfterDB
(bsddb.test.test_associate.ThreadedAssociateRecnoTestCase)

4.1 fails like this:

Traceback (most recent call last):
  File "Lib/threading.py", line 444, in __bootstrap
self.run()
  File "Lib/threading.py", line 424, in run
self.__target(*self.__args, **self.__kwargs)
  File "Lib/bsddb/test/test_thread.py", line 275, in readerThread
rec = dbutils.DeadlockWrap(c.next, max_retries=10)
  File "Lib/bsddb/dbutils.py", line 62, in DeadlockWrap
return function(*_args, **_kwargs)
DBLockDeadlockError: (-30996, 'DB_LOCK_DEADLOCK: Locker killed to
resolve a deadlock')


When looking for leaks, the following tests fail:

 test_decimal test_difflib test_optparse test_warnings test_zipimport

To test:
 ./python -E -tt ./Lib/test/regrtest.py -R 3:2: \
   test_decimal test_difflib test_optparse test_warnings test_zipimport

The following test has actual leaks which was reported a while ago.  Armin
found the problem to be that itertools.tee needs to participate with GC IIRC:

  test_generators

The following tests do not report stable leaks (at least sometimes):

test_capi test_cfgparser test_charmapcodec
test_cmd_line test_compiler test_filecmp test_logging
test_threadedtempfile test_threading
test_threading_local test_urllib2

n
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c

2006-01-02 Thread Jeremy Hylton 
On 1/2/06, Neal Norwitz <[EMAIL PROTECTED]> wrote:
> On 1/2/06, Barry Warsaw <[EMAIL PROTECTED]> wrote:
> > I think we have a fundamental problem with Python-ast.c and
> > Python-ast.h.  These files should not be both auto-generated and checked
> > into Subversion.
>
> I agree with the problem statement.
>
> > The general rule should be that no file that is ever generated can be
> > checked into Subversion.  Probably the right approach is to check in a
> > template file that will not get removed by a distclean, and modify the
> > build process to generate Python-ast.* from those template files.
>
> I'm not sure about your proposed solution, though.
>
> There's a bootstrapping issue.  Python-ast.[ch] are generated by a
> python 2.2+ script.  /f created a bug report if only 2.1 is available.
>
> The Python-ast.[ch] should probably not be removed by distclean.  This
> is similar to configure.  Would that make you happy?  What else would
> improve the current situation?

I think this solution is better.  It's relatively rare for people to
change the ast definition, so for most purposes these should be static
files.

Jeremy
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] automated builds and tests

2006-01-02 Thread Neal Norwitz 
I've updated the script that builds python and the docs, runs the
tests, and copies everything up to docs.python.org.  Currently, this
only works for the trunk.  I'm not sure if there's much of a benefit
to set this up for branch(es) also.

The docs are here:
  http://docs.python.org/dev/

The results of the build are here:
  http://docs.python.org/dev/results/

The script is checked in to Misc/build.sh.

If the script is modified, it doesn't pick up the changes until the
next run.  There is a hook to pickup the changes on each run, but I
didn't finish that.  Look for one of the several FIXMEs.

A brief description of what the script does is:
  svn up ; ./configure ; make ; make test ; make install ; cd Doc ; make ; rsync

Below is a description of everything that's done in the script.  Most
commands are checked for errors and the results are emailed iff there
are problems.  Right now I'm the only one that gets spammed.  This ran
all last week without any problems.  I made a bunch of changes and
probably sometime this week, I'll change the mail to go to
python-checkins.

svn update
svn status
./configure --prefix=$INSTALL_DIR --with-pydebug
make | grep warning
if make fails, goto building docs
make install
make test | grep fail
./python ./Lib/test/regrtest.py -R 4:3:$REFLOG -u network | grep leak
./python -E -tt ./Lib/test/regrtest.py -uall -x test_curses
test_linuxaudiodev test_ossaudiodev | grep fail

cd Doc ; make

rsync doc
rsync build results

---

test_curses is ignored because this script is run from cron and there
is no terminal.  The test stops prematurely.  The sound tests are
ignored because the sound device is not configured on this computer.

Some of the failure counts are off because it does a simple grep and
make test runs everything twice.  I've generally tried to filter out
stuff we don't care about.

There is potential for the tests to fail due to them running at the
same time as the buildbot test run.  These tests are run every 12
hours.  It currently takes over 1.25 hours to build and run
everything.  There is no make clean step for either the code or doc,
perhaps there should be?

n
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] buildbot

2006-01-02 Thread skip 
Neal> We currently have 4 slaves setup:
Neal>   Linux: x86 and amd64 (gentoo 2.6, glibc 2.3)
Neal>   Solaris10 sparc
Neal>   OS X: G5 (not yet working, need to setup path to svn)

The G5 *was* working.  I changed nothing at my end.  Got a mail yesterday
from Martin.  It looks like PATH lost /usr/local/bin (where the Metissian
installer puts the svn executable).  I added a /usr/bin/svn symlink, but
would really rather see /usr/local/bin in PATH.

Skip
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] buildbot

2006-01-02 Thread Neal Norwitz 
On 1/2/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> The G5 *was* working.  I changed nothing at my end.  Got a mail yesterday
> from Martin.  It looks like PATH lost /usr/local/bin (where the Metissian
> installer puts the svn executable).  I added a /usr/bin/svn symlink, but
> would really rather see /usr/local/bin in PATH.

It seems reasonable for /usr/local/bin to be in PATH.  But isn't this
be done on the slave (ie your) side?  It looks like the PATH comes
from your env't based on how my PATH in twistd.log.  So if you started
this from cron, you may need to add it there.  If nothing else works,
you could probably update PATH in buildbot.tac.

I forced a build, but it failed since svnversion was not found.

BTW, I noticed this warning:
  Modules/getpath.c:405: warning: passing arg 2 of
`_NSGetExecutablePath' from incompatible pointer type

Can somebody with a Mac fix this warning?

n
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] buildbot

2006-01-02 Thread Bob Ippolito 

On Jan 2, 2006, at 10:30 PM, Neal Norwitz wrote:

> On 1/2/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>>
>> The G5 *was* working.  I changed nothing at my end.  Got a mail  
>> yesterday
>> from Martin.  It looks like PATH lost /usr/local/bin (where the  
>> Metissian
>> installer puts the svn executable).  I added a /usr/bin/svn  
>> symlink, but
>> would really rather see /usr/local/bin in PATH.
>
> It seems reasonable for /usr/local/bin to be in PATH.  But isn't this
> be done on the slave (ie your) side?  It looks like the PATH comes
> from your env't based on how my PATH in twistd.log.  So if you started
> this from cron, you may need to add it there.  If nothing else works,
> you could probably update PATH in buildbot.tac.
>
> I forced a build, but it failed since svnversion was not found.
>
> BTW, I noticed this warning:
>   Modules/getpath.c:405: warning: passing arg 2 of
> `_NSGetExecutablePath' from incompatible pointer type
>
> Can somebody with a Mac fix this warning?

This warning depends on the version of Mac OS X you're using.  The  
type signature for arg 2 is "unsigned long" up to 10.3, and  
"uint32_t" on 10.4.  The version I see in svn is current with Mac OS  
X 10.4.

The easy fix is to upgrade your OS.  I don't think anyone is going to  
bother with the preprocessor hackery necessary to make that  
(harmless) warning go away on older versions of the OS.

-bob

___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Doc-SIG] that library reference, again

2006-01-02 Thread Ian Bicking 
I've put an instance of Commentary up against the full 2.4 
documentation: http://pythonpaste.org/comment/python24/

It writes to a Subversion repository so you can see what the backend 
data looks like: http://pythonpaste.org/comment/svn/python24/ -- not 
much there yet.  Obviously things like notification and reports would be 
useful, but I don't know what the state of the art for Subversion is 
either, so potentially these tools already exist.  But last I really 
looked at the tools for Subversion, I wasn't overly impressed.  Things 
like self-signup for pages you were interested in would be useful.  But 
anyway, there's nothing too difficult about those features.

Anyway, it's just meant as a demo for now, but give it a look, and if 
you have problems or suggestions write a ticket: 
http://pythonpaste.org/commentary/trac/newticket

Cheers.

-- 
Ian Bicking  |  [EMAIL PROTECTED]  |  http://blog.ianbicking.org
___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] mac memory leaks

2006-01-02 Thread Neal Norwitz 
I had a friend run regrtest -L on Mac OSX a while ago.  There are
several memory leaks which still appear to be an issue.  There are a
bunch of leaks reported from  putenv which I'm not sure how to fix

The attached patch should correct one of the problems.  Can someone
with a Mac test it?  I'll add to SF later if I don't get a response.

n
--

I'm not sure about how to fix these or if they are real problems:

Leak: 0x02541470  size=368  instance of 'NSCFData'
Call stack: call_function | ici_ICFindPrefHandle | ICFindPrefHandle |
OpaqueICInstance::FindPrefHandle(ICKeyInfo const&, unsigned long*,
char**) | OpaqueICInstance::GetPref(ICKeyInfo const&, long, void*,
long*, unsigned long*) | OpaqueICInstance::GetPrefCore(ICKeyInfo
const&, long, void*, long*, unsigned long*) |
OpaqueICInstance::LazyLoad() | ICCFPrefWrapper::ContainsPrefs() |
ICCFPrefWrapper::GetPrefDictionary() | fetchXMLValue |
_loadXMLDomainIfStale | _CFPropertyListCreateFromXMLData |
__CFTryParseBinaryPlist | __CFBinaryPlistCreateObject |
__CFBinaryPlistCreateObject | __CFBinaryPlistCreateObject |
__CFBinaryPlistCreateObject | __CFBinaryPlistCreateObject |
__CFDataInit | _CFRuntimeCreateInstance | CFAllocatorAllocate

Leak: 0x02506640  size=256
Call stack: call_function | do_call | PyObject_Call | parser_st2tuple
| node2tuple | node2tuple | node2tuple | node2tuple | node2tuple |
node2tuple | node2tuple | node2tuple | node2tuple | node2tuple |
node2tuple | node2tuple | node2tuple | node2tuple | node2tuple |
node2tuple | node2tuple | node2tuple | node2tuple | node2tuple |
node2tuple | PyTuple_New | _PyObject_GC_NewVar | _PyObject_GC_Malloc |
PyObject_Malloc | new_arena

Leak: 0x0118ad10  size=80
Call stack: call_function | AE_AECreateDesc | AECreateDesc | operator
new(unsigned long)
Index: Mac/Modules/file/_Filemodule.c
===
--- Mac/Modules/file/_Filemodule.c	(revision 41886)
+++ Mac/Modules/file/_Filemodule.c	(working copy)
@@ -3204,11 +3204,10 @@
 char *path = NULL;
 if (!PyArg_Parse(v, "et", Py_FileSystemDefaultEncoding, &path))
 return 0;
-if ( (err=FSPathMakeRef(path, fsr, NULL)) ) {
+if ( (err=FSPathMakeRef(path, fsr, NULL)) )
 PyMac_Error(err);
-return 0;
-}
-return 1;
+PyMem_Free(path);
+return !err;
 }
 /*  Should try unicode here too */
 /* Otherwise we try to go via an FSSpec */




___
Python-Dev mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com