[issue38766] AttributeError: 'xml.etree.ElementTree.ParseError' has no attribute 'filename'

2019-11-11 Thread mlj


New submission from mlj :

traceback.py and how it handles 'SyntaxError's, which includes a bunch of 
assumptions about attributes that a SyntaxError should have defined:

https://github.com/python/cpython/blob/master/Lib/traceback.py#L516

Definition of xml.etree.ElementTree.ParseError, marking it out as a sub-class 
of a SyntaxError:

https://github.com/python/cpython/blob/master/Lib/xml/etree/ElementTree.py#L106

How a ParseError is raised by ElementTree, noting that it doesn't set 
`filename` (and probably `text` too) as an attribute of the exception isntance:

https://github.com/python/cpython/blob/master/Lib/xml/etree/ElementTree.py#L1625

The most recent commit in the code areas I've highlighted is from 
`6bc2c1e7ebf359224e5e547f58ffc2c42cb36a39` from March 2015, which added in the 
assumptions about attributes to `traceback.py`.

The whole thing is markedly confusing, because the code in `traceback.py` isn't 
being run inside an exception handler, so when it crashes it completly 
obfuscates the actual root-cause of the issue (in other cases you'd get the 
"while handling this error, another happened" which is much more user friendly).

I'm not sure what the correct fix here is but I tried making 
xml.etree.ElementTree.ParseError a standalone exception, not a sub-class of 
SyntaxError but it didn't take. Probably shouldn't be delving about in the guts 
of the python-core on my laptop, but ho-hum.

--
components: XML
messages: 356366
nosy: mlj
priority: normal
severity: normal
status: open
title: AttributeError: 'xml.etree.ElementTree.ParseError' has no attribute 
'filename'
type: crash
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue38766>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38766] AttributeError: 'xml.etree.ElementTree.ParseError' has no attribute 'filename'

2019-11-11 Thread mlj


mlj  added the comment:

Bleh.

Sorry. I've crucially forgottn that this is an issue when running unit-tests 
under `nose` and isn't exclusively a core problem. Let me do some more 
debugging and then decide who the correct people to annoy are.

--
resolution:  -> works for me
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue38766>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com