[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files
david awad added the comment: It's been a while since then but I really think we can get this fix merged in the next two weeks or so. Can someone give this another look? I had a quick question for Serhiy Here: https://github.com/python/cpython/pull/8319#discussion_r273539593 If we could get that resolved I think this can finally be done and I can try to help out on a different PR and do a better job in the future. Thanks! -- ___ Python tracker <https://bugs.python.org/issue34088> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files
Change by david awad : -- keywords: +patch pull_requests: +7854 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34088> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files
david awad added the comment: Hey, I saw the issue and spent some time piecing together a PR for it. I've never contributed to Python before but this seemed like a good place to start! I posted these questions on the PR but I'll echo them here as well. - Should we only handle the specific exceptions that are created in these two examples? or is there a cleaner, more pythonic way to handle it? - It doesn't appear that test_sndhdr.py does any testing of bad inputs. Can I add test cases to the test_sndhdr.py file? Thanks! I'm here to learn so if there's anything I missed please feel free to let me know. -- nosy: +davidawad ___ Python tracker <https://bugs.python.org/issue34088> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
