[issue9721] urlparse.urljoin() cuts off last base character with semicolon at url start
Wes Chow added the comment: Here's a patch for 3.2 which fixes this problem I believe. There does exist a test case that should have produced an error, except that the last path segment in RFC3986_BASE is only one character long. Had it been more than one character long, RFC3986 checks would have failed. Also in the supplied patch is a test to catch this specific bug. -- nosy: +weschow Added file: http://bugs.python.org/file19695/urlparse-9721.patch ___ Python tracker <http://bugs.python.org/issue9721> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9721] urlparse.urljoin() cuts off last base character with semicolon at url start
Wes Chow added the comment: New patch (urlparse-9721-3.2.patch) against 3.2 which fixes the erroneous test. -- Added file: http://bugs.python.org/file19706/urlparse-9721-3.2.patch ___ Python tracker <http://bugs.python.org/issue9721> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9721] urlparse.urljoin() cuts off last base character with semicolon at url start
Wes Chow added the comment: Patch against 2.7 (urlparse-9721-2.7.patch). -- Added file: http://bugs.python.org/file19707/urlparse-9721-2.7.patch ___ Python tracker <http://bugs.python.org/issue9721> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4493] urllib2 doesn't always supply / where URI path component is empty
Wes Chow added the comment: Attached is a patch against 3.2 that replaces empty paths with '/' in HTTPConnection. I do not totally understand the ; syntax in URIs, and so this implementation may break that, as it splits urls and unsplits them if needed. The Python docs seem to indicate there might be some obscure cases where this is problematic. And yes, I do realize that this patch fixes the problem in yet another place. Hopefully HTTPConnection is the lowest common denominator. -- keywords: +patch nosy: +weschow Added file: http://bugs.python.org/file19716/empty-path-4493.patch ___ Python tracker <http://bugs.python.org/issue4493> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4493] urllib2 doesn't always supply / where URI path component is empty
Wes Chow added the comment: This same bug also exists in HTTPClient, and my patch addresses that. Addressing it in HTTPClient has a side effect of taking care of it for urllib2 as well (and all future libraries that use HTTPClient). Even if the urllib2 patch is preferable, shouldn't we fix the problem in HTTPClient as well? -- ___ Python tracker <http://bugs.python.org/issue4493> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
