[issue6598] calling email.utils.make_msgid frequently has a non-trivial probability of generating colliding ids

[Varun Sharma]

Changes by Varun Sharma :


--
nosy: +varun

___
Python tracker 
<http://bugs.python.org/issue6598>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11558] Raise a more helpful exception in email.message.Message.attach after set_payload("some string")

[Varun Sharma]

Varun Sharma added the comment:

I have made a patch which raises TypeError whenever a string type payload is 
attached to message using email.Message.attach() method.I have also added a 
unit test for the same. Need review.

--
keywords: +patch
nosy: +varun
Added file: http://bugs.python.org/file34258/string_payload_to_attach.patch

___
Python tracker 
<http://bugs.python.org/issue11558>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11558] Raise a more helpful exception in email.message.Message.attach after set_payload("some string")

[Varun Sharma]

Varun Sharma added the comment:

Afer getting a lot of help from david on irc, i finally improved the patch. Now 
it catches AttributeError and raises TypeError for non-object types in attach 
function.

--
Added file: http://bugs.python.org/file34269/test_email_attach_to_string.patch

___
Python tracker 
<http://bugs.python.org/issue11558>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11558] Raise a more helpful exception in email.message.Message.attach after set_payload("some string")

[Varun Sharma]

Varun Sharma added the comment:

I have fixed the pep8 voilations and shortened the regex as you suggested in 
the new patch.

--
Added file: 
http://bugs.python.org/file34270/test_email_attach_to_string_11558.patch

___
Python tracker 
<http://bugs.python.org/issue11558>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11558] Raise a more helpful exception in email.message.Message.attach after set_payload("some string")

[Varun Sharma]

Varun Sharma added the comment:

Sorry :)

--
Added file: 
http://bugs.python.org/file34273/test_email_attach_to_string_11558.patch

___
Python tracker 
<http://bugs.python.org/issue11558>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20770] Inform caller of smtplib STARTTLS failures

[Varun Sharma]

Varun Sharma added the comment:

I think that raising an exception for starttls failure can be avoided, so i 
have added a patch for documentation which adds the following line to doc 
string : "If server supports TLS but fails to start it, then it does not raise 
any exception".

--
keywords: +patch
nosy: +varun
Added file: http://bugs.python.org/file34288/starttls_doc_fix_20770.patch

___
Python tracker 
<http://bugs.python.org/issue20770>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4142] smtplib doesn't clear helo/ehlo flags on quit

[Varun Sharma]

Varun Sharma added the comment:

I have added a patch and it's test case as per martin's suggestions. Now 
function close() resets the attributes :sock, default_port, ehlo_msg, 
ehlo_resp, helo_resp, source_address

But it does *not* reset : debuglevel, does_esmtp,esmtp_features, file, 
local_hostname

I think the attributes does_esmtp, esmtp_features and local_hostname are most 
probably not going to be changed even if someone uses the same object more than 
once.

--
nosy: +varun
Added file: http://bugs.python.org/file34316/flag_reset_4142.patch

___
Python tracker 
<http://bugs.python.org/issue4142>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com