[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

[Toby Thurston]

Toby Thurston  added the comment:

Hey!  thanks for letting me know, glad it got there in the end.  T.

On Fri, 13 Aug 2021, at 12:33, Łukasz Langa wrote:
> 
> Łukasz Langa  added the comment:
> 
> Thanks for reporting and the initial patch, Toby. And thanks for 
> pushing this across the finish line, Yussuf! ✨ 🍰 ✨
> 
> --
> resolution:  -> fixed
> stage: patch review -> resolved
> status: open -> closed
> versions: +Python 3.11 -Python 3.8
> 
> ___
> Python tracker 
> <https://bugs.python.org/issue30077>
> ___
>

--

___
Python tracker 
<https://bugs.python.org/issue30077>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

[Toby Thurston]

New submission from Toby Thurston:

aifc.py fails to open AIFF files containing the compression type "sowt" in the 
COMM chunk with an "unsupported compression type" error.

This compression type is an Apple specific extension that signals that the data 
is not actually compressed but is stored uncompressed in little Endian order.  

Supporting it would require a trivial change to allow the compression type as a 
byte-string and to add a do-nothing _convert routine. 

This would allow aifc.py to be used with AIFF files on Apple macOS.

--
components: Extension Modules
messages: 291727
nosy: thruston
priority: normal
severity: normal
status: open
title: Support Apple AIFF-C pseudo compression in aifc.py
type: enhancement
versions: Python 3.6

___
Python tracker 
<http://bugs.python.org/issue30077>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

[Toby Thurston]

Changes by Toby Thurston :


--
pull_requests: +1287

___
Python tracker 
<http://bugs.python.org/issue30077>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

[Toby Thurston]

Toby Thurston added the comment:

I think it's probably better as a no-op.  Currently in my patch I just put 

return data

You could do

return data[::-1]

to reverse the sample, so that it came out as big endian, but if you leave it 
as a no-op then the data is returned in the native format for Intel Mac OS, 
which is the whole point of the "sowt" encoding.  Either way, the user can 
easily reverse the data in a `unpack` format if they want to, but in my own 
testing it seemed easier and simpler just to leave it in the native format. 
Then basically "it just works".

The patch as I've proposed it works fine on my MacOS boxes, but I have only 
tested it with AIFF-C files from one source.

--

___
Python tracker 
<http://bugs.python.org/issue30077>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com