[issue37933] faulthandler causes segfaults

2019-08-23 Thread Thomas Caswell 


New submission from Thomas Caswell :

Changing faulthandler to only allocate it's stack when use causes python to 
segfault with

import faulthandler
faulthandler.cancel_dump_traceback_later()

https://bugs.python.org/issue37851 https://github.com/python/cpython/pull/15358

--
components: Library (Lib)
messages: 350332
nosy: tcaswell, vstinner
priority: normal
severity: normal
status: open
title: faulthandler causes segfaults
type: crash
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue37933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37933] faulthandler causes segfaults

2019-08-23 Thread Thomas Caswell 


Change by Thomas Caswell :


--
components: +Extension Modules -Library (Lib)

___
Python tracker 
<https://bugs.python.org/issue37933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37933] faulthandler causes segfaults

2019-08-23 Thread Thomas Caswell 


Change by Thomas Caswell :


--
keywords: +patch
pull_requests: +15133
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15440

___
Python tracker 
<https://bugs.python.org/issue37933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-08-29 Thread Thomas Caswell 


New submission from Thomas Caswell :

In python37, numpy1.17 the following runs without warning.

import numpy as np
sorted([1, 2], reverse=np.bool_(True))  

with python38 this emits a

DeprecationWarning: In future, it will be an error for 'np.bool_' scalars to be 
interpreted as an index

I bisected this back to https://github.com/python/cpython/pull/11952 which 
looks very intentional, however it is tripping deprecation warnings in numpy to 
prevent things like `[1, 2, 3][np.bool_(False), np.bool_(True)]` from doing 
surprising things.

I have previously gotten the sense that core would like to know about these 
sorts of regressions rather than just handling them down-stream.  I will be 
opening an issue with numpy as well.

--
files: numpy_warning_bisect.log
messages: 350800
nosy: tcaswell
priority: normal
severity: normal
status: open
title: regression when passing numpy bools to sorted(..., reverse=r)
versions: Python 3.8
Added file: https://bugs.python.org/file48568/numpy_warning_bisect.log

___
Python tracker 
<https://bugs.python.org/issue37980>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-08-29 Thread Thomas Caswell 


Change by Thomas Caswell :


Added file: https://bugs.python.org/file48569/python_bisect.sh

___
Python tracker 
<https://bugs.python.org/issue37980>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-08-29 Thread Thomas Caswell 


Change by Thomas Caswell :


Added file: https://bugs.python.org/file48570/test.py

___
Python tracker 
<https://bugs.python.org/issue37980>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-08-29 Thread Thomas Caswell 


Thomas Caswell  added the comment:

xref numpy issue https://github.com/numpy/numpy/issues/14397

--

___
Python tracker 
<https://bugs.python.org/issue37980>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-08-29 Thread Thomas Caswell 


Change by Thomas Caswell :


--
components: +Library (Lib)
versions: +Python 3.9

___
Python tracker 
<https://bugs.python.org/issue37980>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37980] regression when passing numpy bools to sorted(..., reverse=r)

2019-10-11 Thread Thomas Caswell 


Thomas Caswell  added the comment:

Any update on resolving this?

--

___
Python tracker 
<https://bugs.python.org/issue37980>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37289] regression in Cython when pickling objects

2019-10-26 Thread Thomas Caswell 


Thomas Caswell  added the comment:

I believe this can be closed, the regression has been fixed and there is now a 
test to prevent it from coming back.

--

___
Python tracker 
<https://bugs.python.org/issue37289>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44242] enum.IntFlag regression: missing values cause TypeError

2021-06-04 Thread Thomas Caswell 


Thomas Caswell  added the comment:

This change also affects PyQt6:

Python 3.10.0b2+ (heads/3.10:d0991e2db3, Jun  1 2021, 11:42:08) [GCC 11.1.0] on 
linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import PyQt6.QtCore
>>> PyQt6.QtCore.PYQT_VERSION_STR
'6.1.1.dev2105301600'
>>> PyQt6.QtCore.Qt.Key
Traceback (most recent call last):
  File "", line 1, in 
  File "/home/tcaswell/.pybuild/bleeding/lib/python3.10/enum.py", line 615, in 
__call__
return cls._create_(
  File "/home/tcaswell/.pybuild/bleeding/lib/python3.10/enum.py", line 762, in 
_create_
return metacls.__new__(metacls, class_name, bases, classdict, 
boundary=boundary)
  File "/home/tcaswell/.pybuild/bleeding/lib/python3.10/enum.py", line 544, in 
__new__
raise TypeError(
TypeError: invalid Flag 'DropAction' -- missing values: 8, 16, 32, 64, 128, 
32768
>>> 


> remove the creation time check (which will remove the error for the OP), and 
> then add a decorator to the enum module that does that creation time check

I am very supportive of this plan!

Could this be labeled as a higher priority / release blocker?

--
nosy: +tcaswell

___
Python tracker 
<https://bugs.python.org/issue44242>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45251] signal.SIGCLD alias is not available on OSX

2021-09-20 Thread Thomas Caswell 


New submission from Thomas Caswell :

The module attribute signal.SIGCLD 
(https://docs.python.org/3/library/signal.html#signal.SIGCLD) is an "archaic" 
(quoting from the GNU C Library source) alias for signal.SIGCHLD 
(https://docs.python.org/3/library/signal.html#signal.SIGCHLD). signal.SIGCHLD 
is documented as being available on unix, and signal.SIGCLD is documented as an 
alias of signal.SIGCHLD.  

However, it seems that clang does not define the SIGCLD back-compatibility name 
[1] so the SIGCLD alias is missing on OSX (all the way to at least 2.7) because 
the clang headers appear to not define the SIGCLD macro and hence the logic in 
modulesignal.c does not find it, and hence the rest of the tooling in signal.py 
does not find it.

I am not sure if the correct fix is to document that SIGCLD in only available 
on linux (which I am not sure is completely correct, maybe "availability is 
platform dependent, but definitely not on darwin"?) or to add the macro if 
SIGCHLD is defined and SIGCLD is missing (see attached patch)

[1] SIGCLD is not documented in 
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/signal.3.html
 and not the signal.h that ships with xcode

--
assignee: docs@python
components: Documentation, Library (Lib)
files: osx_signal_compat.patch
keywords: patch
messages: 402280
nosy: docs@python, tcaswell
priority: normal
severity: normal
status: open
title: signal.SIGCLD alias is not available on OSX
versions: Python 3.10, Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 
3.9
Added file: https://bugs.python.org/file50290/osx_signal_compat.patch

___
Python tracker 
<https://bugs.python.org/issue45251>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40574] segfault causing regression from PEP 573 implementation

2020-05-08 Thread Thomas Caswell 

New submission from Thomas Caswell :

https://github.com/python/cpython/commit/e1becf46b4e3ba6d7d32ebf4bbd3e0804766a423
 causes pyqt5 to segfault an accessing an attribute

To reproduce this:


pip install pyqt5
pip install sip
python -c "import PyQt5.QtCore; PyQt5.QtCore.Qt.Key_Control"  # this segfaults

Setting up faulthandler gives:

jupiter@23:54  ➤  python -X faulthandler -c "import PyQt5.QtCore; 
PyQt5.QtCore.Qt.Key_Control"
Fatal Python error: Segmentation fault

Current thread 0x7f52111cd740 (most recent call first):

Segmentation fault (core dumped)

It is likely that this should also be reported to riverbank as a pyqt/sip bug, 
but I'm starting here.  I apologize for not having a simpler reproducing case.




jupiter@00:01  ➤ git bisect log
git bisect start
# good: [2d8757758d0d75882fef0fe0e3c74c4756b3e81e] bpo-40286: Remove C 
implementation of Random.randbytes() (GH-19797)
git bisect good 2d8757758d0d75882fef0fe0e3c74c4756b3e81e
# bad: [d10091aa171250c67a5079abfe26b8b3964ea39a] bpo-40502: Initialize 
n->n_col_offset (GH-19988)
git bisect bad d10091aa171250c67a5079abfe26b8b3964ea39a
# good: [c3f001461d5794c81cf5f70e08ae5435fe935ceb] bpo-40491: Fix typo in 
syntax error for numeric literals (GH-19893)
git bisect good c3f001461d5794c81cf5f70e08ae5435fe935ceb
# good: [c21c51235aa8061da6b0593d6f857f42fd92fd8b] bpo-40355: Improve error 
messages in ast.literal_eval with malformed Dict nodes (GH-19868)
git bisect good c21c51235aa8061da6b0593d6f857f42fd92fd8b
# good: [c1c7d8ead9eb214a6149a43e31a3213c52448877] bpo-40397: Refactor 
typing._GenericAlias (GH-19719)
git bisect good c1c7d8ead9eb214a6149a43e31a3213c52448877
# bad: [c068b53a0ca6ebf740d98e422569d2f705e54f93] bpo-38787: Update 
structures.rst docs (PEP 573) (GH-19980)
git bisect bad c068b53a0ca6ebf740d98e422569d2f705e54f93
# good: [4638c6429575bd6de26b12b2af5df74d6568b553] bpo-40334: Error message for 
invalid default args in function call (GH-19973)
git bisect good 4638c6429575bd6de26b12b2af5df74d6568b553
# bad: [8963a7f1f84a05412178b56629508b660d38861b] bpo-40545: Export 
_PyErr_GetTopmostException() function (GH-19978)
git bisect bad 8963a7f1f84a05412178b56629508b660d38861b
# bad: [e1becf46b4e3ba6d7d32ebf4bbd3e0804766a423] bpo-38787: C API for module 
state access from extension methods (PEP 573) (GH-19936)
git bisect bad e1becf46b4e3ba6d7d32ebf4bbd3e0804766a423
# first bad commit: [e1becf46b4e3ba6d7d32ebf4bbd3e0804766a423] bpo-38787: C API 
for module state access from extension methods (PEP 573) (GH-19936)

--
components: C API
messages: 368499
nosy: tcaswell
priority: normal
severity: normal
status: open
title: segfault causing regression from PEP 573 implementation
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40574] segfault causing regression from PEP 573 implementation

2020-05-08 Thread Thomas Caswell 


Thomas Caswell  added the comment:

Sorry, forgot to add this is on Linux.

--

___
Python tracker 
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40574] segfault causing regression from PEP 573 implementation (PyQt5)

2020-05-10 Thread Thomas Caswell 

Thomas Caswell  added the comment:

The script I used for the bisect was:

---

TARGET_ENV=bisect_env


rm -r ~/.pybuild/$TARGET_ENV || true
git clean -xfd
./configure --prefix=/home/tcaswell/.pybuild/$TARGET_ENV
make -j 9
make install
~/.pybuild/$TARGET_ENV/bin/python3 -m venv --copies --clear 
~/.virtualenvs/$TARGET_ENV

popd

source ~/.virtualenvs/$TARGET_ENV/bin/activate
pip install --upgrade pip
echo $PATH

pushd ../sip# this was at "tip" in the hg repo
pip install .
pip install pyqt5
popd

python -c "import PyQt5.QtCore; PyQt5.QtCore.Qt.Key_Control"
retVal=$?
if [ $retVal -ne 0 ]; then
exit 1
fi

---


I'm on a relatively up-to-date Arch 

➤  gcc --version
gcc (Arch Linux 9.3.0-1) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


---

updating pip is a key step (that I thoughtlessly carried over from my normal 
build process) because that lets it see manylinux2014 wheels and does not try 
to build pyqt5 from source.

python3.9 -m pip freeze
packaging==20.3
pyparsing==2.4.7
PyQt5==5.14.2
PyQt5-sip==12.7.2
sip==5.2.0
six==1.14.0
toml==0.10.0

➤  python3.9 -VV
Python 3.9.0a6+ (heads/master-7-g1c2fa78156:1c2fa78156, May 10 2020, 11:11:03) 
[GCC 9.3.0]




I'm also having issues getting pyqt5 to compile from the tarball, what do you 
mean by "Ah, if I install Python, I can install PyQt5. I installed PyQt5:"?

--

___
Python tracker 
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40574] segfault causing regression from PEP 573 implementation (PyQt5)

2020-05-10 Thread Thomas Caswell 


Thomas Caswell  added the comment:

I think I have figured out the problem.  I had a locally built and cached wheel 
of PyQt5-sip from before PEP573 went in.  If that wheel is used for later 
commits I get the segfault, if I rebuilt the wheel from source it works.

I am not sure if this is an expected sharp edge (wheels are be expected to be 
good between commits prior to a release) or not.


-


Below is a script that will build everything (sip, pyqt5, pyqt5-sip) from 
source and install them into a virtual env.


#! /usr/bin/bash
set -e
set -o xtrace



rm -r ~/.pybuild/py39 || true
pushd cpython
git clean -xfd
./configure --prefix=/home/tcaswell/.pybuild/py39
make -j 9
make install
popd

~/.pybuild/py39/bin/python3 -m venv --copies --clear ~/.virtualenvs/py39



source ~/.virtualenvs/py39/bin/activate
pip install --upgrade pip
echo $PATH

pushd PyQt5
pip install sip --no-binary sip
rm -rf PyQt5-5.14.2
tar -xzf PyQt5-5.14.2.tar.gz

pushd PyQt5-5.14.2
python configure.py --confirm-license
# patch the one palce that does not respect the venv settings
sed -i 's|$(INSTALL_ROOT)/usr|$(INSTALL_ROOT)/$(HOME)/.virtualenvs/py39/usr|g' 
Makefile
make -j 9
make install
popd
popd
pip install PyQt5-sip --no-binary PyQt5-sip

python -c "import PyQt5.QtCore; PyQt5.QtCore.Qt.Key_Control"




--

___
Python tracker 
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40574] segfault causing regression from PEP 573 implementation (PyQt5)

2020-05-11 Thread Thomas Caswell 


Thomas Caswell  added the comment:

The path is

 - on a commit prior to e1becf46b4e3ba6d7d32ebf4bbd3e0804766a423 install 
pyqt-sip.  pip will build a wheel for you called 
PyQt5_sip-12.7.2-cp39-cp39-linux_x86_64.whl
 - on a commit after e1becf46b4e3ba6d7d32ebf4bbd3e0804766a423 if you do `pip 
install pyqt-sip` pip will discover the wheel from the previous install in it's 
cache and use it, but the ABI has changed (?) which leads to a segfault.  If 
you do `pip install pyqt5-sip --no-binary pyqt5-sip` or clear the cache then 
things work correctly

I suspect that this also means that wheels made with the early alphas will not 
work future 3.9 (pre-)releases, however I am not sure if that is a problem or 
not (given that it is all pre-releases).

I am going to close this as I think if there is a bug, it would be better 
addressed in the packaging space.

--
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40574] segfault causing regression from PEP 573 implementation (PyQt5)

2020-05-12 Thread Thomas Caswell 


Thomas Caswell  added the comment:

That seems reasonable.

To be pedantic, it is pyqt5-sip (not sip) that was the source of the problem.

I am going to open an issue with pip to disable caching locally built wheels 
for pre-released versions of Python.

--

___
Python tracker 
<https://bugs.python.org/issue40574>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40257] Improve the use of __doc__ in pydoc

2020-05-17 Thread Thomas Caswell 


Change by Thomas Caswell :


--
nosy: +tcaswell

___
Python tracker 
<https://bugs.python.org/issue40257>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41520] 3.8.5 regression, warnings.simplefilter('error', SyntaxWarning) does not raise.

2020-08-10 Thread Thomas Caswell 


Thomas Caswell  added the comment:

bisecting agrees with Matthias:

# first bad commit: [c067183605cf84bb1a246635f52827251d0476f8] bpo-40807: Show 
warnings once from codeop._maybe_compile (GH-20486)

--
nosy: +tcaswell

___
Python tracker 
<https://bugs.python.org/issue41520>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37289] regression in cython due to peephole optomization

2019-06-14 Thread Thomas Caswell 


New submission from Thomas Caswell :

The fix for 
https://bugs.python.org/issue37213 in 3498c642f4e83f3d8e2214654c0fa8e0d51cebe5 
(https://github.com/python/cpython/pull/13969) seems to break building numpy 
(master) with cython (master) due to a pickle failure.

The traceback (which is mostly in the cython source) is in an attachment.

I bisected it back to this commit and tested that reverting this commit fixes 
the numpy build.

--
files: np_fail.txt
messages: 345655
nosy: pablogsal, scoder, serhiy.storchaka, tcaswell, vstinner
priority: normal
severity: normal
status: open
title: regression in cython due to peephole optomization
type: behavior
versions: Python 3.8, Python 3.9
Added file: https://bugs.python.org/file48421/np_fail.txt

___
Python tracker 
<https://bugs.python.org/issue37289>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37289] regression in cython due to peephole optomization

2019-06-14 Thread Thomas Caswell 


Thomas Caswell  added the comment:

This change also causes failures in the cython test suite (see attached).

--
Added file: https://bugs.python.org/file48422/cython_test_log.txt

___
Python tracker 
<https://bugs.python.org/issue37289>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37289] regression in Cython when pickling objects

2019-06-15 Thread Thomas Caswell 


Thomas Caswell  added the comment:

I can confirm that master branches of cpython, cython, and numpy all build 
together again, thank you for the quick investigation and fix!

--

___
Python tracker 
<https://bugs.python.org/issue37289>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30623] python-nightly import numpy fails since recently

2017-06-24 Thread Thomas Caswell 

Thomas Caswell added the comment:

https://github.com/python/cpython/pull/1236 has been merged, I believe this 
issue can be closed.

--
nosy: +tcaswell

___
Python tracker 
<http://bugs.python.org/issue30623>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31286] import in finally results in SystemError

2017-08-26 Thread Thomas Caswell 

New submission from Thomas Caswell:

Code to reproduce:

def import_in_finally_fail():
try:
print('yo')
finally:
import asyncio.queues as aq


Results in:

In [68]: import_in_finally_fail()
yo
---
SystemError   Traceback (most recent call last)
 in ()
> 1 import_in_finally_fail()

/tmp/py2661VBj in import_in_finally_fail()

SystemError: 'finally' pops bad exception


The exact import does matter, but it needs to be at least 2 modules deep and be 
aliased.  

By patching cpython to put what finally pops off the stack in the error message 
it looks like it is the parent module of the import.

This was found via the Matplotlib test suite (ex 
https://travis-ci.org/matplotlib/matplotlib/jobs/262907186 ) and reported to 
pytest (https://github.com/pytest-dev/pytest/issues/2674)

--
components: Interpreter Core
messages: 300911
nosy: tcaswell
priority: normal
severity: normal
status: open
title: import in finally results in SystemError
type: crash
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue31286>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31286] import in finally results in SystemError

2017-08-29 Thread Thomas Caswell 

Thomas Caswell added the comment:

Your welcome!

Matplotlib ended up just moving the import out of the finally block once we
understood the issue.

Tom

On Tue, Aug 29, 2017 at 8:50 AM Serhiy Storchaka 
wrote:

>
> Serhiy Storchaka added the comment:
>
> Thank you for your report Thomas!
>
> Don't forget to remove pyc-files before re-running the Matplotlib test
> suite.
>
> --
> resolution:  -> fixed
> stage: patch review -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> <http://bugs.python.org/issue31286>
> ___
>

--

___
Python tracker 
<http://bugs.python.org/issue31286>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

2018-06-27 Thread Thomas Caswell 


Change by Thomas Caswell :


--
keywords: +patch
pull_requests: +7589
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue31546>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

2017-02-12 Thread Thomas Caswell 

Thomas Caswell added the comment:

I agree this is very confusing (and in fact confused me for about an hour 
between getting import errors, double checking the docs, checking I was in the 
right env, double checking the docs, checking the source of my env, double 
checking the docs, checking the git source and then tracking through these too 
issues).

--
nosy: +tcaswell

___
Python tracker 
<http://bugs.python.org/issue29481>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

2017-02-12 Thread Thomas Caswell 

Changes by Thomas Caswell :


--
pull_requests: +50

___
Python tracker 
<http://bugs.python.org/issue29481>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

2017-02-14 Thread Thomas Caswell 

Thomas Caswell added the comment:

I am not optimistic about the speed at which my employer will get this
sorted out.

better to just fix it and drop my commit!

On Tue, Feb 14, 2017, 23:43 Mariatta Wijaya  wrote:

Mariatta Wijaya added the comment:

Thanks, Raymond :) I prepared the pull requests for 3.5, 3.6, and master
branches.

Thomas, you mentioned about needing to go over CLA with your employer in
your PR.

Not sure if you have any update on that? If your CLA is approved, I can
merge and cherry-pick your PR instead.

--
stage:  -> patch review

___
Python tracker 
<http://bugs.python.org/issue29481>
___

--

___
Python tracker 
<http://bugs.python.org/issue29481>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

2016-01-31 Thread Thomas Caswell 

Thomas Caswell added the comment:

I do not think that readline-cancel.patch is sufficient. The clean up function 
that readline uses internally 
(http://git.savannah.gnu.org/cgit/readline.git/tree/isearch.c#n720 ) also 
cleans up the context that used by isearch.

The functions to cleanup the context (and a pointer to the context) are exposed 
on `rlprivate.h` so python _can_ get at them to support old versions of rl. 
Once started down that path for isearch mode, might as well vendor all of 
rl_callback_sigcleanup() which will end up being 50-100 LoC (some of the helper 
functions will also need to be vendored).

--
nosy: +tcaswell

___
Python tracker 
<http://bugs.python.org/issue24266>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

2016-01-31 Thread Thomas Caswell 

Thomas Caswell added the comment:

For reference https://github.com/ludwigschwardt/python-gnureadline/pull/47 is 
what a back-port of the functionality looks like.

--

___
Python tracker 
<http://bugs.python.org/issue24266>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22757] TclStackFree: incorrect freePtr. Call out of sequence?

2016-04-02 Thread Thomas Caswell 

Thomas Caswell added the comment:

I do not think this got reported to mpl, is a year and a half old, and has no 
example, probably can be closed.

--
nosy: +tcaswell

___
Python tracker 
<http://bugs.python.org/issue22757>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24176] Incorrect parsing of unpacked expressions in call

2015-05-13 Thread Thomas Caswell 

New submission from Thomas Caswell:

On the current tip (changeset: 96023:4b5461dcd190) the following results in a 
syntax error

def test(a='a', b='b'):
print(a, b)

opta = dict()
optb = dict(a=1, b=2)
test(**(opta or {}))  # <- works on all python
test(**optb or {})# <- fails on current hg tip


This is suspected to be a result of 
https://hg.python.org/cpython/rev/a65f685ba8c0 

This was reported as an issue against sphinx 
(https://github.com/sphinx-doc/sphinx/pull/1889) and I was redirected here.

As suggested by Robert Lehmann suggests the issue is 
https://hg.python.org/cpython/rev/a65f685ba8c0#l1.33 which should be `** test`. 
 Making this change prevents the syntax error (patch attached).

--
components: Interpreter Core
files: unpack_grammar.patch
keywords: patch
messages: 243087
nosy: tcaswell
priority: normal
severity: normal
status: open
title: Incorrect parsing of unpacked expressions in call
type: behavior
versions: Python 3.5
Added file: http://bugs.python.org/file39359/unpack_grammar.patch

___
Python tracker 
<http://bugs.python.org/issue24176>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com