[issue31074] Startup failure if executable is a \\?\ path on Windows
Shubha Ramani added the comment: May I take resolve this issue and submit a patch ? -- nosy: +shubha_bloodhound ___ Python tracker <http://bugs.python.org/issue31074> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30467] Propagate zipfile.py pypy issue #905 patch to CPython
New submission from Shubha Ramani: PyPy had a longstanding issue : ZipFile.extractall is very slow compared to CPython 2.6 https://bitbucket.org/pypy/pypy/issues/905/zipfileextractall-is-very-slow-compared-to which has been fixed in the PyPy code base. The changes were entirely in zipfile.py (see the attached patch for PyPy) The patch fixed a significant performance bottleneck in PyPy. -- files: issue905.diff keywords: patch messages: 294411 nosy: shubhar priority: normal severity: normal status: open title: Propagate zipfile.py pypy issue #905 patch to CPython type: performance versions: Python 2.7 Added file: http://bugs.python.org/file46898/issue905.diff ___ Python tracker <http://bugs.python.org/issue30467> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30467] Propagate zipfile.py pypy issue #905 patch to CPython 2.7
Changes by Shubha Ramani : -- title: Propagate zipfile.py pypy issue #905 patch to CPython -> Propagate zipfile.py pypy issue #905 patch to CPython 2.7 ___ Python tracker <http://bugs.python.org/issue30467> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7
New submission from Shubha Ramani: PyPy had a longstanding issue : ZipFile.extractall is very slow compared to CPython 2.6 https://bitbucket.org/pypy/pypy/issues/905/zipfileextractall-is-very-slow-compared-to which has been fixed in the PyPy code base. The changes were entirely in zipfile.py (see the attached patch for PyPy) The patch fixed a significant performance bottleneck in PyPy. -- files: issue905.diff keywords: patch messages: 294413 nosy: shubhar priority: normal severity: normal status: open title: Propagate zipfile.py pypy issue #905 patch to CPython 3.7 type: performance versions: Python 3.7 Added file: http://bugs.python.org/file46899/issue905.diff ___ Python tracker <http://bugs.python.org/issue30468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7
Shubha Ramani added the comment: Please assign this bug to me. I will submit a patch -- ___ Python tracker <http://bugs.python.org/issue30468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7
Shubha Ramani added the comment: serhiy sure I will attach proof of the performance bottle-neck on 2.7 and 3.7 before I submit a patch. Please assign this bug to me. -- ___ Python tracker <http://bugs.python.org/issue30468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30467] Propagate zipfile.py pypy issue #905 patch to CPython 2.7
Shubha Ramani added the comment: Please assign this bug to me. -- ___ Python tracker <http://bugs.python.org/issue30467> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7
Shubha Ramani added the comment: Serhiy yes what you said makes sense. Thanks for clarifying. Updates (benchmarking results) shortly...stay tuned. -- ___ Python tracker <http://bugs.python.org/issue30468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30476] Add _GenerateCRCTable() to zipfile.py to pre-compute CRC Table
New submission from Shubha Ramani: It is wasteful to generate the CRC Table every time, via _crctable = list(map(_gen_crc, range(256))). Better to have a pre-computed table. I will submit the patch which incorporates this feature along with micro-benchmark results. Related issue: http://bugs.python.org/issue30467 http://bugs.python.org/issue30468 -- messages: 294513 nosy: serhiy.storchaka, shubhar priority: normal severity: normal status: open title: Add _GenerateCRCTable() to zipfile.py to pre-compute CRC Table type: performance versions: Python 3.7 ___ Python tracker <http://bugs.python.org/issue30476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30476] Add _GenerateCRCTable() to zipfile.py to pre-compute CRC Table
Shubha Ramani added the comment: It looks like _GenerateCRCTable() is already implemented here: https://svn.python.org/projects/python/trunk/Lib/zipfile.py The question is, why isn't it implemented here ? https://github.com/python/cpython/blob/master/Lib/zipfile.py -- ___ Python tracker <http://bugs.python.org/issue30476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30476] Add _GenerateCRCTable() to zipfile.py to pre-compute CRC Table
Shubha Ramani added the comment: This is not needed after all jkloth explained. Please feel free to close. -- ___ Python tracker <http://bugs.python.org/issue30476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7
Shubha Ramani added the comment: Upon comparing the PyPy changes from attached diff to the latest cpython3 github, I don't find a need for improvement. Looks like cpython3 zipfile.py has the same changes and the read() method in class ZipExtFile(io.BufferedIOBase) is vastly improved compared to what pypy had. In fact it has been completely re-written. The CPython 2.7 version of this bug was promptly closed as a duplicate: http://bugs.python.org/issue30467 Perhaps the changes from CPython3 are not being backported to CPython2 ? This bug can be closed because CPython3 has no issues. -- ___ Python tracker <http://bugs.python.org/issue30468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
