[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: Hey, I am starting my journey with the contribution to CPython. and this is i think i can do these changes. if Charalampos is not there to work on it. i would like to try this. -- nosy: +shivank98 ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: Thanks, Charalampos :) I would be thankful if you or Serhiy can help me a little bit. so do I need to just do the following work? 1924--> n._call_user_data_handler(operation, n, entity) -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: *1924--> n._call_user_data_handler(operation, n, notation) -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: Oh, I see, so I believe that's where my learning of CPython is going to start. can anyone help me in completing this? what I understood till now is in minidom.py we need to change line 1924. else it, we need to create a test. I want to help in what should a test include and do we need to create a new function for it in test_minidom.py? -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: >I want to help in *need help in -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: now when I am running test_minidom.py for both 1,2 1: e._call_user_data_handler(operation, n, entity) 2: n._call_user_data_handler(operation, n, notation) I am receiving the same following result. FAIL: testRemoveAttributeNode (__main__.MinidomTest) -- Traceback (most recent call last): File "test_minidom.py", line 328, in testRemoveAttributeNode self.assertIs(node, child.removeAttributeNode(node)) AssertionError: is not None -- Ran 120 tests in 0.048s FAILED (failures=1) -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: Oh Sorry, it was like was more like a question. running test_minidom.py is giving an error for both (1 and 2), i am not sure even if "testRemoveAttributeNode (__main__.MinidomTest)" is related to _clone_node or not. should i first try solve for this error? or maybe i haven't understood what type of test function i need to write. -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: I See, I need to find out for what test case `_clone_node()` will show unexpected behaviour, which will verify that it is a bug and we also need a test code to in test_minidom.py just to verify the behaviour. am I going in right direction Tai? -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: I just want to update that i was not able to work more in last two days as i was busy in some personal work. now i am on it and will update something soon. Sorry for delay :) -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py
Shivank Gautam added the comment: Hey Tal, I am extremely sorry for all delay. actually, due to internship and my university exams, I am unable to dedicate my time to bug(#35052). please consider it and you can tell Charalampos Stratakis in the bug to push his prepared pull request. I hope you will be still supportive when I will return in mid-dec after completing my exams. -- ___ Python tracker <https://bugs.python.org/issue35052> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
