[issue1467929] %-formatting and dicts
Sean Reifschneider added the comment:
I'm attaching a new version of this which includes AMK's string patch
ported over to unicode.
Any objections to my committing this to the trunk? Should it also go in
for the next 2.5 release?
--
nosy: +jafo
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1467929>
_Index: Objects/unicodeobject.c
===
--- Objects/unicodeobject.c (revision 57477)
+++ Objects/unicodeobject.c (working copy)
@@ -7730,12 +7730,19 @@
*/
#define FORMATBUFLEN (size_t)120
+/* Constants for the type of % argument being used -- not known,
+ a mapping, or a tuple. */
+#define FORMAT_TYPE_UNKNOWN 0
+#define FORMAT_TYPE_MAPPING 1
+#define FORMAT_TYPE_TUPLE 2
+
PyObject *PyUnicode_Format(PyObject *format,
PyObject *args)
{
Py_UNICODE *fmt, *res;
Py_ssize_t fmtcnt, rescnt, reslen, arglen, argidx;
int args_owned = 0;
+int format_type = FORMAT_TYPE_UNKNOWN;
PyUnicodeObject *result = NULL;
PyObject *dict = NULL;
PyObject *uformat;
@@ -7806,6 +7813,13 @@
"format requires a mapping");
goto onError;
}
+ if (format_type == FORMAT_TYPE_TUPLE) {
+ PyErr_SetString(PyExc_ValueError,
+"both keyed and unkeyed format "
+"specifiers used");
+ goto onError;
+ }
+ format_type = FORMAT_TYPE_MAPPING;
++fmt;
--fmtcnt;
keystart = fmt;
@@ -7849,6 +7863,15 @@
arglen = -1;
argidx = -2;
}
+ else if (format_type == FORMAT_TYPE_MAPPING) {
+ PyErr_SetString(PyExc_ValueError,
+"both keyed and unkeyed format specifiers used"
+);
+ goto onError;
+ }
+ else if (format_type == FORMAT_TYPE_UNKNOWN) {
+ format_type = FORMAT_TYPE_TUPLE;
+ }
while (--fmtcnt >= 0) {
switch (c = *fmt++) {
case '-': flags |= F_LJUST; continue;
Index: Objects/stringobject.c
===
--- Objects/stringobject.c (revision 57477)
+++ Objects/stringobject.c (working copy)
@@ -4455,6 +4455,12 @@
*/
#define FORMATBUFLEN (size_t)120
+/* Constants for the type of % argument being used -- not known,
+ a mapping, or a tuple. */
+#define FORMAT_TYPE_UNKNOWN 0
+#define FORMAT_TYPE_MAPPING 1
+#define FORMAT_TYPE_TUPLE 2
+
PyObject *
PyString_Format(PyObject *format, PyObject *args)
{
@@ -4462,6 +4468,7 @@
Py_ssize_t arglen, argidx;
Py_ssize_t reslen, rescnt, fmtcnt;
int args_owned = 0;
+ int format_type = FORMAT_TYPE_UNKNOWN;
PyObject *result, *orig_args;
#ifdef Py_USING_UNICODE
PyObject *v, *w;
@@ -4534,6 +4541,12 @@
"format requires a mapping");
goto error;
}
+if (format_type == FORMAT_TYPE_TUPLE) {
+ PyErr_SetString(PyExc_ValueError,
+ "both keyed and unkeyed format specifiers used");
+ goto error;
+}
+format_type = FORMAT_TYPE_MAPPING;
++fmt;
--fmtcnt;
keystart = fmt;
@@ -4568,6 +4581,14 @@
arglen = -1;
argidx = -2;
}
+ else if (format_type == FORMAT_TYPE_MAPPING) {
+ PyErr_SetString(PyExc_ValueError,
+ "both keyed and unkeyed format specifiers used");
+ goto error;
+ }
+ else if (format_type == FORMAT_TYPE_UNKNOWN) {
+ format_type = FORMAT_TYPE_TUPLE;
+ }
while (--fmtcnt >= 0) {
switch (c = *fmt++) {
case '-': flags |= F_LJUST; continue;
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue459007] Document sys.path on Windows
Sean Reifschneider added the comment: This is a high priority item that hasn't been touched in half a decade. Mark: Consider this a reminder if this is still on your agenda to do. If not, shall we just close it? Is there anyone else that could do this? -- nosy: +jafo Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue459007> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue515751] Missing docs for module imputil
Sean Reifschneider added the comment: I've committed some *very* basic documentation as Doc/library/imputil.rst. This is mostly pulling the documentation I could find in the web and in the code and setting it up in Python doc format. I'm adding people who have recently touched the module, as well as Greg, to the nosy list. If someone could expand it, particularly the sections marked "Undocumented", that'd be great. Though the documentation is not perfect, it is something. I'm going to close this bug, let me know if there are any objections. -- nosy: +georg.brandl, gstein, jafo, loewis, tim_one status: open -> closed Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue515751> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1530559] struct.pack raises TypeError where it used to convert
Sean Reifschneider added the comment: etrepum: Can you fix the test which caused this to be re-opened? I'm tempted to push this down in priority from urgent to high, since the code is (apparently) fixed, just the test is failing, but ideally this could just get fixed. -- nosy: +jafo _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1530559> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.__new__
Changes by Sean Reifschneider: _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1692335> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.__new__
Changes by Sean Reifschneider: _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1692335> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue775964] fix test_grp failing on RedHat 6.2
Sean Reifschneider added the comment: A few comments on this one: Perhaps the tests should be patched instead of the grp module? Because it may be useful for someone to know that old-style NIS maps are being referenced. I presume if the change is made in grp that it should also be made in pwd? Shouldn't the patch do a "continue" instead of a break? I believe the "+" entry means "include the contents of the NIS map here (I don't believe it can be used for LDAP), and as far as I know does not HAVE to be included at the end of the file. We probably don't care, but just to be canonical it seems that there are also "+name" and "-name" entries in /etc/group and /etc/passwd. "+name" in an entry is the same as a "name" entry, but the additional fields are read from NIS. "-name" means that "name" is not a valid user (in other words, don't let "name" login, even if they exist in NIS). I can't imagine we want to implement those though, because... Note that the "+" syntax is the old syntax from before nsswitch was introduced. As far as I know, + syntax was deprecated back in 1995 when nsswitch.conf was added. In conclusion, I think the tests that the tests that annoy Anthony should be fixed, but I'm not convinced the behavior of grp should be changed. Particularly without a corresponding change in pwd. Thoughts? See the following URL for more information about the +/- syntax: http://bama.ua.edu/cgi-bin/man-cgi?nsswitch.conf+4 -- nosy: +jafo Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue775964> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1597011] Reading with bz2.BZ2File() returns one garbage character
Changes by Sean Reifschneider: -- assignee: -> jafo _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1597011> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1597011] Reading with bz2.BZ2File() returns one garbage character
Sean Reifschneider added the comment:
There are some bugs in the bz2 module. The problem boils down to the
following code, notice how *c is assigned *BEFORE* the check to see if
there was a read error:
do {
BZ2_bzRead(&bzerror, f->fp, &c, 1);
f->pos++;
*buf++ = c;
} while (bzerror == BZ_OK && c != '\n' && buf != end);
This could be fixed by putting a "if (bzerror == BZ_OK) break;" after
the BZ2_bzRead() call.
However, I also noticed that in the universal newline section of the
code it is reading a character, incrementing f->pos, *THEN* checking if
buf == end and if so is throwing away the character.
I changed the code around so that the read loop is unified between
universal newlines and regular newlines. I guess this is a small
performance penalty, since it's checking the newline mode for each
character read, however we're already doing a system call for every
character so one additional comparison and jump to merge duplicate code
for maintenance reasons is probably a good plan. Especially since the
reason for this bug only existed in one of the two duplicated parts of
the code.
Please let me know if this looks good to commit.
--
nosy: +jafo
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1597011>
_Index: Modules/bz2module.c
===
--- Modules/bz2module.c (revision 57479)
+++ Modules/bz2module.c (working copy)
@@ -249,24 +249,20 @@
for (;;) {
Py_BEGIN_ALLOW_THREADS
- if (univ_newline) {
- while (1) {
-BZ2_bzRead(&bzerror, f->fp, &c, 1);
-f->pos++;
-if (bzerror != BZ_OK || buf == end)
- break;
+ while (buf != end) {
+ BZ2_bzRead(&bzerror, f->fp, &c, 1);
+ if (bzerror != BZ_OK) break;
+ f->pos++;
+ if (univ_newline) {
if (skipnextlf) {
skipnextlf = 0;
if (c == '\n') {
- /* Seeing a \n here with
- * skipnextlf true means we
+ /* Seeing a \n here with skipnextlf true means we
* saw a \r before.
*/
newlinetypes |= NEWLINE_CRLF;
- BZ2_bzRead(&bzerror, f->fp,
- &c, 1);
- if (bzerror != BZ_OK)
- break;
+ BZ2_bzRead(&bzerror, f->fp, &c, 1);
+ if (bzerror != BZ_OK) break;
} else {
newlinetypes |= NEWLINE_CR;
}
@@ -276,17 +272,12 @@
c = '\n';
} else if ( c == '\n')
newlinetypes |= NEWLINE_LF;
-*buf++ = c;
-if (c == '\n') break;
}
- if (bzerror == BZ_STREAM_END && skipnextlf)
-newlinetypes |= NEWLINE_CR;
- } else /* If not universal newlines use the normal loop */
- do {
-BZ2_bzRead(&bzerror, f->fp, &c, 1);
-f->pos++;
-*buf++ = c;
- } while (bzerror == BZ_OK && c != '\n' && buf != end);
+ *buf++ = c;
+ if (c == '\n') break;
+ }
+ if (univ_newline && bzerror == BZ_STREAM_END && skipnextlf)
+ newlinetypes |= NEWLINE_CR;
Py_END_ALLOW_THREADS
f->f_newlinetypes = newlinetypes;
f->f_skipnextlf = skipnextlf;
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1403221] 2.3.5 source RPM install fails w/o tk-devel
Sean Reifschneider added the comment: I'm going to call this closed because this is basically a build environment problem and the RPM can't really detect it at build time. This is noted in the RPM building FAQ, and if you search for the "unclear" message you will find the resolution (either installing the TK development package or removing the TK runtime package, depending on your exact needs). -- status: open -> closed _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1403221> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1000] Patch to rename *Server modules to lower-case
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1000> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1598083] Top-level exception handler writes to stdout unsafely
Sean Reifschneider added the comment: I don't suppose you could wrangle up a proposed patch to fix this? -- nosy: +jafo _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1598083> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue837234] Tk.quit and sys.exit cause Fatal Error
Sean Reifschneider added the comment: Is this a bug or just incorrect usage? From reading the message it sounds like it may just have been an incorrect usage. If it's a bug, can we get a sample that reproduces the problem? -- nosy: +jafo Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue837234> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1001] 2to3 crashes on input files with no trailing newlines
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1001> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue889544] win32 raw socket support
Sean Reifschneider added the comment: Removed the "works for me" resolution because I think the poster accidentally selected this. No patch was attached, and the referenced URL for the information is gone now. Can the original submitter attach a patch for this. Once we have the patch I'm thinking about assigning to mhammond because Mark recently touched some of the Windows sections of the socket module. -- assignee: -> mhammond nosy: +jafo resolution: works for me -> Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue889544> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue837234] Tk.quit and sys.exit cause Fatal Error
Sean Reifschneider added the comment: blaforge: I know it's been years, but can you provide code that reproduces this? I'm going to switch it to "pending" state, please re-open when you include some code to reproduce it. -- status: open -> pending Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue837234> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1597011] Reading with bz2.BZ2File() returns one garbage character
Sean Reifschneider added the comment: I have committed this into trunk and the 2.5 maintenance branch. It passes all tests and the resulting build passes the submitter-provided test. -- status: open -> closed _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1597011> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1020] pydoc doesn't work on pyexpat
Changes by Sean Reifschneider: -- priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1020> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1021] logging.basicConfig does not allow to set NOTSET level
Changes by Sean Reifschneider: -- assignee: -> vsajip nosy: +vsajip priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1021> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1025] tracebacks from list comps (probably other comps) don't show full stack
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1025> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1042] test_glob fails with UnicodeDecodeError
Changes by Sean Reifschneider: -- priority: -> high __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1042> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1053] bogus attributes reported in asyncore doc
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1053> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1053] bogus attributes reported in asyncore doc
Changes by Sean Reifschneider: -- assignee: -> fdrake nosy: +fdrake __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1053> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1060] zipfile cannot handle files larger than 2GB (inside archive)
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1060> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1003] zipfile password fails validation
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1003> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1067] test_smtplib failures (caused by asyncore)
Changes by Sean Reifschneider: -- priority: -> high __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1067> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1079] decode_header does not follow RFC 2047
Sean Reifschneider added the comment: Can you provide an example of an address that triggers this? Preferably in a code sample that can be used to reproduce it? Uber-ideally, a patch to the email module test suite would be great. -- nosy: +jafo priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1079> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1597011] Reading with bz2.BZ2File() returns one garbage character
Changes by Sean Reifschneider: -- resolution: -> fixed _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1597011> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1081] file.seek allows float arguments
Changes by Sean Reifschneider: -- assignee: -> loewis nosy: +loewis priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1081> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1082] platform system may be Windows or Microsoft since Vista
Sean Reifschneider added the comment: Attached a patch which I *THINK* fixes this, but I don't run Windows. Can someone else check this? -- assignee: -> lemburg nosy: +jafo, lemburg priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1082> __Index: Lib/platform.py === --- Lib/platform.py (revision 58178) +++ Lib/platform.py (working copy) @@ -1158,7 +1158,9 @@ An empty string is returned if the value cannot be determined. """ -return uname()[0] +systemName = uname()[0] +if systemName == 'Microsoft': return 'Windows' +return systemName def node(): @@ -1177,7 +1179,10 @@ An empty string is returned if the value cannot be determined. """ -return uname()[2] +unameInfo = uname() +if unameInfo[0] == 'Microsoft' and unameInfo == 'Windows': +return 'Vista' +return unameInfo[2] def version(): ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1087] py3k os.popen result is not iterable, patch attached
Changes by Sean Reifschneider: -- assignee: -> aimacintyre nosy: +aimacintyre priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1087> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1004] MultiMethods with type annotations in 3000
Changes by Sean Reifschneider: -- assignee: -> gvanrossum nosy: +gvanrossum priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1004> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1082] platform system may be Windows or Microsoft since Vista
Sean Reifschneider added the comment: Supplied patch passes "make test", BTW. -- keywords: +patch __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1082> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1027] uudecoding (uu.py) does not supprt base64, patch attached
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1027> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1254718] GCC detection for runtime_library_dirs when ccache is used
Sean Reifschneider added the comment: NOTE: See also issue1032 which has a patch for this. Can we come to a consensus on which one has the best patch? -- assignee: -> loewis nosy: +jafo, loewis _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1254718> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1032] Improve the hackish runtime_library_dirs support for gcc
Changes by Sean Reifschneider: -- assignee: -> loewis nosy: +loewis priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1032> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1047] py3k: corrections for test_subprocess on windows
Changes by Sean Reifschneider: -- priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1047> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1061] ABC caches should use weak refs
Changes by Sean Reifschneider: -- assignee: -> georg.brandl priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1061> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1086] test_email failed
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1086> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1022] use bytes for code objects
Changes by Sean Reifschneider: -- assignee: -> gvanrossum priority: -> low resolution: -> remind __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1022> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1045] Performance regression in 2.5
Changes by Sean Reifschneider: -- assignee: -> tim_one nosy: +tim_one priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1045> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1077] itertools missing, causes interactive help to break
Changes by Sean Reifschneider: -- assignee: -> georg.brandl priority: -> low severity: urgent -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1077> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1102> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1110] Problems with the msi installer - python-3.0a1.msi
Changes by Sean Reifschneider: -- assignee: -> loewis priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1110> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1115] Minor Change For Better cross compile
Changes by Sean Reifschneider: -- assignee: -> loewis nosy: +loewis priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1115> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1104> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1034] [patch] Add 2to3 support for displaying warnings as Python comments
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1034> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1109] Warning required when calling register() on an ABCMeta subclass
Changes by Sean Reifschneider: -- assignee: -> gvanrossum nosy: +gvanrossum priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1109> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1005] Patches to rename Queue module to queue
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1005> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1002] Patch to rename HTMLParser module to lower_case
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1002> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1108] Problem with doctest and decorated functions
Changes by Sean Reifschneider: -- assignee: -> tim_one nosy: +tim_one priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1108> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1014] cgi: parse_qs and parse_qsl misbehave on empty strings
Changes by Sean Reifschneider: -- assignee: -> gvanrossum nosy: +gvanrossum priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1014> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1128] msilib.Directory.make_short only handles file names with a single dot in them
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1128> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1124] Webchecker not parsing css "@import url"
Changes by Sean Reifschneider: -- priority: -> low severity: normal -> minor status: open -> pending __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1124> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1126] file.fileno and file.isatty() should be implementable by any file like object
Sean Reifschneider added the comment: This is a documentation complaint, right? Perhaps more of a discussion of why not implement these attributes on file-like objects. In general, I believe the documentation is correct. Setting fileno to -1 is likely to break other things in unexpected ways. Because when opening a real file object, -1 would mean the file open failed, and the file object would not get created. The documentation is right, right? -- assignee: -> fdrake components: +Documentation -Library (Lib) nosy: +fdrake, jafo priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1126> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1131] Reference Manual: "for statement" links to "break statement"
Sean Reifschneider added the comment: Can I get more information about how to reproduce this? What is it you do to get to this? It sounds like you're talking about some HTML documentation, but if I go to the current documentation in the Language section, and click on the "for" section, I do get the for document: http://docs.python.org/dev/reference/compound_stmts.html#the-for-statement -- assignee: -> jafo nosy: +jafo priority: -> normal status: open -> pending __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1131> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1137] pyexpat patch for changing buffer_size
Changes by Sean Reifschneider: -- assignee: -> akuchling nosy: +akuchling priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1137> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1114] _curses issues on 64-bit big-endian (e.g, AIX)
Changes by Sean Reifschneider: -- assignee: -> akuchling components: +Library (Lib) -Extension Modules nosy: +akuchling priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1114> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1140] re.sub returns str when processing empty unicode string
Sean Reifschneider added the comment: Applied as revision 58179 to 2.5 maintenance branch, passes tests. -- nosy: +jafo priority: -> low status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1140> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1144] parsermodule validation out of sync with Grammar
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1144> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1530559] struct.pack raises TypeError where it used to convert
Changes by Sean Reifschneider: -- priority: urgent -> normal _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1530559> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.__new__
Sean Reifschneider added the comment: It's not clear to me what the next step is here, does one or more of the other folks need to provide some input? Georg: If you are looking for something from someone, can you assign the ticket to them? -- assignee: -> georg.brandl nosy: +jafo _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1692335> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue815646] thread unsafe file objects cause crash
Sean Reifschneider added the comment: If I read the 2003 python-dev thready correctly, there isn't a solution to this. Does this need to go back to python-dev, or do we just call it "wont fix"? Or...? -- assignee: -> tim_one nosy: +jafo, tim_one Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue815646> ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1150] Rename PyBUF_WRITEABLE to PyBUF_WRITABLE
Sean Reifschneider added the comment:
Attached is a patch that fixes "writeable". I'm thinking, close this if
the patch looks ok, and open another for a general "identify
non-englishisms" ticket, once they're identified a ticket could be
opened to fix them.
I fixed only the PyBUF instances but also documents and comments and doc
strings and printfs where it occurred. Yes? Let me know if it looks
good to commit.
Does this need a fix in 2to3?
--
assignee: -> gvanrossum
keywords: +patch
nosy: +jafo
priority: -> low
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1150>
__Index: Include/abstract.h
===
--- Include/abstract.h (revision 58179)
+++ Include/abstract.h (working copy)
@@ -524,9 +524,9 @@
Py_ssize_t *buffer_len);
/*
- Takes an arbitrary object which must support the (writeable,
+ Takes an arbitrary object which must support the (writable,
single segment) buffer interface and returns a pointer to a
- writeable memory location in buffer of size buffer_len.
+ writable memory location in buffer of size buffer_len.
0 is returned on success. buffer and buffer_len are only
set in case no error occurrs. Otherwise, -1 is returned and
Index: Include/object.h
===
--- Include/object.h (revision 58179)
+++ Include/object.h (working copy)
@@ -162,7 +162,7 @@
/* Flags for getting buffers */
#define PyBUF_SIMPLE 0
#define PyBUF_CHARACTER 1
-#define PyBUF_WRITEABLE 0x0002
+#define PyBUF_WRITABLE 0x0002
#define PyBUF_LOCKDATA 0x0004
#define PyBUF_FORMAT 0x0008
#define PyBUF_ND 0x0010
@@ -172,19 +172,19 @@
#define PyBUF_ANY_CONTIGUOUS (0x0100 | PyBUF_STRIDES)
#define PyBUF_INDIRECT (0x0200 | PyBUF_STRIDES)
-#define PyBUF_CONTIG (PyBUF_ND | PyBUF_WRITEABLE)
+#define PyBUF_CONTIG (PyBUF_ND | PyBUF_WRITABLE)
#define PyBUF_CONTIG_RO (PyBUF_ND)
#define PyBUF_CONTIG_LCK (PyBUF_ND | PyBUF_LOCKDATA)
-#define PyBUF_STRIDED (PyBUF_STRIDES | PyBUF_WRITEABLE)
+#define PyBUF_STRIDED (PyBUF_STRIDES | PyBUF_WRITABLE)
#define PyBUF_STRIDED_RO (PyBUF_STRIDES)
#define PyBUF_STRIDED_LCK (PyBUF_STRIDES | PyBUF_LOCKDATA)
-#define PyBUF_RECORDS (PyBUF_STRIDES | PyBUF_WRITEABLE | PyBUF_FORMAT)
+#define PyBUF_RECORDS (PyBUF_STRIDES | PyBUF_WRITABLE | PyBUF_FORMAT)
#define PyBUF_RECORDS_RO (PyBUF_STRIDES | PyBUF_FORMAT)
#define PyBUF_RECORDS_LCK (PyBUF_STRIDES | PyBUF_LOCKDATA | PyBUF_FORMAT)
-#define PyBUF_FULL (PyBUF_INDIRECT | PyBUF_WRITEABLE | PyBUF_FORMAT)
+#define PyBUF_FULL (PyBUF_INDIRECT | PyBUF_WRITABLE | PyBUF_FORMAT)
#define PyBUF_FULL_RO (PyBUF_INDIRECT | PyBUF_FORMAT)
#define PyBUF_FULL_LCK (PyBUF_INDIRECT | PyBUF_LOCKDATA | PyBUF_FORMAT)
Index: Include/memoryobject.h
===
--- Include/memoryobject.h (revision 58179)
+++ Include/memoryobject.h (working copy)
@@ -33,15 +33,15 @@
The buffertype argument can be PyBUF_READ, PyBUF_WRITE,
PyBUF_UPDATEIFCOPY to determine whether the returned buffer
- should be READONLY, WRITEABLE, or set to update the
+ should be READONLY, WRITABLE, or set to update the
original buffer if a copy must be made. If buffertype is
PyBUF_WRITE and the buffer is not contiguous an error will
be raised. In this circumstance, the user can use
- PyBUF_UPDATEIFCOPY to ensure that a a writeable temporary
+ PyBUF_UPDATEIFCOPY to ensure that a a writable temporary
contiguous buffer is returned. The contents of this
contiguous buffer will be copied back into the original
object after the memoryview object is deleted as long as
- the original object is writeable and allows setting its
+ the original object is writable and allows setting its
memory to "readonly". If this is not allowed by the
original object, then a BufferError is raised.
Index: Objects/abstract.c
===
--- Objects/abstract.c (revision 58179)
+++ Objects/abstract.c (working copy)
@@ -304,9 +304,9 @@
pb = obj->ob_type->tp_as_buffer;
if (pb == NULL ||
pb->bf_getbuffer == NULL ||
-((*pb->bf_getbuffer)(obj, &view, PyBUF_WRITEABLE) != 0)) {
+((*pb->bf_getbuffer)(obj, &view, PyBUF_WRITABLE) != 0)) {
PyErr_SetString(PyExc_TypeError,
-"expected an object with a writeable buffer interface");
+"expected an object with a writable buffer interface");
return -1;
}
@@ -659,10 +659,10 @@
"Cannot ma
[issue1130] Idle - Save (buffer) - closes IDLE and does not save file (Windows XP)
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1130> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1019] Cleanup pass on _curses and _curses_panel
Changes by Sean Reifschneider: -- priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1019> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1123] split(None, maxsplit) does not strip whitespace correctly
Sean Reifschneider added the comment: I believe this is just a place where the documentation could be cleared up. Seems to me the confusion is from the document saying (paraphrased): "white space is removed from both ends". Perhaps it should say something like "runs of 1 or more whitespace are collapsed (up to the maximum split), and then split on" or simply "split on runs of 1 or more whitespace. In other words, 3 spaces together would be treated as a single split-point instead of 3 0-length fields separated by spaces." So, in the first example provided by "nirs" in this issue, "both ends" refers to both the left and right side of "k:". Since maxsplit is 1, the second part (v) is left untouched. This is the intended operation. This is a documentation bug, not a library bug. Fred: Thoughts on wording? -- assignee: -> fdrake components: +Documentation -Library (Lib) nosy: +fdrake, jafo priority: -> low __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1123> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1150] Rename PyBUF_WRITEABLE to PyBUF_WRITABLE
Changes by Sean Reifschneider: -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1150> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1150] Rename PyBUF_WRITEABLE to PyBUF_WRITABLE
Sean Reifschneider added the comment: Comitted as revision 58182, with additional change mentioned by Guido. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1150> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1082] platform system may be Windows or Microsoft since Vista
Sean Reifschneider added the comment:
Attached is a patch that fixes uname() instead of the individual
helpers. I agree that is the better way to do it. Again, not tested on
Windows because I don't have it.
What about adding a "isWindows()" sort of method that does the right
thing, or "amIRunningOn('Vista')"? I suggest the latter because I
imagine the former might just lead to a bunch of "Where is isX()?" for
different platforms. This could implement the logic so that users don't
have to know the details of this issue.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1082>
__Index: Lib/platform.py
===
--- Lib/platform.py (revision 58178)
+++ Lib/platform.py (working copy)
@@ -1146,6 +1146,12 @@
machine = ''
if processor == 'unknown':
processor = ''
+
+# normalize name
+if system == 'Microsoft' and release == 'Windows':
+system = 'Windows'
+release = 'Vista'
+
_uname_cache = system,node,release,version,machine,processor
return _uname_cache
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1126] file.fileno and file.isatty() should be implementable by any file like object
Sean Reifschneider added the comment: I'm thinking that nirs is not thinking of this in the "duck typing" environment. Duck typing says that you implement things that are appropriate for your object type, and code does what it needs to do. If the object doesn't support attributes that the code it's passed to needs, (it doesn't "quack like a duck"), then the code should fail. I think nirs is thinking that you have to check every attribute before you use it. But if the object you implement doesn't reasonably have a "istty" or "fileno" associated with it, the Python Way is that if you pass it to code that needs that attribute, that it bomb out. There may be cases where you might write code that checks for an attribute, say if the code can provide enhanced functionality if the attribute is available, but can still provide it's basic functionality if it does not. I'm agreeing that I don't think the documentation is incorrect in this case. I'm thinking that nirs should probably take this to the python mailing list, and if after discussion there it is believed to still be a problem, reference the thread here and re-open it. I'm going to call it closed for the moment. -- resolution: -> works for me status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1126> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1082] platform system may be Windows or Microsoft since Vista
Sean Reifschneider added the comment: Shall I commit my "v2" patch then, to 2.5.2 and trunk? It has the code in the uname() method, as you say. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1082> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1082] platform system may be Windows or Microsoft since Vista
Changes by Sean Reifschneider: -- versions: +Python 2.6 __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1082> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1082] platform system may be Windows or Microsoft since Vista
Sean Reifschneider added the comment: Commited in trunk revision 58183 and 25-maint revision 58184. -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1082> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1131] Reference Manual: "for statement" links to "break statement"
Sean Reifschneider added the comment: I don't know anything about the .chm file. Fred: Do you know where this comes from? -- assignee: jafo -> fdrake nosy: +fdrake status: pending -> open __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1131> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1149] fdopen does not work as expected
Sean Reifschneider added the comment: I do not believe this is a Python problem but instead a problem with your code. I believe the problem is likely that you still have a copy of the stdout is open, the fork that is reading also gets associated with that same file. I can't point you at any specific references, but you should check Posix references or possibly other sources for more information about side-effects such as this. These interactions, I have found, can be pretty subtle, so you may need to spend some time on getting everything right. -- nosy: +jafo resolution: -> invalid status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1149> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1141] reading large files
Sean Reifschneider added the comment: I'm closing this because the slow I/O issue is known and expected to be resolved as part of the Python 3.0 development. The Windows problems with missing lines should be opened as a separate issue. -- nosy: +jafo resolution: -> duplicate status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1141> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1155] Carbon.CF memory management problem
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1155> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1157] test_urllib2net fails on test_ftp
Changes by Sean Reifschneider: -- assignee: -> jafo components: +Tests nosy: +jafo priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1157> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1151] "TypeError: expected string, bytes found" instead of KeyboardInterrupt
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1151> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1161] Garbled chars in offending line of SyntaxError traceback
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1161> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1159] os.getenv() not updated after external module uses C putenv()
Changes by Sean Reifschneider: -- priority: -> normal resolution: -> postponed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1159> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1083] Confusing error message when dividing timedelta using /
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1083> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1163] Patch to make py3k/Lib/test/test_thread.py use unittest
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1163> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1135] xview/yview of Tix.Grid is broken
Sean Reifschneider added the comment: I can verify that on Red Hat 7 Python 2.5 that the test does fail and the patch resolves it. -- nosy: +jafo priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1135> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1099] Mac compile fails with pydebug and framework enabled
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1099> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1135] xview/yview of Tix.Grid is broken
Changes by Sean Reifschneider: -- nosy: -jafo __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1135> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1134] Parsing a simple script eats all of your memory
Changes by Sean Reifschneider: -- assignee: -> nnorwitz nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1134> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1134] Parsing a simple script eats all of your memory
Sean Reifschneider added the comment:
Confirmed problem (used 4.5GB before I killed it), and that the second
patch resolved the problem. I'm uploading the inline patch as an
attachment, with the directory name in it as well (from svn diff).
Bumping the priority to high because the side effect can cause all sorts
of problems on a system including other processes being killed.
--
nosy: +jafo
priority: -> high
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1134>
__Index: Parser/tokenizer.c
===
--- Parser/tokenizer.c (revision 58192)
+++ Parser/tokenizer.c (working copy)
@@ -395,6 +395,7 @@
goto error;
buflen = size;
}
+
memcpy(s, buf, buflen);
s[buflen] = '\0';
if (buflen == 0) /* EOF */
@@ -402,6 +403,12 @@
if (allocated) {
Py_DECREF(bufobj);
}
+
+ if ( bufobj == tok->decoding_buffer ){
+Py_XDECREF(tok->decoding_buffer);
+tok->decoding_buffer = 0;
+ }
+
return s;
error:
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1157] test_urllib2net fails on test_ftp
Changes by Sean Reifschneider: -- assignee: jafo -> nobody nosy: +nobody __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1157> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1167] gdbm/ndbm 1.8.1+ needs libgdbm_compat.so
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1167> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1169] Option -OO doesn't remove docstrings from functions
Changes by Sean Reifschneider: -- assignee: -> georg.brandl nosy: +georg.brandl priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1169> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1175] .readline() has bug WRT nonblocking files
Sean Reifschneider added the comment: Doesn't the exception count as warning the user? We probably don't want to change readline to return a partial line in this case. An exception could be added for EGAIN that includes the partial line. Another option would be to just document the behavior for readline or fcntl. What is the right behavior for a non-blocking readline? Obviously, it can't return a None and buffer the line. Another option would be to define readline as a blocking operation and enable buffering before starting the readline, and possibly revert it when done. Opinions? -- components: +Library (Lib) -Interpreter Core nosy: +jafo priority: -> low type: behavior -> rfe versions: +Python 2.4, Python 2.5, Python 2.6 __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1175> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1170] shlex have problems with parsing unicode
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1170> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1171] allow subclassing of bytes type
Changes by Sean Reifschneider: -- assignee: -> gvanrossum keywords: +patch, py3k nosy: +gvanrossum priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1171> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1172] Documentation for done attribute of FieldStorage class
Sean Reifschneider added the comment: Patch looks good to me. Fred? Comments on "should I do more fixes": Just straight documentation changes are, in my experience, fairly likely to be processed quickly. Changes to the code may take quite a lot more discussion. Smaller, individual patches are likely to be taken much more than large mega patches that change many things. So, my recommendation would be to do individual efforts: Fix the current documentation, fix "XXX fix me" parts, do enhancements. I understand where you're coming from, I spent a full day implementing string.rsplit() including documentation, only to have it languish for around a year before other people re-opening the rejected submission finally got it accepted. However, python definitely benefits from the attention. Sometimes things do get dropped, because of other commitments from the maintainers. Assign your issue that has been ignored to me and I'll take a look at it. -- assignee: -> fdrake keywords: +patch nosy: +fdrake, jafo priority: -> normal versions: +Python 2.6 __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1172> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1175] .readline() has bug WRT nonblocking files
Sean Reifschneider added the comment: Why are you putting the file in non-blocking mode? Why not just reading in blocking mode? If you want to do other work when a line is not available, you could use select to check to see if there's data ready via a small or 0 timeout. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1175> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1176] str.split() takes no keyword arguments (Should this be expected?)
Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1176> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1177] urllib* 20x responses not OK?
Sean Reifschneider added the comment: Facundo: Should this be closed? -- nosy: +jafo priority: -> normal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1177> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1175] .readline() has bug WRT nonblocking files
Sean Reifschneider added the comment: Arguably, you should be using "select" and "read" (instead of readline) for this operation. That's what I've done in the past when doing something similar. Specifically, I believe I have looped reading into a buffer with read, and using select with a timeout (even a fraction of a second can work) until the timeout triggers. This way I don't block, but I also don't run into problems with the system call returning an error. I avoid using readline in this case because I don't expect it to work well on the stdout of an interactive command. You may also want to look at the pty module. I guess I'd say this should probably go to the python mailing list for further discussion. Can you post a message there about it? __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1175> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
