[issue38698] While parsing email message id: UnboundLocalError

2019-11-20 Thread PCManticore


Change by PCManticore :


--
keywords: +patch
pull_requests: +16770
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17277

___
Python tracker 
<https://bugs.python.org/issue38698>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38526] zipfile.Path has the wrong method name

2019-11-21 Thread PCManticore


Change by PCManticore :


--
keywords: +patch
pull_requests: +16804
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17317

___
Python tracker 
<https://bugs.python.org/issue38526>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38876] pickle is raising KeyError insteat of pickle.UnpicklingError under certain conditions

2019-11-21 Thread PCManticore


PCManticore  added the comment:

It seems there are a couple of places in `_pickle.c` where we favour a 
`KeyError` instead of `UnpicklingError` such as 
https://github.com/python/cpython/blob/master/Modules/_pickle.c#L6178. From a 
quick debugging it seems it originates in `load_long_binget`. 

Ideally those places should return `UnpicklingError` instead, not sure why a 
`KeyError` was preferred. Happy to submit a patch if that's a change that makes 
sense.

--
nosy: +Claudiu.Popa

___
Python tracker 
<https://bugs.python.org/issue38876>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38876] pickle is raising KeyError insteat of pickle.UnpicklingError under certain conditions

2019-11-22 Thread PCManticore


Change by PCManticore :


--
keywords: +patch
pull_requests: +16819
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17335

___
Python tracker 
<https://bugs.python.org/issue38876>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38854] Decorator breaks inspect.getsource

2019-11-25 Thread PCManticore


Change by PCManticore :


--
keywords: +patch
pull_requests: +16857
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17374

___
Python tracker 
<https://bugs.python.org/issue38854>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38854] Decorator breaks inspect.getsource

2019-11-25 Thread PCManticore


PCManticore  added the comment:

Thanks for the report!

Turns out this was a bug in ``inspect.BlockFinder`` which is responsible for 
extracting out the source code from a given block. This class was considering 
")" inside a decorator call as closing the decorator itself, even when the 
decorator call was accepting additional arguments that needed parentheses, such 
as function calls or tuples.

Just submitted a PR https://github.com/python/cpython/pull/17374 to address 
this issue.

--
nosy: +Claudiu.Popa

___
Python tracker 
<https://bugs.python.org/issue38854>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36470] dataclasses.replace raises an exception if InitVar with default argument is not provided.

2019-12-02 Thread PCManticore


Change by PCManticore :


--
keywords: +patch
pull_requests: +16922
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17441

___
Python tracker 
<https://bugs.python.org/issue36470>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38572] Misleading AttributeError accessing fileno attribute in tarfile

2019-12-03 Thread PCManticore


Change by PCManticore :


--
nosy: +Claudiu.Popa

___
Python tracker 
<https://bugs.python.org/issue38572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38572] Misleading AttributeError accessing fileno attribute in tarfile

2019-12-03 Thread PCManticore


Change by PCManticore :


--
keywords: +patch
pull_requests: +16930
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17449

___
Python tracker 
<https://bugs.python.org/issue38572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38572] Misleading AttributeError accessing fileno attribute in tarfile

2019-12-03 Thread PCManticore


PCManticore  added the comment:

Just submitted a PR for this issue, hope I got it right. Curious to see if 
there are any backwards compatibility concerns with this approach.

--

___
Python tracker 
<https://bugs.python.org/issue38572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38947] dataclass defaults behave inconsistently for init=True/init=False when default is a descriptor

2019-12-10 Thread PCManticore


Change by PCManticore :


--
nosy: +Claudiu.Popa

___
Python tracker 
<https://bugs.python.org/issue38947>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com