[issue11151] Arguments to various types not specified in types module

[Noufal]

New submission from Noufal :

The documentation for the types module seems to have an obvious bug. The 
arguments to create the various types are not mentioned in the docs page on 
http://docs.python.org/library/types.html

This came to my attention from a stack overflow question here
http://stackoverflow.com/questions/4933325/where-can-i-find-documentation-for-calling-the-various-types-in-pythons-types-mo

--
assignee: docs@python
components: Documentation
messages: 128175
nosy: docs@python, noufal
priority: normal
severity: normal
status: open
title: Arguments to various types not specified in types module
type: behavior
versions: Python 2.7

___
Python tracker 
<http://bugs.python.org/issue11151>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3132] implement PEP 3118 struct changes

[Noufal]

Changes by Noufal :


--
nosy: +noufal

___
Python tracker 
<http://bugs.python.org/issue3132>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4860] js_output wrong for cookies with " characters

[Noufal]

New submission from Noufal :

If a cookie is created with a " character in the content, the js_output
which is emitted is bad javascript. eg.
>>> import Cookie
>>> c=Cookie.Cookie('Customer="WILE_E_COYOTE"; Version=1; Path=/acme')
>>> print c
Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme; Version=1
>>> print c.js_output()


<!-- begin hiding
document.cookie = "Customer="WILE_E_COYOTE"; Path=/acme; Version=1";
// end hiding -->


>>> 

Also, the test_cookie tests (test_load) explicitly checks for this
(wrong) output.

I have attached a patch that seems to fix this or at the very least
produces the same Cookie settings whether the cookie is set using the
header or using javascript (I've verified this on firefox on Linux).

--
components: Library (Lib), Tests
files: cookie.patch
keywords: patch
messages: 79292
nosy: noufal
severity: normal
status: open
title: js_output wrong for cookies with " characters
type: behavior
versions: Python 2.7
Added file: http://bugs.python.org/file12625/cookie.patch

___
Python tracker 
<http://bugs.python.org/issue4860>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4860] js_output wrong for cookies with " characters

[Noufal]

Noufal  added the comment:

A lot of the cookie tests need to be updated. A separate bug was filed
regarding this. http://bugs.python.org/issue3788. 

I'm working on that now and will apply your patch there as well.

___
Python tracker 
<http://bugs.python.org/issue4860>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4860] js_output wrong for cookies with " characters

[Noufal]

Noufal  added the comment:

What's wrong with < and >?

I can see the issues with ; though.

___
Python tracker 
<http://bugs.python.org/issue4860>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3788] test_cookie isn't comprehensive

[Noufal]

Noufal  added the comment:

This patch contains some simple tests for Morsel. I will update it again
to increase coverage.

The changes to the Cookie tests assume that the patch in issue4860 has
been applied.

--
keywords: +patch
nosy: +noufal
Added file: http://bugs.python.org/file13154/test_cookie.patch

___
Python tracker 
<http://bugs.python.org/issue3788>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com