[issue4111] Add Systemtap/DTrace probes
Mark Wielaard added the comment: > - renamed the probepoints: > "function__entry" -> "frame__entry" > "function__return" -> "frame__exit" >as I believe this better describes what these do Are you sure you want to do this? You are right that it better describes the action that these probe points signify. But since previous versions of this patch have been used and applied people might be depending on the old names. It is not a very big issue, we can always write a tapset to translate the old to new names. But it is an interface break for anybody who might already have scripts around. -- ___ Python tracker <http://bugs.python.org/issue4111> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4111] Add Systemtap/DTrace probes
Mark Wielaard added the comment: The original patch was created to be as close as possible to the support that Sun and Apple added to their python implementation for Solaris and MacOS. Changing the probe point names would make the current patch slightly different for scripts written against those. That isn't a major problem, and can be worked around in user scripts or a tapset that translates the old names to new names. But it is something to consider before changing the probe names. -- ___ Python tracker <http://bugs.python.org/issue4111> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14776] Add SystemTap static markers
Changes by Mark Wielaard : -- nosy: +mjw ___ Python tracker <http://bugs.python.org/issue14776> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14776] Add SystemTap static markers
Mark Wielaard added the comment: Just a comment that newer [eu]-readelf -n will provide a nicer view of the sdt ELF notes. You might want to suggest that in the documentation. e.g. $ eu-readelf -n /usr/lib64/libpython2.7.so Note section [ 1] '.note.gnu.build-id' of 36 bytes at offset 0x190: Owner Data size Type GNU 20 GNU_BUILD_ID Build ID: a28f8db1b224530b0d38ad7b82a249cf7c3f18d6 Note section [27] '.note.stapsdt' of 184 bytes at offset 0x1ae884: Owner Data size Type stapsdt 70 Version: 3 PC: 0xe0d3a, Base: 0x14b150, Semaphore: 0x3ae882 Provider: python, Name: function__return, Args: '8@%rbx 8@%r13 -4@%eax' stapsdt 69 Version: 3 PC: 0xe0f37, Base: 0x14b150, Semaphore: 0x3ae880 Provider: python, Name: function__entry, Args: '8@%rbx 8@%r13 -4@%eax' -- ___ Python tracker <http://bugs.python.org/issue14776> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4111] Add DTrace probes
Changes by Mark Wielaard : -- nosy: +mjw ___ Python tracker <http://bugs.python.org/issue4111> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4111] Add Systemtap/DTrace probes
Mark Wielaard added the comment: I took the patch and tweaked it a little so that it works with systemtap (at least for the function entry/exit probes). It is against 2.6.2 since that was what was in the Fedora 12 src package I was using. Cleaned up the configure checks a little, but otherwise it is almost exactly as is. Also tracked in Fedora as https://bugzilla.redhat.com/show_bug.cgi?id=545179 -- components: -Installation title: Add DTrace probes -> Add Systemtap/DTrace probes Added file: http://bugs.python.org/file15503/stap-python.patch ___ Python tracker <http://bugs.python.org/issue4111> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
