[issue4470] smtplib SMTP_SSL not working.
Lorenzo M. Catucci added the comment:
On Fri, 17 Jun 2011, R. David Murray wrote:
RDM>
RDM> R. David Murray added the comment:
RDM>
RDM> According to your traceback you should be seeing the error in the
RDM> first line (the creation of the SMTP_SSL object). If I run that line
RDM> at the python prompt of python2.7.1, I get your connection failure.
RDM> If I run it using 2.7 tip (or 3.3 tip), the connection succeeds. I
RDM> know there have been other fixes in this area, but I don't know which
RDM> one makes the difference.
RDM>
RDM> Torsten, can you test with 2.7.2 and/or 2.7 tip?
RDM>
RDM> I'm not sure what is left to do in this issue. Do you have an
RDM> opinion, Lorenzo?
RDM>
Torsten, would you mind letting us know both the python and the .deb
version by running
$ python2.7 --version
and
$ dpkg -l python2.7
At least in debian's python2.7_2.7.1-8, default_port is still an instance
attribute instead of a class attribute.
If the ubuntu situation is the same, the missing patch is
smtplib_01_default_port.diff , and you could work-around the problem by
explicitly calling s = smtplib.SMTP_SSL("relay-auth.rwth-aachen.de", 465).
The patch got in with:
changeset: 69931:bcf04ced5ef1
branch: 2.7
parent: 69915:7c3a20b5943a
user:Antoine Pitrou
date:Sat May 07 19:59:33 2011 +0200
summary: Issue #11927: SMTP_SSL now uses port 465 by default as
documented. Patch by Kasun Herath.
The last hunk, which fixes LMTP is still missing.
@@ -776,8 +777,9 @@
authentication, but your mileage might vary."""
ehlo_msg = "lhlo"
+default_port = LMTP_PORT
-def __init__(self, host = '', port = LMTP_PORT, local_hostname =
None):
+def __init__(self, host = '', port = 0, local_hostname = None):
"""Initialize a new instance."""
SMTP.__init__(self, host, port, local_hostname)
Have a nice week-end, yours
lorenzo
+-+--+
| Lorenzo M. Catucci | Centro di Calcolo e Documentazione |
| catu...@ccd.uniroma2.it | Università degli Studi di Roma "Tor Vergata" |
| | Via O. Raimondo 18 ** I-00173 ROMA ** ITALY |
| Tel. +39 06 7259 2255 | Fax. +39 06 7259 2125|
+-+--+
--
___
Python tracker
<http://bugs.python.org/issue4470>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file22401/v2_01_fix_lmtp_init ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file22402/v2_02_mock_socket_shutdown ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file22403/v2_03_shutdown_socket_on_close ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file22403/v2_03_shutdown_socket_on_close ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file22402/v2_02_mock_socket_shutdown ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Lorenzo M. Catucci added the comment: Just finished testing both 2.7 and default branches' socket close behaviour, and it seems 05 is not strictly needed. I'd still prefer if smtplib_05_shutdown_socket_v2.patch since, this way the REMOTE socket close will be unconditionally correct, instead of being dependent on GC artifacts. -- ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Lorenzo M. Catucci added the comment: I'd still prefer if smtplib_05_shutdown_socket_v2.patch could get in, ^^ since, this way the REMOTE socket close will be unconditionally correct, instead of being dependent on GC artifacts. -- ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
New submission from Lorenzo M. Catucci <[EMAIL PROTECTED]>: The enclosed patch does three things: 1. enables SMTP_SSL working: the _get_socket method was setting self.sock instead of returning the socket to the caller, which did reset self.sock to None 2. replace home-grown SSLFakeFile() with calls to ssl.socket's makefile() calls both in the starttls and in the SMTP_SSL cases 3. shutdown sockets before closing them, to avoid server-side piling and connection refused on connection-limited servers The last change is just a cosmetical refactoring, but it really helps the SMTP_SSL case: default_port should really be a class attribute, instead of being set at __init__ time. -- components: Library (Lib) files: smtplib.py.patch keywords: patch messages: 76640 nosy: lcatucci severity: normal status: open title: smtplib SMTP_SSL not working. versions: Python 2.6 Added file: http://bugs.python.org/file12168/smtplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
New submission from Lorenzo M. Catucci <[EMAIL PROTECTED]>: In the enclosed patch, there are three changes: 1. Support starttls on IMAP4 connections 2. Rework of the IMAP_SSL, to replace home-grown file-like methods with proper ones from ssl module's makefile(); 3. Properly shutdown sockets at close() time to avoid server-side pile-up -- components: Library (Lib) files: imaplib.py.patch keywords: patch messages: 76641 nosy: lcatucci severity: normal status: open title: IMAP4 missing support for starttls versions: Python 2.6 Added file: http://bugs.python.org/file12169/imaplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
New submission from Lorenzo M. Catucci <[EMAIL PROTECTED]>: In the enclosed patch, there are four changes 1. add support for the optional CAPA pop command, since it is needed for starttls support discovery 2. add support for the STLS pop command 3. replace home-grown file-like methods and replace them with ssl socket's makefile() in POP3_SSL 4. Properly shutdown sockets at close() time to avoid server-side pile-up -- files: poplib.py.patch keywords: patch messages: 76643 nosy: lcatucci severity: normal status: open title: POP3 missing support for starttls Added file: http://bugs.python.org/file12170/poplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: the needed changes to library documentation if the patch is accepted Added file: http://bugs.python.org/file12171/imaplib.rst.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: The needed changes to documentation if the patch gets accepted Added file: http://bugs.python.org/file12172/poplib.rst.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: I understand the need to keep things simple, but this time the split seemed a bit overkill. If needed, I'll redo the patch into a small series. Thinking of it... I was unsure if it really made sense to split out smtp/pop/imap patches instead of sending them all at once... :-) As for the shutdown before close, it's needed to let the server know we are leaving, instead of waiting until socket timeout. This is the reason I need to keep the reference to the wrapped socket. You don't usually configure maildrop servers to limit the number/rate of connects as you do on smtp servers; still, you could get into problems with stateful forewalls or the like. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: As in #4473: if needed, I'll redo the patch into a small series. I've cut and pasted the following. As for the shutdown before close, it's needed to let the server know we are leaving, instead of waiting until socket timeout. This is the reason I need to keep the reference to the wrapped socket. You don't usually configure maildrop servers to limit the number/rate of connects as you do on smtp servers; still, you could get into problems with stateful firewalls or the like. As for the last comment, I'll gladly look at your changes and try to copy^H^H^H^Hbackport them. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12189/poplib_04_STLS.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12170/poplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: I'm reasonably sure Victor is right about the original socket being unneeded. How does the series look now? ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: Changed CAPA as requested: now there is a proper docstring, and the useless if ... else ... is gone. Added file: http://bugs.python.org/file12192/poplib_01_CAPA.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12186/poplib_01_CAPA.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: As for the shutdown/close comment, I think there could be cases where you are going to close but don't want to shutdown: e.g. you might close a dup-ed socket, but the other owner would want to continue working with his copy of the socket. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12186/poplib_01_CAPA.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12187/poplib_02_sock_shutdown.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12188/poplib_03_SSL_refactor.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: As requested, I've split the patch into three parts: the first one does just refactor IMAP4_SSL, the second is really a one liner for shutting down the socket before closing it, and the thirs does introduce the starttls method in IMAP4. Added file: http://bugs.python.org/file12193/imaplib_01_SSL_refactor.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12194/imaplib_02_shutdown.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12195/imaplib_03_starttls.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12169/imaplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12168/smtplib.py.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12197/smtplib_01_default_port.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12198/smtplib_02_fix_ssl.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12199/smtplib_03_use_makefile.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file12200/smtplib_04_remove_fakefile.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Lorenzo M. Catucci <[EMAIL PROTECTED]> added the comment: I've reworked the patch into a series, like haypo requested for poplib and imaplib. Added file: http://bugs.python.org/file12201/smtplib_05_shutdown_socket.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Lorenzo M. Catucci added the comment: I just found out that the gmail servers don't support connections on the standard pop3/imapv4 ports, but only on the SSL wrapped ones. I'm unsure if cmu.edu anonymous imap server admin's would be happy with their server becoming python's official imap/pop testing playground; still, I just verified it does support TLS upgrades both for pop3 and imap and anonymous (read-only) logins. I think I could cook-up something. ___ Python tracker <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Lorenzo M. Catucci added the comment: Thanks for following-up, Bill. While I fully understand the need for unit-testing, I don't have the guts to start writing a dummy imap server from scratch. I tested my changes on a couple of servers I manage, one running uw-imapd and the other running cyrus imapd; still, I don't think unit tests could rely on a "real" server. On the other hand, I don't think a python.org hosted test server would be a very wise choice: even if we found some dummy all-data-in-memory server, I fear the ssl/tls load on the server. ___ Python tracker <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4471] IMAP4 missing support for starttls
Lorenzo M. Catucci added the comment: As the tests are new, I hope sending the real file is the right way to proceed. Added file: http://bugs.python.org/file12963/test_imapnet.py ___ Python tracker <http://bugs.python.org/issue4471> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file12964/test_smtpnet.py ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file12965/test_popnet.py ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : -- components: +Library (Lib) ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci added the comment: There is a problem I forgot to state with test_anonlogin: since I try and test both SSL and starttls, the DoS checker at cmu kicks in and refuse the login attempt in PopSSLTest. Since I'd rather avoid cheating, I'm leaning to try logging in as SomeUser, and expecting a failure in both cases. Comments? ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci added the comment: I'm enclosing the expected-failure version of test_popnet. It's much simpler to talk and comment about something you can see! Added file: http://bugs.python.org/file12966/test_popnet.py ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12188/poplib_03_SSL_refactor.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12172/poplib.rst.patch ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12187/poplib_02_sock_shutdown.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12189/poplib_04_STLS.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26132/poplib_01_socket_shutdown.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26134/poplib_03_starttls.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12192/poplib_01_CAPA.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12965/test_popnet.py ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file12966/test_popnet.py ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26133/poplib_02_server_capabilities.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci added the comment: I've refreshed the patches to apply on 3.3, and adapted the to the unit-test framework by giampaolo.rodola. -- ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26240/poplib_02_server_capabilities.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26133/poplib_02_server_capabilities.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26134/poplib_03_starttls.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26241/poplib_03_starttls.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26242/poplib_03_starttls.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26241/poplib_03_starttls.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci added the comment: I've refreshed once more the patches, adding the implementation of the stls command in test_poplib.py. IMHO, the changes as they stand now are low risk, and could as well go into 3.3. With many thanks to Giampaolo for implementing the asynchat/asyncore pop3 server! -- ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26250/poplib_01_socket_shutdown_v3.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26251/poplib_02_server_capabilities_v3.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file26252/poplib_03_starttls_v3.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26132/poplib_01_socket_shutdown.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26240/poplib_02_server_capabilities.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26242/poplib_03_starttls.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file28025/poplib_02_server_capabilities_v4.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Added file: http://bugs.python.org/file28026/poplib_03_starttls_v4.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26251/poplib_02_server_capabilities_v3.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file26252/poplib_03_starttls_v3.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci added the comment:
Updated 02 and 03 patches (mostly) in line with Antoine's review comments:
> 2) poplib_02_server_capabilities_v3.diff:
> - please try to follow PEP 8 (i.e. `capa = {}` not `capa={}`)
> - I think the capa() result should be a dict mapping str keys to str > values
> (not bytes), since that part of the POP3 protocol seems to
> have a well-defined character set (ASCII)
Completely right. Done.
> 3) poplib_03_starttls_v3.diff:
>
> - same comment about PEP 8
where?
> - why did you change the signature of the _create_socket()
> method? it looks gratuitous
undone
> - the new method should be called starttls() as in other modules, not >
> stls()
Here I'm following: at :ref:`pop3-objects` in Doc/library/poplib.rst,
All POP3 commands are represented by methods of the same name, in
lower-case; most return the response text sent by the server.
IMHO, having a single method with a name different than the underlying
POP command would just be confusing. For this reason, I'd rather avoid
adding an alias like in
starttls = stls
or the reverse...
> - starttls() should only take a context argument; no need to support >
> separate keyfile and certfile arguments
Right, non need to mimick pre-SSLContext method signatures!
> - what is the point of catching errors like this:
> [...]
undone
--
___
Python tracker
<http://bugs.python.org/issue4473>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Lorenzo M. Catucci added the comment: OK, I'm uploading poplib_03_starttls_v5.diff; I only changed the "caps=self.capa()" into "caps = self.capa()" in the "@@ -352,21 +360,42 @@ class POP3:" hunk. Thank you for pointing at the line; I tried to run pep8.py on poplib.py, but failed to find the line, since I was overwhelmed by the reported pre-existing pep8 inconsistencies... I'm tempted to open a pep8 issue on poplib after we finish with stls... Thank you very much for reviewing! -- Added file: http://bugs.python.org/file28085/poplib_03_starttls_v5.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4473] POP3 missing support for starttls
Changes by Lorenzo M. Catucci : Removed file: http://bugs.python.org/file28026/poplib_03_starttls_v4.diff ___ Python tracker <http://bugs.python.org/issue4473> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4470] smtplib SMTP_SSL not working.
Lorenzo M. Catucci added the comment: On Sun, 19 May 2013, R. David Murray wrote: RDM> RDM> R. David Murray added the comment: RDM> RDM> Lorenzo, any chance you could supply a unit test that fails without RDM> smtplib_05_shutdown_socket.diff applied? RDM> It would really be a functional test, since the problem with half-open connection pile-up stems from smtp server's access control rules. To test we should setup a fake smtp server, which forbids having multiple connections from the same IP address, and connect twice in a row to the fake server. I'm not sure I'm able to implement both an smtpd.py server serving more than one connection and the client code in a race-free way in the same "unit" test. Will try in the next week. Thank you very much, lorenzo -- ___ Python tracker <http://bugs.python.org/issue4470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
