[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-08-25 Thread Lorenz Mende 


Change by Lorenz Mende :


--
keywords: +patch
pull_requests: +15175
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15488

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2019-09-28 Thread Lorenz Mende 


Change by Lorenz Mende :


--
pull_requests: +16036
pull_request: https://github.com/python/cpython/pull/16456

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-06-09 Thread Lorenz Mende 


Lorenz Mende  added the comment:

Did some minor changes with win_utils.
Encoding changed to 'oem'.
@heckad: does this bugfix work for u?

@all: please verify working of the changes with different localizations.
thx

--
Added file: https://bugs.python.org/file48406/win_utils.py

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-06-09 Thread Lorenz Mende 


Change by Lorenz Mende :


Removed file: https://bugs.python.org/file48285/win_utils.py

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

2019-04-09 Thread Lorenz Mende 


Change by Lorenz Mende :


--
pull_requests: +12669

___
Python tracker 
<https://bugs.python.org/issue32409>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-19 Thread Lorenz Mende 

New submission from Lorenz Mende :

The test suite fails with the first tests (I assume 1st call of getloadavg of 
WindowsLoadTracker).
Traceback (most recent call last):
  File "P:\Repos\CPython\cpython\lib\runpy.py", line 192, in _run_module_as_main
return _run_code(code, main_globals, None,
  File "P:\Repos\CPython\cpython\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
  File "P:\Repos\CPython\cpython\lib\test\__main__.py", line 2, in 
main()
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\main.py", line 653, in 
main
Regrtest().main(tests=tests, **kwargs)
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\main.py", line 586, in 
main
self._main(tests, kwargs)
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\main.py", line 632, in 
_main
self.run_tests()
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\main.py", line 515, in 
run_tests
self.run_tests_sequential()
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\main.py", line 396, in 
run_tests_sequential
self.display_progress(test_index, text)
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\main.py", line 150, in 
display_progress
load_avg_1min = self.getloadavg()
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\win_utils.py", line 81, 
in getloadavg
typeperf_output = self.read_output()
  File "P:\Repos\CPython\cpython\lib\test\libregrtest\win_utils.py", line 78, 
in read_output
return response.decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x81 in position 67: 
invalid start byte
##
The windows 'typeperf "\System\Processor Queue Length" -si 1' command unluckily 
returns an string with an umlaut which leads to the Decode-Error. This comes up 
because the  for the typeperf is location dependend. (In german the 
counter would read \System\Prozessor-Warteschlangenlänge)

I see two possible solutions to this issue.
1. Raising an exception earlier on creation of WindowsLoadTracker resulting in 
the same behaviour as if there is no typeperf available (german pythoneers 
would have a drawback with this)
2. Getting the typeperf counter correctly from registry 
(HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows 
NT\CurrentVersion\Perflib\CurrentLanguage, described here 
https://social.technet.microsoft.com/Forums/de-DE/25bc6907-cf2c-4dc8-8687-974b799ba754/powershell-ausgabesprache-umstellen?forum=powershell_de)

environment:
Windows 10 x64, 1809, german
cpython @e16467af0bfcc9f399df251495ff2d2ad20a1669
commit of assumed root cause of https://bugs.python.org/issue34060

--
components: Tests
messages: 340547
nosy: LorenzMende
priority: normal
severity: normal
status: open
title: test suite broken due to cpu usage feature on win 10/ german
type: crash
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-19 Thread Lorenz Mende 


Change by Lorenz Mende :


--
nosy: +ammar2

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-19 Thread Lorenz Mende 


Change by Lorenz Mende :


--
nosy:  -ammar2

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-19 Thread Lorenz Mende 

Lorenz Mende  added the comment:

Hi Ammar, you are correct.
typeperf returns:
P:\Repos\CPython\cpython>typeperf "\System\Prozessor-Warteschlangenlänge" -si 1

"(PDH-CSV 4.0)","\\ZERO\System\Prozessor-Warteschlangenlänge"
"04/19/2019 19:09:14.510","0.00"
"04/19/2019 19:09:15.514","0.00"

So even with correct counter name the outpu needs to be decoded correctly.
I already got a solution to get the location specific counter name from 
registry - if it helps I'll commit it.

--

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-24 Thread Lorenz Mende 


Lorenz Mende  added the comment:

Sorry, was off some days. I tried to decode the output with mbcs, solves the 
issue partly - the counter name is still wrong.
Was able to pick the localization specific counter name from registry and use 
it for the typeperf.

But the tests fail after several seconds with Broken Pipe Error of the 
command_stdout pipe.

@Ammar - why is the handle closed in start()? If I uncomment it, the load 
tracker workks fine.

Added the fixed file, may someone evaluate the solution on another windows 
localization?

--
Added file: https://bugs.python.org/file48285/win_utils.py

___
Python tracker 
<https://bugs.python.org/issue36670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32942] test_script_helper fails on Windows when run from the source code directory

2018-06-30 Thread Lorenz Mende 


Change by Lorenz Mende :


--
keywords: +patch
pull_requests: +7643
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue32942>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32942] test_script_helper fails on Windows when run from the source code directory

2018-06-30 Thread Lorenz Mende 


Lorenz Mende  added the comment:

I confirm the issue too.
I am running the tests on a win 10 Ver 1709, clean build.

Most likely the issue is caused by the changes from commit 
fa9a502a387a26ba116840d35ae4a30f672e78ad
at test.support.script_helper
The function in test was altered to support a different behaviour when run from 
CI. The related tests were not changed.

As I am relativly new to python-dev: Does the bot/ user machines differ in the 
existence of PYTHONHOME? (Then the passing of the bot runs are plausible)

The tests are modified/ one added. PR attached.

--
nosy: +LorenzMende

___
Python tracker 
<https://bugs.python.org/issue32942>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34144] venv activate.bat reset codepage fails on windows 10

2018-07-18 Thread Lorenz Mende 


New submission from Lorenz Mende :

environment: Windows 10 Pro German/ 1803
cpython @master

When running the venv activate.bat the script fails to reset the codepage to 
the stored.

# Parameterformat falsch - 65001.

It seems that version 1803 brought a small change to the output of chcp.com - a 
dot is appended at the output

The issue can be solved by modifying the codepage grep of activate.bat:
for /f "tokens=2 delims=:." %%a in ('"%SystemRoot%\System32\chcp.com"') do (...

A pull will be requested.

--
components: Library (Lib)
messages: 321868
nosy: LorenzMende
priority: normal
severity: normal
status: open
title: venv activate.bat reset codepage fails on windows 10
type: behavior
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34144>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34144] venv activate.bat reset codepage fails on windows 10

2018-07-18 Thread Lorenz Mende 


Change by Lorenz Mende :


--
keywords: +patch
pull_requests: +7857
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue34144>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

2018-07-21 Thread Lorenz Mende 


Lorenz Mende  added the comment:

Approving the behaviour on 3.6.5 and fresh cpython-built @master:

>From the docs: test_sundry "contains extremely basic regression tests... which 
>don't have separate tests of their own".

IMHO 2to3 can be added to the whitelist of test_sundry as it comes with its own 
unit tests. When test_sundry runs import_tool with '2to3', lib2to3 is called 
without args, resulting in an exit 2 which breaks the basic test.

--
nosy: +LorenzMende

___
Python tracker 
<https://bugs.python.org/issue25094>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34200] importlib: python -m test test_pkg -m test_7 fails randomly

2018-09-01 Thread Lorenz Mende 


Lorenz Mende  added the comment:

I was able to reproduce the issue with Win 10, current cpython @master.
All sequential test runs are good.
With parallel execution a race condition comes up, as Victor already mentioned.

I was able to track the issue to the teardown function of the TestCase
In parallel the cleanup of the modules crashed the other tests.

line 57: support.modules_cleanup(*self.modules_before)

Is it possible to manage the cleanup differently?

--
nosy: +LorenzMende

___
Python tracker 
<https://bugs.python.org/issue34200>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23460] Decimals do not obey ':g' exponential notation formatting rules

2018-09-02 Thread Lorenz Mende 


Lorenz Mende  added the comment:

I want to bring this issue up again.
As the others correctly stated, either the documentation or the implementation 
of Decimal 'g' formatting is incorrect.

For floats the implementation suits the docu:
>>> '{:g}'.format(0.1)
'1e-05'
For decimals:
>>> '{:g}'.format(decimal.Decimal('0.1'))
'0.1'

As there is a deviation between documentation and implementation, I advise to 
modify one of both.

--
nosy: +LorenzMende

___
Python tracker 
<https://bugs.python.org/issue23460>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2018-09-02 Thread Lorenz Mende 


Lorenz Mende  added the comment:

This issue shall be closed, as the solution is already on master with 
4171bbe687904582329c7977d571686953275b45.

--
nosy: +LorenzMende

___
Python tracker 
<https://bugs.python.org/issue23949>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5038] urrlib2/httplib doesn't reset file position between requests

2018-09-02 Thread Lorenz Mende 


Lorenz Mende  added the comment:

Issue shall be closed, as no reproduction code is provided.
No patch provided and no comments since 2015.

--
nosy: +LorenzMende

___
Python tracker 
<https://bugs.python.org/issue5038>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34200] importlib: python -m test test_pkg -m test_7 fails randomly

2018-09-03 Thread Lorenz Mende 


Lorenz Mende  added the comment:

@jeremy: nice work
The fix works for me reproducable, tests run normal now.
Why dont you create a PR?

Can someone explain why this issue only came up with parallel tests?

--

___
Python tracker 
<https://bugs.python.org/issue34200>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com