[issue21914] Create unit tests for Turtle guionly

2018-06-26 Thread Lita Cho


Lita Cho  added the comment:

Feel free.

On Tue, Jun 26, 2018, 3:21 AM RAJALAKSHMI V  wrote:

>
> RAJALAKSHMI V  added the comment:
>
> Hey, I am a new contributor here. Could I take this issue up?
>
> --
> nosy: +RAJALAKSHMI V
>
> ___
> Python tracker 
> <https://bugs.python.org/issue21914>
> ___
>

--

___
Python tracker 
<https://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20585] urllib2 unrelease KQUEUE on Mac OSX 10.9+

2014-04-20 Thread Lita Cho

Lita Cho added the comment:

Going to try working on this.

--
nosy: +Lita.Cho

___
Python tracker 
<http://bugs.python.org/issue20585>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-05-23 Thread Lita Cho

Lita Cho added the comment:

I tested the patch and it looks correct upon inspection. It looks like it 
applies cleanly and a straight forward solution. 

I made a slight change so that when the Demo exits, it has a better message. I 
also added the change to the NEWS.txt file. 

I also ran the IDLE tests, and everything passed. I didn't see new tests added, 
but I am not sure if that is needed, since we are just adding a menu binding.

I've attached my patch with the changes listed above. It should be ready for 
review.

--
nosy: +Lita.Cho, jesstess
Added file: http://bugs.python.org/file35328/issue.patch

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3015] tkinter with wantobjects=False has been broken for some time

2014-05-23 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +Lita.Cho, jesstess

___
Python tracker 
<http://bugs.python.org/issue3015>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-05-23 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +Lita.Cho, jesstess

___
Python tracker 
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-05-23 Thread Lita Cho

Changes by Lita Cho :


___
Python tracker 
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3015] tkinter with wantobjects=False has been broken for some time

2014-05-23 Thread Lita Cho

Lita Cho added the comment:

I am in the process of reviewing this patch, but I don't know what 
"wantobjects" does. I can make a guess, I think it is a hack to make tcl 
objects work in Python. I am guessing this is less needed in Python 3.4, but 
still has some dependencies. 

If we can add in the documentation of what "wantobjects" is and why it is being 
depreciated somewhere, that would be great. I would do it myself, but I do need 
some direction.

I ran the tests, and it seems to run fine. The patch didn't have any new tests. 
We should add one that checks if the depreciation is working.

--

___
Python tracker 
<http://bugs.python.org/issue3015>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-05-23 Thread Lita Cho

Lita Cho added the comment:

I was looking at this more, and from my understanding, the turtle code is 
continuing to run even when the TK window is destroyed. Thus the crash.

It looks like the drawing functions are being made on the fly with the 
following method:

for methodname in _tg_turtle_functions:
pl1, pl2 = getmethparlist(eval('Turtle.' + methodname))
if pl1 == "":
print(">>>>>>", pl1, pl2)
continue
defstr = ("def %(key)s%(pl1)s: return _getpen().%(key)s%(pl2)s" %
   {'key':methodname, 'pl1':pl1, 'pl2':pl2})
exec(defstr)
eval(methodname).__doc__ = 
_turtle_docrevise(eval('Turtle.'+methodname).__doc__)

So while all the methods are being generated, I am going to add in a check to 
see if the window was destroyed before running the pen code. If it was, then I 
exit gratefully. The check will be duplicated for each pen method, but I feel 
it is the best way to contain the check within the turtle.py module. The other 
option would be to make the user check for it, which is not a good option.

--

___
Python tracker 
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-05-24 Thread Lita Cho

Lita Cho added the comment:

I did not know that NEWS items should not be edited unless it is about to be 
committed. The previous comments suggested to put it in. Thank you for the 
feedback.

I can move the Turtle Demp into the Help Menu rather than the File menu. I 
agree that it seems out of place. I can also make it such that it runs the demo 
as an external process rather than within IDLE. That way, it is completely 
separate by IDLE and we don't create a dependency.

I think if we were to load in future demos, they could be run as other 
processes rather than within IDLE, so that future additions don't end up 
crashing IDLE.

--

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21573] Clean up turtle.py code formatting

2014-05-24 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +Lita.Cho

___
Python tracker 
<http://bugs.python.org/issue21573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21573] Clean up turtle.py code formatting

2014-05-24 Thread Lita Cho

Lita Cho added the comment:

I'm claiming this ticket. Plan to work on it during my OPW internship.

--

___
Python tracker 
<http://bugs.python.org/issue21573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-05-27 Thread Lita Cho

Lita Cho added the comment:

I am currently in the process of editing this patch such that the Turtle Demo 
launches from the Help Menu and spawns a separate process. 

However, I am deciding whether if the separate process should be asynchronous 
or not. Currently, I have it working with the subprocess module, but the IDLE 
window is hanging. 

I can use the multiprocess module or Popen to make it asynchronous. However, I 
am not sure where the clean-up should happen once the turtle process has been 
terminated.

--

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-05-27 Thread Lita Cho

Lita Cho added the comment:

Okay, maybe "hanging" is not the right word. The IDLE window becomes busy since 
it spawned off the Turtle demo subprocess, and it is waiting for the subprocess 
to finish. After I close the Turtle window, it returns back to normal.

I was wondering if the Turtle Demo should be a separate asynchronous process so 
that users could use the IDLE window as well as the Turtle demo.

--

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-05-27 Thread Lita Cho

Lita Cho added the comment:

I currently have a patch where the Turtle Demo now shows up in the Help menu 
rather than in File menu.

I also have it such that Turtle is now launched as a separate process rather 
than within the IDLE process. Currently, the commend is calling ./python.exe so 
it uses my build of Python rather than my system's python. But I can change 
that once people agree this is the right way to go.

--
Added file: http://bugs.python.org/file35383/turtle_demo.patch

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3015] tkinter with wantobjects=False has been broken for some time

2014-05-27 Thread Lita Cho

Lita Cho added the comment:

Serhiy, does that mean this is fixed the way it is? Do I need to do anything 
else to close out this issue? It looks like wantobjects is set to False, 
currently.

--

___
Python tracker 
<http://bugs.python.org/issue3015>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-05-27 Thread Lita Cho

Lita Cho added the comment:

So I have a patch that fixes the original problem, but doesn't fix the crash 
with the tdemo_round_dance.py. However, I was wondering why 
TurtleScreen._RUNNING = True in the _destroy method. Can anyone shed some light 
on this? Here is the current state of my patch.

--
keywords: +patch
Added file: http://bugs.python.org/file35384/turtle_bug.patch

___
Python tracker 
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21585] Run Tkinter tests with wantobjects=False

2014-05-28 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +Lita.Cho, jesstess

___
Python tracker 
<http://bugs.python.org/issue21585>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21585] Run Tkinter tests with wantobjects=False

2014-05-28 Thread Lita Cho

Lita Cho added the comment:

So I don't know what the best way to do this, but I changed the widget_tests.py 
in order to set tkinter.wantobjects = 0 if a 'wantobjects' flag was passed 
through test.support.use_resources. 

Then I added a new test called test_ttk_guionly_wantobj, where it turns on 
wantobjects. If we create a new module, then we start off with a clean tkinter 
object.

Before I go this route for all the tests, I wanted to make sure if this was the 
correct way to go about it.

--

___
Python tracker 
<http://bugs.python.org/issue21585>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21585] Run Tkinter tests with wantobjects=False

2014-05-28 Thread Lita Cho

Lita Cho added the comment:

Patches lived in my Linux machine. I've attached my patch. I will add my module 
next.

--
keywords: +patch
Added file: http://bugs.python.org/file35394/test_wantobj.patch

___
Python tracker 
<http://bugs.python.org/issue21585>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21585] Run Tkinter tests with wantobjects=False

2014-05-28 Thread Lita Cho

Changes by Lita Cho :


Added file: http://bugs.python.org/file35395/test_ttk_guionly_wantobj.py

___
Python tracker 
<http://bugs.python.org/issue21585>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21573] Clean up turtle.py code formatting

2014-05-30 Thread Lita Cho

Lita Cho added the comment:

Hi Terry,

> is there project link? are any of the mentors core developers, with
>  commit rights? or would you need commits from someone like me?

I am not 100% sure. Let me ask Jessica, who is my mentor, and get back to you.

> I have read turtle.py and found that the multiple layers made some 
> things hard to follow. To me, this was a bigger impediment than code
>  formatting. You may want to develop an outline of the layer
>  structure.

There is no project link to Turtle cleanup specifically. But I can definitely 
try to reorganize the code such that it flows better and it is easier to read. 
I can add that to the list.

> As you may know, Guido generally discourages pure code cleanups and
> prefers that they be done when the code is examined for other 
> purposes. I personally think some changes are safe enough if verified 
> by a second person.

I actually did not know that Guido discourages pure code cleanup. Should I try 
to find a feature to add? Currently, I am doing all the easy stuff, and making 
it pep8 compliant and work through linter. I am also trying to delete some of 
the commented out code.

> I looked for and did not fine test/test_turtle. Did I miss something?
> Turtledemo is a partial substitute, but it might not exercise all 
> turtle functions.

I actually don't see the Turtle tests as well. Should creating unit tests for 
turtle.py be a separate ticket?

I am currently developing off of 3.4. I will try to run my patch through all 
the versions of Python 3 to make sure it is a clean fix.

--

___
Python tracker 
<http://bugs.python.org/issue21573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21573] Clean up turtle.py code formatting

2014-06-01 Thread Lita Cho

Lita Cho added the comment:

Thank you so much for your support, Terry. I really appreciate all your 
feedback. Your comments have been very helpful as I am learning Turtle and 
Tkinter.

Most of my changes are related to spacing, visual indentation, consistent line 
spaces between method definitions, and making sure all the code falls within 80 
lines. They have been all been minor changes that wouldn't change the logic of 
the code. I haven't gotten to removing the commented out code yet.

I will wait to commit this till I fix a bug in Turtle.

--

___
Python tracker 
<http://bugs.python.org/issue21573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-06-01 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +jesstess

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-06-01 Thread Lita Cho

Lita Cho added the comment:

Okay! That makes sense. Any bugs that Turtle has, people will assume IDLE has 
them too if they launch it from IDLE.

I will take on #21597, and work on that instead. Thanks!

--

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-06-01 Thread Lita Cho

Lita Cho added the comment:

I'll take this on.

--
nosy: +Lita.Cho

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-06-02 Thread Lita Cho

Lita Cho added the comment:

So it looks like the bug fix was really simple. I just needed to set 
TurtleScreen._RUNNING to True when the screen object tries to get destroyed.

--
Added file: http://bugs.python.org/file35462/turtle_crash.patch

___
Python tracker 
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-06-02 Thread Lita Cho

Lita Cho added the comment:

Oops, pressed submit too soon.

Now the programs raise a Terminator exception rather than a TclError, which I 
think is correct because the programs are calling Turtle methods when the 
TurtleScreen had been destroyed. 

I wasn't sure if it was better to return None rather than raise an exception, 
but I think raising exception is correct, as these programs are not calling 
mainloop to handle event loops. So when the user closes the window, 
round_dance.py should handle that.

--

___
Python tracker 
<http://bugs.python.org/issue6639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21655] Write Unit Test for Vec2 class in the Turtle Module

2014-06-04 Thread Lita Cho

New submission from Lita Cho:

Ingrid and I are trying to add test coverage to the Turtle module as there 
isn't one currently. Going to work on testing the Vec2 module.

--
components: Tests, Tkinter
messages: 219747
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Write Unit Test for Vec2 class in the Turtle Module
type: enhancement
versions: Python 3.5

___
Python tracker 
<http://bugs.python.org/issue21655>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21656] Create test coverage for TurtleScreenBase in Turtle

2014-06-04 Thread Lita Cho

New submission from Lita Cho:

Turtle module currently doesn't have any tests. This ticket is tracking the 
tests created for TurtleScreenBase.

--
components: Tests
messages: 219748
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create test coverage for TurtleScreenBase in Turtle
versions: Python 3.5

___
Python tracker 
<http://bugs.python.org/issue21656>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-06-06 Thread Lita Cho

Lita Cho added the comment:

Hi Terry!

I went ahead and added a movable divider (also known as a "sash") using the 
PanedWindow widget. http://effbot.org/tkinterbook/panedwindow.htm#reference

I also converted the master window to use a grid geometry manager. It looks 
like you can use pack manager and grid managers together as long as each 
manager is separated by a container/frame. So I use the pack manager to manage 
the scrollbars within the Frame. It ended up working out nicely.

I've attached a patch and would like to submit it for review!

--
keywords: +patch
Added file: http://bugs.python.org/file35503/turtledemo_pane.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-06-09 Thread Lita Cho

Lita Cho added the comment:

Hi Terry!

> 2. More important: when I move the slider right, the text widen and the 
> canvas narrows relatively smoothly. 

This is not due to the mixing of Pack and Grid Managers. This is due to adding 
Frames within a Pane Window. If I just create two empty Pane Windows, I don't 
get the lag. However, if I add a Frame container within Pane Window, I do. I've 
tried switching between using only the Pack Manager and then again using only 
the Grid Manager. However, that lag still exists. 

I have the code here if you want to try the packed version.

```
from tkinter import *
root = Tk()
m = PanedWindow(root, orient=HORIZONTAL, sashwidth=10)
rightF =  Frame(m)
leftF = Frame(m)
top = Label(leftF, text="lefgt pane", bg='blue')
bottom = Label(rightF, text="right pane", bg='red')
top.pack(fill=BOTH, expand=1)
bottom.pack(fill=BOTH, expand=1)
m.add(leftF)
m.add(rightF)

m.pack(fill=BOTH, expand=1)
mainloop()
```

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-06-09 Thread Lita Cho

Lita Cho added the comment:

> 1. The minor one: The blue label does not have drop shadows, the red/yellow 
> buttons do. 

I created a patch to add a border around the label and create some padding 
between the buttons and the label. Let me know if this is less jarring than the 
previous version.

--
Added file: http://bugs.python.org/file35546/turtledemo_pane.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21655] Write Unit Test for Vec2 class in the Turtle Module

2014-06-10 Thread Lita Cho

Lita Cho added the comment:

Here are the tests for Vec2D. I have also included the tests for TNavigator 
here as well as they are all going into the same test module.

--
Added file: http://bugs.python.org/file35557/test_turtle_textonly.py

___
Python tracker 
<http://bugs.python.org/issue21655>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21656] Create test coverage for TurtleScreenBase in Turtle

2014-06-12 Thread Lita Cho

Changes by Lita Cho :


--
resolution:  -> duplicate
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue21656>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-06-12 Thread Lita Cho

Lita Cho added the comment:

Hi Terry, can we close this issue? Thanks!

--

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21743] Create tests for RawTurtleScreen

2014-06-12 Thread Lita Cho

New submission from Lita Cho:

Create test coverage for the RawTurtleScreen class.

--
messages: 220414
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create tests for RawTurtleScreen

___
Python tracker 
<http://bugs.python.org/issue21743>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21655] Write Unit Test for Vec2 and TNavigator class in the Turtle Module

2014-06-19 Thread Lita Cho

Lita Cho added the comment:

Finished testing TNavigator and Vec2 class.

--
keywords: +patch
title: Write Unit Test for Vec2 class in the Turtle Module -> Write Unit Test 
for Vec2 and TNavigator class in the Turtle Module
Added file: http://bugs.python.org/file35701/vec2_tnav.patch

___
Python tracker 
<http://bugs.python.org/issue21655>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-19 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +jesstess

___
Python tracker 
<http://bugs.python.org/issue21812>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-19 Thread Lita Cho

New submission from Lita Cho:

When you call turtle.shapetransform with a transformation matrix, nothing 
happens. You have to call turtle.shapesize or turtle.shearfactor first before 
turtle.shapetransform will take affect. Here is an example.

turtle.shapetransform(2,0,0,2) 
turtle.shapesize(1) 
turtle.shapetransform(2,0,0,2)

Nothing happens with the first call of shapetransform, but after calling 
shapesize, shapetransform then doubles in size, like it should.

--
components: Library (Lib)
messages: 221068
nosy: Lita.Cho
priority: normal
severity: normal
status: open
title: turtle.shapetransform doesn't transform the turtle on the first call

___
Python tracker 
<http://bugs.python.org/issue21812>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-20 Thread Lita Cho

Lita Cho added the comment:

Have a patch that fixes this. Rather than calling self._update() directory, we 
should be calling self._pen(resizemode="user"), since the user is changing the 
size of the turtle, just like how shapesize and shearfactor are updating.

--
keywords: +patch
Added file: http://bugs.python.org/file35714/turtle_shapetransform.patch

___
Python tracker 
<http://bugs.python.org/issue21812>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-06-20 Thread Lita Cho

Lita Cho added the comment:

ping!

I just want to know how I should proceed with this ticket. I can try removing 
the Frames with get rid of the lag, but then I feel like we can't use the Grid 
Manager at all. :\

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21812] turtle.shapetransform doesn't transform the turtle on the first call

2014-06-22 Thread Lita Cho

Lita Cho added the comment:

Absolutely! I totally forgot I made those changes for PEP8! Next time, I will 
totally submit just the change associated with the ticket.

Thank you, Raymond, for the feedback and reviewing my code!

--

___
Python tracker 
<http://bugs.python.org/issue21812>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)

2014-06-25 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +jesstess

___
Python tracker 
<http://bugs.python.org/issue21867>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)

2014-06-25 Thread Lita Cho

New submission from Lita Cho:

Turtle currently has a bug where it will return a TypeError when undobuffer is 
set to less than or equal to 0 (aka undo is not allowed).

turtle.setundobuffer(0)
turtle.undo()


If an exception must be thrown, it should be a Turtle exception and not a 
TypeError. However, I also feel like if the user calls undo, nothing should 
happen when undobuffer is set to 0.

--
messages: 221529
nosy: Lita.Cho
priority: normal
severity: normal
status: open
title: Turtle returns TypeError when undobuffer is set to 0 (aka no undo is 
allowed)

___
Python tracker 
<http://bugs.python.org/issue21867>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-06-25 Thread Lita Cho

New submission from Lita Cho:

Currently, you can set the undobuffer size to negative numbers. Aka, the 
Tbuffer can be set to negative.

s = turtle.Screen()
raw = turtle.RawTurtle(s)
raw.setundobuffer(-10)
raw.undobuffer.bufsize == -10 <-- returns True

This should not be possible. Tbuffer should not be allowed to have negative 
inputs. If the value is less than 0, it should just default to 0 or None. 
Otherwise, when you call undo, turtle just crashes.

--
messages: 221530
nosy: Lita.Cho
priority: normal
severity: normal
status: open
title: Tbuffer in turtle allows negative size

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-06-25 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +jesstess

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-06-25 Thread Lita Cho

Lita Cho added the comment:

Here is a patch for this bug. Basically, when a user gives 0 and below, it 
doesn't create a TBuffer. Then "undo" does the right thing.

--
keywords: +patch
Added file: http://bugs.python.org/file35778/undobuffer_fix.patch

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)

2014-06-25 Thread Lita Cho

Lita Cho added the comment:

The patch in issue21868 will fix this issue if it gets approved.

--

___
Python tracker 
<http://bugs.python.org/issue21867>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)

2014-06-25 Thread Lita Cho

Lita Cho added the comment:

That makes a lot of sense. Does that mea we shouldn't change this behaviour as 
there might be code that relies on these exceptions? The fix in issue21868 will 
make it so that undo doesn't cause turtle to crash.

--

___
Python tracker 
<http://bugs.python.org/issue21867>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-06-25 Thread Lita Cho

Lita Cho added the comment:

I should clarify. The right thing being that calling undo does nothing, and 
turtle keeps on running. This is the default behaviour when setundobuffer is 
called with no size.

--

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-07-03 Thread Lita Cho

Lita Cho added the comment:

Hey Raymond, just wanted to ping you to see if you had a chance to review this 
patch yet. Thanks!

--

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-07-03 Thread Lita Cho

Changes by Lita Cho :


--
versions: +Python 3.4, Python 3.5

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-07-03 Thread Lita Cho

Changes by Lita Cho :


--
versions: +Python 2.7

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21914] Create unit tests for Turtle guionly

2014-07-03 Thread Lita Cho

New submission from Lita Cho:

Create unit tests for the Turtle library, specifically on their gui commands.

--
components: Library (Lib), Tkinter
messages: 59
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create unit tests for Turtle guionly
versions: Python 3.5

___
Python tracker 
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21914] Create unit tests for Turtle guionly

2014-07-03 Thread Lita Cho

Lita Cho added the comment:

I created tests for the gui portion of Turtle. This file combines both me and 
Ingrid's work that is specifically the gui tests.

--
Added file: http://bugs.python.org/file35846/test_turtle_guionly.py

___
Python tracker 
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21914] Create unit tests for Turtle guionly

2014-07-03 Thread Lita Cho

Lita Cho added the comment:

I forgot to make it a patch. Created it as a patch for convenience.

--
keywords: +patch
Added file: http://bugs.python.org/file35847/test_turtle_guionly.patch

___
Python tracker 
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21743] Create tests for RawTurtleScreen

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

submitted a patch that tests all of this. Issue 21914

--
resolution:  -> duplicate
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue21743>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

Hi Terry, I started digging into this deeper and it looks like my tests doesn't 
tear in Python 2.7. I have tried on Python 3.5 and 3.4 and it tears on those 
versions.

I also tried the ttk objects, and the widgets also teared when I added frames. 
Here is the code I tried.

from tkinter import *
from tkinter import ttk

paned = ttk.Panedwindow(orient="horizontal")
left = ttk.Frame(paned)
left.pack(side='left', fill='both', expand=True)
right = ttk.Frame(paned)
right.pack(side='right', fill='both', expand=True)
button = ttk.Button(left,text="lefgt pane")
button.pack( fill='both', expand=True)
button2 = ttk.Button(right, text="right pane")
button2.pack( fill='both', expand=True)
paned.add(left)
paned.add(right)
paned.pack(fill="both",expand=True, pady = (4,1), padx=4)

mainloop()

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

Should I file a bug? I feel like this a bug specifically related to Python 3 
and Tkinter.

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

Oh I had no idea! That makes sense. How do I know which version of Tk I'm 
working with? I'm testing on Mac OSX as well!

Would there be anyway for you to test my patch for turtledemo to see if the 
sash causes artifacting for you? I see tearing but it snap back into place 
within less than a second, which doesn't seem that bad.

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

I feel like the PaneWindow is nice. I could also see down the road making the 
code text bigger.

However, if on Windows, the artifacting is really bad, I can totally switch 
this back to the grid view.

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

Oh man, I was running version '8.5.9' using 'aqua'. I am going to try and 
upgrade and see if the artifacting goes away.

Lita

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

Hm, when I upgrade to 8.6, I still get the tearing action on the very right of 
the window. Although, again, it doesn't seem that bad. I've attahed what I am 
seeing, just to confirm we are all talking about the same thing.

--
Added file: http://bugs.python.org/file35859/tkinter_tear.mov

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-04 Thread Lita Cho

Lita Cho added the comment:

Yes! This is the first version of the code without using ttk widgetd. Using 
Labels instead of buttons.

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-06 Thread Lita Cho

Lita Cho added the comment:

Hey Terry,

So the reason why the tearing is a lot slower in 06/09 patch is because the 
canvas is using the turtle.ScrolledCanvas widget. Everytime the window resizes, 
it is calling a callback to `onResize` -> `adjustScrolls` to update the 
scrollbars. When I comment out that binding in turtle.py (line 358) it still 
tears, but it snaps back a lot quicker.

The main widget is already a 2x2 grid (ScrolledCanvas). I tried just returning 
the ScrolledCanvas, but that didn't work either.

I will try to ask in stackoverflow tomorrow and seeing what they say!

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-06 Thread Lita Cho

Lita Cho added the comment:

I also put this patch out there. This doesn't have the PaneWindow, but I 
manually widen the text pane. This would be the compromise if I can't figure 
out the tearing due to the sash moving.

--
Added file: http://bugs.python.org/file35874/turtledemo_grid.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-06 Thread Lita Cho

Lita Cho added the comment:

?! After debugging for awhile, I got it so that PanedWindow doesn't cause the 
rightmost widget to tear! I had to disable the resizing binding on Turtle to 
make it work. 

However, now it seems like the canvas is no longer centered. Is there anyway 
for me to get around this? Maybe I disable the binding on the demo side and 
re-adjust the center when we initialize the canvas?

I want to make sure it works for you guys first before digging into it.

--
Added file: http://bugs.python.org/file35877/turtledemo_pane_srcoll_fix.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-06 Thread Lita Cho

Lita Cho added the comment:



I think I have a fix!! I made it so that centering works while fixing the 
tearing.

For some reason, in the Turtle API, the adjustScrolls method creates a new 
scroll widget for x and y and deletes the old one. I am not sure why it does it 
this way. I'm sure there is a reason for it though.

For the demo, I overwrote the onResize method so that it centers canvas but 
doesn't instantiate a new scroll widget and throws away the old one, which 
fixes the tearing!

I would love for someone to review the patch. Thanks!

--
Added file: http://bugs.python.org/file35878/turtledemo_pane_srcoll_fix.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-07 Thread Lita Cho

New submission from Lita Cho:

Currently, the turtledemo doesn't allow you to change font sizes of the demo 
code, and the default font size is really small.

I can work on creating a patch to fix this. Best option be to have 
control-mousewheel change size, as is standard in browsers, as well as Ctrl + 
and Ctrl - to change sizes (since laptops don't have a mousewheel). 

If tk has a problem with that, a second choice would be a menu entry "Font size 
with choices such as the current size (9?), 10, 12, 14.

Also, update the Help Text of this new feature.

--
messages: 222466
nosy: Lita.Cho, jesstess, ned.deily, terry.reedy
priority: normal
severity: normal
status: open
title: Allow the user to change font sizes with the text pane of turtledemo
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker 
<http://bugs.python.org/issue21933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-07 Thread Lita Cho

Changes by Lita Cho :


Added file: http://bugs.python.org/file35890/turtledemo_pane_scroll_SOLID.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-07 Thread Lita Cho

Lita Cho added the comment:

Hi Terry,

So the shadow can easily be removed. I just went with the default sashrelief 
style. I am going to attach two patches with different sashrelief styles, both 
of which don't have the shadow.

--
Added file: http://bugs.python.org/file35889/turtledemo_pane_scroll_FLAT.patch

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-07 Thread Lita Cho

Lita Cho added the comment:

I personally like the FLAT look because it matches with the rest of the GUI.

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1186900] nntplib shouldn't raise generic EOFError

2014-07-10 Thread Lita Cho

Lita Cho added the comment:

I am going to fix it so that it raises the NNTPConnectionError rather than 
update the documentation.

--
nosy: +Lita.Cho, jesstess

___
Python tracker 
<http://bugs.python.org/issue1186900>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1186900] nntplib shouldn't raise generic EOFError

2014-07-10 Thread Lita Cho

Lita Cho added the comment:

I have a fix and added some test coverage in order to make sure the 
NNTFConnectError was being called. However, in the test case, I am monkey 
patching. If there is a way to do this with mock, I would appreciate the 
feedback.

--
keywords: +patch
Added file: http://bugs.python.org/file35922/nntplib_error.patch

___
Python tracker 
<http://bugs.python.org/issue1186900>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21868] Tbuffer in turtle allows negative size

2014-07-11 Thread Lita Cho

Lita Cho added the comment:

Hi Raymond! Just wanted to check if you had time to test this yet. I ran the 
tests through the Turtle tests I wrote (issue21914), but those are still 
pending approval.

This is off topic, but I also didn't realize till now that you gave a talk 
about "Transforming Code into Beautiful, Idiomatic Python", which is super 
awesome! Getting a patch reviewed by you is super exciting! :)

--

___
Python tracker 
<http://bugs.python.org/issue21868>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3015] tkinter with wantobjects=False has been broken for some time

2014-07-11 Thread Lita Cho

Lita Cho added the comment:

That's perfect. I agree that this issue is closed! :)

--

___
Python tracker 
<http://bugs.python.org/issue3015>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21655] Write Unit Test for Vec2 and TNavigator class in the Turtle Module

2014-07-11 Thread Lita Cho

Lita Cho added the comment:

Ingrid and I combined our tests. The patch now lives here: 
http://bugs.python.org/issue21916

--
resolution:  -> duplicate
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue21655>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17172] Add turtledemo to IDLE menu

2014-07-11 Thread Lita Cho

Lita Cho added the comment:

I personally think it would be better to check to see if the turtledemo exists 
during startup, and if so, add the menu entry. Otherwise, don't add it when 
loading up IDLE.

--

___
Python tracker 
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21914] Create unit tests for Turtle guionly

2014-07-12 Thread Lita Cho

Lita Cho added the comment:

Make some changes to patch.

--

___
Python tracker 
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21914] Create unit tests for Turtle guionly

2014-07-12 Thread Lita Cho

Lita Cho added the comment:

Trying to attach a file again. I seem to be having trouble attaching it.

--

___
Python tracker 
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21914] Create unit tests for Turtle guionly

2014-07-12 Thread Lita Cho

Changes by Lita Cho :


Added file: http://bugs.python.org/file35930/test_turtle_guionly_v2.patch

___
Python tracker 
<http://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1186900] nntplib shouldn't raise generic EOFError

2014-07-13 Thread Lita Cho

Lita Cho added the comment:

That's a good point. I can add that so the NNTPConnectError can inherit the 
EOFError

--

___
Python tracker 
<http://bugs.python.org/issue1186900>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1186900] nntplib shouldn't raise generic EOFError

2014-07-13 Thread Lita Cho

Lita Cho added the comment:

Here is an updated patch.

--
Added file: http://bugs.python.org/file35941/nntplib_error.patch

___
Python tracker 
<http://bugs.python.org/issue1186900>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-14 Thread Lita Cho

Changes by Lita Cho :


--
nosy: +Lita.Cho, jesstess

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-14 Thread Lita Cho

Lita Cho added the comment:

I was reading the RFC spec, and it looks like it doesn't specificy '[' and ']' 
are not allowed in the PERNANENTFLAGS names. 

I can try to add a fix for this. But if anyone else knows if you are not 
allowed to have '[' or ']' in flag names, please let me know.

--

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-15 Thread Lita Cho

Lita Cho added the comment:

I have a patch for this. With my patch, the debug output is fixed.

--
keywords: +patch
Added file: http://bugs.python.org/file35962/imap_regex.patch

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-15 Thread Lita Cho

Lita Cho added the comment:

Here is a log of the output.

--
Added file: http://bugs.python.org/file35963/imaplib_log_with_patch.txt

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-15 Thread Lita Cho

Lita Cho added the comment:

Yes! I agree, this change will need tests. I will start working on creating 
those now.

Here is test I did to create a flag with brackets.

import imaplib

mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login('usern...@gmail.com', 'password') # Enter your login here
mail.select('test') # Mailbox selection. I have a test inbox with 6
# messages in it.
code, [msg_ids] = mail.search(None, 'ALL')
first_id = msg_ids.split()[0]
mail.store(first_id, "+FLAGS", "[test]")
typ, response = mail.fetch(first_id, '(FLAGS)')
print("Flags: %s" % response)
mail.close()
mail.logout()

--

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-15 Thread Lita Cho

Lita Cho added the comment:

Here is the code in order to see the bug.

imaplib.Debug = 5
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login(username, password) # Enter your login here
mail.select('test')

--

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-16 Thread Lita Cho

Lita Cho added the comment:

>
> R. David Murray added the comment:
>
> Just to make sure I understand: the issue is that gmail may produce flags
> with [] in them, and imaplib currently fails to process such flags when it
> receives them from gmail?
>
> This is correct. Gmail allows you to create flags with [], and the
Response_code regex doesn't process them properly.

> In principle I think we would not want to allow imaplib to be used to
> create such flags unless the user specifies some sort of "I want to violate
> the RFC" flag (which they might want to do, for example, to run tests
> against gmail :)  But currently it looks like it can?  (I haven't looked at
> this in enough detail to be sure.)  If that's true we probably have to
> continue to allow it for backward compatibility reasons, but we should
> document the RFC violation and possible consequences (an IMAP server
> rejecting such flags).
>
> Yes, currently we can. I've posted the code in order to do this. This is
basically the result.

>>> first_id = msg_ids.split()[0]
>>> mail.store(first_id, "+FLAGS", "[test]")
('OK', [b'1 (FLAGS (\\Seen Answered [test] NotJunk $NotJunk [Brackets]
[testing2]))'])

However, I would think it would be the server's job to uphold this rule,
not the library. The server should return with a BAD response, but right
now, Gmail allows you to do this.

Should we throw a warning in the "store" method? Otherwise, I can update
the documenation in the "store" method stating that having '[]' is allowed
but violates the RFC protocol.

> --
>
> ___
> Python tracker 
> <http://bugs.python.org/issue21815>
> ___
>

--

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-16 Thread Lita Cho

Lita Cho added the comment:

Okay, sounds good. I will also create a patch in the documentation that 
explains this, as well as comment on the regex patch.

--

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-16 Thread Lita Cho

Lita Cho added the comment:

Here is a patch for test_imaplib.py, adding the test for brackets. It should 
fail with the current version of imaplib, but should pass with the 
imap_regex.patch.

--
Added file: http://bugs.python.org/file35977/test_imaplib.patch

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-16 Thread Lita Cho

Lita Cho added the comment:

Updated the documentation in imaplib.rst to describe the RFC violation.

--
versions:  -Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35978/imap_doc.patch

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2014-07-16 Thread Lita Cho

Lita Cho added the comment:

Updated my regex patch to include a comment about how we are violating the RFC 
and allowing all characters rather thane excluding the ] character.

--
Added file: http://bugs.python.org/file35979/imap_regex.patch

___
Python tracker 
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1598] unexpected response in imaplib

2014-07-16 Thread Lita Cho

Lita Cho added the comment:

Has this been determine as a server bug or a bug with imaplib? I am not able to 
reproduce this bug with Gmail. Do I need to use it with Lotus Server to 
recreate it?

--
nosy: +Lita.Cho

___
Python tracker 
<http://bugs.python.org/issue1598>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1598] unexpected response in imaplib

2014-07-17 Thread Lita Cho

Lita Cho added the comment:

I spent the last 2 hours trying to setup a Lotus Server, which is ending up to 
be a lot more work then I thought in order to test this bug.

Is there anyway I can get a test Lotus account on a Lotus Server to test this 
bug?

--

___
Python tracker 
<http://bugs.python.org/issue1598>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1598] unexpected response in imaplib

2014-07-18 Thread Lita Cho

Lita Cho added the comment:

Hi Roy,

Oh I see. Should we close this out as "Won't Fix" due to the fact that we
aren't sure how many users are using this with Domino servers?

Lita

On Fri, Jul 18, 2014 at 8:52 AM, Roy Hyunjin Han 
wrote:

>
> Roy Hyunjin Han added the comment:
>
> Hi Lita,
>
> I no longer have access to a Domino server.
>
> I'm not sure whether there are enough users trying to access Domino with
> imaplib for this to warrant investigation.
>
> RHH
>
> --
>
> ___
> Python tracker 
> <http://bugs.python.org/issue1598>
> ___
>

--

___
Python tracker 
<http://bugs.python.org/issue1598>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21597] Allow turtledemo code pane to get wider.

2014-07-21 Thread Lita Cho

Lita Cho added the comment:

Ping! Just wanted to see what the status was on getting this patch reviewed. I 
hope your eye is feeling better, Terry!

--

___
Python tracker 
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-21 Thread Lita Cho

Lita Cho added the comment:

I have  a version of this working with Ctrl-plus and Ctrl-minus. However, there 
is a bug with Tk 8.5.9 where binding to MouseWheel  crashes Tkinter for Macs 
(issue10731), which I am running into. I need to update Tkinter to see if this 
works.

--

___
Python tracker 
<http://bugs.python.org/issue21933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-21 Thread Lita Cho

Lita Cho added the comment:

Here is a patch for changing the font size using the scroll wheel. I also added 
the shortcuts "Ctrl-plus" to increase the font size and "Ctrl-minus" to 
decrease the font size.

However, since the MouseWheel is now bound to changing the font
size, the canvas won't scroll. I can try to fix this so that the mousewheel 
only changes the font size if the text pane is highlighted. But that might not 
be intuitive. Thoughts?

Note, this patch also includes the window sash (issue21597). They are sort of 
dependent since I am also redefining the onResize method, so I clumped all the 
bindings to one method. But if you want that to be separate, I can try to make 
it into two separate patches.

--
keywords: +patch
Added file: http://bugs.python.org/file36019/window_pane_font_size.patch

___
Python tracker 
<http://bugs.python.org/issue21933>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >