[issue21475] Support the Sitemap extension in robotparser

2018-05-15 Thread Lady Red

Lady Red  added the comment:

I wrote a test for this as it seems to have been abandoned, and opened a PR.  
https://github.com/python/cpython/pull/6878

--
nosy: +mcsc...@gmail.com

___
Python tracker 
<https://bugs.python.org/issue21475>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21475] Support the Sitemap extension in robotparser

2018-05-15 Thread Lady Red

Lady Red  added the comment:

Sorry, wrong PR number. it is 6883, and attached to this ticket

--

___
Python tracker 
<https://bugs.python.org/issue21475>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33667] Mock calls on mutable objects

2018-05-28 Thread Lady Red

Lady Red  added the comment:

To have the behavior that you are expecting, I believe the mock would have to 
store a deep copy of every mutable object that is passed in to any of it's 
calls, in case that object later mutates. 

That would really expand the memory and time footprint of working with a Mock 
object.  The mock object would grow with every call to. (This is already true, 
as it's adding to it's mock_calls list... but it would grow much more. )

I'm also not sure about the safety of trying to deepcopy all objects passed in. 

I think that in addition to the safety and memory/performance issues that I've 
highlighted, deepcopying all objects would lead to it's own unintuitive 
behaviors.  Objects you get back from mock_call wouldn't be the objects that it 
was actually called with, they would be copies. 

I am attaching a file that illustrates this last point.

--
nosy: +mcsc...@gmail.com
Added file: https://bugs.python.org/file47622/unintuitive_side_effect.py

___
Python tracker 
<https://bugs.python.org/issue33667>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com