[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: Another true positive for make suspicious: WARNING: [c-api/apiabiversion:70] ":macro" found in "the same format as the c:macro:" I'm working on implementing it on rstlint, in the meantime I opened: => https://github.com/python/cpython/pull/30149 to fix this occurrence. This show that the current version of rstlint catches two mores \o/ -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46318] asyncio and ssl: ResourceWarning: unclosed transport
New submission from Julien Palard :
Originally opened at: https://github.com/aio-libs/aiohttp/issues/6071
Reproducer:
import asyncio
class DumbProtocol(asyncio.Protocol):
def connection_made(self, transport):
print("Connection made")
self.transport = transport
def data_received(self, data):
print("Data received: {!r}".format(data))
async def main():
loop = asyncio.get_running_loop()
for i in range(2):
_, _ = await loop.create_connection(DumbProtocol, "python.org",
443, ssl=True)
while True:
print("Waiting for the server to close the connection...")
await asyncio.sleep(10)
asyncio.run(main())
Using this reproducer I get a ResourceWarning:
Data received: b"HTTP/1.0 408 Request Time-out\r\nCache-Control:
no-cache\r\nConnection: close\r\nContent-Type:
text/html\r\n\r\n408 Request Time-out\nYour browser didn't
send a complete request in time.\n\n\n"
/usr/lib/python3.9/asyncio/sslproto.py:320: ResourceWarning: unclosed
transport
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
Object allocated at (most recent call last):
File "/usr/lib/python3.9/asyncio/sslproto.py", lineno 445
self._app_transport = _SSLProtocolTransport(self._loop, self)
I can also reproduce it on current master.
--
components: asyncio
messages: 410156
nosy: asvetlov, mdk, yselivanov
priority: normal
severity: normal
status: open
title: asyncio and ssl: ResourceWarning: unclosed transport
versions: Python 3.10, Python 3.11, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue46318>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46318] asyncio and ssl: ResourceWarning: unclosed transport
Julien Palard added the comment: Related to: https://bugs.python.org/issue23243 -- ___ Python tracker <https://bugs.python.org/issue46318> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46318] asyncio and ssl: ResourceWarning: unclosed transport
Julien Palard added the comment: Feel like SSLProtocol's connection_lost should "bubble up" the info by calling SSLProtocolTransport's close. But I'm no familiar with this stack. -- ___ Python tracker <https://bugs.python.org/issue46318> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45729] [doc] "history and license" link has wrong target
Julien Palard added the comment: This should be fixed in python-docs-theme==2022.1. I'll close the issue when I actually see the fix applied on docs.python.org. -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue45729> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45729] [doc] "history and license" link has wrong target
Change by Julien Palard : -- keywords: +patch pull_requests: +28728 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30527 ___ Python tracker <https://bugs.python.org/issue45729> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45729] [doc] "history and license" link has wrong target
Julien Palard added the comment: I checked on docs.python.org and it's fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue45729> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46318] asyncio and ssl: ResourceWarning: unclosed transport
Julien Palard added the comment: I don't know if it's related but _SSLPipe._shutdown_cb looks never called, in: self._sslobj.unwrap() self._sslobj = None self._state = _UNWRAPPED if self._shutdown_cb: self._shutdown_cb() the unwrap() call seems to always raise (The operation did not complete (read) (_ssl.c:2756)), thus never calling `self._shutdown_cb()`. -- ___ Python tracker <https://bugs.python.org/issue46318> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45729] [doc] "history and license" link has wrong target
Julien Palard added the comment: > dev docs direct to `/license.html` which redirects to `/3/license.html` All docs are redirecting to `/license.html`, this allow it to work also out of docs.python.org. > 3.9 docs have the same; wouldn’t it be better to have `/3.9/license.html`? It's maybe a slight better yes (the page should be the same so I don't know if it make real difference), but doing so means a bit of complexity, which I don't think is worth it. I tried to keep it simple for this fix (the previous state was "links to the current page" which was worse). -- ___ Python tracker <https://bugs.python.org/issue45729> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46318] asyncio and ssl: ResourceWarning: unclosed transport
Julien Palard added the comment: Probably related to https://bugs.python.org/issue44011 and https://github.com/MagicStack/uvloop/pull/385 -- ___ Python tracker <https://bugs.python.org/issue46318> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +29059 pull_request: https://github.com/python/cpython/pull/30879 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: I slowly started to work on rstlint in its own tree because working in a single file felt inconfortable. The more I advanced in this direction the more it made sense to me: - I first added tests, I may have been able to do so in the cpython tree though. - It would ease the publication of it to pypi.org so it can be used by other projects. - It may ease contributions (some non-core-devs could be given rights to the repo, which make sense as it's not really Python related but more Sphinx related). It currently looks like this: https://github.com/JulienPalard/sphinxlint but should obviously be moved to github.com/python/ if we adopt this direction. So what do you think? (cc Georg as the main author of the script) If so I'd also like to rename the thing, it's currently named `rstlint`, but it's more a `sphinxlint` as Sphinx has adds a lot to rst and existing rst linters does not handle Sphinx well. -- nosy: +georg.brandl ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +29160 pull_request: https://github.com/python/cpython/pull/30981 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: New changeset 44afdbd5af4503e376148e9404b9c7a4f595b1fe by Julien Palard in branch 'main': bpo-42238: [doc] Avoid hardcoding fast-moving lines in susp-ignored.csv. (GH-30981) https://github.com/python/cpython/commit/44afdbd5af4503e376148e9404b9c7a4f595b1fe -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment:
> You gave me a small shock, but I checked and it was only 11/12 years ago :D
HAha! Either I misstyped 12 as 21, either I'm bad at math, sorry for the shock
;)
> I'm fine with moving this out of tree; please coordinate with the Sphinx
> maintainers whether it should be an "official" extension or completely
> separate.
They propose [1] to have it in sphinx-contrib ("A collection of Sphinx
extensions maintained by their respective authors. It is not an official part
of Sphinx."), what do you think?
[1] https://github.com/sphinx-doc/sphinx/issues/10143#issuecomment-1025093280
--
___
Python tracker
<https://bugs.python.org/issue42238>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: OK, we have: https://github.com/sphinx-contrib/sphinx-lint Ping me if you want rights :) -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: Georg, I was able to move forward: - https://github.com/sphinx-contrib/sphinx-lint - https://pypi.org/project/sphinx-lint/ Does everything looks good to you? Next step would be to remove rstlint.py from Docs/tools and add a dependency to rstlint from the Makefile (for make check), so the CI uses sphinx-lint. -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +29282 pull_request: https://github.com/python/cpython/pull/31097 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44006] symbol documentation still exists
Julien Palard added the comment: Oh, it's ~unrelated, but thanks for the heads up, I overlooked a Sentry error :D It's related to: https://github.com/python/docsbuild-scripts/issues/122, let's track it there. (The visible effects are the same: the full build, reponsible for deleting the file is failing, while the quick (html only, not removing files) build succeed, so the old HTML files are kept if PDF builds are failing...) -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/issue44006> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: New changeset b878b3af0b3a9e3ab3ffcaf90a4066dfb3bb7cac by Julien Palard in branch 'main': bpo-42238: [doc] moving from rstlint.py to sphinx-lint. (GH-31097) https://github.com/python/cpython/commit/b878b3af0b3a9e3ab3ffcaf90a4066dfb3bb7cac -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: News: Hitting 3 months without a true positive from `make suspicious`, looks like sphinxlint starting to take over properly, I hope to close this issue soon (like in a few months maybe). Also sphinxlint attracted some contributors [1] \o/ [1] https://github.com/sphinx-contrib/sphinx-lint -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +30067 pull_request: https://github.com/python/cpython/pull/31977 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +30159 pull_request: https://github.com/python/cpython/pull/32070 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: New changeset ec8906fb5930b1f078e2a2170cdf445e6c6faf57 by Julien Palard in branch 'main': bpo-42238: [doc] Some lines moved in rst, but had hardcoded lineno in susp-ignored.csv. (GH-32070) https://github.com/python/cpython/commit/ec8906fb5930b1f078e2a2170cdf445e6c6faf57 -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45953] Statically allocate interpreter states as much as possible.
Julien Palard added the comment:
Since
https://github.com/python/cpython/commit/121f1f893a39d0b58d3d2b5597505c154ecaac2a,
`sys.getrefcount(1)` is surprising:
>>> __import__("sys").getrefcount(1)
100210
Should sys.getrefcount try to "fix" the value like by returning
`PyREFCNT(object) % 9`? (But using a define to avoid the "magic,
copy/pasted value").
--
nosy: +mdk
___
Python tracker
<https://bugs.python.org/issue45953>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45953] Statically allocate interpreter states as much as possible.
Julien Palard added the comment: Hum, and why 9? I am probably missing something obvious but 1 should be enough to ensure the value never hits 0. Except for refcount bugs obviously, but I don't think this is the right reason? -- ___ Python tracker <https://bugs.python.org/issue45953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45953] Statically allocate interpreter states as much as possible.
Julien Palard added the comment: > Since you seem to be challenging the value of 9, my question to you > is, why do you care what the refcount of 1 is? Yesterday I was teaching Python, and we were speaking of integer immutability, names being "labels to objects" and so on, and I was showing the memory layout of all of this by hand on a whiteboard while "prooving" my drawings using an interpreter. While doing so came a question like "So, many modules can use the object int(1)?" So I answered yes, told that I expected many reuse of 1, and went importing sys.getrefcount to show them. And boom, it printed 100209 so I bugged for a few seconds, the value was obviously not the real refcount, and was also obviously bumped by a constant like 1, so I went inspecting why and found this commit. I have nothing against keeping 9, but in the other hand it could surprise other people, maybe we should at least document it near sys.getrefcount. -- ___ Python tracker <https://bugs.python.org/issue45953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +30354 pull_request: https://github.com/python/cpython/pull/32292 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: One true positive and one false positive this week, see: - 7f9c084fdec7ddcfe8855aa79f98545591ae2261 - ec8906fb5930b1f078e2a2170cdf445e6c6faf57 -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: New changeset bdc497496548e30fa208a8d98c30bf6d1833ac4c by Julien Palard in branch 'main': bpo-42238: [doc]: make suspicious: false positive. (GH-32292) https://github.com/python/cpython/commit/bdc497496548e30fa208a8d98c30bf6d1833ac4c -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Change by Julien Palard : -- pull_requests: +30388 pull_request: https://github.com/python/cpython/pull/32329 ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: New changeset d0e696e05d4aaca1f1cde72a5c3326ca3d0f5c24 by Julien Palard in branch 'main': bpo-42238: [doc]: A make sucpicious false positive. (GH-32329) https://github.com/python/cpython/commit/d0e696e05d4aaca1f1cde72a5c3326ca3d0f5c24 -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21956] Doc files deleted from repo are not deleted from docs.python.org.
Julien Palard added the comment: This is resolved since https://github.com/python/docsbuild-scripts/pull/28. It could still happen in very specific conditions, but not for a long time, see: https://github.com/python/docs-community/issues/41#issuecomment-1088462199= -- nosy: +mdk resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue21956> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42238] Deprecate suspicious.py?
Julien Palard added the comment: One true positive today: https://github.com/python/cpython/pull/32355 -- ___ Python tracker <https://bugs.python.org/issue42238> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30122] Added missing archive programs.
Julien Palard added the comment: This FAQ entry has been deleted. -- nosy: +mdk resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue30122> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18576] Document test.support.script_helper
Julien Palard added the comment: All those functions has already been documented. -- dependencies: -Make test.script_helper more comprehensive, and use it in the test suite nosy: +mdk resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue18576> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37597] audit event table breaks PDF sphinx build
Change by Julien Palard : -- stage: patch review -> resolved ___ Python tracker <https://bugs.python.org/issue37597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25237] Add doc for tkinter commondialog.Dialog and subclasses
Julien Palard added the comment: New changeset 80428ed4e19b31071433806b4d89465c88e084c6 by Julien Palard (Nikhil) in branch 'master': bpo-25237: Documentation for tkinter modules (GH-1870) https://github.com/python/cpython/commit/80428ed4e19b31071433806b4d89465c88e084c6 -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue25237> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25237] Add doc for tkinter commondialog.Dialog and subclasses
Change by Julien Palard : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue25237> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21018] [patch] added missing documentation about escaping characters for configparser
Julien Palard added the comment: New changeset 9a94093189417a6b59d6c80cc5544630c8aa by Julien Palard (Arun Persaud) in branch 'master': bpo-21018: added missing documentation about escaping characters for configparser (GH-6137) https://github.com/python/cpython/commit/9a94093189417a6b59d6c80cc5544630c8aa -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue21018> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21018] [patch] added missing documentation about escaping characters for configparser
Julien Palard added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue21018> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21018] [patch] added missing documentation about escaping characters for configparser
Julien Palard added the comment: New changeset 122bbf7f8ac2cef4368e3601af593a027dc62ccf by Julien Palard (Miss Islington (bot)) in branch '3.7': bpo-21018: added missing documentation about escaping characters for configparser (GH-6137) (GH-15845) https://github.com/python/cpython/commit/122bbf7f8ac2cef4368e3601af593a027dc62ccf -- ___ Python tracker <https://bugs.python.org/issue21018> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21018] [patch] added missing documentation about escaping characters for configparser
Julien Palard added the comment: New changeset 5cf8155bbd2c65572295b26e96c221763b3322f0 by Julien Palard (Miss Islington (bot)) in branch '3.8': bpo-21018: added missing documentation about escaping characters for configparser (GH-6137) (GH-15846) https://github.com/python/cpython/commit/5cf8155bbd2c65572295b26e96c221763b3322f0 -- ___ Python tracker <https://bugs.python.org/issue21018> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33602] Remove set and queue references from Data Types
Julien Palard added the comment: New changeset 912108891db52c2067889be1f4ce5713839807cd by Julien Palard (Andre Delfino) in branch 'master': bpo-33602: Doc: Remove set and queue references from Data Types (GH-7055) https://github.com/python/cpython/commit/912108891db52c2067889be1f4ce5713839807cd -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue33602> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33602] Remove set and queue references from Data Types
Julien Palard added the comment: New changeset 58ef7d341c79f649da275bb1d5c11f668d7bac9e by Julien Palard (Miss Islington (bot)) in branch '3.8': bpo-33602: Doc: Remove set and queue references from Data Types (GH-7055) (GH-15875) https://github.com/python/cpython/commit/58ef7d341c79f649da275bb1d5c11f668d7bac9e -- ___ Python tracker <https://bugs.python.org/issue33602> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33602] Remove set and queue references from Data Types
Julien Palard added the comment: New changeset 816825e192ed430438c613d52a58fb9e1a8d90f4 by Julien Palard (Miss Islington (bot)) in branch '3.7': bpo-33602: Doc: Remove set and queue references from Data Types (GH-7055) (GH-15876) https://github.com/python/cpython/commit/816825e192ed430438c613d52a58fb9e1a8d90f4 -- ___ Python tracker <https://bugs.python.org/issue33602> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33602] Remove set and queue references from Data Types
Change by Julien Palard : -- nosy: -mdk resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue33602> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16438] Numeric operator predecence confusing
Julien Palard added the comment: New changeset 4576b5431bd597df7581fe3c852b315e47e4b230 by Julien Palard (Anjali) in branch 'master': bpo-16438: Doc: confusing text regarding numeric precedence corrected (GH-10521) https://github.com/python/cpython/commit/4576b5431bd597df7581fe3c852b315e47e4b230 -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue16438> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16438] Numeric operator predecence confusing
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue16438> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser
Julien Palard added the comment: New changeset c78dae8d2b890d487e428dce00c7f600612cce7b by Julien Palard (Xtreak) in branch 'master': bpo-35603: Add a note on difflib table header interpreted as HTML (GH-11439) https://github.com/python/cpython/commit/c78dae8d2b890d487e428dce00c7f600612cce7b -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue35603> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35649] http.client doesn't close. Infinite loop
Julien Palard added the comment: New changeset 62cf6981425c6a6b136c5e2abef853364f535e9d by Julien Palard (Ashwin Ramaswami) in branch 'master': bpo-35649: update http client example (GH-11441) https://github.com/python/cpython/commit/62cf6981425c6a6b136c5e2abef853364f535e9d -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue35649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35649] http.client doesn't close. Infinite loop
Julien Palard added the comment: New changeset 43fb3bb223338511a7aee9b55d75af4a415134dc by Julien Palard (Miss Islington (bot)) in branch '3.8': bpo-35649: update http client example (GH-11441) (GH-15930) https://github.com/python/cpython/commit/43fb3bb223338511a7aee9b55d75af4a415134dc -- ___ Python tracker <https://bugs.python.org/issue35649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35649] http.client doesn't close. Infinite loop
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35649] http.client doesn't close. Infinite loop
Julien Palard added the comment: New changeset 0fd8c0560b2099d2c976b17cf01cb596badc1ec6 by Julien Palard (Miss Islington (bot)) in branch '3.7': bpo-35649: update http client example (GH-11441) (GH-15931) https://github.com/python/cpython/commit/0fd8c0560b2099d2c976b17cf01cb596badc1ec6 -- ___ Python tracker <https://bugs.python.org/issue35649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23460] Decimals do not obey ':g' exponential notation formatting rules
Julien Palard added the comment: New changeset 1660a61a105bcd62e2dfa77885959a8992e9f14e by Julien Palard (Brennan D Baraban) in branch 'master': bpo-23460: Fix documentation for decimal string :g formatting (GH-11850) https://github.com/python/cpython/commit/1660a61a105bcd62e2dfa77885959a8992e9f14e -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue23460> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23460] Decimals do not obey ':g' exponential notation formatting rules
Julien Palard added the comment: New changeset 629f1f87e9b0bfd9f1dc3d02f966decde5c65201 by Julien Palard (Miss Islington (bot)) in branch '3.8': bpo-23460: Fix documentation for decimal string :g formatting (GH-11850) (GH-15954) https://github.com/python/cpython/commit/629f1f87e9b0bfd9f1dc3d02f966decde5c65201 -- ___ Python tracker <https://bugs.python.org/issue23460> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23460] Decimals do not obey ':g' exponential notation formatting rules
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue23460> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36182] Path.write_text() docs do not include the case that a file exists
Julien Palard added the comment: New changeset af636f4f91b8289b6dad95cb84123f6e22fd7f4f by Julien Palard (Lysandros Nikolaou) in branch 'master': bpo-36182: Update pathlib.Path.write_text() docs (GH-12161) https://github.com/python/cpython/commit/af636f4f91b8289b6dad95cb84123f6e22fd7f4f -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue36182> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36182] Path.write_text() docs do not include the case that a file exists
Julien Palard added the comment: New changeset 893653357cc83d49049debfeb9074a4ce99cd478 by Julien Palard (Miss Islington (bot)) in branch '3.8': bpo-36182: Update pathlib.Path.write_text() docs (GH-12161) (GH-15977) https://github.com/python/cpython/commit/893653357cc83d49049debfeb9074a4ce99cd478 -- ___ Python tracker <https://bugs.python.org/issue36182> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36182] Path.write_text() docs do not include the case that a file exists
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36182> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36270] DOC: Add link to sys.exc_info for "Reference Manual"
Julien Palard added the comment: New changeset 9936371af298d465095ae70bc9c2943b4b16eac4 by Julien Palard (Björn Meier) in branch 'master': bpo-36270: Doc: add link to traceback object reference (GH-13119) https://github.com/python/cpython/commit/9936371af298d465095ae70bc9c2943b4b16eac4 -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue36270> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36675] Doctest directives and comments missing from code samples
Julien Palard added the comment: I opened an issue on the sphinx-doc repo [1] to check if it would be possible to have an option in doctest blocks to not trim them. We previously had a hack in Doc/tools/extensions/pyspecific.py to patch sphinx to not trim them for the doctest.rst file. But sphinx deprecated the hack we used :( [1]: https://github.com/sphinx-doc/sphinx/issues/6698 -- ___ Python tracker <https://bugs.python.org/issue36675> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36675] Doctest directives and comments missing from code samples
Change by Julien Palard : -- pull_requests: +15647 pull_request: https://github.com/python/cpython/pull/16024 ___ Python tracker <https://bugs.python.org/issue36675> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35685] Add samples on patch.dict of the use of decorator and in class
Julien Palard added the comment: We're using assert instead of assertEqual to denote that we're not "testing unittest" but asserting that unittest work as documented. Whch is semantically a bit different. Unittesting unittest using unittest works, but using unittest test to test unittest as documentation example could lead the reader to having hard time figuring what's what. I think using assert here disambiguate the whole thing. -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue35685> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35685] Add samples on patch.dict of the use of decorator and in class
Julien Palard added the comment: New changeset 31a82e25b6044a5b5ee25246bad3eb7b873cf5ec by Julien Palard (Emmanuel Arias) in branch 'master': bpo-35685: Add examples of unittest.mock.patch.dict usage (GH-11456) https://github.com/python/cpython/commit/31a82e25b6044a5b5ee25246bad3eb7b873cf5ec -- ___ Python tracker <https://bugs.python.org/issue35685> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35685] Add samples on patch.dict of the use of decorator and in class
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35685> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35325] imp.find_module() return value documentation discrepancy
Julien Palard added the comment: New changeset 967b84c913c7b09ae2fc86272cb9373415e2beaf by Julien Palard (Windson yang) in branch 'master': bpo-35325: Doc: imp.find_module() return value documentation discrepancy (GH-11040) https://github.com/python/cpython/commit/967b84c913c7b09ae2fc86272cb9373415e2beaf -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue35325> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35325] imp.find_module() return value documentation discrepancy
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35325> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13474] Mention of "-m" Flag Missing From Doc on Execution Model
Change by Julien Palard : -- pull_requests: +15667 pull_request: https://github.com/python/cpython/pull/16045 ___ Python tracker <https://bugs.python.org/issue13474> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13474] Mention of "-m" Flag Missing From Doc on Execution Model
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue13474> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36270] DOC: Add link to sys.exc_info for "Reference Manual"
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36270> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33459] Fix "tuple display" mention in Expressions
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue33459> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38143] plistlib: cleanup PEP8 violations
Julien Palard added the comment: Hi Jon, thanks for trying to enhance Python. You should start by reading the devguide [1]. We'd like to enhance the style and may or may not do it in the future, but if we do I'll be all in the single conmit, and I bet using black. We do not accept such small changes because they mess with got history (blame mainly). [1]: https://devguide.python.org Excuse my short message, sent from my phone. -- nosy: +mdk resolution: -> later stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue38143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Julien Palard added the comment: New changeset 42671aea2db6cbc54369617da0fd3545048e0a45 by Julien Palard (Jakub Kulík) in branch 'master': bpo-37785: Fix xgettext warning in argparse (GH-15161) https://github.com/python/cpython/commit/42671aea2db6cbc54369617da0fd3545048e0a45 -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31040] mimetypes.add_type should complain when you give it an undotted ext
Julien Palard added the comment: I think we should deprecate calling `add_type` with an empty `ext`, as I don't think it's a feature, more a side effect of the current implementation. But as some may use it like a feature, I asked the current PR to emit a warning, to not break the current implementations. To be able to simplify in the future, why not deprecating empty `ext` so we can remove it in a few versions? -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue31040> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Julien Palard added the comment: OK to revert in 3.7, got your point. -- ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Julien Palard added the comment: Thanks for noticing Serhiy! -- ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Change by Julien Palard : -- pull_requests: +15704 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/16082 ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Julien Palard added the comment: New changeset f14fcbf2995b43c8607a1448402633ac558a745f by Julien Palard in branch '3.7': Revert "bpo-37785: Fix xgettext warning in argparse (GH-15161)" (GH-16082) https://github.com/python/cpython/commit/f14fcbf2995b43c8607a1448402633ac558a745f -- ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21041] pathlib.PurePath.parents rejects negative indexes
Julien Palard added the comment:
I checked conversation in #7951, tells about an ambiguity because it could be
an index from a sequence or a key for a dict, like {-1: "foo"}.
Here there is no such confusion.
Confusion *may* arrise from the fact that it's not composed of parts, but more
like it's already sliced, I mean it does NOT look like:
['/', 'home', 'mdk', 'clones', 'python']
It's more like:
['/home/mdk/clones/python', '/home/mdk/clones', '/home/mdk', '/home', '/']
In fact I'd say it behave more like a function call than a sequence access, I
read:
pathlib.Path.cwd().parents[1]
a bit like:
pathlib.Path.cwd().parents(go_down=1)
It may explain why negative indices or slices were initially not implemented:
It already looks like the result of a slice.
--
nosy: +mdk
___
Python tracker
<https://bugs.python.org/issue21041>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35498] Parents objects in pathlib.Path don't support slices as __getitem__ arguments
Julien Palard added the comment: Just commented on the related issue: https://bugs.python.org/issue21041#msg352281 My question is: Why would you need to slice parents? parents already looks like the result of some slice. -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue35498> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37785] argparse uses %s in gettext calls causing xgettext warnings
Change by Julien Palard : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31040] mimetypes.add_type should complain when you give it an undotted ext
Julien Palard added the comment:
I just found a case where the empty mime type is actually usefull, it's in
Lib/http/server.py:
extensions_map = mimetypes.types_map.copy()
extensions_map.update({
'': 'application/octet-stream', # Default
'.py': 'text/plain',
'.c': 'text/plain',
'.h': 'text/plain',
})
It does *not* uses add_type, but demos the fact that the empty type may be
usefull from time to time, maybe don't warn and don't deprecate it at all.
--
___
Python tracker
<https://bugs.python.org/issue31040>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5430] imaplib: must not replace LF or CR by CRLF in literals
Julien Palard added the comment: It looks like a revert of 47404f3e36699786082d0ee6565872d627e1 Which is the fix for https://bugs.python.org/issue723962 which I'm currently reading. -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue5430> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29986] Documentation recommends raising TypeError from tp_richcompare
Change by Julien Palard : -- keywords: +patch pull_requests: +15716 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16095 ___ Python tracker <https://bugs.python.org/issue29986> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29986] Documentation recommends raising TypeError from tp_richcompare
Julien Palard added the comment: New changeset 375a3e2bdbeb4dce69aba4b5bc90f55fe27e81b4 by Julien Palard in branch 'master': bpo-29986: Doc: Delete tip to raise TypeError from tp_richcompare. (GH-16095) https://github.com/python/cpython/commit/375a3e2bdbeb4dce69aba4b5bc90f55fe27e81b4 -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue29986> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33082] multiprocessing docs bury very important 'callback=' args
Julien Palard added the comment: I'd wait for Davin's review, but I'd keep the documentation as they are. -- ___ Python tracker <https://bugs.python.org/issue33082> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33082] multiprocessing docs bury very important 'callback=' args
Julien Palard added the comment: I agree Antoine on this one, if one want the result, It'll get it from the returned value (.get method in the example), or simply by using the not-async versions and directly get the results as a return value of the call. Also the given example in the documentation won't work as the result is never waited for, the pool gets destroyed before the sleep have the time to sleep. -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue33082> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33095] Cross-reference isolated mode from relevant locations
Change by Julien Palard : -- pull_requests: +15791 pull_request: https://github.com/python/cpython/pull/16181 ___ Python tracker <https://bugs.python.org/issue33095> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33095] Cross-reference isolated mode from relevant locations
Julien Palard added the comment: New changeset 210dc3bb37ec57a8b8b16ffe0881181138a6e973 by Julien Palard in branch '3.7': [3.7] bpo-33095: Add reference to isolated mode in -m and script option (GH-7764) (GH-16181) https://github.com/python/cpython/commit/210dc3bb37ec57a8b8b16ffe0881181138a6e973 -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue33095> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27542] Segfault in gcmodule.c:360 visit_decref
Julien Palard added the comment: I tried again with the same version of pip and cffi on cpython 2.7.16 (no 13, I have no VM atm to compile a 2.7.13) but no segfault this time. -- ___ Python tracker <https://bugs.python.org/issue27542> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38538] dictobject dictviews don't return NotImplemented for unrecognized types.
New submission from Julien Palard :
In the following snippet:
>>> class Ror:
... def __ror__(self, other):
... return set()
...
>>> {}.keys() | Ror()
Traceback (most recent call last):
File "", line 1, in
TypeError: 'Ror' object is not iterable
I expect the __or__ implementation of dict_keys to return NotImplemented when
given a non-interesting thing, so my __ror__ can run and get an empty set
instead of a TypeError.
Strangely enough, it worked in Python 2.7, I'm not fluent enough en 2.7 object
nor C implementation to know why, the dictviews_or looks the same for me.
It looks easy to fix without breaking the tests in dictobject.c like:
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -4284,7 +4284,8 @@ dictviews_or(PyObject* self, PyObject *other)
tmp = _PyObject_CallMethodIdOneArg(result, &PyId_update, other);
if (tmp == NULL) {
Py_DECREF(result);
-return NULL;
+PyErr_Clear();
+Py_RETURN_NOTIMPLEMENTED;
}
the question is more: should we? I think so but am I missing something?
--
messages: 355007
nosy: mdk
priority: normal
severity: normal
status: open
title: dictobject dictviews don't return NotImplemented for unrecognized types.
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38538>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38538] dictobject dictviews don't return NotImplemented for unrecognized types.
Julien Palard added the comment: > It is not strange since dict.keys() in Python 2.7 returns list. Oh, ok thanks :) Do you think that it should be fixed? As it works with sets, I think so: >>> set() | Ror() set() but it's not that simple as the __or__ of dictviews is less strict that the __or__ of set: __or__ of dictview accept any iterable, __or__ of set only accepts sets. -- ___ Python tracker <https://bugs.python.org/issue38538> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38592] Add pt-br to the language switcher at the Python docs website
Julien Palard added the comment: New changeset 85c6f8c65cd4f7219522c1f304bdfff19f785e7a by Julien Palard (Marco Rougeth) in branch 'master': bpo-38592 Add pt-br switcher to Python Docs website (GH-16924) https://github.com/python/cpython/commit/85c6f8c65cd4f7219522c1f304bdfff19f785e7a -- ___ Python tracker <https://bugs.python.org/issue38592> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38592] Add pt-br to the language switcher at the Python docs website
Julien Palard added the comment: New changeset 955f96f6aae7c1a54d88c3f7a51c2e142ac7e4d4 by Julien Palard (Miss Skeleton (bot)) in branch '3.8': bpo-38592 Add pt-br switcher to Python Docs website (GH-16924) (GH-16953) https://github.com/python/cpython/commit/955f96f6aae7c1a54d88c3f7a51c2e142ac7e4d4 -- ___ Python tracker <https://bugs.python.org/issue38592> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38592] Add pt-br to the language switcher at the Python docs website
Julien Palard added the comment: New changeset 155a9dc129c129270763525cd3eb2704990e406d by Julien Palard (Miss Skeleton (bot)) in branch '3.7': bpo-38592 Add pt-br switcher to Python Docs website (GH-16924) (GH-16954) https://github.com/python/cpython/commit/155a9dc129c129270763525cd3eb2704990e406d -- ___ Python tracker <https://bugs.python.org/issue38592> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41933] Wording of s * n in Common Sequence Operations is not optimal
Julien Palard added the comment: New changeset 0269ce87c9347542c54a653dd78b9f60bb9fa822 by Chavdar Yotov in branch 'master': bpo-41933: Clarify wording for s * n in Common Sequence Operations (GH-22570) https://github.com/python/cpython/commit/0269ce87c9347542c54a653dd78b9f60bb9fa822 -- ___ Python tracker <https://bugs.python.org/issue41933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41933] Wording of s * n in Common Sequence Operations is not optimal
Change by Julien Palard : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue41933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43504] effbot.org down
New submission from Julien Palard : effbot.org is down, it's currently displaying: > effbot.org on hiatus > > effbot.org is taking a break. We’ll be back, in some form or another. But docs.python.org have a few links pointing to it, `git grep effbot` finds 11 of them in the Doc/. I think they should be manually reviewed one by one, checking on web archive [1] if they still contain relevant information. For example: Doc/library/xml.etree.elementtree.rst:See http://effbot.org/zone/element-index.htm for tutorials and links to other The given links give Python 2 examples, so I think it's OK just to remove it. [1]: https://web.archive.org/web/20200315142708/http://effbot.org/ -- messages: 388787 nosy: mdk priority: normal severity: normal status: open title: effbot.org down ___ Python tracker <https://bugs.python.org/issue43504> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
