[issue21091] EmailMessage.is_attachment should be a method

2014-08-03 Thread Joseph Godbehere

Joseph Godbehere added the comment:

Patch to change message.is_attachment from a property to a normal method. I've 
updated the doc and all calls to is_attachment.

--
keywords: +patch
nosy: +joegod
Added file: http://bugs.python.org/file36243/attach_not_property.patch

___
Python tracker 
<http://bugs.python.org/issue21091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21091] EmailMessage.is_attachment should be a method

2014-08-04 Thread Joseph Godbehere

Joseph Godbehere added the comment:

Very good point, Serhiy.

Here is an alternative patch, which instead changes Message.is_multipart from a 
method to a property as per your suggestion. This way incorrect usage should 
fail noisily.

This patch is against the relevant docs, tests, is_multipart and calls to 
is_multipart only.

--
Added file: http://bugs.python.org/file36249/multipart_is_property.patch

___
Python tracker 
<http://bugs.python.org/issue21091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com