[issue43567] regen.vcxproj cannot regenerate some necessary files
New submission from Jiaxin Peng : I tried to modify Grammar/python.gram, Grammar/Tokens, Parser/Python.asdl, to add a new token to the grammar. And when using `build.bat --regen`, only parser.c is newly generated. Other files, as mentioned in https://devguide.python.org/grammar/ that should be updated:ast.c, Python-ast.h etc. regen.vcxproj is now not capable for the new PEG parser. So an update is need. -- components: Build messages: 389155 nosy: pjx206 priority: normal severity: normal status: open title: regen.vcxproj cannot regenerate some necessary files type: compile error versions: Python 3.10 ___ Python tracker <https://bugs.python.org/issue43567> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43567] regen.vcxproj cannot regenerate some necessary files
Jiaxin Peng added the comment: I did: - modified Grammar/python.gram - added new operator to compare_op_bitwise_or_pair - added corresponding token to Grammer/Tokens - build.bar --regen - not having Include/Python-ast.h and Python/Python-ast.c I agree that a regen.bat that using a system python is better solution. regen.vcxproj is confusing. -- nosy: -anthonypjshaw, lys.nikolaou, pablogsal, paul.moore, steve.dower, tim.golden, vstinner, zach.ware ___ Python tracker <https://bugs.python.org/issue43567> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43567] regen.vcxproj cannot regenerate some necessary files
Change by Jiaxin Peng : -- nosy: -anthonypjshaw, lys.nikolaou, pablogsal, paul.moore, pjx206, steve.dower, tim.golden, vstinner, zach.ware ___ Python tracker <https://bugs.python.org/issue43567> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43567] regen.vcxproj cannot regenerate some necessary files
Jiaxin Peng added the comment: `build.bat --regen` produces such error because it uses build tool from visual studio to build regen.vcxproj, and you do not have v142 toolset. I'm using vs2019 and have v142 toolset installed and regen.vcxproj workd, just cannot actually regenerate files needed completely. -- nosy: +pjx206 ___ Python tracker <https://bugs.python.org/issue43567> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43567] regen.vcxproj cannot regenerate some necessary files
Jiaxin Peng added the comment: The regen.vcxproj was modified but not test well. In the first version of regen.vcxproj there were such build targets: _RegenGrammar(BeforeTargets="Build") -> _RegenAST_H -> _RegenAST_C -> _RegenOpcodes -> _RegenTokens -> _RegenKeywords -> _RegenSymbols In commit 1ed83ad: bpo-40939: Remove the old parser (GH-20768), "_RegenGrammar" was removed, but there's still "_RegenAST_H" as AfterTargets of "_RegenGrammar". @gvanrossum sorry about removing nosy folks, This website displays in my language so I did not realize what is "nosy list". -- ___ Python tracker <https://bugs.python.org/issue43567> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43567] regen.vcxproj cannot regenerate some necessary files
Jiaxin Peng added the comment: Steve's PR zooba:bpo-43567 works as expected. Really clean implementation! Thanks! -- resolution: -> works for me ___ Python tracker <https://bugs.python.org/issue43567> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com